27502 2009-07-21 08:10:35 -0700 Web Inspector: Add ability to evaluate selection while on break point. 2009-07-21 09:51:23 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P3 Normal --- 0 pfeldman webkit-unassigned sam timothy oldest_to_newest 133467 0 pfeldman 2009-07-21 08:10:35 -0700 While on a break point, there should be a way to evaluate selected text in the source frame. There should be a separate request to evaluate text on hover, but it is beyond the scope of this one. I'd suggest the following user scenario: 1. User hits a breakpoint 2. User selects text he wants to evaluate 3. Presses Meta + Shift + E shortcut (or optionally chooses item in Popup menu?) 4. Result is printed in the console. 133468 1 33177 pfeldman 2009-07-21 08:19:02 -0700 Created attachment 33177 patch 133480 2 timothy 2009-07-21 09:16:48 -0700 We really need a way to change the context menu from JS for the Inspector so we can add items like this for discoverability. Bug 26881 and bug 22147. 133482 3 33177 timothy 2009-07-21 09:22:29 -0700 Comment on attachment 33177 patch > + var shortcut = WebInspector.KeyboardShortcut.makeKey( > + 69 /* 'E' */, > + platformSpecificModifier | WebInspector.KeyboardShortcut.Modifiers.Shift); I think that would be fine and more readable on one line. Talk to Sam Weinig, he has a patch (maybe landed) that will let us add "evaluate on hover". 133494 4 pfeldman 2009-07-21 09:51:23 -0700 Sending WebCore/ChangeLog Sending WebCore/inspector/front-end/SourceFrame.js Transmitting file data .. Committed revision 46176. 33177 2009-07-21 08:19:02 -0700 2009-07-21 09:22:29 -0700 patch eval_selection.txt text/plain 3678 pfeldman SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViQ29yZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDQ2MTQzKQ0KKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp DQpAQCAtMSwzICsxLDE1IEBADQorMjAwOS0wNy0yMSAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFu QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkhCisKKyAgICAgICAg V2ViIEluc3BlY3RvcjogQWRkIGFiaWxpdHkgdG8gZXZhbHVhdGUgc2VsZWN0aW9uIHdoaWxlIG9u IGJyZWFrIHBvaW50LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yNzUwMgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9Tb3VyY2VGcmFt ZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Tb3VyY2VGcmFtZS5wcm90b3R5cGUuX2xvYWRl ZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU291cmNlRnJhbWUucHJvdG90eXBlLl9kb2N1bWVu dEtleURvd24pOgorCiAyMDA5LTA3LTIwICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4KSW5kZXg6IFdlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9Tb3VyY2VGcmFtZS5qcw0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9Tb3VyY2VGcmFtZS5qcwkocmV2aXNpb24gNDYwODcpDQorKysg V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NvdXJjZUZyYW1lLmpzCSh3b3JraW5nIGNvcHkp DQpAQCAtMjcsNiArMjcsNyBAQA0KIHsKICAgICB0aGlzLm1lc3NhZ2VzID0gW107CiAgICAgdGhp cy5icmVha3BvaW50cyA9IFtdOworICAgIHRoaXMuX3Nob3J0Y3V0cyA9IHt9OwogCiAgICAgdGhp cy5hZGRCcmVha3BvaW50RGVsZWdhdGUgPSBhZGRCcmVha3BvaW50RGVsZWdhdGU7CiAKQEAgLTE5 OSwxMCArMjAwLDE4IEBADQogICAgIHsKICAgICAgICAgV2ViSW5zcGVjdG9yLmFkZE1haW5FdmVu dExpc3RlbmVycyh0aGlzLmVsZW1lbnQuY29udGVudERvY3VtZW50KTsKICAgICAgICAgdGhpcy5l bGVtZW50LmNvbnRlbnREb2N1bWVudC5hZGRFdmVudExpc3RlbmVyKCJtb3VzZWRvd24iLCB0aGlz Ll9kb2N1bWVudE1vdXNlRG93bi5iaW5kKHRoaXMpLCB0cnVlKTsKLSAgICAgICAgdGhpcy5lbGVt ZW50LmNvbnRlbnREb2N1bWVudC5hZGRFdmVudExpc3RlbmVyKCJrZXlkb3duIiwgV2ViSW5zcGVj dG9yLmRvY3VtZW50S2V5RG93bi5iaW5kKFdlYkluc3BlY3RvciksIHRydWUpOworICAgICAgICB0 aGlzLmVsZW1lbnQuY29udGVudERvY3VtZW50LmFkZEV2ZW50TGlzdGVuZXIoImtleWRvd24iLCB0 aGlzLl9kb2N1bWVudEtleURvd24uYmluZCh0aGlzKSwgdHJ1ZSk7CiAgICAgICAgIHRoaXMuZWxl bWVudC5jb250ZW50RG9jdW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigia2V5dXAiLCBXZWJJbnNwZWN0 b3IuZG9jdW1lbnRLZXlVcC5iaW5kKFdlYkluc3BlY3RvciksIHRydWUpOwogICAgICAgICB0aGlz LmVsZW1lbnQuY29udGVudERvY3VtZW50LmFkZEV2ZW50TGlzdGVuZXIoIndlYmtpdEFuaW1hdGlv bkVuZCIsIHRoaXMuX2hpZ2hsaWdodExpbmVFbmRzLmJpbmQodGhpcyksIGZhbHNlKTsKIAorICAg ICAgICAvLyBSZWdpc3RlciAnZXZhbCcgc2hvcnRjdXQuCisgICAgICAgIHZhciBpc01hYyA9IElu c3BlY3RvckNvbnRyb2xsZXIucGxhdGZvcm0oKS5pbmRleE9mKCJtYWMtIikgPT09IDA7CisgICAg ICAgIHZhciBwbGF0Zm9ybVNwZWNpZmljTW9kaWZpZXIgPSBpc01hYyA/IFdlYkluc3BlY3Rvci5L ZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVycy5NZXRhIDogV2ViSW5zcGVjdG9yLktleWJvYXJkU2hv cnRjdXQuTW9kaWZpZXJzLkN0cmw7CisgICAgICAgIHZhciBzaG9ydGN1dCA9IFdlYkluc3BlY3Rv ci5LZXlib2FyZFNob3J0Y3V0Lm1ha2VLZXkoCisgICAgICAgICAgICA2OSAvKiAnRScgKi8sCisg ICAgICAgICAgICBwbGF0Zm9ybVNwZWNpZmljTW9kaWZpZXIgfCBXZWJJbnNwZWN0b3IuS2V5Ym9h cmRTaG9ydGN1dC5Nb2RpZmllcnMuU2hpZnQpOworICAgICAgICB0aGlzLl9zaG9ydGN1dHNbc2hv cnRjdXRdID0gdGhpcy5fZXZhbFNlbGVjdGlvbkluQ2FsbEZyYW1lLmJpbmQodGhpcyk7CisKICAg ICAgICAgdmFyIGhlYWRFbGVtZW50ID0gdGhpcy5lbGVtZW50LmNvbnRlbnREb2N1bWVudC5nZXRF bGVtZW50c0J5VGFnTmFtZSgiaGVhZCIpWzBdOwogICAgICAgICBpZiAoIWhlYWRFbGVtZW50KSB7 CiAgICAgICAgICAgICBoZWFkRWxlbWVudCA9IHRoaXMuZWxlbWVudC5jb250ZW50RG9jdW1lbnQu Y3JlYXRlRWxlbWVudCgiaGVhZCIpOwpAQCAtMjg4LDYgKzI5NywzMyBAQA0KICAgICAgICAgICAg IHRoaXMuYWRkQnJlYWtwb2ludERlbGVnYXRlKHRoaXMubGluZU51bWJlckZvclNvdXJjZVJvdyhz b3VyY2VSb3cpKTsKICAgICB9LAogCisgICAgX2RvY3VtZW50S2V5RG93bjogZnVuY3Rpb24oZXZl bnQpCisgICAgeworICAgICAgICB2YXIgc2hvcnRjdXQgPSBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRT aG9ydGN1dC5tYWtlS2V5RnJvbUV2ZW50KGV2ZW50KTsKKyAgICAgICAgdmFyIGhhbmRsZXIgPSB0 aGlzLl9zaG9ydGN1dHNbc2hvcnRjdXRdOworICAgICAgICBpZiAoaGFuZGxlcikgeworICAgICAg ICAgICAgaGFuZGxlcihldmVudCk7CisgICAgICAgICAgICBldmVudC5wcmV2ZW50RGVmYXVsdCgp OworICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAgV2ViSW5zcGVjdG9yLmRvY3VtZW50S2V5 RG93bihldmVudCk7CisgICAgICAgIH0KKyAgICB9LAorCisgICAgX2V2YWxTZWxlY3Rpb25JbkNh bGxGcmFtZTogZnVuY3Rpb24oZXZlbnQpIHsKKyAgICAgICAgaWYgKCFXZWJJbnNwZWN0b3IucGFu ZWxzLnNjcmlwdHMgfHwgIVdlYkluc3BlY3Rvci5wYW5lbHMuc2NyaXB0cy5wYXVzZWQpCisgICAg ICAgICAgICByZXR1cm47CisKKyAgICAgICAgdmFyIHNlbGVjdGlvbiA9IHRoaXMuZWxlbWVudC5j b250ZW50V2luZG93LmdldFNlbGVjdGlvbigpOworICAgICAgICBpZiAoIXNlbGVjdGlvbi5yYW5n ZUNvdW50KQorICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgIHZhciBleHByZXNzaW9uID0g c2VsZWN0aW9uLmdldFJhbmdlQXQoMCkudG9TdHJpbmcoKS50cmltV2hpdGVzcGFjZSgpOworICAg ICAgICBXZWJJbnNwZWN0b3IucGFuZWxzLnNjcmlwdHMuZXZhbHVhdGVJblNlbGVjdGVkQ2FsbEZy YW1lKGV4cHJlc3Npb24sIGZhbHNlLCBmdW5jdGlvbihyZXN1bHQsIGV4Y2VwdGlvbikgeworICAg ICAgICAgICAgV2ViSW5zcGVjdG9yLnNob3dDb25zb2xlKCk7CisgICAgICAgICAgICBXZWJJbnNw ZWN0b3IuY29uc29sZS5hZGRNZXNzYWdlKG5ldyBXZWJJbnNwZWN0b3IuQ29uc29sZUNvbW1hbmRS ZXN1bHQocmVzdWx0LCBleGNlcHRpb24pKTsKKyAgICAgICAgfSk7CisgICAgfSwKKwogICAgIF9i cmVha3BvaW50RW5hYmxlQ2hhbmdlZDogZnVuY3Rpb24oZXZlbnQpCiAgICAgewogICAgICAgICB2 YXIgYnJlYWtwb2ludCA9IGV2ZW50LnRhcmdldDsK