27497 2009-07-21 07:26:45 -0700 Feature request: cpplint should check for braces - rule 2 2009-07-21 12:56:19 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Minor --- 0 luciano.wolf webkit-unassigned kenneth manyoso oldest_to_newest 133458 0 luciano.wolf 2009-07-21 07:26:45 -0700 According to Braces rule 2 of the Webkit coding style guidelines[1]: "Other braces: place the open brace on the line preceding the code block; place the close brace on its own line." cpplint doesn't complain about non-compliance with this rule when using the Qt foreach macro, as illustrated below WRONG CODING STYLE: foreach (AbstractMetaFunction *func, lst) { qDebug() << "*" << func->ownerClass()->name() << "Private: " << func->isPrivate() << "Empty: " << func->isEmptyFunction(); } [1] http://webkit.org/coding/coding-style.html 133556 1 33199 kenneth 2009-07-21 12:31:22 -0700 Created attachment 33199 Add support for making sure { is on the same line as foreach 133560 2 kenneth 2009-07-21 12:43:57 -0700 Landed in r46188 33199 2009-07-21 12:31:22 -0700 2009-07-21 12:33:27 -0700 Add support for making sure { is on the same line as foreach bug-27497.patch text/plain 3171 kenneth RnJvbSBkM2Y1YjkxM2ZlMDRjOWU4M2E2MmMzMmZlYjgxZWQzZGMzMjI5OWYyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiA8a2VubmV0aEB3 ZWJraXQub3JnPgpEYXRlOiBUdWUsIDIxIEp1bCAyMDA5IDE2OjI5OjU2IC0wMzAwClN1YmplY3Q6 IFtQQVRDSF0gMjAwOS0wNy0yMSAgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4gIDxrZW5uZXRo QHdlYmtpdC5vcmc+CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAg ICBGZWF0dXJlIHJlcXVlc3Q6IGNwcGxpbnQgc2hvdWxkIGNoZWNrIGZvciBicmFjZXMgLSBydWxl IDIKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc0OTcK CiAgICAgICAgQWRkIHRoZSByZXF1ZXN0ZWQgZmVhdHVyZTogTWFrZSBzdXJlIHsgaXMgb24gdGhl IHNhbWUgbGluZQogICAgICAgIGFzIHRoZSBmb3JlYWNoICJrZXl3b3JkIi4KCiAgICAgICAgKiBT Y3JpcHRzL21vZHVsZXMvY3BwbGludC5weToKICAgICAgICAqIFNjcmlwdHMvbW9kdWxlcy9jcHBs aW50X3VuaXR0ZXN0LnB5OgotLS0KIFdlYktpdFRvb2xzL0NoYW5nZUxvZyAgICAgICAgICAgICAg ICAgICAgICAgICAgIHwgICAxMyArKysrKysrKysrKysrCiBXZWJLaXRUb29scy9TY3JpcHRzL21v ZHVsZXMvY3BwbGludC5weSAgICAgICAgICB8ICAgIDIgKy0KIFdlYktpdFRvb2xzL1NjcmlwdHMv bW9kdWxlcy9jcHBsaW50X3VuaXR0ZXN0LnB5IHwgICAgNiArKysrKysKIDMgZmlsZXMgY2hhbmdl ZCwgMjAgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXRU b29scy9DaGFuZ2VMb2cgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKaW5kZXggZTRhYjM2Ni4uNzAy NTkyNyAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1dlYktpdFRvb2xz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDA5LTA3LTIxICBLZW5uZXRoIFJvaGRlIENo cmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGZWF0dXJlIHJlcXVlc3Q6IGNwcGxpbnQgc2hvdWxk IGNoZWNrIGZvciBicmFjZXMgLSBydWxlIDIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTI3NDk3CisKKyAgICAgICAgQWRkIHRoZSByZXF1ZXN0ZWQgZmVh dHVyZTogTWFrZSBzdXJlIHsgaXMgb24gdGhlIHNhbWUgbGluZQorICAgICAgICBhcyB0aGUgZm9y ZWFjaCAia2V5d29yZCIuCisKKyAgICAgICAgKiBTY3JpcHRzL21vZHVsZXMvY3BwbGludC5weToK KyAgICAgICAgKiBTY3JpcHRzL21vZHVsZXMvY3BwbGludF91bml0dGVzdC5weToKKwogMjAwOS0w Ny0yMSAgU2hpbmljaGlybyBIYW1hamkgIDxoYW1hamlAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IERhdmlkIExldmluLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0 cy9tb2R1bGVzL2NwcGxpbnQucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwbGlu dC5weQppbmRleCA2YTljYThhLi42Zjk2NjFlIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3Jp cHRzL21vZHVsZXMvY3BwbGludC5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMv Y3BwbGludC5weQpAQCAtMTY4NSw3ICsxNjg1LDcgQEAgZGVmIGNoZWNrX2JyYWNlcyhmaWxlbmFt ZSwgY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBlcnJvcik6CiAgICAgICAgICMgV2UgYWxzbyBh bGxvdyAnIycgZm9yICNlbmRpZiBhbmQgJz0nIGZvciBhcnJheSBpbml0aWFsaXphdGlvbi4KICAg ICAgICAgcHJldmlvdXNfbGluZSA9IGdldF9wcmV2aW91c19ub25fYmxhbmtfbGluZShjbGVhbl9s aW5lcywgbGluZV9udW1iZXIpWzBdCiAgICAgICAgIGlmICgobm90IHNlYXJjaChyJ1s7On17KT1d XHMqJHxcKVxzKmNvbnN0XHMqJCcsIHByZXZpb3VzX2xpbmUpCi0gICAgICAgICAgICAgb3Igc2Vh cmNoKHInXGIoaWZ8Zm9yfHdoaWxlfHN3aXRjaHxlbHNlKVxiJywgcHJldmlvdXNfbGluZSkpCisg ICAgICAgICAgICAgb3Igc2VhcmNoKHInXGIoaWZ8Zm9yfGZvcmVhY2h8d2hpbGV8c3dpdGNofGVs c2UpXGInLCBwcmV2aW91c19saW5lKSkKICAgICAgICAgICAgIGFuZCBwcmV2aW91c19saW5lLmZp bmQoJyMnKSA8IDApOgogICAgICAgICAgICAgZXJyb3IoZmlsZW5hbWUsIGxpbmVfbnVtYmVyLCAn d2hpdGVzcGFjZS9icmFjZXMnLCA0LAogICAgICAgICAgICAgICAgICAgJ1RoaXMgeyBzaG91bGQg YmUgYXQgdGhlIGVuZCBvZiB0aGUgcHJldmlvdXMgbGluZScpCmRpZmYgLS1naXQgYS9XZWJLaXRU b29scy9TY3JpcHRzL21vZHVsZXMvY3BwbGludF91bml0dGVzdC5weSBiL1dlYktpdFRvb2xzL1Nj cmlwdHMvbW9kdWxlcy9jcHBsaW50X3VuaXR0ZXN0LnB5CmluZGV4IDA0MDVlZjkuLmI0YmYwMTUg MTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBsaW50X3VuaXR0ZXN0 LnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBsaW50X3VuaXR0ZXN0LnB5 CkBAIC0yOTExLDYgKzI5MTEsMTIgQEAgY2xhc3MgV2ViS2l0U3R5bGVUZXN0KENwcGxpbnRUZXN0 QmFzZSk6CiAgICAgICAgICAgICAnfVxuJywKICAgICAgICAgICAgICdUaGlzIHsgc2hvdWxkIGJl IGF0IHRoZSBlbmQgb2YgdGhlIHByZXZpb3VzIGxpbmUgIFt3aGl0ZXNwYWNlL2JyYWNlc10gWzRd JykKICAgICAgICAgc2VsZi5hc3NlcnRfbXVsdGlfbGluZV9saW50KAorICAgICAgICAgICAgJ2Zv cmVhY2ggKEZvbyogZm9vLCBmb29zKVxuJworICAgICAgICAgICAgJ3tcbicKKyAgICAgICAgICAg ICcgICAgaW50IGJhcjtcbicKKyAgICAgICAgICAgICd9XG4nLAorICAgICAgICAgICAgJ1RoaXMg eyBzaG91bGQgYmUgYXQgdGhlIGVuZCBvZiB0aGUgcHJldmlvdXMgbGluZSAgW3doaXRlc3BhY2Uv YnJhY2VzXSBbNF0nKQorICAgICAgICBzZWxmLmFzc2VydF9tdWx0aV9saW5lX2xpbnQoCiAgICAg ICAgICAgICAnc3dpdGNoICh0eXBlKVxuJwogICAgICAgICAgICAgJ3tcbicKICAgICAgICAgICAg ICdjYXNlIGZvbzogcmV0dXJuO1xuJwotLSAKMS42LjAuNAoK