27496 2009-07-21 07:11:52 -0700 Feature request: cpplint should check for indentation - rule 6 2009-07-22 08:17:31 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Minor --- 1 luciano.wolf webkit-unassigned jpetsovits kenneth levin manyoso oldest_to_newest 133457 0 luciano.wolf 2009-07-21 07:11:52 -0700 According to Indentation rule 6 of the Webkit coding style guidelines[1]: "Boolean expressions at the same nesting level that span multiple lines should have their operators on the left side of the line instead of the right side." This isn't currently tested by the cpplint. [1] http://webkit.org/coding/coding-style.html 133566 1 jpetsovits 2009-07-21 13:01:46 -0700 Hm... I wonder if there are any cases where "||" and "&&" are allowed at the end of the line? Otherwise, this would be ridiculously easy. 133569 2 levin 2009-07-21 13:05:26 -0700 > I wonder if there are any cases where "||" and "&&" are allowed at the end of the line? No. 133593 3 33213 jpetsovits 2009-07-21 14:09:24 -0700 Created attachment 33213 Add checks for multi-line boolean operator placement ...like this? Seems the new check caught an issue in cpplint_unittest.py itself :P 133606 4 levin 2009-07-21 14:41:35 -0700 > Seems the new check caught an issue in cpplint_unittest.py itself Yeah, this tool was originally developed for Google style which doesn't have this rule, so as it gets closer to WebKit style, differences in WebKit and Google style are exposed (which is all good). 133772 5 manyoso 2009-07-22 08:17:31 -0700 Landed with r46224. 33213 2009-07-21 14:09:24 -0700 2009-07-21 14:39:47 -0700 Add checks for multi-line boolean operator placement 0001-Add-checks-for-multi-line-boolean-operator-placement.patch text/plain 5170 jpetsovits RnJvbSAxYjI4MGI3MzhjNmE5OTVhZGEyZmI4MWZlN2U3NWQ1YjMyMjlmMzZkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWtvYiBQZXRzb3ZpdHMgPGpha29iLnBldHNvdml0c0B0b3Jj aG1vYmlsZS5jb20+CkRhdGU6IFR1ZSwgMjEgSnVsIDIwMDkgMTc6MDc6MDIgLTA0MDAKU3ViamVj dDogW1BBVENIXSBBZGQgY2hlY2tzIGZvciBtdWx0aS1saW5lIGJvb2xlYW4gb3BlcmF0b3IgcGxh Y2VtZW50LgoKLS0tCiBXZWJLaXRUb29scy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAg ICAgICB8ICAgMTAgKysrKysrKysrKwogV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NwcGxp bnQucHkgICAgICAgICAgfCAgICA5ICsrKysrKystLQogV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1 bGVzL2NwcGxpbnRfdW5pdHRlc3QucHkgfCAgIDIzICsrKysrKysrKysrKysrLS0tLS0tLS0tCiAz IGZpbGVzIGNoYW5nZWQsIDMxIGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwppbmRl eCAyNmVhZTc0Li5lYTIzYWY1IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDctMjEgIEph a29iIFBldHNvdml0cyAgPGpha29iLnBldHNvdml0c0B0b3JjaG1vYmlsZS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGNoZWNrcyBmb3Ig bXVsdGktbGluZSBib29sZWFuIG9wZXJhdG9yIHBsYWNlbWVudC4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3NDk2CisKKyAgICAgICAgKiBTY3JpcHRz L21vZHVsZXMvY3BwbGludC5weToKKyAgICAgICAgKiBTY3JpcHRzL21vZHVsZXMvY3BwbGludF91 bml0dGVzdC5weToKKwogMjAwOS0wNy0yMSAgQWRhbSBUcmVhdCAgPGFkYW0udHJlYXRAdG9yY2ht b2JpbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExldmluLgpkaWZmIC0tZ2l0 IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NwcGxpbnQucHkgYi9XZWJLaXRUb29scy9T Y3JpcHRzL21vZHVsZXMvY3BwbGludC5weQppbmRleCA0NjdmMGMzLi40YzBiNjliIDEwMDY0NAot LS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwbGludC5weQorKysgYi9XZWJLaXRU b29scy9TY3JpcHRzL21vZHVsZXMvY3BwbGludC5weQpAQCAtMTQyNiw3ICsxNDI2LDcgQEAgZGVm IGNoZWNrX3NwYWNpbmcoZmlsZW5hbWUsIGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZXJyb3Ip OgogCiAgICAgIyBCZWZvcmUgbml4aW5nIGNvbW1lbnRzLCBjaGVjayBpZiB0aGUgbGluZSBpcyBi bGFuayBmb3Igbm8gZ29vZAogICAgICMgcmVhc29uLiAgVGhpcyBpbmNsdWRlcyB0aGUgZmlyc3Qg bGluZSBhZnRlciBhIGJsb2NrIGlzIG9wZW5lZCwgYW5kCi0gICAgIyBibGFuayBsaW5lcyBhdCB0 aGUgZW5kIG9mIGEgZnVuY3Rpb24gKGllLCByaWdodCBiZWZvcmUgYSBsaW5lIGxpa2UgJ30nCisg ICAgIyBibGFuayBsaW5lcyBhdCB0aGUgZW5kIG9mIGEgZnVuY3Rpb24gKGllLCByaWdodCBiZWZv cmUgYSBsaW5lIGxpa2UgJ30nKS4KICAgICBpZiBpc19ibGFua19saW5lKGxpbmUpOgogICAgICAg ICBlbGlkZWQgPSBjbGVhbl9saW5lcy5lbGlkZWQKICAgICAgICAgcHJldmlvdXNfbGluZSA9IGVs aWRlZFtsaW5lX251bWJlciAtIDFdCkBAIC0xNDM5LDcgKzE0MzksNyBAQCBkZWYgY2hlY2tfc3Bh Y2luZyhmaWxlbmFtZSwgY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBlcnJvcik6CiAgICAgICAg ICAgICBhbmQgcHJldmlvdXNfbGluZVs6cHJldmlvdXNfYnJhY2VdLmZpbmQoJ25hbWVzcGFjZScp ID09IC0xKToKICAgICAgICAgICAgICMgT0ssIHdlIGhhdmUgYSBibGFuayBsaW5lIGF0IHRoZSBz dGFydCBvZiBhIGNvZGUgYmxvY2suICBCZWZvcmUgd2UKICAgICAgICAgICAgICMgY29tcGxhaW4s IHdlIGNoZWNrIGlmIGl0IGlzIGFuIGV4Y2VwdGlvbiB0byB0aGUgcnVsZTogVGhlIHByZXZpb3Vz Ci0gICAgICAgICAgICAjIG5vbi1lbXB0eSBsaW5lIGhhcyB0aGUgcGFyYW10ZXJzIG9mIGEgZnVu Y3Rpb24gaGVhZGVyIHRoYXQgYXJlIGluZGVudGVkCisgICAgICAgICAgICAjIG5vbi1lbXB0eSBs aW5lIGhhcyB0aGUgcGFyYW1ldGVycyBvZiBhIGZ1bmN0aW9uIGhlYWRlciB0aGF0IGFyZSBpbmRl bnRlZAogICAgICAgICAgICAgIyA0IHNwYWNlcyAoYmVjYXVzZSB0aGV5IGRpZCBub3QgZml0IGlu IGEgODAgY29sdW1uIGxpbmUgd2hlbiBwbGFjZWQgb24KICAgICAgICAgICAgICMgdGhlIHNhbWUg bGluZSBhcyB0aGUgZnVuY3Rpb24gbmFtZSkuICBXZSBhbHNvIGNoZWNrIGZvciB0aGUgY2FzZSB3 aGVyZQogICAgICAgICAgICAgIyB0aGUgcHJldmlvdXMgbGluZSBpcyBpbmRlbnRlZCA2IHNwYWNl cywgd2hpY2ggbWF5IGhhcHBlbiB3aGVuIHRoZQpAQCAtMjAzNiw2ICsyMDM2LDExIEBAIGRlZiBj aGVja19zdHlsZShmaWxlbmFtZSwgY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBmaWxlX2V4dGVu c2lvbiwgZXJyb3IpOgogICAgICAgICBlcnJvcihmaWxlbmFtZSwgbGluZV9udW1iZXIsICd3aGl0 ZXNwYWNlL25ld2xpbmUnLCA0LAogICAgICAgICAgICAgICAnTW9yZSB0aGFuIG9uZSBjb21tYW5k IG9uIHRoZSBzYW1lIGxpbmUnKQogCisgICAgaWYgY2xlYW5zZWRfbGluZS5zdHJpcCgpLmVuZHN3 aXRoKCd8fCcpIG9yIGNsZWFuc2VkX2xpbmUuc3RyaXAoKS5lbmRzd2l0aCgnJiYnKToKKyAgICAg ICAgZXJyb3IoZmlsZW5hbWUsIGxpbmVfbnVtYmVyLCAnd2hpdGVzcGFjZS9vcGVyYXRvcnMnLCA0 LAorICAgICAgICAgICAgICAnQm9vbGVhbiBleHByZXNzaW9ucyB0aGF0IHNwYW4gbXVsdGlwbGUg bGluZXMgc2hvdWxkIGhhdmUgdGhlaXIgJworICAgICAgICAgICAgICAnb3BlcmF0b3JzIG9uIHRo ZSBsZWZ0IHNpZGUgb2YgdGhlIGxpbmUgaW5zdGVhZCBvZiB0aGUgcmlnaHQgc2lkZS4nKQorCiAg ICAgIyBTb21lIG1vcmUgc3R5bGUgY2hlY2tzCiAgICAgY2hlY2tfbmFtZXNwYWNlX2luZGVudGF0 aW9uKGZpbGVuYW1lLCBjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGZpbGVfZXh0ZW5zaW9uLCBl cnJvcikKICAgICBjaGVja19zd2l0Y2hfaW5kZW50YXRpb24oZmlsZW5hbWUsIGNsZWFuX2xpbmVz LCBsaW5lX251bWJlciwgZXJyb3IpCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL21v ZHVsZXMvY3BwbGludF91bml0dGVzdC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9j cHBsaW50X3VuaXR0ZXN0LnB5CmluZGV4IDZmZDY4ZTYuLmM4MTkxNGMgMTAwNjQ0Ci0tLSBhL1dl YktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBsaW50X3VuaXR0ZXN0LnB5CisrKyBiL1dlYktp dFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBsaW50X3VuaXR0ZXN0LnB5CkBAIC0xMTI2LDkgKzEx MjYsMTAgQEAgY2xhc3MgQ3BwbGludFRlc3QoQ3BwbGludFRlc3RCYXNlKToKICAgICAgICAgICAg ICd9XG4nLAogICAgICAgICAgICAgJycpCiAgICAgICAgIHNlbGYuYXNzZXJ0X211bHRpX2xpbmVf bGludCgKLSAgICAgICAgICAgICdpZiAoY29uZGl0aW9uICYmXG4nCi0gICAgICAgICAgICAnICAg IGNvbmRpdGlvbjIgJiZcbicKLSAgICAgICAgICAgICcgICAgY29uZGl0aW9uMykge1xuJywKKyAg ICAgICAgICAgICdpZiAoY29uZGl0aW9uXG4nCisgICAgICAgICAgICAnICAgICYmIGNvbmRpdGlv bjJcbicKKyAgICAgICAgICAgICcgICAgJiYgY29uZGl0aW9uMykge1xuJworICAgICAgICAgICAg J31cbicsCiAgICAgICAgICAgICAnJykKIAogICAgIGRlZiB0ZXN0X21pc21hdGNoaW5nX3NwYWNl c19pbl9wYXJlbnMoc2VsZik6CkBAIC0yODE5LDEyICsyODIwLDE2IEBAIGNsYXNzIFdlYktpdFN0 eWxlVGVzdChDcHBsaW50VGVzdEJhc2UpOgogICAgICAgICAjIDYuIEJvb2xlYW4gZXhwcmVzc2lv bnMgYXQgdGhlIHNhbWUgbmVzdGluZyBsZXZlbCB0aGF0IHNwYW4KICAgICAgICAgIyAgIG11bHRp cGxlIGxpbmVzIHNob3VsZCBoYXZlIHRoZWlyIG9wZXJhdG9ycyBvbiB0aGUgbGVmdCBzaWRlIG9m CiAgICAgICAgICMgICB0aGUgbGluZSBpbnN0ZWFkIG9mIHRoZSByaWdodCBzaWRlLgotICAgICAg ICAjIEZJWE1FOiBObyB0ZXN0cyBmb3IgdGhpcyBydWxlLiBUaGUgZm9sbG93aW5nIHNob3VsZCBm YWlsLgotICAgICAgICAjIHNlbGYuYXNzZXJ0X211bHRpX2xpbmVfbGludCgKLSAgICAgICAgIyAg ICAgJyAgICByZXR1cm4gYXR0ci0+bmFtZSgpID09IHNyY0F0dHIgfHxcbicKLSAgICAgICAgIyAg ICAgJyAgICAgICAgYXR0ci0+bmFtZSgpID09IGxvd3NyY0F0dHIgfHxcbicKLSAgICAgICAgIyAg ICAgJyAgICAgICAgKGF0dHItPm5hbWUoKSA9PSB1c2VtYXBBdHRyICYmIGF0dHItPnZhbHVlKCku ZG9tU3RyaW5nKClbMF0gIT0gXCcjXCcpO1xuJywKLSAgICAgICAgIyAgICAgJycpCisgICAgICAg IHNlbGYuYXNzZXJ0X211bHRpX2xpbmVfbGludCgKKyAgICAgICAgICAgICcgICAgcmV0dXJuIGF0 dHItPm5hbWUoKSA9PSBzcmNBdHRyXG4nCisgICAgICAgICAgICAnICAgICAgICB8fCBhdHRyLT5u YW1lKCkgPT0gbG93c3JjQXR0cjtcbicsCisgICAgICAgICAgICAnJykKKyAgICAgICAgc2VsZi5h c3NlcnRfbXVsdGlfbGluZV9saW50KAorICAgICAgICAgICAgJyAgICByZXR1cm4gYXR0ci0+bmFt ZSgpID09IHNyY0F0dHIgfHxcbicKKyAgICAgICAgICAgICcgICAgICAgIGF0dHItPm5hbWUoKSA9 PSBsb3dzcmNBdHRyO1xuJywKKyAgICAgICAgICAgICdCb29sZWFuIGV4cHJlc3Npb25zIHRoYXQg c3BhbiBtdWx0aXBsZSBsaW5lcyBzaG91bGQgaGF2ZSB0aGVpciAnCisgICAgICAgICAgICAnb3Bl cmF0b3JzIG9uIHRoZSBsZWZ0IHNpZGUgb2YgdGhlIGxpbmUgaW5zdGVhZCBvZiB0aGUgcmlnaHQg c2lkZS4nCisgICAgICAgICAgICAnICBbd2hpdGVzcGFjZS9vcGVyYXRvcnNdIFs0XScpCiAKICAg ICBkZWYgdGVzdF9zcGFjaW5nKHNlbGYpOgogICAgICAgICAjIDEuIERvIG5vdCBwbGFjZSBzcGFj ZXMgYXJvdW5kIHVuYXJ5IG9wZXJhdG9ycy4KLS0gCjEuNi4zLjMKCg==