27489 2009-07-21 01:20:33 -0700 cpplint's parse_argument should not exit even if no files are specified 2009-07-21 03:07:03 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 hamaji webkit-unassigned levin oldest_to_newest 133396 0 hamaji 2009-07-21 01:20:33 -0700 run-webkit-lint script will use parse_argument() function. As the script will lint the current diff by default, we should not exit even if no files are specified. 133397 1 33156 hamaji 2009-07-21 01:22:20 -0700 Created attachment 33156 Patch v1 --- 3 files changed, 17 insertions(+), 7 deletions(-) 133430 2 levin 2009-07-21 03:07:03 -0700 Committed as http://trac.webkit.org/changeset/46161 33156 2009-07-21 01:22:20 -0700 2009-07-21 01:25:09 -0700 Patch v1 bug-27489-20090721172219.patch text/plain 3326 hamaji ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA3ZTUwNTUzLi42MWQ4NzY1IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTYgQEAKIAogICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBjcHBsaW50J3MgcGFyc2Vf YXJndW1lbnQgc2hvdWxkIG5vdCBleGl0IGV2ZW4gaWYgbm8gZmlsZXMgYXJlIHNwZWNpZmllZAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc0ODkKKwor ICAgICAgICAqIFNjcmlwdHMvbW9kdWxlcy9jcHBsaW50LnB5OgorICAgICAgICAqIFNjcmlwdHMv bW9kdWxlcy9jcHBsaW50X3VuaXR0ZXN0LnB5OgorCisyMDA5LTA3LTIxICBTaGluaWNoaXJvIEhh bWFqaSAgPGhhbWFqaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKICAgICAgICAgY3BwbGludC5weSdzIHByb2Nlc3NfZmlsZSgpIHNob3VsZCBh Y2NlcHQgY3VzdG9taXplZCBlcnJvciBmdW5jdGlvbgogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc0ODcKIApkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMv U2NyaXB0cy9tb2R1bGVzL2NwcGxpbnQucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMv Y3BwbGludC5weQppbmRleCAzZTcyMmNmLi4xNmViNDdjIDEwMDc1NQotLS0gYS9XZWJLaXRUb29s cy9TY3JpcHRzL21vZHVsZXMvY3BwbGludC5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL21v ZHVsZXMvY3BwbGludC5weQpAQCAtMjc5MCw5ICsyNzkwLDYgQEAgZGVmIHBhcnNlX2FyZ3VtZW50 cyhhcmdzKToKICAgICAgICAgICAgIGlmIG5vdCBmaWx0ZXJzOgogICAgICAgICAgICAgICAgIHBy aW50X2NhdGVnb3JpZXMoKQogCi0gICAgaWYgbm90IGZpbGVuYW1lczoKLSAgICAgICAgcHJpbnRf dXNhZ2UoJ05vIGZpbGVzIHdlcmUgc3BlY2lmaWVkLicpCi0KICAgICBfc2V0X291dHB1dF9mb3Jt YXQob3V0cHV0X2Zvcm1hdCkKICAgICBfc2V0X3ZlcmJvc2VfbGV2ZWwodmVyYm9zaXR5KQogICAg IF9zZXRfZmlsdGVycyhmaWx0ZXJzKQpAQCAtMjg0OCw2ICsyODQ1LDggQEAgdGhhdCB5b3Ugbm90 aWNlIHRoYXQgaXQgZmxhZ3MgaW5jb3JyZWN0bHkuCiAgICAgdXNlX3dlYmtpdF9zdHlsZXMoKQog CiAgICAgZmlsZW5hbWVzID0gcGFyc2VfYXJndW1lbnRzKHN5cy5hcmd2WzE6XSkKKyAgICBpZiBu b3QgZmlsZW5hbWVzOgorICAgICAgICBwcmludF91c2FnZSgnTm8gZmlsZXMgd2VyZSBzcGVjaWZp ZWQuJykKIAogICAgICMgQ2hhbmdlIHN0ZGVyciB0byB3cml0ZSB3aXRoIHJlcGxhY2VtZW50IGNo YXJhY3RlcnMgc28gd2UgZG9uJ3QgZGllCiAgICAgIyBpZiB3ZSB0cnkgdG8gcHJpbnQgc29tZXRo aW5nIGNvbnRhaW5pbmcgbm9uLUFTQ0lJIGNoYXJhY3RlcnMuCmRpZmYgLS1naXQgYS9XZWJLaXRU b29scy9TY3JpcHRzL21vZHVsZXMvY3BwbGludF91bml0dGVzdC5weSBiL1dlYktpdFRvb2xzL1Nj cmlwdHMvbW9kdWxlcy9jcHBsaW50X3VuaXR0ZXN0LnB5CmluZGV4IGRhMzEwYzQuLjA0MDVlZjkg MTAwNzU1Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBsaW50X3VuaXR0ZXN0 LnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBsaW50X3VuaXR0ZXN0LnB5 CkBAIC0xNTA0LDIwICsxNTA0LDIxIEBAIGNsYXNzIENwcGxpbnRUZXN0KENwcGxpbnRUZXN0QmFz ZSk6CiAgICAgICAgICAgICBjcHBsaW50Ll9VU0FHRSA9ICcnCiAgICAgICAgICAgICBjcHBsaW50 Ll9FUlJPUl9DQVRFR09SSUVTID0gJycKIAotICAgICAgICAgICAgc2VsZi5hc3NlcnRSYWlzZXMo U3lzdGVtRXhpdCwgY3BwbGludC5wYXJzZV9hcmd1bWVudHMsIFtdKQogICAgICAgICAgICAgc2Vs Zi5hc3NlcnRSYWlzZXMoU3lzdGVtRXhpdCwgY3BwbGludC5wYXJzZV9hcmd1bWVudHMsIFsnLS1i YWRvcHQnXSkKICAgICAgICAgICAgIHNlbGYuYXNzZXJ0UmFpc2VzKFN5c3RlbUV4aXQsIGNwcGxp bnQucGFyc2VfYXJndW1lbnRzLCBbJy0taGVscCddKQotICAgICAgICAgICAgc2VsZi5hc3NlcnRS YWlzZXMoU3lzdGVtRXhpdCwgY3BwbGludC5wYXJzZV9hcmd1bWVudHMsIFsnLS12PTAnXSkKICAg ICAgICAgICAgIHNlbGYuYXNzZXJ0UmFpc2VzKFN5c3RlbUV4aXQsIGNwcGxpbnQucGFyc2VfYXJn dW1lbnRzLCBbJy0tZmlsdGVyPSddKQogICAgICAgICAgICAgIyBUaGlzIGlzIGlsbGVnYWwgYmVj YXVzZSBhbGwgZmlsdGVycyBtdXN0IHN0YXJ0IHdpdGggKyBvciAtCi0gICAgICAgICAgICBzZWxm LmFzc2VydFJhaXNlcyhTeXN0ZW1FeGl0LCBjcHBsaW50LnBhcnNlX2FyZ3VtZW50cywgWyctLWZp bHRlcj1mb28nXSkKLSAgICAgICAgICAgIHNlbGYuYXNzZXJ0UmFpc2VzKFN5c3RlbUV4aXQsIGNw cGxpbnQucGFyc2VfYXJndW1lbnRzLAorICAgICAgICAgICAgc2VsZi5hc3NlcnRSYWlzZXMoVmFs dWVFcnJvciwgY3BwbGludC5wYXJzZV9hcmd1bWVudHMsIFsnLS1maWx0ZXI9Zm9vJ10pCisgICAg ICAgICAgICBzZWxmLmFzc2VydFJhaXNlcyhWYWx1ZUVycm9yLCBjcHBsaW50LnBhcnNlX2FyZ3Vt ZW50cywKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFsnLS1maWx0ZXI9K2EsYiwtYydd KQogCiAgICAgICAgICAgICBzZWxmLmFzc2VydEVxdWFscyhbJ2Zvby5jYyddLCBjcHBsaW50LnBh cnNlX2FyZ3VtZW50cyhbJ2Zvby5jYyddKSkKICAgICAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxz KG9sZF9vdXRwdXRfZm9ybWF0LCBjcHBsaW50Ll9jcHBsaW50X3N0YXRlLm91dHB1dF9mb3JtYXQp CiAgICAgICAgICAgICBzZWxmLmFzc2VydEVxdWFscyhvbGRfdmVyYm9zZV9sZXZlbCwgY3BwbGlu dC5fY3BwbGludF9zdGF0ZS52ZXJib3NlX2xldmVsKQogCisgICAgICAgICAgICBzZWxmLmFzc2Vy dEVxdWFscyhbXSwgY3BwbGludC5wYXJzZV9hcmd1bWVudHMoW10pKQorICAgICAgICAgICAgc2Vs Zi5hc3NlcnRFcXVhbHMoW10sIGNwcGxpbnQucGFyc2VfYXJndW1lbnRzKFsnLS12PTAnXSkpCisK ICAgICAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKFsnZm9vLmNjJ10sCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBjcHBsaW50LnBhcnNlX2FyZ3VtZW50cyhbJy0tdj0xJywgJ2Zvby5j YyddKSkKICAgICAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKDEsIGNwcGxpbnQuX2NwcGxpbnRf c3RhdGUudmVyYm9zZV9sZXZlbCk=