274880 2024-05-29 20:38:10 -0700 `import-w3c-tests` should provide a meaningful error when the directory doesn't exist 2025-06-16 16:49:07 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified NEW InRadar P2 Normal --- 1 marcosc gsnedders gsnedders marcosc simon.fraser webkit-bug-importer oldest_to_newest 2038660 0 marcosc 2024-05-29 20:38:10 -0700 STR: ``` import-w3c-tests web-platform-tests/clipboard-apis --src-dir . --clean-dest-dir ``` Where the --src-dir does not contain any wpt tests (any random folder). 2038661 1 marcosc 2024-05-29 20:40:50 -0700 Noting that the output form this is: Import complete IMPORTED 0 TOTAL TESTS Imported 0 reftests Imported 0 JS tests Imported 0 Crash tests Imported 0 pixel/manual tests Properties needing prefixes (by count): So, even though it claims nothing happened, it actually trashed an entire directory. That's quite unexpected and could lead to confusion. 2038662 2 marcosc 2024-05-29 20:41:00 -0700 Noting that the output form this is: Import complete IMPORTED 0 TOTAL TESTS Imported 0 reftests Imported 0 JS tests Imported 0 Crash tests Imported 0 pixel/manual tests Properties needing prefixes (by count): So, even though it claims nothing happened, it actually trashed an entire directory. That's quite unexpected and could lead to confusion. 2038663 3 webkit-bug-importer 2024-05-29 20:41:29 -0700 <rdar://problem/128981568> 2038784 4 gsnedders 2024-05-30 09:07:08 -0700 rdar://117683918 2040711 5 karlcow 2024-06-10 19:29:12 -0700 Pull request: https://github.com/WebKit/WebKit/pull/29695 2040830 6 gsnedders 2024-06-11 10:52:05 -0700 The fundamental problem here is we should error out when you request to import a path that doesn't exist (because either the source directory doesn't exist, or the path doesn't exist within the source directory), rather than continuing and importing the zero tests within the non-existent path, and with `--clean-dest-dir` deleting any currently imported tests because those tests don't exist in the non-existent path. That makes the same as rdar://117683918, which wasn't specifically about the `--clean-dest-dir` case, but was about confusion with nothing getting imported when a non-existent path is passed (because it just does nothing at all without `--clean-dest-dir`). 2040868 7 karlcow 2024-06-11 14:53:12 -0700 > The fundamental problem here is we should error out when you request to import a path that doesn't exist yes that's the goal. 2120738 8 gsnedders 2025-05-30 11:30:10 -0700 *** Bug 277278 has been marked as a duplicate of this bug. *** 2124091 9 gsnedders 2025-06-16 16:49:07 -0700 Pull request: https://github.com/WebKit/WebKit/pull/46826