27487 2009-07-21 00:56:17 -0700 cpplint.py's process_file() should accept customized error function 2009-07-21 03:12:47 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 hamaji webkit-unassigned levin oldest_to_newest 133388 0 hamaji 2009-07-21 00:56:17 -0700 run-webkit-lint will need this to filter lint errors based on the patch. 133391 1 33153 hamaji 2009-07-21 01:09:25 -0700 Created attachment 33153 Patch v1 --- 3 files changed, 25 insertions(+), 0 deletions(-) 133392 2 33154 hamaji 2009-07-21 01:10:31 -0700 Created attachment 33154 Patch v2 --- 2 files changed, 11 insertions(+), 2 deletions(-) 133394 3 hamaji 2009-07-21 01:11:37 -0700 Oops, I sent a wrong patch. Please ignore "Patch v1". 133395 4 33154 levin 2009-07-21 01:16:20 -0700 Comment on attachment 33154 Patch v2 I thought I had just reviewed that other patch but then thought maybe I forgot to click submit. :) 133433 5 levin 2009-07-21 03:12:47 -0700 Committed as http://trac.webkit.org/changeset/46163 33153 2009-07-21 01:09:25 -0700 2009-07-21 01:10:27 -0700 Patch v1 bug-27487-20090721170924.patch text/plain 2055 hamaji ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBiNmFmZTUyLi5iYzg3YTMzIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDct MjEgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBjcHBsaW50LnB5IHNob3VsZCBo YXZlIGFuIGludGVyZmFjZSB0byBnZXQgZ2xvYmFsIGVycm9yIGNvdW50CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzQ4NgorCisgICAgICAgICogU2Ny aXB0cy9tb2R1bGVzL2NwcGxpbnQucHk6CisgICAgICAgICogU2NyaXB0cy9tb2R1bGVzL2NwcGxp bnRfdW5pdHRlc3QucHk6CisKIDIwMDktMDctMjAgIFBldGVyIEthc3RpbmcgIDxwa2FzdGluZ0Bn b29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hcmsgUm93ZS4KZGlmZiAtLWdpdCBh L1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBsaW50LnB5IGIvV2ViS2l0VG9vbHMvU2Ny aXB0cy9tb2R1bGVzL2NwcGxpbnQucHkKb2xkIG1vZGUgMTAwNjQ0Cm5ldyBtb2RlIDEwMDc1NQpp bmRleCA4OTk3NDQ0Li4xMmJlZTIyCi0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9j cHBsaW50LnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBsaW50LnB5CkBA IC00NDQsNiArNDQ0LDExIEBAIGRlZiBfc2V0X2ZpbHRlcnMoZmlsdGVycyk6CiAgICAgX2NwcGxp bnRfc3RhdGUuc2V0X2ZpbHRlcnMoZmlsdGVycykKIAogCitkZWYgZXJyb3JfY291bnQoKToKKyAg ICAiIiJSZXR1cm5zIHRoZSBnbG9iYWwgY291bnQgb2YgcmVwb3J0ZWQgZXJyb3JzLiIiIgorICAg IHJldHVybiBfY3BwbGludF9zdGF0ZS5lcnJvcl9jb3VudAorCisKIGNsYXNzIF9GdW5jdGlvblN0 YXRlKG9iamVjdCk6CiAgICAgIiIiVHJhY2tzIGN1cnJlbnQgZnVuY3Rpb24gbmFtZSBhbmQgdGhl IG51bWJlciBvZiBsaW5lcyBpbiBpdHMgYm9keS4iIiIKIApkaWZmIC0tZ2l0IGEvV2ViS2l0VG9v bHMvU2NyaXB0cy9tb2R1bGVzL2NwcGxpbnRfdW5pdHRlc3QucHkgYi9XZWJLaXRUb29scy9TY3Jp cHRzL21vZHVsZXMvY3BwbGludF91bml0dGVzdC5weQpvbGQgbW9kZSAxMDA2NDQKbmV3IG1vZGUg MTAwNzU1CmluZGV4IGY2ZTQ4NzguLmRhMzEwYzQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9t b2R1bGVzL2NwcGxpbnRfdW5pdHRlc3QucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1 bGVzL2NwcGxpbnRfdW5pdHRlc3QucHkKQEAgLTI2NTcsNiArMjY1NywxNiBAQCBjbGFzcyBOb05v blZpcnR1YWxEZXN0cnVjdG9yc1Rlc3QoQ3BwbGludFRlc3RCYXNlKToKICAgICAgICAgICAgICAn dmlydHVhbCBtZXRob2QocyksIG9uZSBkZWNsYXJlZCBhdCBsaW5lIDIuICBbcnVudGltZS92aXJ0 dWFsXSBbNF0nXSkKIAogCitjbGFzcyBDcHBMaW50U3RhdGVUZXN0KHVuaXR0ZXN0LlRlc3RDYXNl KToKKyAgICBkZWYgdGVzdF9lcnJvcl9jb3VudChzZWxmKToKKyAgICAgICAgc2VsZi5hc3NlcnRF cXVhbHMoMCwgY3BwbGludC5lcnJvcl9jb3VudCgpKQorICAgICAgICBjcHBsaW50Ll9jcHBsaW50 X3N0YXRlLmluY3JlbWVudF9lcnJvcl9jb3VudCgpCisgICAgICAgIGNwcGxpbnQuX2NwcGxpbnRf c3RhdGUuaW5jcmVtZW50X2Vycm9yX2NvdW50KCkKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMo MiwgY3BwbGludC5lcnJvcl9jb3VudCgpKQorICAgICAgICBjcHBsaW50Ll9jcHBsaW50X3N0YXRl LnJlc2V0X2Vycm9yX2NvdW50KCkKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoMCwgY3BwbGlu dC5lcnJvcl9jb3VudCgpKQorCisKIGNsYXNzIFdlYktpdFN0eWxlVGVzdChDcHBsaW50VGVzdEJh c2UpOgogCiAgICAgIyBmb3IgaHR0cDovL3dlYmtpdC5vcmcvY29kaW5nL2NvZGluZy1zdHlsZS5o dG1s 33154 2009-07-21 01:10:31 -0700 2009-07-21 01:16:19 -0700 Patch v2 bug-27487-20090721171030.patch text/plain 1390 hamaji ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBiYzg3YTMzLi43ZTUwNTUzIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTUgQEAKIAogICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBjcHBsaW50LnB5J3MgcHJv Y2Vzc19maWxlKCkgc2hvdWxkIGFjY2VwdCBjdXN0b21pemVkIGVycm9yIGZ1bmN0aW9uCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzQ4NworCisgICAg ICAgICogU2NyaXB0cy9tb2R1bGVzL2NwcGxpbnQucHk6CisKKzIwMDktMDctMjEgIFNoaW5pY2hp cm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKwogICAgICAgICBjcHBsaW50LnB5IHNob3VsZCBoYXZlIGFuIGludGVy ZmFjZSB0byBnZXQgZ2xvYmFsIGVycm9yIGNvdW50CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzQ4NgogCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9T Y3JpcHRzL21vZHVsZXMvY3BwbGludC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9j cHBsaW50LnB5CmluZGV4IDEyYmVlMjIuLjNlNzIyY2YgMTAwNzU1Ci0tLSBhL1dlYktpdFRvb2xz L1NjcmlwdHMvbW9kdWxlcy9jcHBsaW50LnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9k dWxlcy9jcHBsaW50LnB5CkBAIC0yNjcwLDE0ICsyNjcwLDE0IEBAIGRlZiBwcm9jZXNzX2ZpbGVf ZGF0YShmaWxlbmFtZSwgZmlsZV9leHRlbnNpb24sIGxpbmVzLCBlcnJvcik6CiAgICAgY2hlY2tf Zm9yX25ld19saW5lX2F0X2VvZihmaWxlbmFtZSwgbGluZXMsIGVycm9yKQogCiAKLWRlZiBwcm9j ZXNzX2ZpbGUoZmlsZW5hbWUsIHZsZXZlbCk6CitkZWYgcHJvY2Vzc19maWxlKGZpbGVuYW1lLCB2 bGV2ZWwsIGVycm9yPWVycm9yKToKICAgICAiIiJEb2VzIGdvb2dsZS1saW50IG9uIGEgc2luZ2xl IGZpbGUuCiAKICAgICBBcmdzOgogICAgICAgZmlsZW5hbWU6IFRoZSBuYW1lIG9mIHRoZSBmaWxl IHRvIHBhcnNlLgotCiAgICAgICB2bGV2ZWw6IFRoZSBsZXZlbCBvZiBlcnJvcnMgdG8gcmVwb3J0 LiAgRXZlcnkgZXJyb3Igb2YgY29uZmlkZW5jZQogICAgICAgPj0gdmVyYm9zZV9sZXZlbCB3aWxs IGJlIHJlcG9ydGVkLiAgMCBpcyBhIGdvb2QgZGVmYXVsdC4KKyAgICAgIGVycm9yOiBUaGUgZnVu Y3Rpb24gdG8gY2FsbCB3aXRoIGFueSBlcnJvcnMgZm91bmQuCiAgICAgIiIiCiAKICAgICBfc2V0 X3ZlcmJvc2VfbGV2ZWwodmxldmVsKQ==