<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>27484</bug_id>
          
          <creation_ts>2009-07-20 23:17:41 -0700</creation_ts>
          <short_desc>diff_parser: s/add_deleted_line/add_old_line/g</short_desc>
          <delta_ts>2009-07-21 02:58:09 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Shinichiro Hamaji">hamaji</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>levin</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>133370</commentid>
    <comment_count>0</comment_count>
    <who name="Shinichiro Hamaji">hamaji</who>
    <bug_when>2009-07-20 23:17:41 -0700</bug_when>
    <thetext>The name of function &quot;add_old_line&quot; should be add_deleted_line.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>133371</commentid>
    <comment_count>1</comment_count>
      <attachid>33146</attachid>
    <who name="Shinichiro Hamaji">hamaji</who>
    <bug_when>2009-07-20 23:19:16 -0700</bug_when>
    <thetext>Created attachment 33146
Patch v1


---
 2 files changed, 15 insertions(+), 6 deletions(-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>133428</commentid>
    <comment_count>2</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2009-07-21 02:58:09 -0700</bug_when>
    <thetext>Committed as http://trac.webkit.org/changeset/46160</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>33146</attachid>
            <date>2009-07-20 23:19:16 -0700</date>
            <delta_ts>2009-07-20 23:42:10 -0700</delta_ts>
            <desc>Patch v1</desc>
            <filename>bug-27484-20090721151915.patch</filename>
            <type>text/plain</type>
            <size>2351</size>
            <attacher name="Shinichiro Hamaji">hamaji</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv
ZwppbmRleCBiNmFmZTUyLi43OTQyNDUzIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM
b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMDct
MjAgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBS
ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBkaWZmX3BhcnNlcjogcy9hZGRf
ZGVsZXRlZF9saW5lL2FkZF9vbGRfbGluZS9nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu
b3JnL3Nob3dfYnVnLmNnaT9pZD0yNzQ4NAorCisgICAgICAgICogU2NyaXB0cy9tb2R1bGVzL2Rp
ZmZfcGFyc2VyLnB5OgorCiAyMDA5LTA3LTIwICBQZXRlciBLYXN0aW5nICA8cGthc3RpbmdAZ29v
Z2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYXJrIFJvd2UuCmRpZmYgLS1naXQgYS9X
ZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvZGlmZl9wYXJzZXIucHkgYi9XZWJLaXRUb29scy9T
Y3JpcHRzL21vZHVsZXMvZGlmZl9wYXJzZXIucHkKaW5kZXggODQxNDBjZi4uNzQ5ZDE4MyAxMDA2
NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2RpZmZfcGFyc2VyLnB5CisrKyBi
L1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9kaWZmX3BhcnNlci5weQpAQCAtODMsOCArODMs
OCBAQCBjbGFzcyBEaWZmRmlsZToKICAgICAiIiJDb250YWlucyB0aGUgaW5mb3JtYXRpb24gZm9y
IG9uZSBmaWxlIGluIGEgcGF0Y2guCiAKICAgICBUaGUgZmllbGQgImxpbmVzIiBpcyBhIGxpc3Qg
d2hpY2ggY29udGFpbnMgdHVwbGVzIGluIHRoaXMgZm9ybWF0OgotICAgICAgIChvbGRfbGluZV9u
dW1iZXIsIG5ld19saW5lX251bWJlciwgbGluZV9zdHJpbmcpCi0gICAgSWYgb2xkX2xpbmVfbnVt
YmVyIGlzIHplcm8sIGl0IG1lYW5zIHRoaXMgbGluZSBpcyBuZXdseSBhZGRlZC4KKyAgICAgICAo
ZGVsZXRlZF9saW5lX251bWJlciwgbmV3X2xpbmVfbnVtYmVyLCBsaW5lX3N0cmluZykKKyAgICBJ
ZiBkZWxldGVkX2xpbmVfbnVtYmVyIGlzIHplcm8sIGl0IG1lYW5zIHRoaXMgbGluZSBpcyBuZXds
eSBhZGRlZC4KICAgICBJZiBuZXdfbGluZV9udW1iZXIgaXMgemVybywgaXQgbWVhbnMgdGhpcyBs
aW5lIGlzIGRlbGV0ZWQuCiAgICAgIiIiCiAKQEAgLTk1LDExICs5NSwxMSBAQCBjbGFzcyBEaWZm
RmlsZToKICAgICBkZWYgYWRkX25ld19saW5lKHNlbGYsIGxpbmVfbnVtYmVyLCBsaW5lKToKICAg
ICAgICAgc2VsZi5saW5lcy5hcHBlbmQoKDAsIGxpbmVfbnVtYmVyLCBsaW5lKSkKIAotICAgIGRl
ZiBhZGRfb2xkX2xpbmUoc2VsZiwgbGluZV9udW1iZXIsIGxpbmUpOgorICAgIGRlZiBhZGRfZGVs
ZXRlZF9saW5lKHNlbGYsIGxpbmVfbnVtYmVyLCBsaW5lKToKICAgICAgICAgc2VsZi5saW5lcy5h
cHBlbmQoKGxpbmVfbnVtYmVyLCAwLCBsaW5lKSkKIAotICAgIGRlZiBhZGRfdW5jaGFuZ2VkX2xp
bmUoc2VsZiwgb2xkX2xpbmVfbnVtYmVyLCBuZXdfbGluZV9udW1iZXIsIGxpbmUpOgotICAgICAg
ICBzZWxmLmxpbmVzLmFwcGVuZCgob2xkX2xpbmVfbnVtYmVyLCBuZXdfbGluZV9udW1iZXIsIGxp
bmUpKQorICAgIGRlZiBhZGRfdW5jaGFuZ2VkX2xpbmUoc2VsZiwgZGVsZXRlZF9saW5lX251bWJl
ciwgbmV3X2xpbmVfbnVtYmVyLCBsaW5lKToKKyAgICAgICAgc2VsZi5saW5lcy5hcHBlbmQoKGRl
bGV0ZWRfbGluZV9udW1iZXIsIG5ld19saW5lX251bWJlciwgbGluZSkpCiAKIAogY2xhc3MgRGlm
ZlBhcnNlcjoKQEAgLTE0OCw3ICsxNDgsNyBAQCBjbGFzcyBEaWZmUGFyc2VyOgogICAgICAgICAg
ICAgICAgICAgICBjdXJyZW50X2ZpbGUuYWRkX25ld19saW5lKG5ld19kaWZmX2xpbmUsIGxpbmVb
MTpdKQogICAgICAgICAgICAgICAgICAgICBuZXdfZGlmZl9saW5lICs9IDEKICAgICAgICAgICAg
ICAgICBlbGlmIGxpbmUuc3RhcnRzd2l0aCgnLScpOgotICAgICAgICAgICAgICAgICAgICBjdXJy
ZW50X2ZpbGUuYWRkX29sZF9saW5lKG9sZF9kaWZmX2xpbmUsIGxpbmVbMTpdKQorICAgICAgICAg
ICAgICAgICAgICBjdXJyZW50X2ZpbGUuYWRkX2RlbGV0ZWRfbGluZShvbGRfZGlmZl9saW5lLCBs
aW5lWzE6XSkKICAgICAgICAgICAgICAgICAgICAgb2xkX2RpZmZfbGluZSArPSAxCiAgICAgICAg
ICAgICAgICAgZWxpZiBsaW5lLnN0YXJ0c3dpdGgoJyAnKToKICAgICAgICAgICAgICAgICAgICAg
Y3VycmVudF9maWxlLmFkZF91bmNoYW5nZWRfbGluZShvbGRfZGlmZl9saW5lLCBuZXdfZGlmZl9s
aW5lLCBsaW5lWzE6XSk=
</data>
<flag name="review"
          id="17467"
          type_id="1"
          status="+"
          setter="levin"
    />
          </attachment>
      

    </bug>

</bugzilla>