27483 2009-07-20 23:10:18 -0700 diff_parser should accept lines without trailing \n 2009-07-21 03:13:15 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 hamaji webkit-unassigned levin oldest_to_newest 133368 0 hamaji 2009-07-20 23:10:18 -0700 It would be better to normalize the input lines by removing trailing newlines to accept both patch.splitlines() and file object. 133369 1 33145 hamaji 2009-07-20 23:14:08 -0700 Created attachment 33145 Patch v1 --- 3 files changed, 29 insertions(+), 2 deletions(-) 133378 2 33145 levin 2009-07-20 23:50:07 -0700 Comment on attachment 33145 Patch v1 > diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog > + > + Normalize the input lines by removing a trailing newline. > + Also, add a case for unittest for newly added files. I think this reads better: "Also, add a case to the unittest for newly added files." fwiw, it is best to keep your patches focused on one thing and this does a bit more, so the bug doesn't reflect what is being done. However, it is all rather simple and you do describe it, so no need to break it up this time. 133434 3 levin 2009-07-21 03:13:15 -0700 Committed as http://trac.webkit.org/changeset/46164 33145 2009-07-20 23:14:08 -0700 2009-07-20 23:50:07 -0700 Patch v1 bug-27483-20090721151407.patch text/plain 3354 hamaji ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBiNmFmZTUyLi5kZDZhYWU0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDct MjAgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBkaWZmX3BhcnNlciBzaG91bGQg YWNjZXB0IGxpbmVzIHdpdGhvdXQgdHJhaWxpbmcgXG4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3NDgzCisKKyAgICAgICAgTm9ybWFsaXplIHRoZSBp bnB1dCBsaW5lcyBieSByZW1vdmluZyBhIHRyYWlsaW5nIG5ld2xpbmUuCisgICAgICAgIEFsc28s IGFkZCBhIGNhc2UgZm9yIHVuaXR0ZXN0IGZvciBuZXdseSBhZGRlZCBmaWxlcy4KKworICAgICAg ICAqIFNjcmlwdHMvbW9kdWxlcy9kaWZmX3BhcnNlci5weToKKyAgICAgICAgKiBTY3JpcHRzL21v ZHVsZXMvZGlmZl9wYXJzZXJfdW5pdHRlc3QucHk6CisKIDIwMDktMDctMjAgIFBldGVyIEthc3Rp bmcgIDxwa2FzdGluZ0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hcmsgUm93 ZS4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9kaWZmX3BhcnNlci5w eSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9kaWZmX3BhcnNlci5weQppbmRleCA4NDE0 MGNmLi5kZDAzOGVmIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvZGlm Zl9wYXJzZXIucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2RpZmZfcGFyc2Vy LnB5CkBAIC0xMjIsNiArMTIyLDcgQEAgY2xhc3MgRGlmZlBhcnNlcjoKICAgICAgICAgb2xkX2Rp ZmZfbGluZSA9IE5vbmUKICAgICAgICAgbmV3X2RpZmZfbGluZSA9IE5vbmUKICAgICAgICAgZm9y IGxpbmUgaW4gZGlmZl9pbnB1dDoKKyAgICAgICAgICAgIGxpbmUgPSBsaW5lLnJzdHJpcCgiXG4i KQogICAgICAgICAgICAgaWYgc3RhdGUgPT0gX0lOSVRJQUxfU1RBVEU6CiAgICAgICAgICAgICAg ICAgdHJhbnNmb3JtX2xpbmUgPSBnZXRfZGlmZl9jb252ZXJ0ZXIobGluZSkKICAgICAgICAgICAg IGxpbmUgPSB0cmFuc2Zvcm1fbGluZShsaW5lKQpAQCAtMTU0LDcgKzE1NSw3IEBAIGNsYXNzIERp ZmZQYXJzZXI6CiAgICAgICAgICAgICAgICAgICAgIGN1cnJlbnRfZmlsZS5hZGRfdW5jaGFuZ2Vk X2xpbmUob2xkX2RpZmZfbGluZSwgbmV3X2RpZmZfbGluZSwgbGluZVsxOl0pCiAgICAgICAgICAg ICAgICAgICAgIG9sZF9kaWZmX2xpbmUgKz0gMQogICAgICAgICAgICAgICAgICAgICBuZXdfZGlm Zl9saW5lICs9IDEKLSAgICAgICAgICAgICAgICBlbGlmIGxpbmUgPT0gJ1xcIE5vIG5ld2xpbmUg YXQgZW5kIG9mIGZpbGVcbic6CisgICAgICAgICAgICAgICAgZWxpZiBsaW5lID09ICdcXCBObyBu ZXdsaW5lIGF0IGVuZCBvZiBmaWxlJzoKICAgICAgICAgICAgICAgICAgICAgIyBOb3RoaW5nIHRv IGRvLiAgV2UgbWF5IHN0aWxsIGhhdmUgc29tZSBhZGRlZCBsaW5lcy4KICAgICAgICAgICAgICAg ICAgICAgcGFzcwogICAgICAgICAgICAgICAgIGVsc2U6CmRpZmYgLS1naXQgYS9XZWJLaXRUb29s cy9TY3JpcHRzL21vZHVsZXMvZGlmZl9wYXJzZXJfdW5pdHRlc3QucHkgYi9XZWJLaXRUb29scy9T Y3JpcHRzL21vZHVsZXMvZGlmZl9wYXJzZXJfdW5pdHRlc3QucHkKaW5kZXggNzM4ZDA1NS4uMWM4 MDZmMCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2RpZmZfcGFyc2Vy X3VuaXR0ZXN0LnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9kaWZmX3BhcnNl cl91bml0dGVzdC5weQpAQCAtNzQsMTIgKzc0LDIwIEBAIGluZGV4IGNlMjE3MjAuLjMyNDkyOWUg MTAwNjQ0CiAgfQogIAogIGJvb2wgU3R5bGVSYXJlSW5oZXJpdGVkRGF0YTo6c2hhZG93RGF0YUVx dWl2YWxlbnQoY29uc3QgU3R5bGVSYXJlSW5oZXJpdGVkRGF0YSYgbykgY29uc3QKK2RpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9mbGV4Ym94L2JveC1vcmllbnQtYnV0 dG9uLWV4cGVjdGVkLmNoZWNrc3VtIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvZmxl eGJveC9ib3gtb3JpZW50LWJ1dHRvbi1leHBlY3RlZC5jaGVja3N1bQorbmV3IGZpbGUgbW9kZSAx MDA2NDQKK2luZGV4IDAwMDAwMDAuLjZkYjI2YmQKKy0tLSAvZGV2L251bGwKKysrKyBiL0xheW91 dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L2ZsZXhib3gvYm94LW9yaWVudC1idXR0b24tZXhwZWN0 ZWQuY2hlY2tzdW0KK0BAIC0wLDAgKzEgQEAKKys2MWEzNzNlZTczOTY3M2E5ZGNkN2JhYzYyYjlm MTgyZQorXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCiAnJycuc3BsaXRsaW5lcygpCiAKIAog ICAgIGRlZiB0ZXN0X2RpZmZfcGFyc2VyKHNlbGYpOgogICAgICAgICBwYXJzZXIgPSBkaWZmX3Bh cnNlci5EaWZmUGFyc2VyKHNlbGYuX1BBVENIKQotICAgICAgICBzZWxmLmFzc2VydEVxdWFscygy LCBsZW4ocGFyc2VyLmZpbGVzKSkKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoMywgbGVuKHBh cnNlci5maWxlcykpCiAKICAgICAgICAgc2VsZi5hc3NlcnRUcnVlKCdXZWJDb3JlL3JlbmRlcmlu Zy9zdHlsZS9TdHlsZUZsZXhpYmxlQm94RGF0YS5oJyBpbiBwYXJzZXIuZmlsZXMpCiAgICAgICAg IGRpZmYgPSBwYXJzZXIuZmlsZXNbJ1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1N0eWxlRmxleGli bGVCb3hEYXRhLmgnXQpAQCAtMTEzLDYgKzEyMSwxMSBAQCBpbmRleCBjZTIxNzIwLi4zMjQ5Mjll IDEwMDY0NAogICAgICAgICBzZWxmLmFzc2VydEVxdWFscygoODYsIDg5KSwgZGlmZi5saW5lc1sy MV1bMDoyXSkKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoKDg3LCA5MCksIGRpZmYubGluZXNb MjJdWzA6Ml0pCiAKKyAgICAgICAgIyBDaGVjayBpZiBhIG5ld2x5IGFkZGVkIGZpbGUgaXMgY29y cmVjdGx5IGhhbmRsZWQuCisgICAgICAgIGRpZmYgPSBwYXJzZXIuZmlsZXNbJ0xheW91dFRlc3Rz L3BsYXRmb3JtL21hYy9mYXN0L2ZsZXhib3gvYm94LW9yaWVudC1idXR0b24tZXhwZWN0ZWQuY2hl Y2tzdW0nXQorICAgICAgICBzZWxmLmFzc2VydEVxdWFscygxLCBsZW4oZGlmZi5saW5lcykpCisg ICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKCgwLCAxKSwgZGlmZi5saW5lc1swXVswOjJdKQorCiAK IGlmIF9fbmFtZV9fID09ICdfX21haW5fXyc6CiAgICAgdW5pdHRlc3QubWFpbigp