27479 2009-07-20 19:25:43 -0700 Guard access to installedMediaEngines()[0] 2009-07-20 20:32:58 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 agl webkit-unassigned oldest_to_newest 133334 0 agl 2009-07-20 19:25:43 -0700 Else where in the file, installedMediaEngines is always checked for being empty because access. This patch adds a case which missed that check. This triggered a crash in Chromium: http://www.yakeze.com/chat/example-chromium-crash/ However, I've been unable to reduce the reproduction, so there's no layout test. 133335 1 33136 agl 2009-07-20 19:26:38 -0700 Created attachment 33136 patch 133345 2 33136 mjs 2009-07-20 19:53:21 -0700 Comment on attachment 33136 patch r=me 133346 3 33138 agl 2009-07-20 19:55:05 -0700 Created attachment 33138 patch 133347 4 agl 2009-07-20 19:55:43 -0700 (eric helped me find a reduction and write a layout test) 133349 5 33138 eric 2009-07-20 19:57:17 -0700 Comment on attachment 33138 patch Ok. A coupel things to fix when landing. The layout test should self-document (i.e. say something like: "PASSED -- crash using Audio with no installed engines bug 27479") The test needs a -expected.txt file from a layout tests run. empty.wav belongs in the resources/ subdirectory. You can fix those when landing. Thanks! 33136 2009-07-20 19:26:38 -0700 2009-07-20 19:55:28 -0700 patch patch text/plain 1585 agl ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODllYmUxMy4uM2Y3Y2NkYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAwOS0wNy0yMCAgQWRhbSBMYW5nbGV5 ICA8YWdsQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgR3VhcmQgYWNjZXNzIHRvIGluc3RhbGxlZE1lZGlhRW5naW5lcygpWzBdLgor CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzQ3OQor CisgICAgICAgIEVsc2Ugd2hlcmUgaW4gdGhlIGZpbGUsIGluc3RhbGxlZE1lZGlhRW5naW5lcyBp cyBhbHdheXMgY2hlY2tlZCBmb3IKKyAgICAgICAgYmVpbmcgZW1wdHkgYmVjYXVzZSBhY2Nlc3Mu IFRoaXMgcGF0Y2ggYWRkcyBhIGNhc2Ugd2hpY2ggbWlzc2VkIHRoYXQKKyAgICAgICAgY2hlY2su CisKKyAgICAgICAgVGhpcyB0cmlnZ2VyZWQgYSBjcmFzaCBpbiBDaHJvbWl1bToKKyAgICAgICAg ICAgIGh0dHA6Ly93d3cueWFrZXplLmNvbS9jaGF0L2V4YW1wbGUtY2hyb21pdW0tY3Jhc2gvCisK KyAgICAgICAgSG93ZXZlciwgSSd2ZSBiZWVuIHVuYWJsZSB0byByZWR1Y2UgdGhlIHJlcHJvZHVj dGlvbiwgc28gdGhlcmUncyBubworICAgICAgICBsYXlvdXQgdGVzdC4KKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlh UGxheWVyOjpsb2FkKToKKwogMjAwOS0wNy0yMCAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0 Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCmRpZmYgLS1naXQgYS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmNwcCBiL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuY3BwCmluZGV4IGI0N2EzZDUuLmQ0ZmFiNTIgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuY3BwCisrKyBiL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuY3BwCkBAIC0yMjksNyArMjI5LDcg QEAgdm9pZCBNZWRpYVBsYXllcjo6bG9hZChjb25zdCBTdHJpbmcmIHVybCwgY29uc3QgQ29udGVu dFR5cGUmIGNvbnRlbnRUeXBlKQogICAgICAgICBlbmdpbmUgPSBjaG9vc2VCZXN0RW5naW5lRm9y VHlwZUFuZENvZGVjcyh0eXBlLCBjb2RlY3MpOwogCiAgICAgLy8gaWYgd2UgZGlkbid0IGZpbmQg YW4gZW5naW5lIHRoYXQgY2xhaW1zIHRoZSBNSU1FIHR5cGUsIGp1c3QgdXNlIHRoZSBmaXJzdCBl bmdpbmUKLSAgICBpZiAoIWVuZ2luZSkKKyAgICBpZiAoIWVuZ2luZSAmJiAhaW5zdGFsbGVkTWVk aWFFbmdpbmVzKCkuaXNFbXB0eSgpKQogICAgICAgICBlbmdpbmUgPSBpbnN0YWxsZWRNZWRpYUVu Z2luZXMoKVswXTsKICAgICAKICAgICAvLyBkb24ndCBkZWxldGUgYW5kIHJlY3JlYXRlIHRoZSBw bGF5ZXIgdW5sZXNzIGl0IGNvbWVzIGZyb20gYSBkaWZmZXJlbnQgZW5naW5lCg== 33138 2009-07-20 19:55:05 -0700 2009-07-20 19:57:17 -0700 patch patch text/plain 2644 agl ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0N2ZjZWEzLi40ZDU5NGNiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDct MjAgIEFkYW0gTGFuZ2xleSAgPGFnbEBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IEVyaWMgU2VpZGVsLgorCisgICAgICAgIENoZWNrIHRoYXQgd2UgY2FuIHBsYXkgYW4gZW1wdHkg YXVkaW8gZmlsZS4gSW4gdGhlIGNhc2UgdGhhdAorICAgICAgICB3ZSBoYXZlIGF1ZGlvL3ZpZGVv IHRhZ3MgZW5hYmxlZCwgYnV0IG5vIGVuZ2luZXMgaW5zdGFsbGVkLAorICAgICAgICB0aGlzIHBy ZXZpb3VzbHkgdHJpZ2dlcmVkIGEgY3Jhc2guCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTI3NDc5CisKKyAgICAgICAgKiBtZWRpYS9hdWRpby1uby1p bnN0YWxsZWQtZW5naW5lcy5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBtZWRpYS9lbXB0eS53YXY6 CisKIDIwMDktMDctMTkgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRp YS9hdWRpby1uby1pbnN0YWxsZWQtZW5naW5lcy5odG1sIGIvTGF5b3V0VGVzdHMvbWVkaWEvYXVk aW8tbm8taW5zdGFsbGVkLWVuZ2luZXMuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwLi4yZThkYjZlCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEvYXVk aW8tbm8taW5zdGFsbGVkLWVuZ2luZXMuaHRtbApAQCAtMCwwICsxLDQgQEAKKzxzY3JpcHQ+Cisg IHZhciBhdWRpbyA9IG5ldyBBdWRpbygiZW1wdHkud2F2Iik7CisgIGF1ZGlvLnBsYXkoKTsKKzwv c2NyaXB0PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvZW1wdHkud2F2IGIvTGF5b3V0 VGVzdHMvbWVkaWEvZW1wdHkud2F2Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAu LmU2OWRlMjkKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VM b2cKaW5kZXggODllYmUxMy4uNTZlZTI5YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAwOS0wNy0yMCAgQWRh bSBMYW5nbGV5ICA8YWdsQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgR3VhcmQgYWNjZXNzIHRvIGluc3RhbGxlZE1lZGlhRW5naW5l cygpWzBdLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yNzQ3OQorCisgICAgICAgIEVsc2Ugd2hlcmUgaW4gdGhlIGZpbGUsIGluc3RhbGxlZE1lZGlh RW5naW5lcyBpcyBhbHdheXMgY2hlY2tlZCBmb3IKKyAgICAgICAgYmVpbmcgZW1wdHkgYmVjYXVz ZSBhY2Nlc3MuIFRoaXMgcGF0Y2ggYWRkcyBhIGNhc2Ugd2hpY2ggbWlzc2VkIHRoYXQKKyAgICAg ICAgY2hlY2suCisKKyAgICAgICAgVGhpcyB0cmlnZ2VyZWQgYSBjcmFzaCBpbiBDaHJvbWl1bToK KyAgICAgICAgICAgIGh0dHA6Ly93d3cueWFrZXplLmNvbS9jaGF0L2V4YW1wbGUtY2hyb21pdW0t Y3Jhc2gvCisKKyAgICAgICAgaHR0cDovL2NvZGUuZ29vZ2xlLmNvbS9wL2Nocm9taXVtL2lzc3Vl cy9kZXRhaWw/aWQ9MTY1NDEKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxh eWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyOjpsb2FkKToKKwogMjAwOS0w Ny0yMCAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBTaW1vbiBGcmFzZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L01lZGlhUGxheWVyLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIu Y3BwCmluZGV4IGI0N2EzZDUuLmQ0ZmFiNTIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvTWVkaWFQbGF5ZXIuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv TWVkaWFQbGF5ZXIuY3BwCkBAIC0yMjksNyArMjI5LDcgQEAgdm9pZCBNZWRpYVBsYXllcjo6bG9h ZChjb25zdCBTdHJpbmcmIHVybCwgY29uc3QgQ29udGVudFR5cGUmIGNvbnRlbnRUeXBlKQogICAg ICAgICBlbmdpbmUgPSBjaG9vc2VCZXN0RW5naW5lRm9yVHlwZUFuZENvZGVjcyh0eXBlLCBjb2Rl Y3MpOwogCiAgICAgLy8gaWYgd2UgZGlkbid0IGZpbmQgYW4gZW5naW5lIHRoYXQgY2xhaW1zIHRo ZSBNSU1FIHR5cGUsIGp1c3QgdXNlIHRoZSBmaXJzdCBlbmdpbmUKLSAgICBpZiAoIWVuZ2luZSkK KyAgICBpZiAoIWVuZ2luZSAmJiAhaW5zdGFsbGVkTWVkaWFFbmdpbmVzKCkuaXNFbXB0eSgpKQog ICAgICAgICBlbmdpbmUgPSBpbnN0YWxsZWRNZWRpYUVuZ2luZXMoKVswXTsKICAgICAKICAgICAv LyBkb24ndCBkZWxldGUgYW5kIHJlY3JlYXRlIHRoZSBwbGF5ZXIgdW5sZXNzIGl0IGNvbWVzIGZy b20gYSBkaWZmZXJlbnQgZW5naW5lCg==