27477 2009-07-20 18:52:46 -0700 Incorrect assertion in Vector::remove 2009-07-20 20:10:03 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jberlin jberlin jberlin mrowe oldest_to_newest 133326 0 jberlin 2009-07-20 18:52:46 -0700 inline void Vector<T, inlineCapacity>::remove(size_t position, size_t length) { ASSERT(position < size()); ASSERT(position + length < size()); T* beginSpot = begin() + position; .... Should be: inline void Vector<T, inlineCapacity>::remove(size_t position, size_t length) { ASSERT(position < size()); ASSERT(position + length <= size()); T* beginSpot = begin() + position; .... 133339 1 33137 jberlin 2009-07-20 19:36:52 -0700 Created attachment 33137 Patch that makes the assertion check for <= instead of just <. 133352 2 jberlin 2009-07-20 20:10:03 -0700 commited with revision 46147 33137 2009-07-20 19:36:52 -0700 2009-07-20 19:44:49 -0700 Patch that makes the assertion check for <= instead of just <. fixIncorrectVectorAssertion.txt text/plain 1341 jberlin SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ2MTQzKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDktMDctMjAgIEplc3NpZSBC ZXJsaW4gIDxqYmVybGluQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBGaXggYW4gaW5jb3JyZWN0IGFzc2VydGlvbiBpbiBWZWN0b3I6 OnJlbW92ZS4KKyAgICAgICAgCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yNzQ3NworCisgICAgICAgICogd3RmL1ZlY3Rvci5oOgorICAgICAgICAoV1RG Ojo6OnJlbW92ZSk6CisgICAgICAgIEFzc2VydCB0aGF0IHRoZSBwb3NpdGlvbiBhdCB3aGljaCB0 byBzdGFydCByZW1vdmluZyBlbGVtZW50cyArIHRoZQorICAgICAgICBsZW5ndGggKHRoZSBudW1i ZXIgb2YgZWxlbWVudHMgdG8gcmVtb3ZlKSBpcyBsZXNzIHRoYW4gb3IgZXF1YWwgdG8gdGhlCisg ICAgICAgIHNpemUgb2YgdGhlIGVudGlyZSBWZWN0b3IuCisKIDIwMDktMDctMjAgIFBldGVyIEth c3RpbmcgIDxwa2FzdGluZ0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hcmsg Um93ZS4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9WZWN0b3IuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBK YXZhU2NyaXB0Q29yZS93dGYvVmVjdG9yLmgJKHJldmlzaW9uIDQ2MTQzKQorKysgSmF2YVNjcmlw dENvcmUvd3RmL1ZlY3Rvci5oCSh3b3JraW5nIGNvcHkpCkBAIC05MzQsNyArOTM0LDcgQEAgbmFt ZXNwYWNlIFdURiB7CiAgICAgaW5saW5lIHZvaWQgVmVjdG9yPFQsIGlubGluZUNhcGFjaXR5Pjo6 cmVtb3ZlKHNpemVfdCBwb3NpdGlvbiwgc2l6ZV90IGxlbmd0aCkKICAgICB7CiAgICAgICAgIEFT U0VSVChwb3NpdGlvbiA8IHNpemUoKSk7Ci0gICAgICAgIEFTU0VSVChwb3NpdGlvbiArIGxlbmd0 aCA8IHNpemUoKSk7CisgICAgICAgIEFTU0VSVChwb3NpdGlvbiArIGxlbmd0aCA8PSBzaXplKCkp OwogICAgICAgICBUKiBiZWdpblNwb3QgPSBiZWdpbigpICsgcG9zaXRpb247CiAgICAgICAgIFQq IGVuZFNwb3QgPSBiZWdpblNwb3QgKyBsZW5ndGg7CiAgICAgICAgIFR5cGVPcGVyYXRpb25zOjpk ZXN0cnVjdChiZWdpblNwb3QsIGVuZFNwb3QpOyAK