27466 2009-07-20 15:55:04 -0700 Search boxes should fallback when the RenderTheme doesn't deal with them 2009-07-20 20:06:27 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 agl webkit-unassigned oldest_to_newest 133279 0 agl 2009-07-20 15:55:04 -0700 <input type="search"> is very much like a text entry except that, currently, if the RenderTheme doesn't deal with it, nothing is rendered. With this patch, the default CSS border is rendered if the RenderTheme requests it. 133280 1 33118 agl 2009-07-20 15:58:00 -0700 Created attachment 33118 patch 133336 2 33118 eric 2009-07-20 19:28:30 -0700 Comment on attachment 33118 patch Change looks fine. Fix the fallthrough issue and re-post. :) 133348 3 33139 agl 2009-07-20 19:57:05 -0700 Created attachment 33139 patch 133350 4 33139 eric 2009-07-20 19:59:44 -0700 Comment on attachment 33139 patch Your changelog is unclear. This is already covered by many layout tests. It's just that chromium layout test results are not stored in the webkit tree. Your comment currently sounds like you're adding new tests, but only to the chromium tree, which makes no sense. ;) please adjust the commnet when landing. 33118 2009-07-20 15:58:00 -0700 2009-07-20 19:57:05 -0700 patch patch text/plain 1475 agl ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZmU4YjE0OS4uZTVjOTViNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAwOS0wNy0yMCAgQWRhbSBMYW5nbGV5 ICA8YWdsQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWxsb3cgc2VhcmNoIGVudHJpZXMgdG8gcmVuZGVyIHdpdGggYSBDU1MgYm9y ZGVyIGlmIHRoZSBSZW5kZXJUaGVtZQorICAgICAgICBkb2Vzbid0IHBhaW50IHRoZW0uCisKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3NDY2CisKKyAg ICAgICAgPGlucHV0IHR5cGU9InNlYXJjaCI+IGlzIHZlcnkgbXVjaCBsaWtlIGEgdGV4dCBlbnRy eSBleGNlcHQgdGhhdCwKKyAgICAgICAgY3VycmVudGx5LCBpZiB0aGUgUmVuZGVyVGhlbWUgZG9l c24ndCBkZWFsIHdpdGggaXQsIG5vdGhpbmcgaXMKKyAgICAgICAgcmVuZGVyZWQuIFdpdGggdGhp cyBwYXRjaCwgdGhlIGRlZmF1bHQgQ1NTIGJvcmRlciBpcyByZW5kZXJlZCBpZiB0aGUKKyAgICAg ICAgUmVuZGVyVGhlbWUgcmVxdWVzdHMgaXQuCisKKyAgICAgICAgT25seSBhZmZlY3RzIENocm9t aXVtIExpbnV4LiBUZXN0cyB3aWxsIGJlIGFkZGVkIHRvIHRoZSBDaHJvbWl1bSB0cmVlLgorCisg ICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlclRoZW1lOjpwYWludEJvcmRlck9ubHkpOgorCiAyMDA5LTA3LTIwICBZb25nIExpICA8eW9u Zy5saUB0b3JjaG1vYmlsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBSb2Jlbi4K ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lLmNwcCBiL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclRoZW1lLmNwcAppbmRleCAyM2I2MzQzLi41YjdlMGM3IDEwMDY0NAot LS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZS5jcHAKKysrIGIvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyVGhlbWUuY3BwCkBAIC0zMzIsNiArMzMyLDcgQEAgYm9vbCBSZW5kZXJUaGVt ZTo6cGFpbnRCb3JkZXJPbmx5KFJlbmRlck9iamVjdCogbywgY29uc3QgUmVuZGVyT2JqZWN0OjpQ YWludEluZm8KICAgICAgICAgY2FzZSBTbGlkZXJUaHVtYkhvcml6b250YWxQYXJ0OgogICAgICAg ICBjYXNlIFNsaWRlclRodW1iVmVydGljYWxQYXJ0OgogICAgICAgICBjYXNlIFNlYXJjaEZpZWxk UGFydDoKKyAgICAgICAgICAgIHJldHVybiB0cnVlOwogICAgICAgICBjYXNlIFNlYXJjaEZpZWxk Q2FuY2VsQnV0dG9uUGFydDoKICAgICAgICAgY2FzZSBTZWFyY2hGaWVsZERlY29yYXRpb25QYXJ0 OgogICAgICAgICBjYXNlIFNlYXJjaEZpZWxkUmVzdWx0c0RlY29yYXRpb25QYXJ0Ogo= 33139 2009-07-20 19:57:05 -0700 2009-07-20 19:59:44 -0700 patch patch text/plain 1808 agl ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODllYmUxMy4uODRmYWZjMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAwOS0wNy0yMCAgQWRhbSBMYW5nbGV5 ICA8YWdsQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWxsb3cgc2VhcmNoIGVudHJpZXMgdG8gcmVuZGVyIHdpdGggYSBDU1MgYm9y ZGVyIGlmIHRoZSBSZW5kZXJUaGVtZQorICAgICAgICBkb2Vzbid0IHBhaW50IHRoZW0uCisKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3NDY2CisKKyAg ICAgICAgPGlucHV0IHR5cGU9InNlYXJjaCI+IGlzIHZlcnkgbXVjaCBsaWtlIGEgdGV4dCBlbnRy eSBleGNlcHQgdGhhdCwKKyAgICAgICAgY3VycmVudGx5LCBpZiB0aGUgUmVuZGVyVGhlbWUgZG9l c24ndCBkZWFsIHdpdGggaXQsIG5vdGhpbmcgaXMKKyAgICAgICAgcmVuZGVyZWQuIFdpdGggdGhp cyBwYXRjaCwgdGhlIGRlZmF1bHQgQ1NTIGJvcmRlciBpcyByZW5kZXJlZCBpZiB0aGUKKyAgICAg ICAgUmVuZGVyVGhlbWUgcmVxdWVzdHMgaXQuCisKKyAgICAgICAgT25seSBhZmZlY3RzIENocm9t aXVtIExpbnV4LiBUZXN0cyB3aWxsIGJlIGFkZGVkIHRvIHRoZSBDaHJvbWl1bSB0cmVlLgorCisg ICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlclRoZW1lOjpwYWludEJvcmRlck9ubHkpOgorCiAyMDA5LTA3LTIwICBSeW9zdWtlIE5pd2Eg IDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4K ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lLmNwcCBiL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclRoZW1lLmNwcAppbmRleCAyM2I2MzQzLi5kNDg2NTJmIDEwMDY0NAot LS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZS5jcHAKKysrIGIvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyVGhlbWUuY3BwCkBAIC0zMTksNiArMzE5LDcgQEAgYm9vbCBSZW5kZXJUaGVt ZTo6cGFpbnRCb3JkZXJPbmx5KFJlbmRlck9iamVjdCogbywgY29uc3QgUmVuZGVyT2JqZWN0OjpQ YWludEluZm8KICAgICAgICAgY2FzZSBUZXh0QXJlYVBhcnQ6CiAgICAgICAgICAgICByZXR1cm4g cGFpbnRUZXh0QXJlYShvLCBwYWludEluZm8sIHIpOwogICAgICAgICBjYXNlIE1lbnVsaXN0QnV0 dG9uUGFydDoKKyAgICAgICAgY2FzZSBTZWFyY2hGaWVsZFBhcnQ6CiAgICAgICAgICAgICByZXR1 cm4gdHJ1ZTsKICAgICAgICAgY2FzZSBDaGVja2JveFBhcnQ6CiAgICAgICAgIGNhc2UgUmFkaW9Q YXJ0OgpAQCAtMzMxLDcgKzMzMiw2IEBAIGJvb2wgUmVuZGVyVGhlbWU6OnBhaW50Qm9yZGVyT25s eShSZW5kZXJPYmplY3QqIG8sIGNvbnN0IFJlbmRlck9iamVjdDo6UGFpbnRJbmZvCiAgICAgICAg IGNhc2UgU2xpZGVyVmVydGljYWxQYXJ0OgogICAgICAgICBjYXNlIFNsaWRlclRodW1iSG9yaXpv bnRhbFBhcnQ6CiAgICAgICAgIGNhc2UgU2xpZGVyVGh1bWJWZXJ0aWNhbFBhcnQ6Ci0gICAgICAg IGNhc2UgU2VhcmNoRmllbGRQYXJ0OgogICAgICAgICBjYXNlIFNlYXJjaEZpZWxkQ2FuY2VsQnV0 dG9uUGFydDoKICAgICAgICAgY2FzZSBTZWFyY2hGaWVsZERlY29yYXRpb25QYXJ0OgogICAgICAg ICBjYXNlIFNlYXJjaEZpZWxkUmVzdWx0c0RlY29yYXRpb25QYXJ0Ogo=