27448 2009-07-20 09:53:42 -0700 [Chromium] On Mac, arrow keys should cause Select to pop up its menu 2009-07-21 12:19:55 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Minor --- 1 jens levin levin oldest_to_newest 133157 0 jens 2009-07-20 09:53:42 -0700 (Split off from bug 22784) On Mac OS, when a pop-up menu control has focus, pressing an arrow key or the spacebar should pop up the menu. On other platforms, the arrow keys will just change the currently selected item without popping it up. WebCore's SelectElement.cpp configures what behavior to use by defining a constant ARROW_KEYS_POP_UP_MENU. This constant is currently set to true if PLATFORM(MAC) is enabled. Unfortunately, in the Mac build of Chromium this flag is always false, because other code in WebCore assumes that if it's on, AppKit is available (which is not true inside a Chromium renderer process.) So that means Mac Chromium gets the wrong key behavior for pop-ups. I've fixed this by changing the definition of ARROW_KEYS_POP_UP_MENU from #if PLATFORM(MAC) to #if PLATFORM(MAC) || (PLATFORM(CHROMIUM) && PLATFORM(DARWIN)) which is a bit of a hack, but the best we can do given that there isn't currently a 'Mac platform but not necessarily AppKit' flag. (See 22784 for the discussion that led to using this particular test.) 133161 1 33092 jens 2009-07-20 10:10:36 -0700 Created attachment 33092 patch for ARROW_KEYS_POP_MENU It's the feel-good, focused patch of the summer! The critics are raving: "If you had a patch and a bug just for the define change for ARROW_KEYS_POP_MENU. I'd r+ it right now." --David Levin, from comment in 22784 133526 2 levin 2009-07-21 11:17:25 -0700 Assign to levin for landing. 133551 3 levin 2009-07-21 12:19:55 -0700 Committed as http://trac.webkit.org/changeset/46185 33092 2009-07-20 10:10:36 -0700 2009-07-20 10:13:54 -0700 patch for ARROW_KEYS_POP_MENU selectSpaceKey.patch text/plain 1599 jens SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NjEyNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKyAyMDA5LTA3LTIwICBKZW5zIEFsZmtlICA8c25lakBnb29nbGUuY29t PgorIAorICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgCisgICAgICAgICBC dWcgMjc0NDg6IFtDaHJvbWl1bV0gT24gTWFjLCBhcnJvdyBrZXlzIHNob3VsZCBjYXVzZSBTZWxl Y3QgdG8gcG9wIHVwIGl0cyBtZW51LgorICAgICAgICAgTWFjIGJ1aWxkIG9mIENocm9taXVtIGRv ZXNuJ3QgZm9sbG93IE1hYyBISSBndWlkZWxpbmVzIHRvIHBvcCB1cCB0aGUgbWVudSB3aGVuCisg ICAgICAgICBhbiBhcnJvdyBrZXkgaXMgcHJlc3NlZC4KKyAgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzQ0OAorIAorICAgICAgICAgTm8gbmV3IHRlc3Rz OyBhZmZlY3RzIG9ubHkgY29udHJvbCByZXNwb25zZSB0byB1c2VyIGlucHV0LgorIAorICAgICAg ICAgKiBkb20vU2VsZWN0RWxlbWVudC5jcHA6CisgICAgICAgICBDaGFuZ2VkIGRlZmluaXRpb24g b2YgQVJST1dfS0VZU19QT1BfTUVOVSB0byBtYWtlIGl0IHRydWUgaW4gTWFjIENocm9taXVtLAor ICAgICAgICAgc28gaXQgd2lsbCBiZWhhdmUgY29tcGF0aWJseSB3aXRoIE1hYyBISSBndWlkZWxp bmVzIG9uIHBvcC11cCBtZW51cy4KKyAgICAgICAgIEl0J3Mgbm90IHBvc3NpYmxlIHRvIGhhdmUg UExBVEZPUk0oTUFDKSBiZSB0cnVlIGluIHRoZSBNYWMgYnVpbGQgb2YgQ2hyb21pdW0uCisgCiAy MDA5LTA3LTIwICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBHdXN0YXZvIE5vcm9uaGEuCkluZGV4OiBXZWJDb3JlL2RvbS9TZWxlY3RFbGVtZW50 LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2RvbS9TZWxlY3RFbGVtZW50LmNwcAkocmV2aXNp b24gNDYxMjUpCisrKyBXZWJDb3JlL2RvbS9TZWxlY3RFbGVtZW50LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNDcsNyArNDcsOSBAQAogI2luY2x1ZGUgIldNTFNlbGVjdEVsZW1lbnQuaCIKICNlbmRp ZgogCi0jaWYgUExBVEZPUk0oTUFDKQorLy8gQ29uZmlndXJlIHBsYXRmb3JtLXNwZWNpZmljIGJl aGF2aW9yIHdoZW4gZm9jdXNlZCBwb3AtdXAgcmVjZWl2ZXMgYXJyb3cvc3BhY2UvcmV0dXJuIGtl eXN0cm9rZS4KKy8vIChQTEFURk9STShNQUMpIGlzIGFsd2F5cyBmYWxzZSBpbiBDaHJvbWl1bSwg aGVuY2UgdGhlIGV4dHJhIHRlc3QuKQorI2lmIFBMQVRGT1JNKE1BQykgfHwgKFBMQVRGT1JNKENI Uk9NSVVNKSAmJiBQTEFURk9STShEQVJXSU4pKQogI2RlZmluZSBBUlJPV19LRVlTX1BPUF9NRU5V IDEKICNkZWZpbmUgU1BBQ0VfT1JfUkVUVVJOX1BPUF9NRU5VIDAKICNlbGlmIFBMQVRGT1JNKEdU SykK