27447 2009-07-20 08:36:28 -0700 WebInspector: Accept autocomplete on 'End' key pressed. 2009-07-28 21:41:07 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P3 Normal --- 1 pfeldman pfeldman eric levin oldest_to_newest 133145 0 pfeldman 2009-07-20 08:36:28 -0700 Currently only 'Right' leads to autocomplete accept. Should be both 'Right' and 'End'. 133147 1 33087 pfeldman 2009-07-20 08:55:50 -0700 Created attachment 33087 зфеср 133234 2 eric 2009-07-20 14:47:47 -0700 In XCode "end" cancels autocomplete. What autocomplete are you basing this functionality off of? MS Word? 133412 3 pfeldman 2009-07-21 02:01:01 -0700 (In reply to comment #2) > In XCode "end" cancels autocomplete. What autocomplete are you basing this > functionality off of? MS Word? On non-Mac OS-based systems (Linux, Windows), "End" is moving cursor to the end of the edit field. It sounds much more intuitive to use "End" for auto-complete accept rather than "Right" arrow on these platforms. I could make this action platform-specific, but then decided to keep it simple. On a more general topic, non-popup-based autocomplete is pretty unique to XCode and I don't think many web developers find it useful. (much more are familiar with Eclipse and Visual Studio). So I am thinking of filing a bug to support popup-based autocomplete. 133417 4 33163 pfeldman 2009-07-21 02:13:41 -0700 Created attachment 33163 patch 135466 5 33163 timothy 2009-07-28 20:35:40 -0700 Comment on attachment 33163 patch Sometimes space accepts completions too, but I think that isn't as comon. (I never used End before.) 135478 6 pfeldman 2009-07-28 21:41:07 -0700 Committed r46515 M WebCore/ChangeLog M WebCore/inspector/front-end/TextPrompt.js r46515 = 3a4dd73bf7f0b4ef5f4148170c0a1e7e6330f94d (trunk) 33087 2009-07-20 08:55:50 -0700 2009-07-21 02:13:41 -0700 зфеср accept-on-end.txt text/plain 1015 pfeldman SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQ2MDg3 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMDct MjAgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2Vi SW5zcGVjdG9yOiBBY2NlcHQgYXV0b2NvbXBsZXRlIG9uICdFbmQnIGtleSBwcmVzc2VkLgorCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzQ0Ny4KKwor ICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvVGV4dFByb21wdC5qczoKKyAgICAgICAgKFdl Ykluc3BlY3Rvci5UZXh0UHJvbXB0LnByb3RvdHlwZS5oYW5kbGVLZXlFdmVudCk6CisKIDIwMDkt MDctMTggIEplcmVteSBPcmxvdyAgPGpvcmxvd0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUnVi YmVyIHN0YW1wZWQgYnkgQWRhbSBCYXJ0aC4KSW5kZXg6IGluc3BlY3Rvci9mcm9udC1lbmQvVGV4 dFByb21wdC5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBpbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRQcm9tcHQu anMJKHJldmlzaW9uIDQ2MDg3KQorKysgaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0UHJvbXB0Lmpz CSh3b3JraW5nIGNvcHkpCkBAIC02Niw2ICs2Niw3IEBACiAgICAgICAgICAgICAgICAgdGhpcy5f dGFiS2V5UHJlc3NlZChldmVudCk7CiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAg ICBjYXNlICJSaWdodCI6CisgICAgICAgICAgICBjYXNlICJFbmQiOgogICAgICAgICAgICAgICAg IGlmICghdGhpcy5hY2NlcHRBdXRvQ29tcGxldGUoKSkKICAgICAgICAgICAgICAgICAgICAgdGhp cy5hdXRvQ29tcGxldGVTb29uKCk7CiAgICAgICAgICAgICAgICAgYnJlYWs7Cg== 33163 2009-07-21 02:13:41 -0700 2009-07-28 20:35:40 -0700 patch accept-on-end.txt text/plain 1063 pfeldman SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NjA4NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDktMDctMjAgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgV2ViSW5zcGVjdG9yOiBBY2NlcHQgYXV0b2NvbXBsZXRlIG9u ICdFbmQnIGtleSBwcmVzc2VkLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yNzQ0Ny4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvVGV4 dFByb21wdC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0UHJvbXB0LnByb3RvdHlwZS5o YW5kbGVLZXlFdmVudCk6CisKIDIwMDktMDctMTggIEplcmVteSBPcmxvdyAgPGpvcmxvd0BjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgUnViYmVyIHN0YW1wZWQgYnkgQWRhbSBCYXJ0aC4KSW5kZXg6 IFdlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0UHJvbXB0LmpzCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0UHJvbXB0LmpzCShyZXZpc2lvbiA0NjA4 NykKKysrIFdlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0UHJvbXB0LmpzCSh3b3JraW5n IGNvcHkpCkBAIC02Niw2ICs2Niw3IEBACiAgICAgICAgICAgICAgICAgdGhpcy5fdGFiS2V5UHJl c3NlZChldmVudCk7CiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICBjYXNlICJS aWdodCI6CisgICAgICAgICAgICBjYXNlICJFbmQiOgogICAgICAgICAgICAgICAgIGlmICghdGhp cy5hY2NlcHRBdXRvQ29tcGxldGUoKSkKICAgICAgICAgICAgICAgICAgICAgdGhpcy5hdXRvQ29t cGxldGVTb29uKCk7CiAgICAgICAgICAgICAgICAgYnJlYWs7Cg==