274407 2024-05-20 11:37:01 -0700 check-webkit-style failing for Python changes in WPT 2024-09-30 13:51:21 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=246825 InRadar P2 Normal --- 1 gsnedders fujii fujii jbedard karlcow webkit-bug-importer oldest_to_newest 2036462 0 gsnedders 2024-05-20 11:37:01 -0700 Karl hit the following: ``` % git webkit pr From github.com:WebKit/WebKit * branch main -> FETCH_HEAD Current branch 274304-wpt-html-canvas is up to date. ERROR: Unexpected diff format when parsing a chunk: '100" height="&#xD;' ERROR: Unexpected diff format when parsing a chunk: '100"><p class="fallback">FAIL (fallback content)</p></canvas>' ERROR: LayoutTests/imported/w3c/web-platform-tests/html/canvas/tools/gentestutilsunion.py:386: too many blank lines (2) [pep8/E303] [5] ERROR: LayoutTests/imported/w3c/web-platform-tests/html/canvas/tools/gentestutilsunion.py:484: continuation line with same indent as next logical line [pep8/E125] [5] ERROR: LayoutTests/imported/w3c/web-platform-tests/html/canvas/tools/gentestutilsunion.py:580: continuation line over-indented for hanging indent [pep8/E126] [5] Total errors found: 3 in 1020 files style-checker failed, continue uploading pull request? Retry will amend the commit with your changes. (Yes/Retry/[No]): ``` This is surprising given on the face of it we should be ignoring all of LayoutTests, per https://github.com/WebKit/WebKit/blob/87181326e4b98e672a0cb51872cb55f7f0dd0ae3/Tools/Scripts/webkitpy/style/checker.py#L478 2036463 1 webkit-bug-importer 2024-05-20 11:37:12 -0700 <rdar://problem/128408640> 2036538 2 karlcow 2024-05-20 16:15:44 -0700 I wonder if it matches an exception. https://github.com/WebKit/WebKit/blob/87181326e4b98e672a0cb51872cb55f7f0dd0ae3/Tools/Scripts/webkitpy/style/checker.py#L717-L733 https://github.com/WebKit/WebKit/blob/b1a07690232ffd27093173e2fd66cf65aa0ed777/Tools/Scripts/webkitpy/style/checker.py#L423 The filepath is LayoutTests/imported/w3c/web-platform-tests/html/canvas/tools/gentestutilsunion.py Some logging to do. :) 2064114 3 fujii 2024-09-29 12:52:57 -0700 *** Bug 280504 has been marked as a duplicate of this bug. *** 2064115 4 fujii 2024-09-29 12:57:37 -0700 https://github.com/WebKit/WebKit/blob/1e0f90c0a4748d952997071013e3836e5306dd1d/Tools/Scripts/webkitpy/style/checker.py#L462 > re.compile('(?!WebDriverTests).{0,14}.*.py$'), This regexp in _NEVER_SKIPPED_FILES matches .py files under LayoutTests directory. This was aded by Bug 246825. 2064118 5 fujii 2024-09-29 13:25:52 -0700 Pull request: https://github.com/WebKit/WebKit/pull/34427 2064323 6 ews-feeder 2024-09-30 13:51:19 -0700 Committed 284464@main (1b97d0c6ae2e): <https://commits.webkit.org/284464@main> Reviewed commits have been landed. Closing PR #34427 and removing active labels.