27439 2009-07-19 18:58:52 -0700 [Gtk] crash when closing page from javascript 2009-08-18 22:57:29 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED http://mysterion.org/~danw/close.html Gtk P2 Normal --- 1 danw webkit-unassigned eric jmalonzo plaes xan.lopez oldest_to_newest 133054 0 danw 2009-07-19 18:58:52 -0700 go to http://mysterion.org/~danw/close.html. click the button on the web page, which just runs "window.close()". Nothing happens. Click it a second time, and the browser crashes. trace is from epiphany, but it crashes in GtkLauncher too Program received signal SIGSEGV, Segmentation fault. 0x00f01b80 in webkit_web_view_focus_out_event (widget=0x86d10e8, event=0x8734000) at WebKit/gtk/webkit/webkitwebview.cpp:601 601 core(webView)->focusController()->setActive(false); Current language: auto; currently c++ (gdb) where #0 0x00f01b80 in webkit_web_view_focus_out_event (widget=0x86d10e8, event=0x8734000) at WebKit/gtk/webkit/webkitwebview.cpp:601 #1 0x03e3ee24 in _gtk_marshal_BOOLEAN__BOXED (closure=0x8165930, return_value=0xbfffd864, n_param_values=2, param_values=0x8702d68, invocation_hint=0xbfffd850, marshal_data=0xf01b40) at gtkmarshalers.c:84 #2 0x00a929b9 in g_type_class_meta_marshal (closure=0x8165930, return_value=0xbfffd864, n_param_values=2, param_values=0x8702d68, invocation_hint=0xbfffd850, marshal_data=0xe4) at gclosure.c:878 #3 0x00a94332 in IA__g_closure_invoke (closure=0x8165930, return_value=0xbfffd864, n_param_values=2, param_values=0x8702d68, invocation_hint=0xbfffd850) at gclosure.c:767 #4 0x00aa969b in signal_emit_unlocked_R (node=<value optimized out>, detail=<value optimized out>, instance=0x86d10e8, emission_return=0xbfffd9ac, instance_and_params=0x8702d68) at gsignal.c:3285 #5 0x00aaaba8 in IA__g_signal_emit_valist (instance=0x86d10e8, signal_id=45, detail=0, var_args=0xbfffda10 "L\332\377\277\1") at gsignal.c:2990 #6 0x00aab1a6 in IA__g_signal_emit (instance=0x86d10e8, signal_id=45, detail=0) at gsignal.c:3037 #7 0x03f57bf6 in gtk_widget_event_internal (widget=<value optimized out>, event=0x8734000) at gtkwidget.c:4761 #8 0x03f67731 in do_focus_change (widget=0x86d10e8, in=138938072) at gtkwindow.c:5254 #9 0x03f681ec in gtk_window_real_set_focus (window=0x8144428, focus=0x0) at gtkwindow.c:5456 #10 0x00aa1118 in IA__g_cclosure_marshal_VOID__OBJECT (closure=0x816dd80, return_value=0x0, n_param_values=2, param_values=0x8701918, invocation_hint=0xbfffdc80, marshal_data=0x3f68040) at gmarshal.c:636 #11 0x00a929b9 in g_type_class_meta_marshal (closure=0x816dd80, return_value=0x0, n_param_values=2, param_values=0x8701918, invocation_hint=0xbfffdc80, marshal_data=0x1a0) at gclosure.c:878 #12 0x00a94332 in IA__g_closure_invoke (closure=0x816dd80, return_value=0x0, n_param_values=2, param_values=0x8701918, invocation_hint=0xbfffdc80) at gclosure.c:767 #13 0x00aa969b in signal_emit_unlocked_R (node=<value optimized out>, detail=<value optimized out>, instance=0x8144428, emission_return=0x0, instance_and_params=0x8701918) at gsignal.c:3285 #14 0x00aaad1d in IA__g_signal_emit_valist (instance=0x8144428, signal_id=81, detail=0, var_args=0xbfffde40 "\244\201\250") at gsignal.c:2980 #15 0x00aab1a6 in IA__g_signal_emit (instance=0x8144428, signal_id=81, detail=0) at gsignal.c:3037 #16 0x03f6f01b in _gtk_window_internal_set_focus (window=0x8144428, focus=0x0) at gtkwindow.c:1603 #17 0x03f6f10f in IA__gtk_window_set_focus (window=0x8144428, focus=0x0) at gtkwindow.c:1591 #18 0x03f6f1e2 in _gtk_window_unset_focus_and_default (window=0x8144428, widget=0x86d10e8) at gtkwindow.c:5538 #19 0x03f66f8f in IA__gtk_widget_unparent (widget=0x86d10e8) at gtkwidget.c:2873 #20 0x03d79f03 in gtk_bin_remove (container=0x8465c30, child=0x86d10e8) at gtkbin.c:109 #21 0x03e9f9a2 in gtk_scrolled_window_remove (container=0x8465c30, child=0x86d10e8) at gtkscrolledwindow.c:1701 #22 0x00aa1118 in IA__g_cclosure_marshal_VOID__OBJECT (closure=0x816ccc8, return_value=0x0, n_param_values=2, param_values=0x8701190, invocation_hint=0xbfffe130, marshal_data=0x3e9f8f0) at gmarshal.c:636 #23 0x00a929b9 in g_type_class_meta_marshal (closure=0x816ccc8, return_value=0x0, n_param_values=2, param_values=0x8701190, invocation_hint=0xbfffe130, marshal_data=0x170) at gclosure.c:878 #24 0x00a94332 in IA__g_closure_invoke (closure=0x816ccc8, return_value=0x0, n_param_values=2, param_values=0x8701190, invocation_hint=0xbfffe130) at gclosure.c:767 #25 0x00aa92b5 in signal_emit_unlocked_R (node=<value optimized out>, detail=<value optimized out>, instance=0x8465c30, emission_return=0x0, instance_and_params=0x8701190) at gsignal.c:3177 #26 0x00aaad1d in IA__g_signal_emit_valist (instance=0x8465c30, signal_id=78, detail=0, var_args=0xbfffe2f0 "") at gsignal.c:2980 #27 0x00aab1a6 in IA__g_signal_emit (instance=0x8465c30, signal_id=78, detail=0) at gsignal.c:3037 #28 0x03db161e in IA__gtk_container_remove (container=0x8465c30, widget=0x86d10e8) at gtkcontainer.c:1233 #29 0x03f616ed in gtk_widget_dispose (object=0x86d10e8) at gtkwidget.c:7898 #30 0x00f029af in webkit_web_view_dispose (object=0x86d10e8) at WebKit/gtk/webkit/webkitwebview.cpp:964 #31 0x080c1f0f in ephy_web_view_dispose (object=0x86d10e8) at ephy-web-view.c:490 #32 0x00a96418 in IA__g_object_unref (_object=0x86d10e8) at gobject.c:2393 #33 0x03e37819 in IA__gtk_propagate_event (widget=0x86d10e8, event=0x8299198) at gtkmain.c:2399 #34 0x03e38ac9 in IA__gtk_main_do_event (event=0x8299198) at gtkmain.c:1601 #35 0x00727eba in gdk_event_dispatch (source=0x814d620, callback=0, user_data=0x0) at gdkevents-x11.c:2367 #36 0x009dfd78 in g_main_dispatch (context=<value optimized out>) at gmain.c:1814 #37 IA__g_main_context_dispatch (context=<value optimized out>) at gmain.c:2367 #38 0x009e3310 in g_main_context_iterate (context=0x814d668, block=<value optimized out>, dispatch=1, self=0x81251a0) at gmain.c:2445 #39 0x009e377f in IA__g_main_loop_run (loop=0x812da00) at gmain.c:2653 #40 0x03e39029 in IA__gtk_main () at gtkmain.c:1205 #41 0x0806b3c4 in main (argc=1, argv=0xbffff774) at ephy-main.c:781 133107 1 xan.lopez 2009-07-20 03:49:16 -0700 I can't reproduce this, which webkit revision are you using exactly? 133118 2 danw 2009-07-20 05:46:59 -0700 latest svn (r46105). it was crashing before that too though. when you say you can't reproduce, does that mean the window closes the *first* time you click the button? because if not, that may also be a bug. (It doesn't actually close the window in Firefox though, so I'm not sure if there's some sort of "don't let javascript close windows it didn't open" thing going on. However, this is a simplification of another site where a window is opened by clicking on a link and then later closed by javascript in that window, so the closing is definitely correct there.) does valgrind show anything? 133119 3 jmalonzo 2009-07-20 05:50:34 -0700 (In reply to comment #2) > latest svn (r46105). it was crashing before that too though. Hi Dan > when you say you can't reproduce, does that mean the window closes the *first* > time you click the button? because if not, that may also be a bug. (It doesn't > actually close the window in Firefox though, so I'm not sure if there's some > sort of "don't let javascript close windows it didn't open" thing going on. Yeah that's what it's actually doing. > However, this is a simplification of another site where a window is opened by > clicking on a link and then later closed by javascript in that window, so the > closing is definitely correct there.) Is the site public? Do you mind sharing it here if it is? Thanks. 136132 4 plaes 2009-07-31 03:15:02 -0700 (In reply to comment #3) > (In reply to comment #2) > > latest svn (r46105). it was crashing before that too though. > > > However, this is a simplification of another site where a window is opened by > > clicking on a link and then later closed by javascript in that window, so the > > closing is definitely correct there.) > > Is the site public? Do you mind sharing it here if it is? I also ran into something like this, so I created a minified testcase: http://plaes.org/files/2009-Q3/webkit-bug-27439/ PS. You can also see that window positioning is not set correctly (at least with ephy) 136416 5 33933 jmalonzo 2009-07-31 23:18:03 -0700 Created attachment 33933 Patch v1 136445 6 plaes 2009-08-01 05:39:17 -0700 (In reply to comment #5) > Created an attachment (id=33933) [details] > Patch v1 Doesn't crash anymore, but window does not close either :( Also, real life testcase that this patch seems to fix: 1) Go to http://www.jassi.ee/ 2) Click on the map 3) Either crash happens after a click or when you try to close the popup window 136489 7 jmalonzo 2009-08-01 15:29:07 -0700 (In reply to comment #6) > (In reply to comment #5) > > Created an attachment (id=33933) [details] [details] > > Patch v1 > > Doesn't crash anymore, but window does not close either :( Embedders need to listen to close-web-view to either destroy or hide their windows which I don't think ephy does atm. 136521 8 xan.lopez 2009-08-02 00:49:23 -0700 (In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #5) > > > Created an attachment (id=33933) [details] [details] [details] > > > Patch v1 > > > > Doesn't crash anymore, but window does not close either :( > > Embedders need to listen to close-web-view to either destroy or hide their > windows which I don't think ephy does atm. Wouldn't it be with this patch *mandatory* that you handle the signal? Otherwise you'd leak the view object, which used to be unreffed by closeWindowSoon until now. If that's the case you should make the documentation more specific about that. 136523 9 jmalonzo 2009-08-02 00:55:31 -0700 (In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > (In reply to comment #5) > > > > Created an attachment (id=33933) [details] [details] [details] [details] > > > > Patch v1 > > > > > > Doesn't crash anymore, but window does not close either :( > > > > Embedders need to listen to close-web-view to either destroy or hide their > > windows which I don't think ephy does atm. > > Wouldn't it be with this patch *mandatory* that you handle the signal? Now it's kinda mandatory. How does a WebView created by create-web-view get freed prior to when this signal was introduced? > Otherwise you'd leak the view object, which used to be unreffed by > closeWindowSoon until now. If that's the case you should make the documentation > more specific about that. I did. * + * It is also recommended that #WebKitWebView::close-web-view be handled + * to hide the #WebKitWebView. + * Maybe add something like "free the WebView you created in create-web-view"? 136528 10 xan.lopez 2009-08-02 01:18:05 -0700 (In reply to comment #9) > Now it's kinda mandatory. How does a WebView created by create-web-view get > freed prior to when this signal was introduced? > Well, in the general case it's handled by the client, since it's the client who created the view right? But in the case of the windows destroyed by window.close() the code that emits the signal would destroy the view itself, so in theory you didn't need to do anything (although this is probably too simplistic anyway, since for popups in new windows you'd need to get rid of the toplevel anyway...). > > Otherwise you'd leak the view object, which used to be unreffed by > > closeWindowSoon until now. If that's the case you should make the documentation > > more specific about that. > > I did. > > * > + * It is also recommended that #WebKitWebView::close-web-view be handled > + * to hide the #WebKitWebView. > + * > > Maybe add something like "free the WebView you created in create-web-view"? Yeah, I read that, but I meant explaining explicitly that you have to free/hide the view in the callback yourself. 'Recommended' sounds a bit like 'it would be good if you do it, but you don't have to', but I don't think that's the case now? Also, I think it would be good to have a test (or tests) about this (we can do it after we land the patch though). 136547 11 jmalonzo 2009-08-02 03:06:18 -0700 (In reply to comment #10) > (In reply to comment #9) > > Now it's kinda mandatory. How does a WebView created by create-web-view get > > freed prior to when this signal was introduced? > > > > Well, in the general case it's handled by the client, since it's the client who > created the view right? Right. > But in the case of the windows destroyed by > window.close() the code that emits the signal would destroy the view itself, so > in theory you didn't need to do anything (although this is probably too > simplistic anyway, since for popups in new windows you'd need to get rid of the > toplevel anyway...). > > Maybe add something like "free the WebView you created in create-web-view"? > > Yeah, I read that, but I meant explaining explicitly that you have to free/hide > the view in the callback yourself. 'Recommended' sounds a bit like 'it would be > good if you do it, but you don't have to', but I don't think that's the case > now? Right. I'll mention that it's mandatory. > Also, I think it would be good to have a test (or tests) about this (we can do > it after we land the patch though). I'll try to come up an updated patch with test in the next couple of days. Thanks for the review. 136548 12 33933 jmalonzo 2009-08-02 03:07:36 -0700 Comment on attachment 33933 Patch v1 Clearing review. I'll update the patch based on Xan's feedback. 138736 13 34486 jmalonzo 2009-08-10 11:14:08 -0700 Created attachment 34486 updated patch, no test 138738 14 jmalonzo 2009-08-10 11:14:54 -0700 (In reply to comment #13) > Created an attachment (id=34486) [details] > updated patch, no test I'll add the test when I get more time. 140423 15 34887 jmalonzo 2009-08-14 22:26:22 -0700 Created attachment 34887 updated signal doc 141151 16 34887 oliver 2009-08-18 11:43:20 -0700 Comment on attachment 34887 updated signal doc I realise i'm not a gtk person, but this patch seems obvious enough to me, r=me 141197 17 xan.lopez 2009-08-18 13:40:14 -0700 (In reply to comment #16) > (From update of attachment 34887 [details]) > I realise i'm not a gtk person, but this patch seems obvious enough to me, r=me Thanks, somehow most of my bugmail of the last days went to the spam folder an I missed this (among other things). 141400 18 34887 eric 2009-08-18 22:57:24 -0700 Comment on attachment 34887 updated signal doc Clearing flags on attachment: 34887 Committed r47493: <http://trac.webkit.org/changeset/47493> 141401 19 eric 2009-08-18 22:57:29 -0700 All reviewed patches have been landed. Closing bug. 33933 2009-07-31 23:18:03 -0700 2009-08-10 11:14:01 -0700 Patch v1 bug-27439-20090801161759.patch text/plain 3405 jmalonzo ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggODk1ZDNiMS4uYWYzM2Y5OSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAwOS0wNy0zMSAg SmFuIE1pY2hhZWwgQWxvbnpvICA8am1hbG9uem9Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR3RrXSBjcmFzaCB3aGVuIGNsb3Np bmcgcGFnZSBmcm9tIGphdmFzY3JpcHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTI3NDM5CisKKyAgICAgICAgRG8gbm90IHVucmVmIHRoZSBXZWJWaWV3 IGluIENocm9tZUNsaWVudEd0azo6Y2xvc2VXaW5kb3dTb29uCisgICAgICAgIGJlY2F1c2UgKDEp IGEgY3JlYXRlLXdlYi12aWV3IGhhbmRsZXIgY2FuIHJldHVybiBhIE5VTEwgV2ViVmlldywKKyAg ICAgICAgKDIpIHRoZSBjcmVhdGVkIFdlYlZpZXcgaXMgb3duZWQgYnkgaXRzIGNvbnRhaW5pbmcg d2lkZ2V0LCBhbmQgKDMpCisgICAgICAgIGNsaWVudHMgbWF5IG5vdCBoYW5kbGUgdGhlIGNsb3Nl LXdlYi12aWV3IHNpZ25hbCBzbyB0aGlzIGF2b2lkcworICAgICAgICB1bnJlZmZpbmcgYSBXZWJW aWV3IG1vcmUgdGhhbiBvbmNlLgorCisgICAgICAgIEkgYWxzbyBhZGRlZCBhIGNvbW1lbnQgaW4g Y3JlYXRlLXdlYi12aWV3IHJlZ2FyZGluZyBjbG9zZS13ZWItdmlldworICAgICAgICBhbmQgc29t ZSBtb3JlIGluZm8gaW4gdGhlIGNsb3NlLXdlYi12aWV3IHNpZ25hbCBkb2MuCisKKyAgICAgICAg KiBXZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRHdGsuY3BwOgorICAgICAgICAoV2ViS2l0OjpD aHJvbWVDbGllbnQ6OmNsb3NlV2luZG93U29vbik6CisgICAgICAgICogd2Via2l0L3dlYmtpdHdl YnZpZXcuY3BwOgorICAgICAgICAod2Via2l0X3dlYl92aWV3X2NsYXNzX2luaXQpOgorCiAyMDA5 LTA3LTMwICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AYXBwY2VsZXJhdG9yLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBYYW4gTG9wZXosIEd1c3Rhdm8gTm9yb25oYSBhbmQgSmFuIEFs b256by4KZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50 R3RrLmNwcCBiL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50R3RrLmNwcApp bmRleCAxMjkyZTk5Li4xN2ExNjNiIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBw b3J0L0Nocm9tZUNsaWVudEd0ay5jcHAKKysrIGIvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9D aHJvbWVDbGllbnRHdGsuY3BwCkBAIC0yMTUsNiArMjE1LDEwIEBAIHZvaWQgQ2hyb21lQ2xpZW50 OjpzZXRSZXNpemFibGUoYm9vbCkKIAogdm9pZCBDaHJvbWVDbGllbnQ6OmNsb3NlV2luZG93U29v bigpCiB7CisgICAgLy8gV2UgbWF5IG5vdCBoYXZlIGEgV2ViVmlldyBhcyBjcmVhdGUtd2ViLXZp ZXcgY2FuIHJldHVybiBOVUxMLgorICAgIGlmICghbV93ZWJWaWV3KQorICAgICAgICByZXR1cm47 CisKICAgICB3ZWJraXRfd2ViX3ZpZXdfc3RvcF9sb2FkaW5nKG1fd2ViVmlldyk7CiAKICAgICBn Ym9vbGVhbiBpc0hhbmRsZWQgPSBmYWxzZTsKQEAgLTIyNiw3ICsyMzAsNiBAQCB2b2lkIENocm9t ZUNsaWVudDo6Y2xvc2VXaW5kb3dTb29uKCkKICAgICAvLyBGSVhNRTogc2hvdWxkIHdlIGNsZWFy IHRoZSBmcmFtZSBncm91cCBuYW1lIGhlcmUgZXhwbGljaXRseT8gTWFjIGRvZXMgaXQuCiAgICAg Ly8gQnV0IHRoaXMgZ2V0cyBjbGVhcmVkIGluIFBhZ2UncyBkZXN0cnVjdG9yIGFueXdheS4KICAg ICAvLyB3ZWJraXRfd2ViX3ZpZXdfc2V0X2dyb3VwX25hbWUobV93ZWJWaWV3LCAiIik7Ci0gICAg Z19vYmplY3RfdW5yZWYobV93ZWJWaWV3KTsKIH0KIAogYm9vbCBDaHJvbWVDbGllbnQ6OmNhblRh a2VGb2N1cyhGb2N1c0RpcmVjdGlvbikKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dl YmtpdHdlYnZpZXcuY3BwIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKaW5k ZXggZWM1OWU2MC4uYjRmMDBiYyAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0 d2Vidmlldy5jcHAKKysrIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKQEAg LTExMDQsNiArMTEwNCw5IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmlld19jbGFzc19pbml0 KFdlYktpdFdlYlZpZXdDbGFzcyogd2ViVmlld0NsYXNzKQogICAgICAqIFRoZSBuZXcgI1dlYktp dFdlYlZpZXcgc2hvdWxkIG5vdCBiZSBkaXNwbGF5ZWQgdG8gdGhlIHVzZXIKICAgICAgKiB1bnRp bCB0aGUgI1dlYktpdFdlYlZpZXc6OndlYi12aWV3LXJlYWR5IHNpZ25hbCBpcyBlbWl0dGVkLgog ICAgICAqCisgICAgICogSXQgaXMgYWxzbyByZWNvbW1lbmRlZCB0aGF0ICNXZWJLaXRXZWJWaWV3 OjpjbG9zZS13ZWItdmlldyBiZSBoYW5kbGVkCisgICAgICogdG8gaGlkZSB0aGUgI1dlYktpdFdl YlZpZXcuCisgICAgICoKICAgICAgKiBUaGUgc2lnbmFsIGhhbmRsZXJzIHNob3VsZCBub3QgdHJ5 IHRvIGRlYWwgd2l0aCB0aGUgcmVmZXJlbmNlCiAgICAgICogY291bnQgZm9yIHRoZSBuZXcgI1dl YktpdFdlYlZpZXcuIFRoZSB3aWRnZXQgdG8gd2hpY2ggdGhlCiAgICAgICogd2lkZ2V0IGlzIGFk ZGVkIHdpbGwgaGFuZGxlIHRoYXQuCkBAIC0xMTU0LDggKzExNTcsOSBAQCBzdGF0aWMgdm9pZCB3 ZWJraXRfd2ViX3ZpZXdfY2xhc3NfaW5pdChXZWJLaXRXZWJWaWV3Q2xhc3MqIHdlYlZpZXdDbGFz cykKICAgICAgKiBAcmV0dXJuOiAlVFJVRSB0byBzdG9wIGhhbmRsZXJzIGZyb20gYmVpbmcgaW52 b2tlZCBmb3IgdGhlIGV2ZW50IG9yCiAgICAgICogJUZBTFNFIHRvIHByb3BhZ2F0ZSB0aGUgZXZl bnQgZnVydGVyCiAgICAgICoKLSAgICAgKiBFbWl0dGVkIHdoZW4gY2xvc2luZyBhIFdlYlZpZXcg aXMgcmVxdWVzdGVkLiBUaGlzIG9jY3VycyB3aGVuIGEgY2FsbAotICAgICAqIGlzIG1hZGUgZnJv bSBKYXZhU2NyaXB0J3Mgd2luZG93LmNsb3NlIGZ1bmN0aW9uLgorICAgICAqIEVtaXR0ZWQgd2hl biBjbG9zaW5nIGEgI1dlYktpdFdlYlZpZXcgaXMgcmVxdWVzdGVkLiBUaGlzIG9jY3VycyB3aGVu IGEgY2FsbAorICAgICAqIGlzIG1hZGUgZnJvbSBKYXZhU2NyaXB0J3Mgd2luZG93LmNsb3NlIGZ1 bmN0aW9uLiBUaGUgc2lnbmFsIGhhbmRsZXIgY2FuCisgICAgICogYmUgdXNlZCB0byBoaWRlIHRo ZSAjV2ViS2l0V2ViVmlldyBhbmQgZGVzdHJveSB0aGUgV2ViVmlldydzIGNvbnRhaW5pbmcgd2lk Z2V0LgogICAgICAqCiAgICAgICogU2luY2UgMS4xLjExCiAgICAgICov 34486 2009-08-10 11:14:08 -0700 2009-08-14 22:26:15 -0700 updated patch, no test bug-27439-20090811041406.patch text/plain 3637 jmalonzo ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggNGQ0OTg2MS4uNzVjNWM1ZSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAwOS0wOC0xMCAg SmFuIE1pY2hhZWwgQWxvbnpvICA8am1hbG9uem9Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR3RrXSBjcmFzaCB3aGVuIGNsb3Np bmcgcGFnZSBmcm9tIGphdmFzY3JpcHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTI3NDM5CisKKyAgICAgICAgRG8gbm90IHVucmVmIHRoZSBXZWJWaWV3 IGluIENocm9tZUNsaWVudEd0azo6Y2xvc2VXaW5kb3dTb29uCisgICAgICAgIGJlY2F1c2UgKDEp IGEgY3JlYXRlLXdlYi12aWV3IGhhbmRsZXIgY2FuIHJldHVybiBhIE5VTEwgV2ViVmlldywKKyAg ICAgICAgKDIpIHRoZSBjcmVhdGVkIFdlYlZpZXcgaXMgb3duZWQgYnkgaXRzIGNvbnRhaW5pbmcg d2lkZ2V0LCBhbmQgKDMpCisgICAgICAgIGNsaWVudHMgbWF5IG5vdCBoYW5kbGUgdGhlIGNsb3Nl LXdlYi12aWV3IHNpZ25hbCBzbyB0aGlzIGF2b2lkcworICAgICAgICB1bnJlZmZpbmcgYSBXZWJW aWV3IG1vcmUgdGhhbiBvbmNlLgorCisgICAgICAgIEkgYWxzbyBhZGRlZCBhIGNvbW1lbnQgaW4g Y3JlYXRlLXdlYi12aWV3IHJlZ2FyZGluZyBjbG9zZS13ZWItdmlldworICAgICAgICBhbmQgc29t ZSBtb3JlIGluZm8gaW4gdGhlIGNsb3NlLXdlYi12aWV3IHNpZ25hbCBkb2MuCisKKyAgICAgICAg KiBXZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRHdGsuY3BwOgorICAgICAgICAoV2ViS2l0OjpD aHJvbWVDbGllbnQ6OmNsb3NlV2luZG93U29vbik6CisgICAgICAgICogd2Via2l0L3dlYmtpdHdl YnZpZXcuY3BwOgorICAgICAgICAod2Via2l0X3dlYl92aWV3X2NsYXNzX2luaXQpOgorCiAyMDA5 LTA4LTEwICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBHVEsg YnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9DaHJvbWVD bGllbnRHdGsuY3BwIGIvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRHdGsu Y3BwCmluZGV4IDEyOTJlOTkuLjE3YTE2M2IgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvV2ViQ29y ZVN1cHBvcnQvQ2hyb21lQ2xpZW50R3RrLmNwcAorKysgYi9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBw b3J0L0Nocm9tZUNsaWVudEd0ay5jcHAKQEAgLTIxNSw2ICsyMTUsMTAgQEAgdm9pZCBDaHJvbWVD bGllbnQ6OnNldFJlc2l6YWJsZShib29sKQogCiB2b2lkIENocm9tZUNsaWVudDo6Y2xvc2VXaW5k b3dTb29uKCkKIHsKKyAgICAvLyBXZSBtYXkgbm90IGhhdmUgYSBXZWJWaWV3IGFzIGNyZWF0ZS13 ZWItdmlldyBjYW4gcmV0dXJuIE5VTEwuCisgICAgaWYgKCFtX3dlYlZpZXcpCisgICAgICAgIHJl dHVybjsKKwogICAgIHdlYmtpdF93ZWJfdmlld19zdG9wX2xvYWRpbmcobV93ZWJWaWV3KTsKIAog ICAgIGdib29sZWFuIGlzSGFuZGxlZCA9IGZhbHNlOwpAQCAtMjI2LDcgKzIzMCw2IEBAIHZvaWQg Q2hyb21lQ2xpZW50OjpjbG9zZVdpbmRvd1Nvb24oKQogICAgIC8vIEZJWE1FOiBzaG91bGQgd2Ug Y2xlYXIgdGhlIGZyYW1lIGdyb3VwIG5hbWUgaGVyZSBleHBsaWNpdGx5PyBNYWMgZG9lcyBpdC4K ICAgICAvLyBCdXQgdGhpcyBnZXRzIGNsZWFyZWQgaW4gUGFnZSdzIGRlc3RydWN0b3IgYW55d2F5 LgogICAgIC8vIHdlYmtpdF93ZWJfdmlld19zZXRfZ3JvdXBfbmFtZShtX3dlYlZpZXcsICIiKTsK LSAgICBnX29iamVjdF91bnJlZihtX3dlYlZpZXcpOwogfQogCiBib29sIENocm9tZUNsaWVudDo6 Y2FuVGFrZUZvY3VzKEZvY3VzRGlyZWN0aW9uKQpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay93ZWJr aXQvd2Via2l0d2Vidmlldy5jcHAgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNw cAppbmRleCBlYzU5ZTYwLi5lN2YwNzg1IDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL3dlYmtpdC93 ZWJraXR3ZWJ2aWV3LmNwcAorKysgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNw cApAQCAtMTEwNCw5ICsxMTA0LDExIEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmlld19jbGFz c19pbml0KFdlYktpdFdlYlZpZXdDbGFzcyogd2ViVmlld0NsYXNzKQogICAgICAqIFRoZSBuZXcg I1dlYktpdFdlYlZpZXcgc2hvdWxkIG5vdCBiZSBkaXNwbGF5ZWQgdG8gdGhlIHVzZXIKICAgICAg KiB1bnRpbCB0aGUgI1dlYktpdFdlYlZpZXc6OndlYi12aWV3LXJlYWR5IHNpZ25hbCBpcyBlbWl0 dGVkLgogICAgICAqCi0gICAgICogVGhlIHNpZ25hbCBoYW5kbGVycyBzaG91bGQgbm90IHRyeSB0 byBkZWFsIHdpdGggdGhlIHJlZmVyZW5jZQotICAgICAqIGNvdW50IGZvciB0aGUgbmV3ICNXZWJL aXRXZWJWaWV3LiBUaGUgd2lkZ2V0IHRvIHdoaWNoIHRoZQotICAgICAqIHdpZGdldCBpcyBhZGRl ZCB3aWxsIGhhbmRsZSB0aGF0LgorICAgICAqIFRoZSBzaWduYWwgaGFuZGxlcnMgc2hvdWxkIG5v dCB0cnkgdG8gZGVhbCB3aXRoIHRoZSByZWZlcmVuY2UgY291bnQgZm9yCisgICAgICogdGhlIG5l dyAjV2ViS2l0V2ViVmlldy4gVGhlIHdpZGdldCB0byB3aGljaCB0aGUgd2lkZ2V0IGlzIGFkZGVk IHdpbGwKKyAgICAgKiBoYW5kbGUgdGhhdC4gSXQgaXMgbWFuZGF0b3J5IHRob3VnaCwgdGhhdCB0 aGUgYXBwbGljYXRpb24gY29ubmVjdCB0bworICAgICAqICNXZWJLaXRXZWJWaWV3OjpjbG9zZS13 ZWItdmlldyB0byBmcmVlIHRoZSAjV2ViS2l0V2ViVmlldyBjcmVhdGVkIGluCisgICAgICogdGhl IHNpZ25hbCBoYW5kbGVyLgogICAgICAqCiAgICAgICogU2luY2UgMS4wLjMKICAgICAgKi8KQEAg LTExNTQsOCArMTE1NiwxMCBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfY2xhc3NfaW5p dChXZWJLaXRXZWJWaWV3Q2xhc3MqIHdlYlZpZXdDbGFzcykKICAgICAgKiBAcmV0dXJuOiAlVFJV RSB0byBzdG9wIGhhbmRsZXJzIGZyb20gYmVpbmcgaW52b2tlZCBmb3IgdGhlIGV2ZW50IG9yCiAg ICAgICogJUZBTFNFIHRvIHByb3BhZ2F0ZSB0aGUgZXZlbnQgZnVydGVyCiAgICAgICoKLSAgICAg KiBFbWl0dGVkIHdoZW4gY2xvc2luZyBhIFdlYlZpZXcgaXMgcmVxdWVzdGVkLiBUaGlzIG9jY3Vy cyB3aGVuIGEgY2FsbAotICAgICAqIGlzIG1hZGUgZnJvbSBKYXZhU2NyaXB0J3Mgd2luZG93LmNs b3NlIGZ1bmN0aW9uLgorICAgICAqIEVtaXR0ZWQgd2hlbiBjbG9zaW5nIGEgI1dlYktpdFdlYlZp ZXcgaXMgcmVxdWVzdGVkLiBUaGlzIG9jY3VycyB3aGVuIGEKKyAgICAgKiBjYWxsIGlzIG1hZGUg ZnJvbSBKYXZhU2NyaXB0J3Mgd2luZG93LmNsb3NlIGZ1bmN0aW9uLiBUaGUgc2lnbmFsCisgICAg ICogaGFuZGxlciBzaG91bGQgYmUgdXNlZCB0byBoaWRlIGFuZCBmcmVlIHRoZSAjV2ViS2l0V2Vi VmlldyByZXNvdXJjZQorICAgICAqIGNyZWF0ZWQgaW4gI1dlYktpdFdlYlZpZXc6OmNyZWF0ZS13 ZWItdmlldy4KICAgICAgKgogICAgICAqIFNpbmNlIDEuMS4xMQogICAgICAqLw== 34887 2009-08-14 22:26:22 -0700 2009-08-18 22:57:24 -0700 updated signal doc bug-27439-20090815152620.patch text/plain 3352 jmalonzo ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggNDBmNWNiNy4uZjdlZTZmNyAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAwOS0wOC0xNCAg SmFuIE1pY2hhZWwgQWxvbnpvICA8am1hbG9uem9Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR3RrXSBjcmFzaCB3aGVuIGNsb3Np bmcgcGFnZSBmcm9tIGphdmFzY3JpcHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTI3NDM5CisKKyAgICAgICAgRG8gbm90IHVucmVmIHRoZSBXZWJWaWV3 IGluIENocm9tZUNsaWVudEd0azo6Y2xvc2VXaW5kb3dTb29uCisgICAgICAgIGJlY2F1c2UgKDEp IGEgY3JlYXRlLXdlYi12aWV3IGhhbmRsZXIgY2FuIHJldHVybiBhIE5VTEwgV2ViVmlldywKKyAg ICAgICAgKDIpIHRoZSBjcmVhdGVkIFdlYlZpZXcgaXMgb3duZWQgYnkgaXRzIGNvbnRhaW5pbmcg d2lkZ2V0LCBhbmQgKDMpCisgICAgICAgIGNsaWVudHMgbWF5IG5vdCBoYW5kbGUgdGhlIGNsb3Nl LXdlYi12aWV3IHNpZ25hbCBzbyB0aGlzIGF2b2lkcworICAgICAgICB1bnJlZmZpbmcgYSBXZWJW aWV3IG1vcmUgdGhhbiBvbmNlLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xp ZW50R3RrLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q2hyb21lQ2xpZW50OjpjbG9zZVdpbmRvd1Nv b24pOgorICAgICAgICAqIHdlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcDoKKyAgICAgICAgKHdlYmtp dF93ZWJfdmlld19jbGFzc19pbml0KToKKwogMjAwOS0wOC0xNCAgQmVuamFtaW4gT3R0ZSAgPG90 dGVAZ25vbWUub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEd1c3Rhdm8gTm9yb25oYS4KZGlm ZiAtLWdpdCBhL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50R3RrLmNwcCBi L1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50R3RrLmNwcAppbmRleCAxMjky ZTk5Li4xN2ExNjNiIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Nocm9t ZUNsaWVudEd0ay5jcHAKKysrIGIvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGll bnRHdGsuY3BwCkBAIC0yMTUsNiArMjE1LDEwIEBAIHZvaWQgQ2hyb21lQ2xpZW50OjpzZXRSZXNp emFibGUoYm9vbCkKIAogdm9pZCBDaHJvbWVDbGllbnQ6OmNsb3NlV2luZG93U29vbigpCiB7Cisg ICAgLy8gV2UgbWF5IG5vdCBoYXZlIGEgV2ViVmlldyBhcyBjcmVhdGUtd2ViLXZpZXcgY2FuIHJl dHVybiBOVUxMLgorICAgIGlmICghbV93ZWJWaWV3KQorICAgICAgICByZXR1cm47CisKICAgICB3 ZWJraXRfd2ViX3ZpZXdfc3RvcF9sb2FkaW5nKG1fd2ViVmlldyk7CiAKICAgICBnYm9vbGVhbiBp c0hhbmRsZWQgPSBmYWxzZTsKQEAgLTIyNiw3ICsyMzAsNiBAQCB2b2lkIENocm9tZUNsaWVudDo6 Y2xvc2VXaW5kb3dTb29uKCkKICAgICAvLyBGSVhNRTogc2hvdWxkIHdlIGNsZWFyIHRoZSBmcmFt ZSBncm91cCBuYW1lIGhlcmUgZXhwbGljaXRseT8gTWFjIGRvZXMgaXQuCiAgICAgLy8gQnV0IHRo aXMgZ2V0cyBjbGVhcmVkIGluIFBhZ2UncyBkZXN0cnVjdG9yIGFueXdheS4KICAgICAvLyB3ZWJr aXRfd2ViX3ZpZXdfc2V0X2dyb3VwX25hbWUobV93ZWJWaWV3LCAiIik7Ci0gICAgZ19vYmplY3Rf dW5yZWYobV93ZWJWaWV3KTsKIH0KIAogYm9vbCBDaHJvbWVDbGllbnQ6OmNhblRha2VGb2N1cyhG b2N1c0RpcmVjdGlvbikKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZp ZXcuY3BwIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKaW5kZXggOTdjMGM5 MS4uNzM5MzhkOSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5j cHAKKysrIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKQEAgLTEyMjYsOSAr MTIyNiw5IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmlld19jbGFzc19pbml0KFdlYktpdFdl YlZpZXdDbGFzcyogd2ViVmlld0NsYXNzKQogICAgICAqIFRoZSBuZXcgI1dlYktpdFdlYlZpZXcg c2hvdWxkIG5vdCBiZSBkaXNwbGF5ZWQgdG8gdGhlIHVzZXIKICAgICAgKiB1bnRpbCB0aGUgI1dl YktpdFdlYlZpZXc6OndlYi12aWV3LXJlYWR5IHNpZ25hbCBpcyBlbWl0dGVkLgogICAgICAqCi0g ICAgICogVGhlIHNpZ25hbCBoYW5kbGVycyBzaG91bGQgbm90IHRyeSB0byBkZWFsIHdpdGggdGhl IHJlZmVyZW5jZQotICAgICAqIGNvdW50IGZvciB0aGUgbmV3ICNXZWJLaXRXZWJWaWV3LiBUaGUg d2lkZ2V0IHRvIHdoaWNoIHRoZQotICAgICAqIHdpZGdldCBpcyBhZGRlZCB3aWxsIGhhbmRsZSB0 aGF0LgorICAgICAqIFRoZSBzaWduYWwgaGFuZGxlcnMgc2hvdWxkIG5vdCB0cnkgdG8gZGVhbCB3 aXRoIHRoZSByZWZlcmVuY2UgY291bnQgZm9yCisgICAgICogdGhlIG5ldyAjV2ViS2l0V2ViVmll dy4gVGhlIHdpZGdldCB0byB3aGljaCB0aGUgd2lkZ2V0IGlzIGFkZGVkIHdpbGwKKyAgICAgKiBo YW5kbGUgdGhhdC4KICAgICAgKgogICAgICAqIFNpbmNlIDEuMC4zCiAgICAgICovCkBAIC0xMjc2 LDggKzEyNzYsMTAgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl92aWV3X2NsYXNzX2luaXQoV2Vi S2l0V2ViVmlld0NsYXNzKiB3ZWJWaWV3Q2xhc3MpCiAgICAgICogQHJldHVybjogJVRSVUUgdG8g c3RvcCBoYW5kbGVycyBmcm9tIGJlaW5nIGludm9rZWQgZm9yIHRoZSBldmVudCBvcgogICAgICAq ICVGQUxTRSB0byBwcm9wYWdhdGUgdGhlIGV2ZW50IGZ1cnRlcgogICAgICAqCi0gICAgICogRW1p dHRlZCB3aGVuIGNsb3NpbmcgYSBXZWJWaWV3IGlzIHJlcXVlc3RlZC4gVGhpcyBvY2N1cnMgd2hl biBhIGNhbGwKLSAgICAgKiBpcyBtYWRlIGZyb20gSmF2YVNjcmlwdCdzIHdpbmRvdy5jbG9zZSBm dW5jdGlvbi4KKyAgICAgKiBFbWl0dGVkIHdoZW4gY2xvc2luZyBhICNXZWJLaXRXZWJWaWV3IGlz IHJlcXVlc3RlZC4gVGhpcyBvY2N1cnMgd2hlbiBhCisgICAgICogY2FsbCBpcyBtYWRlIGZyb20g SmF2YVNjcmlwdCdzIHdpbmRvdy5jbG9zZSBmdW5jdGlvbi4gVGhlIGRlZmF1bHQKKyAgICAgKiBz aWduYWwgaGFuZGxlciBkb2VzIG5vdCBkbyBhbnl0aGluZy4gSXQgaXMgdGhlIG93bmVyJ3MgcmVz cG9uc2liaWxpdHkKKyAgICAgKiB0byBoaWRlIG9yIGRlbGV0ZSB0aGUgd2ViIHZpZXcsIGlmIG5l Y2Vzc2FyeS4KICAgICAgKgogICAgICAqIFNpbmNlIDEuMS4xMQogICAgICAqLw==