274297 2024-05-16 21:33:28 -0700 Stop using `const char*` in string concatenations 2024-07-09 02:09:14 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez dpino dpino philn webkit-bug-importer oldest_to_newest 2035950 0 cdumez 2024-05-16 21:33:28 -0700 Stop using `const char*` in string concatenations, to encourage the use of ASCIILiteral and std::span. 2036003 1 cdumez 2024-05-17 07:49:59 -0700 Pull request: https://github.com/WebKit/WebKit/pull/28707 2036315 2 ews-feeder 2024-05-19 17:11:03 -0700 Committed 278972@main (1cf337e0a50a): <https://commits.webkit.org/278972@main> Reviewed commits have been landed. Closing PR #28707 and removing active labels. 2036316 3 webkit-bug-importer 2024-05-19 17:12:15 -0700 <rdar://problem/128366439> 2036614 4 dpino 2024-05-20 23:10:58 -0700 GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004 fails with the following error: https://build.webkit.org/#/builders/30/builds/8960 (this bot builds with libwebrtc) ``` ../../../Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoEncoderFactory.cpp:121:91: required from here WTF/Headers/wtf/text/StringConcatenate.h:534:38: error: invalid use of incomplete type ‘class WTF::StringTypeAdapter<const char*, void>’ 534 | return tryMakeStringFromAdapters(StringTypeAdapter<StringTypes>(strings)...); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from WTF/Headers/wtf/text/IntegerToStringConversion.h:27, from WTF/Headers/wtf/text/WTFString.h:27, from ../../../Source/WebCore/dom/Exception.h:30, from ../../../Source/WebCore/dom/ExceptionOr.h:29, from ../../../Source/WebCore/platform/mediastream/RTCDTMFSenderBackend.h:29, from ../../../Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCDTMFSenderBackend.h:30, from ../../../Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCDTMFSenderBackend.cpp:27, from WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-74.cpp:1: WTF/Headers/wtf/Forward.h:106:43: note: declaration of ‘class WTF::StringTypeAdapter<const char*, void>’ 106 | template<typename, typename = void> class StringTypeAdapter; | ^~~~~~~~~~~~~~~~~ ``` 2036615 5 dpino 2024-05-20 23:12:23 -0700 Re-opening for pull request https://github.com/webkit/webkit/pull/28830 2036617 6 ews-feeder 2024-05-20 23:35:48 -0700 Committed 279038@main (d1b1d17c730c): <https://commits.webkit.org/279038@main> Reviewed commits have been landed. Closing PR #28830 and removing active labels.