27423 2009-07-19 12:35:42 -0700 Remove some outdated S60 platform specific code 2009-07-20 02:50:54 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 laszlo.gombos webkit-unassigned hausmann oldest_to_newest 133002 0 laszlo.gombos 2009-07-19 12:35:42 -0700 The definition of PLATFORM(S60) is ambiguous; S60 should not be defined for the sole reason of __SYMBIAN32__ being defined. The PLATFORM(S60) guard is not used in the source tree, so to avoid further confusion I would propose to remove the PLATFROM(S60) definition and use PLATFORM(SYMBIAN) instead. I confirmed that this change has no impact on the current Symbian port of QtWebKit. 133003 1 33049 laszlo.gombos 2009-07-19 12:43:26 -0700 Created attachment 33049 Proposed patch ! Also removed WTF_USE_SYMBIAN_UNICODE, it is no longer used. 133093 2 hausmann 2009-07-20 02:50:54 -0700 Landed in r46115 33049 2009-07-19 12:43:26 -0700 2009-07-19 22:58:49 -0700 Proposed patch ! patch_27423.txt text/plain 1632 laszlo.gombos SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ2MTA1KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMDctMTkgIExhc3psbyBH b21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBzb21lIG91dGRhdGVkIFM2MCBwbGF0 Zm9ybSBzcGVjaWZpYyBjb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yNzQyMworCisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6CisKIDIwMDktMDct MTcgIFBldGVyIEthc3RpbmcgIDxwa2FzdGluZ0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IFN0ZXZlIEZhbGtlbmJ1cmcuCkluZGV4OiBKYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZv cm0uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAkocmV2aXNp b24gNDYwOTApCisrKyBKYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAkod29ya2luZyBjb3B5 KQpAQCAtOTMsMTIgKzkzLDEwIEBACiAjZGVmaW5lIFdURl9QTEFURk9STV9TT0xBUklTIDEKICNl bmRpZgogCi0jaWYgZGVmaW5lZCAoX19TNjBfXykgfHwgZGVmaW5lZCAoX19TWU1CSUFOMzJfXykK KyNpZiBkZWZpbmVkIChfX1NZTUJJQU4zMl9fKQogLyogd2UgYXJlIGNyb3NzLWNvbXBpbGluZywg aXQgaXMgbm90IHJlYWxseSB3aW5kb3dzICovCiAjdW5kZWYgV1RGX1BMQVRGT1JNX1dJTl9PUwog I3VuZGVmIFdURl9QTEFURk9STV9XSU4KLSN1bmRlZiBXVEZfUExBVEZPUk1fQ0FJUk8KLSNkZWZp bmUgV1RGX1BMQVRGT1JNX1M2MCAxCiAjZGVmaW5lIFdURl9QTEFURk9STV9TWU1CSUFOIDEKICNl bmRpZgogCkBAIC0xMTUsNyArMTEzLDcgQEAKIC8qIHNob3VsZCBiZSB1c2VkIHJlZ2FyZGxlc3Mg b2Ygb3BlcmF0aW5nIGVudmlyb25tZW50ICovCiAjaWYgICBQTEFURk9STShEQVJXSU4pICAgICBc CiAgICB8fCBQTEFURk9STShGUkVFQlNEKSAgICBcCi0gICB8fCBQTEFURk9STShTNjApICAgICAg ICBcCisgICB8fCBQTEFURk9STShTWU1CSUFOKSAgICBcCiAgICB8fCBQTEFURk9STShORVRCU0Qp ICAgICBcCiAgICB8fCBkZWZpbmVkKHVuaXgpICAgICAgICBcCiAgICB8fCBkZWZpbmVkKF9fdW5p eCkgICAgICBcCkBAIC0zNzAsOCArMzY4LDYgQEAKIC8qIGZvciBVbmljb2RlLCBLREUgdXNlcyBR dCAqLwogI2lmIFBMQVRGT1JNKEtERSkgfHwgUExBVEZPUk0oUVQpCiAjZGVmaW5lIFdURl9VU0Vf UVQ0X1VOSUNPREUgMQotI2VsaWYgUExBVEZPUk0oU1lNQklBTikKLSNkZWZpbmUgV1RGX1VTRV9T WU1CSUFOX1VOSUNPREUgMQogI2VsaWYgUExBVEZPUk0oR1RLKQogLyogVGhlIEdUSysgVW5pY29k ZSBiYWNrZW5kIGlzIGNvbmZpZ3VyYWJsZSAqLwogI2Vsc2UK