27422 2009-07-19 07:46:43 -0700 HTMLAudioElement: constructor should set "autobuffer" attribute 2009-07-19 11:17:06 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 eric.carlson eric.carlson oldest_to_newest 132993 0 eric.carlson 2009-07-19 07:46:43 -0700 The spec now says: " When invoked as constructors ... the element must have its autobuffer attribute set to the literal value "autobuffer"." 132997 1 33046 eric.carlson 2009-07-19 08:35:27 -0700 Created attachment 33046 proposed patch 133000 2 eric.carlson 2009-07-19 11:17:06 -0700 http://trac.webkit.org/changeset/46104 33046 2009-07-19 08:35:27 -0700 2009-07-19 09:05:16 -0700 proposed patch patch.txt text/plain 4047 eric.carlson SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NjEwMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMDctMTkgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBh cHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgSFRNTEF1ZGlvRWxlbWVudDogY29uc3RydWN0b3Igc2hvdWxkIHNldCAiYXV0b2J1ZmZlciIg YXR0cmlidXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yNzQyMgorCisgICAgICAgIFRlc3Q6IG1lZGlhL2F1ZGlvLWNvbnN0cnVjdG9yLWF1dG9idWZm ZXIuaHRtbAorCisgICAgICAgICogYmluZGluZ3MvanMvSlNBdWRpb0NvbnN0cnVjdG9yLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OmNvbnN0cnVjdEF1ZGlvKToKKyAgICAgICAgICAgIFNldCAnYXV0 b2J1ZmZlcicgYXR0cmlidXRlLgorCiAyMDA5LTA3LTE5ICBUaGllcnJ5IEJhc3RpYW4gPHRoaWVy cnkuYmFzdGlhbkBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21h bm4uCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL2pzL0pTQXVkaW9Db25zdHJ1Y3Rvci5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0F1ZGlvQ29uc3RydWN0b3IuY3BwCShy ZXZpc2lvbiA0NjEwMykKKysrIFdlYkNvcmUvYmluZGluZ3MvanMvSlNBdWRpb0NvbnN0cnVjdG9y LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjYsNiArNjYsNyBAQCBzdGF0aWMgSlNPYmplY3QqIGNv bnN0cnVjdEF1ZGlvKEV4ZWNTdGF0CiAgICAgICAgIHJldHVybiB0aHJvd0Vycm9yKGV4ZWMsIFJl ZmVyZW5jZUVycm9yLCAiQXVkaW8gY29uc3RydWN0b3IgYXNzb2NpYXRlZCBkb2N1bWVudCBpcyB1 bmF2YWlsYWJsZSIpOwogCiAgICAgUmVmUHRyPEhUTUxBdWRpb0VsZW1lbnQ+IGF1ZGlvID0gbmV3 IEhUTUxBdWRpb0VsZW1lbnQoSFRNTE5hbWVzOjphdWRpb1RhZywgZG9jdW1lbnQpOworICAgIGF1 ZGlvLT5zZXRBdXRvYnVmZmVyKHRydWUpOwogICAgIGlmIChhcmdzLnNpemUoKSA+IDApIHsKICAg ICAgICAgYXVkaW8tPnNldFNyYyhhcmdzLmF0KDApLnRvU3RyaW5nKGV4ZWMpKTsKICAgICAgICAg YXVkaW8tPnNjaGVkdWxlTG9hZCgpOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNDYxMDMpCisrKyBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0w Ny0xOSAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBIVE1MQXVkaW9FbGVtZW50OiBj b25zdHJ1Y3RvciBzaG91bGQgc2V0ICJhdXRvYnVmZmVyIiBhdHRyaWJ1dGUKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3NDIyCisKKyAgICAgICAgKiBt ZWRpYS9hdWRpby1jb25zdHJ1Y3Rvci1hdXRvYnVmZmVyLWV4cGVjdGVkLnR4dDogQWRkZWQuCisg ICAgICAgICogbWVkaWEvYXVkaW8tY29uc3RydWN0b3ItYXV0b2J1ZmZlci5odG1sOiBBZGRlZC4K KwogMjAwOS0wNy0xOCAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IEFuZGVycyBDYXJsc3Nvbi4KSW5kZXg6IExheW91dFRlc3RzL21lZGlhL2F1 ZGlvLWNvbnN0cnVjdG9yLWF1dG9idWZmZXItZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL21lZGlhL2F1ZGlvLWNvbnN0cnVjdG9yLWF1dG9idWZmZXItZXhwZWN0ZWQudHh0 CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvbWVkaWEvYXVkaW8tY29uc3RydWN0b3ItYXV0 b2J1ZmZlci1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTYgQEAKK1Rlc3Qg dGhhdCBBdWRpbygpIHNldHMgJ2F1dG9idWZmZXInIGF0dHJpYnV0ZS4KKworUlVOKG1lZGlhID0g bmV3IEF1ZGlvKCkpCisKKysrIFRlc3QgaW5pdGlhbCBhdHRyaWJ1dGUgdmFsdWUKK0VYUEVDVEVE IChtZWRpYS5nZXRBdHRyaWJ1dGUoJ2F1dG9idWZmZXInKSAhPSAnbnVsbCcpIE9LCitFWFBFQ1RF RCAobWVkaWEuYXV0b2J1ZmZlciA9PSAndHJ1ZScpIE9LCisKK1JVTihtZWRpYS5zcmMgPSAnY29u dGVudC90ZXN0LndhdicpCitSVU4obWVkaWEubG9hZCgpKQorCisrKyBUZXN0IGFmdGVyICdsb2Fk JyBldmVudAorRVhQRUNURUQgKG1lZGlhLmdldEF0dHJpYnV0ZSgnYXV0b2J1ZmZlcicpICE9ICdu dWxsJykgT0sKK0VYUEVDVEVEIChtZWRpYS5hdXRvYnVmZmVyID09ICd0cnVlJykgT0sKK0VORCBP RiBURVNUCisKSW5kZXg6IExheW91dFRlc3RzL21lZGlhL2F1ZGlvLWNvbnN0cnVjdG9yLWF1dG9i dWZmZXIuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9tZWRpYS9hdWRpby1jb25zdHJ1 Y3Rvci1hdXRvYnVmZmVyLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9tZWRpYS9h dWRpby1jb25zdHJ1Y3Rvci1hdXRvYnVmZmVyLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEs MzggQEAKKzxodG1sPgorICAgIDxoZWFkPgorICAgICAgICA8c2NyaXB0IHNyYz12aWRlby10ZXN0 LmpzPjwvc2NyaXB0PgorCisgICAgICAgIDxzY3JpcHQ+CisKKyAgICAgICAgICAgIGZ1bmN0aW9u IGxvYWRlZCgpCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgY29uc29sZVdyaXRlKCIr KyBUZXN0IGFmdGVyICdsb2FkJyBldmVudCIpOworICAgICAgICAgICAgICAgIHRlc3RFeHBlY3Rl ZCgibWVkaWEuZ2V0QXR0cmlidXRlKCdhdXRvYnVmZmVyJykiLCBudWxsLCAiIT0iKTsKKyAgICAg ICAgICAgICAgICB0ZXN0RXhwZWN0ZWQoIm1lZGlhLmF1dG9idWZmZXIiLCB0cnVlKTsKKyAgICAg ICAgICAgICAgICBlbmRUZXN0KCk7CisgICAgICAgICAgICB9CisKKyAgICAgICAgICAgIGZ1bmN0 aW9uIHN0YXJ0KCkKKyAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICBydW4oIm1lZGlhID0g bmV3IEF1ZGlvKCkiKTsKKyAgICAgICAgICAgICAgICBjb25zb2xlV3JpdGUoIiIpOworCisgICAg ICAgICAgICAgICAgY29uc29sZVdyaXRlKCIrKyBUZXN0IGluaXRpYWwgYXR0cmlidXRlIHZhbHVl Iik7CisgICAgICAgICAgICAgICAgdGVzdEV4cGVjdGVkKCJtZWRpYS5nZXRBdHRyaWJ1dGUoJ2F1 dG9idWZmZXInKSIsIG51bGwsICIhPSIpOworICAgICAgICAgICAgICAgIHRlc3RFeHBlY3RlZCgi bWVkaWEuYXV0b2J1ZmZlciIsIHRydWUpOworICAgICAgICAgICAgICAgIGNvbnNvbGVXcml0ZSgi Iik7CisKKyAgICAgICAgICAgICAgICBtZWRpYS5vbmxvYWQgPSBsb2FkZWQ7CisgICAgICAgICAg ICAgICAgcnVuKCJtZWRpYS5zcmMgPSAnY29udGVudC90ZXN0LndhdiciKTsKKyAgICAgICAgICAg ICAgICBydW4oIm1lZGlhLmxvYWQoKSIpOworCisgICAgICAgICAgICAgICAgY29uc29sZVdyaXRl KCIiKTsKKyAgICAgICAgICAgIH0KKworICAgICAgICA8L3NjcmlwdD4KKyAgICA8L2hlYWQ+CisK KyAgICA8Ym9keSBvbmxvYWQ9InN0YXJ0KCkiPgorICAgICAgICA8cD5UZXN0IHRoYXQgQXVkaW8o KSBzZXRzICdhdXRvYnVmZmVyJyBhdHRyaWJ1dGUuPC9wPgorICAgIDwvYm9keT4KKzwvaHRtbD4K