274214 2024-05-15 09:00:44 -0700 Constructed FormData object should not contain entries for the Image Button submitter by default 2024-05-17 20:36:08 -0700 1 1 1 Unclassified WebKit Forms Safari 16 Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=239070 https://bugs.webkit.org/show_bug.cgi?id=274277 BrowserCompat, InRadar P2 Normal --- 1 jenseng webkit-unassigned ahmad.saleem792 akeerthi cdumez karlcow webkit-bug-importer wenson_hsieh zsun oldest_to_newest 2035556 0 jenseng 2024-05-15 09:00:44 -0700 Overview: When a `FormData` object is constructed in a submit handler, it automatically contains entries for the Image Button submitter even if the `submitter` parameter is not passed to the constructor. This does not happen with regular (non-image) submitters. This also does not happen in Chromium or Gecko. This is related to https://bugs.webkit.org/show_bug.cgi?id=239070, but was not resolved by https://commits.webkit.org/r293444 Steps to Reproduce: 1. Create a page with the following content: > <script> > function onSubmit(event) { > event.preventDefault(); > const formData = new FormData(event.target); > console.log(new URLSearchParams(formData).toString()); > } > </script> > <form onsubmit="onSubmit(event)"> > <input > name="submitter" > type="image" > name="input" > href="/some/image.png" > alt="Image Button" > /> > </form> ``` 2. Click the `Image Button` Actual Results: Something like `submitter.x=10&submitter.y=4` is logged Expected Results: An empty string should be logged. The submitter should only be included in the FormData object if it is explicitly passed to the constructor. See https://developer.mozilla.org/en-US/docs/Web/API/FormData/FormData#submitter 2035687 1 471419 karlcow 2024-05-15 21:12:40 -0700 Created attachment 471419 testcase Adding the testcase 2035699 2 webkit-bug-importer 2024-05-15 22:13:02 -0700 <rdar://problem/128176811> 2035764 3 ahmad.saleem792 2024-05-16 05:44:40 -0700 This is even earlier attempt of bug 239070 which tried to extend WPT test as well for image. https://bugs.webkit.org/show_bug.cgi?id=234069 Also later `image` changes from bug 234069 were not carried into 239070. So it might be just reapplying 234069 (image specific changes)? 2035766 4 ahmad.saleem792 2024-05-16 05:54:12 -0700 (In reply to Ahmad Saleem from comment #3) > This is even earlier attempt of bug 239070 which tried to extend WPT test as > well for image. > > https://bugs.webkit.org/show_bug.cgi?id=234069 > > Also later `image` changes from bug 234069 were not carried into 239070. So > it might be just reapplying 234069 (image specific changes)? Confirmed on local build that just doing `image` specific changes from bug 234069 fixes this test case. 2035769 5 ahmad.saleem792 2024-05-16 06:08:02 -0700 Next steps should be - take tests from bug 234069 and upload them on WPT - so if we introduce this behavior - we don't regress leading to: rdar://88359001 and then once test lands then do this changes and ensure that WPT passes. 2035797 6 jenseng 2024-05-16 08:13:23 -0700 Opened a PR to add wpts around this: https://github.com/web-platform-tests/wpt/pull/46316 2035798 7 ahmad.saleem792 2024-05-16 08:14:49 -0700 (In reply to Jon Jensen from comment #6) > Opened a PR to add wpts around this: > https://github.com/web-platform-tests/wpt/pull/46316 Perfect! Once this get merged, I will add it to WebKit repo and then do PR to fix it and confirm whether it fixes everything and don't regress any behavior. 2036023 8 ahmad.saleem792 2024-05-17 09:21:40 -0700 Draft PR - https://github.com/WebKit/WebKit/pull/28713 ^ I will check bit more locally to confirm it does not cause similar regression as in bug 239070 I synced the tests in bug 274277. 2036029 9 ahmad.saleem792 2024-05-17 09:36:15 -0700 (In reply to Ahmad Saleem from comment #8) > Draft PR - https://github.com/WebKit/WebKit/pull/28713 > > ^ I will check bit more locally to confirm it does not cause similar > regression as in bug 239070 > > I synced the tests in bug 274277. I took tests from: https://github.com/web-platform-tests/wpt/pull/32916 and confirmed that they pass and don't lead to regression as in rdar://88359001. Got following on local: PASS Image submit button should submit the right coordinates on mouse clicks PASS With multiple image submit buttons, the correct one should be used 2036187 10 ews-feeder 2024-05-17 20:36:06 -0700 Committed 278944@main (69eafe9632ca): <https://commits.webkit.org/278944@main> Reviewed commits have been landed. Closing PR #28713 and removing active labels. 471419 2024-05-15 21:12:40 -0700 2024-05-15 21:12:40 -0700 testcase testcase.html text/html 1221 karlcow PCFET0NUWVBFIGh0bWw+CjxodG1sIGxhbmc9ImVuIj4KCjxoZWFkPgogICAgPG1ldGEgY2hhcnNl dD0iVVRGLTgiPgogICAgPG1ldGEgbmFtZT0idmlld3BvcnQiCiAgICAgICAgICBjb250ZW50PSJ3 aWR0aD1kZXZpY2Utd2lkdGgsIGluaXRpYWwtc2NhbGU9MS4wIj4KICAgIDx0aXRsZT50ZXN0Y2Fz ZSBmb3IgZm9ybURhdGE8L3RpdGxlPgo8L2hlYWQ+Cgo8Ym9keT4KICAgIDxmb3JtIG9uc3VibWl0 PSJvblN1Ym1pdChldmVudCkiPgogICAgICAgIDxpbnB1dCBuYW1lPSJzdWJtaXR0ZXIiCiAgICAg ICAgICAgICAgIHR5cGU9ImltYWdlIgogICAgICAgICAgICAgICBuYW1lPSJpbnB1dCIKICAgICAg ICAgICAgICAgaHJlZj0iL3NvbWUvaW1hZ2UucG5nIgogICAgICAgICAgICAgICBhbHQ9IkNsaWNr IG1lISIgLz4KICAgIDwvZm9ybT4KICAgIDxkaXYgaWQ9InJlc3VsdCI+PC9kaXY+CiAgIDxzY3Jp cHQ+CiAgICAgICAgZnVuY3Rpb24gb25TdWJtaXQoZXZlbnQpIHsKICAgICAgICAgICAgZXZlbnQu cHJldmVudERlZmF1bHQoKTsKICAgICAgICAgICAgY29uc3QgZm9ybURhdGEgPSBuZXcgRm9ybURh dGEoZXZlbnQudGFyZ2V0KTsKICAgICAgICAgICAgY29uc3QgYWN0dWFsID0gbmV3IFVSTFNlYXJj aFBhcmFtcyhmb3JtRGF0YSkudG9TdHJpbmcoKTsKICAgICAgICAgICAgY29uc3QgZXhwZWN0ZWQg PSAiIjsKICAgICAgICAgICAgY29uc29sZS5sb2coYWN0dWFsKTsKICAgICAgICAgICAgY29uc3Qg cmVzdWx0ID0gZG9jdW1lbnQucXVlcnlTZWxlY3RvcignI3Jlc3VsdCcpOyAgCiAgICAgICAgICAg IGlmIChhY3R1YWwgPT0gZXhwZWN0ZWQpIHsKICAgICAgICAgICAgICAgIHJlc3VsdC50ZXh0Q29u dGVudCA9ICJQQVNTIjsKICAgICAgICAgICAgICAgIHJlc3VsdC5zdHlsZS5iYWNrZ3JvdW5kQ29s b3IgPSAibGlnaHRncmVlbiI7CiAgICAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICAgICBj b25zdCBtc2cgPSAiRkFJTDogZm9ybURhdGEgc2hvdWxkIHJldHVybiBhbiBlbXB0eSBzdHJpbmcu IEFjdHVhbCB2YWx1ZTogIiArIGFjdHVhbDsKICAgICAgICAgICAgICAgIHJlc3VsdC50ZXh0Q29u dGVudCA9IG1zZzsKICAgICAgICAgICAgICAgIHJlc3VsdC5zdHlsZS5iYWNrZ3JvdW5kQ29sb3Ig PSAiI0ZGQ0NDQiI7CiAgICAgICAgICAgIH0KICAgICAgICAgICAgCiAgICAgICAgfQoKICAgIDwv c2NyaXB0Pgo8L2JvZHk+Cgo8L2h0bWw+