<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>274185</bug_id>
          
          <creation_ts>2024-05-14 15:03:00 -0700</creation_ts>
          <short_desc>REGRESSION(278000@main): [Filters] CanvasFilters should be properly enabled and disabled by the setting</short_desc>
          <delta_ts>2024-05-15 00:55:08 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Canvas</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Said Abou-Hallawa">sabouhallawa</reporter>
          <assigned_to name="Said Abou-Hallawa">sabouhallawa</assigned_to>
          <cc>dino</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2035381</commentid>
    <comment_count>0</comment_count>
      <attachid>471406</attachid>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2024-05-14 15:03:00 -0700</bug_when>
    <thetext>Created attachment 471406
test case

Open the attached test.

Expected: the test case shows the message: &quot;Do not have filters&quot;
Actual result: the test case shows the message: &quot;Have filters&quot;

Since the CanvasFilters feature is not marked &quot;stable&quot; yet, it should be disabled. The attribute filters in CanvasFilters.idl is missing &apos;EnabledBySetting=CanvasFiltersEnabled&apos;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2035382</commentid>
    <comment_count>1</comment_count>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2024-05-14 15:03:25 -0700</bug_when>
    <thetext>rdar://127861271</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2035384</commentid>
    <comment_count>2</comment_count>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2024-05-14 15:07:57 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/28566</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2035491</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2024-05-15 00:55:06 -0700</bug_when>
    <thetext>Committed 278799@main (d8672929f45b): &lt;https://commits.webkit.org/278799@main&gt;

Reviewed commits have been landed. Closing PR #28566 and removing active labels.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>471406</attachid>
            <date>2024-05-14 15:03:00 -0700</date>
            <delta_ts>2024-05-14 15:03:00 -0700</delta_ts>
            <desc>test case</desc>
            <filename>canvas-filter-feature-detection.html</filename>
            <type>text/html</type>
            <size>530</size>
            <attacher name="Said Abou-Hallawa">sabouhallawa</attacher>
            
              <data encoding="base64">PHN0eWxlPgogICAgY2FudmFzIHsKICAgICAgICB3aWR0aDogMTAwcHg7CiAgICAgICAgaGVpZ2h0
OiAxMDBweDsKICAgICAgICBib3JkZXI6IDFweCBzb2xpZCBibGFjazsKICAgIH0KPC9zdHlsZT4K
PGJvZHk+CiAgICA8Y2FudmFzPjwvY2FudmFzPgogICAgPGJyPgogICAgPGRpdiBpZD0icmVzdWx0
cyI+PC9kaXY+CiAgICA8c2NyaXB0PgogICAgICAgIHZhciBjID0gZG9jdW1lbnQucXVlcnlTZWxl
Y3RvcigiY2FudmFzIik7CiAgICAgICAgdmFyIGN0eCA9IGMuZ2V0Q29udGV4dCgiMmQiKTsKICAg
ICAgICAgICAgICAgIAogICAgICAgIGNvbnN0IHJlc3VsdHMgPSBkb2N1bWVudC5nZXRFbGVtZW50
QnlJZCgncmVzdWx0cycpOwogICAgICAgIGlmICgnZmlsdGVyJyBpbiBjdHgpCiAgICAgICAgICAg
IHJlc3VsdHMudGV4dENvbnRlbnQgPSAnSGF2ZSBmaWx0ZXJzJzsKICAgICAgICBlbHNlCiAgICAg
ICAgICAgIHJlc3VsdHMudGV4dENvbnRlbnQgPSAnRG8gbm90IGhhdmUgZmlsdGVycyc7CiAgICA8
L3NjcmlwdD4KPC9ib2R5Pgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>