274154 2024-05-14 07:29:31 -0700 [Win] Switch from MASM to clang-cl for assembling offlineasm 2024-05-14 13:34:36 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build PC Windows 10 RESOLVED FIXED InRadar P2 Normal --- 1 ian.grunert webkit-unassigned fujii webkit-bug-importer oldest_to_newest 2035243 0 ian.grunert 2024-05-14 07:29:31 -0700 This brings Windows in line with every other platform in how they build offlineasm using the LLIntAssembly.h output. After this change we can rip out the intel syntax generation from offlineasm x86.rb, as clang-cl inline asm supports AT&T syntax. I also wonder if it'll open up possibility for ENABLE_UNIFIED_AND_FREEZABLE_CONFIG_RECORD, as the C++ compiler might be able to resolve the DLL bindings for offlineasm automatically (see this comment https://github.com/WebKit/WebKit/blob/b20a04aa7b405aaf02cebbda8fa73e51e32b1db8/Source/WTF/wtf/PlatformEnable.h#L856-L867) 2035249 1 ian.grunert 2024-05-14 07:49:24 -0700 Pull request: https://github.com/WebKit/WebKit/pull/28538 2035287 2 ews-feeder 2024-05-14 09:57:31 -0700 Committed 278767@main (45da61538271): <https://commits.webkit.org/278767@main> Reviewed commits have been landed. Closing PR #28538 and removing active labels. 2035288 3 webkit-bug-importer 2024-05-14 09:58:17 -0700 <rdar://problem/128071085>