27411 2009-07-18 04:16:11 -0700 [GTK] Clipboard data is lost on exit 2010-07-29 14:05:16 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 ickard webkit-unassigned a.butenka christian commit-queue gustavo mrobinson sarah.e.strong oldest_to_newest 132901 0 ickard 2009-07-18 04:16:11 -0700 In gtk applications, one can use the clipboard in different ways: either just using the two convenience functions (if you will) gtk_clipboard_set_text() and gtk_clipboard_set_image(). When using these, clipboard data persists when one exits a program( this is due to gtk automatically calling gtk_clipboard_set_can_store() when one is calling these. If gtk_clipboard_set_can_store() is set properly, clipboard data can be stored to the freedesktop clipboard manager (http://www.freedesktop.org/wiki/Specifications/clipboard-manager-spec) which gnome implements. The transfer to the clipboard will happen once gtk_clipboard_store() is called, or when the application main loop exits. Steps to reproduce: 1. open a webkit-gtk browser( I used epiphany) 2. copy some text to the clipboard (not selection clipboard) 3. open gedit, paste it there (this should work) 4. quit epiphany, try to paste again (this does not work) This bug affects a couple of programs in the linux desktop (for instance firefox), so to see the clipboard manager working as intended try to use for instance gedit in a gnome environment (if you quit gedit, its clipboard data should persist). 132920 1 a.butenka 2009-07-18 10:09:58 -0700 as i know, its a longstanding GTK bug in general. not a webkit 132953 2 ickard 2009-07-18 15:48:11 -0700 (In reply to comment #1) > as i know, its a longstanding GTK bug in general. not a webkit No it's not really a gtk bug, there are properly working gtk apps (such as gedit) 173693 3 christian 2009-12-20 03:05:28 -0800 This works with Clipman in XFCE 4.6. So is this really a problem with WebKitGTK+? From a look at GTK+ sources the default clipboard is stored automatically. And surely GTK+ doesn't expect all existing applications to handle this manually. I might be wrong. 249128 4 sarah.e.strong 2010-07-09 11:20:13 -0700 I can confirm this bug in Epiphany and Empathy using Webkit-1.3.2 in Ubuntu 10.04. Clipboard managers such as Klipper (a part of KDE), Glipper, Parcellite and Clipman work around this problem so it's expected that you wouldn't be able to reproduce it if you're running one of those. It's not a GTK+ bug; that is to say, gtk provides the functions ickard mentioned so that applications can save their data before they exit. It would be nice if existing applications didn't have to handle it manually, but right now gtk_clipboard_set_can_store()/gtk_clipboard_store() are the right way of fixing it. 249819 5 61225 sarah.e.strong 2010-07-12 07:16:41 -0700 Created attachment 61225 Sets gtk_clipboard_set_can_store when clipboard is acquired to fix bug #27411: clipboard lost on exit. 249822 6 61225 gustavo 2010-07-12 07:29:21 -0700 Comment on attachment 61225 Sets gtk_clipboard_set_can_store when clipboard is acquired to fix bug #27411: clipboard lost on exit. WebKit/gtk/webkit/webkitwebview.cpp:3565 + NULL, 0); Two things: no need to break the line here, in WebKit code we're used to longer lines, and this makes a bit more readable. Also, the style guidelines say we should use 0 instead of NULL (though we do use NULL in a few cases we get warnings otherwise). As for the content, it looks sane to me, but I'd like to hear mrobinson's opinion as well, since he's the one who's been working on clipboard/dragndrop the most recently (I'll poke him). Also, we might also want to save the PRIMARY clipboard, right? I'll say r- for now, because we need a ChangeLog entry. I assume you are not a committer, so you may want to set commit-queue to ? as well, so that the person who reviews your patch can make the patch be automatic committed for you =). 249863 7 61234 sarah.e.strong 2010-07-12 08:48:17 -0700 Created attachment 61234 Sets gtk_clipboard_set_can_store when clipboard is acquired. With changes suggested by kov: https://bugs.webkit.org/show_bug.cgi?id=27411#c6 249871 8 sarah.e.strong 2010-07-12 09:03:59 -0700 I didn't add a primary buffer save because there's some disagreement on whether it makes sense conceptually. I think the argument against it is that primary selection isn't meant for workflow where you'd need clipboard persistence. The argument for it is of course preserving more information the user might want. It should be straightforward to add primary save support. I'll up a new patch once I've tested that. 249916 9 mrobinson 2010-07-12 11:08:09 -0700 Patch looks good, but this may not be the correct place to call these functions. Having the change here means that not all code paths which set the clipboard will get this fix. Perhaps it would make more sense to do it here: http://trac.webkit.org/browser/trunk/WebCore/platform/gtk/PasteboardHelper.cpp#L286 in writeClipboardContents. Please consider this change. Thanks! 249959 10 61256 sarah.e.strong 2010-07-12 12:24:10 -0700 Created attachment 61256 Sets gtk_clipboard_set_can_store in WebCore. With changes suggested by mrobinson: https://bugs.webkit.org/show_bug.cgi?id=27411#c9 249964 11 mrobinson 2010-07-12 12:29:12 -0700 This looks good to me! A reviewer will have to do the r+. 252582 12 61822 sarah.e.strong 2010-07-16 10:22:45 -0700 Created attachment 61822 Sets gtk_clipboard_set_can_store in WebCore. With updated information about testing the behaviour. 252585 13 61822 gustavo 2010-07-16 10:29:44 -0700 Comment on attachment 61822 Sets gtk_clipboard_set_can_store in WebCore. With updated information about testing the behaviour. Very good, thanks! 252603 14 61822 commit-queue 2010-07-16 10:55:30 -0700 Comment on attachment 61822 Sets gtk_clipboard_set_can_store in WebCore. With updated information about testing the behaviour. Rejecting patch 61822 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Gustavo Noronha Silva', u'--force']" exit_code: 2 Parsed 2 diffs from patch file(s). patching file WebCore/ChangeLog patch: **** malformed patch at line 21: + I haven't included an automated test because of the difficulty of testing behaviour after application exit. patching file WebCore/platform/gtk/PasteboardHelper.cpp Full output: http://webkit-commit-queue.appspot.com/results/3562073 252614 15 61827 sarah.e.strong 2010-07-16 11:13:47 -0700 Created attachment 61827 Sets gtk_clipboard_set_can_store in WebCore. With malformed patch fix 252616 16 61827 gustavo 2010-07-16 11:16:46 -0700 Comment on attachment 61827 Sets gtk_clipboard_set_can_store in WebCore. With malformed patch fix let's try again 252709 17 61827 commit-queue 2010-07-16 14:49:46 -0700 Comment on attachment 61827 Sets gtk_clipboard_set_can_store in WebCore. With malformed patch fix Clearing flags on attachment: 61827 Committed r63587: <http://trac.webkit.org/changeset/63587> 61225 2010-07-12 07:16:41 -0700 2010-07-12 08:48:17 -0700 Sets gtk_clipboard_set_can_store when clipboard is acquired to fix bug #27411: clipboard lost on exit. webkitbug27411.diff text/plain 1181 sarah.e.strong ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwIGIvV2ViS2l0 L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKaW5kZXggYTQwNGUwOC4uZDhmZmE5OCAxMDA2 NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKKysrIGIvV2ViS2l0 L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKQEAgLTM1NDEsOCArMzU0MSwxMiBAQCB2b2lk IHdlYmtpdF93ZWJfdmlld19jdXRfY2xpcGJvYXJkKFdlYktpdFdlYlZpZXcqIHdlYlZpZXcpCiB7 CiAgICAgZ19yZXR1cm5faWZfZmFpbChXRUJLSVRfSVNfV0VCX1ZJRVcod2ViVmlldykpOwogCi0g ICAgaWYgKHdlYmtpdF93ZWJfdmlld19jYW5fY3V0X2NsaXBib2FyZCh3ZWJWaWV3KSkKKyAgICBp ZiAod2Via2l0X3dlYl92aWV3X2Nhbl9jdXRfY2xpcGJvYXJkKHdlYlZpZXcpKSB7CiAgICAgICAg IGdfc2lnbmFsX2VtaXQod2ViVmlldywgd2Via2l0X3dlYl92aWV3X3NpZ25hbHNbQ1VUX0NMSVBC T0FSRF0sIDApOworICAgICAgICBndGtfY2xpcGJvYXJkX3NldF9jYW5fc3RvcmUoZ3RrX2NsaXBi b2FyZF9nZXQoR0RLX1NFTEVDVElPTl9DTElQQk9BUkQpLAorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgTlVMTCwgMCk7CisgICAgfQorCiB9CiAK IC8qKgpAQCAtMzU1NSw4ICszNTU5LDEyIEBAIHZvaWQgd2Via2l0X3dlYl92aWV3X2NvcHlfY2xp cGJvYXJkKFdlYktpdFdlYlZpZXcqIHdlYlZpZXcpCiB7CiAgICAgZ19yZXR1cm5faWZfZmFpbChX RUJLSVRfSVNfV0VCX1ZJRVcod2ViVmlldykpOwogCi0gICAgaWYgKHdlYmtpdF93ZWJfdmlld19j YW5fY29weV9jbGlwYm9hcmQod2ViVmlldykpCisgICAgaWYgKHdlYmtpdF93ZWJfdmlld19jYW5f Y29weV9jbGlwYm9hcmQod2ViVmlldykpIHsKICAgICAgICAgZ19zaWduYWxfZW1pdCh3ZWJWaWV3 LCB3ZWJraXRfd2ViX3ZpZXdfc2lnbmFsc1tDT1BZX0NMSVBCT0FSRF0sIDApOworICAgICAgICBn dGtfY2xpcGJvYXJkX3NldF9jYW5fc3RvcmUoZ3RrX2NsaXBib2FyZF9nZXQoR0RLX1NFTEVDVElP Tl9DTElQQk9BUkQpLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgTlVMTCwgMCk7CisgICAgfQorCiB9CiAKIC8qKgo= 61234 2010-07-12 08:48:17 -0700 2010-07-12 12:24:10 -0700 Sets gtk_clipboard_set_can_store when clipboard is acquired. With changes suggested by kov: https://bugs.webkit.org/show_bug.cgi?id=27411#c6 webkitbug27411-v2 text/plain 1569 sarah.e.strong SW5kZXg6IFdlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCShyZXZpc2lvbiA2MzA5MCkKKysr IFdlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0z NzE1LDggKzM3MTUsMTEgQEAKIHsKICAgICBnX3JldHVybl9pZl9mYWlsKFdFQktJVF9JU19XRUJf VklFVyh3ZWJWaWV3KSk7CiAKLSAgICBpZiAod2Via2l0X3dlYl92aWV3X2Nhbl9jdXRfY2xpcGJv YXJkKHdlYlZpZXcpKQorICAgIGlmICh3ZWJraXRfd2ViX3ZpZXdfY2FuX2N1dF9jbGlwYm9hcmQo d2ViVmlldykpIHsKICAgICAgICAgZ19zaWduYWxfZW1pdCh3ZWJWaWV3LCB3ZWJraXRfd2ViX3Zp ZXdfc2lnbmFsc1tDVVRfQ0xJUEJPQVJEXSwgMCk7CisgICAgICAgIGd0a19jbGlwYm9hcmRfc2V0 X2Nhbl9zdG9yZShndGtfY2xpcGJvYXJkX2dldChHREtfU0VMRUNUSU9OX0NMSVBCT0FSRCksIDAs IDApOworICAgIH0KKwogfQogCiAvKioKQEAgLTM3MjksOCArMzczMiwxMSBAQAogewogICAgIGdf cmV0dXJuX2lmX2ZhaWwoV0VCS0lUX0lTX1dFQl9WSUVXKHdlYlZpZXcpKTsKIAotICAgIGlmICh3 ZWJraXRfd2ViX3ZpZXdfY2FuX2NvcHlfY2xpcGJvYXJkKHdlYlZpZXcpKQorICAgIGlmICh3ZWJr aXRfd2ViX3ZpZXdfY2FuX2NvcHlfY2xpcGJvYXJkKHdlYlZpZXcpKSB7CiAgICAgICAgIGdfc2ln bmFsX2VtaXQod2ViVmlldywgd2Via2l0X3dlYl92aWV3X3NpZ25hbHNbQ09QWV9DTElQQk9BUkRd LCAwKTsKKyAgICAgICAgZ3RrX2NsaXBib2FyZF9zZXRfY2FuX3N0b3JlKGd0a19jbGlwYm9hcmRf Z2V0KEdES19TRUxFQ1RJT05fQ0xJUEJPQVJEKSwgMCwgMCk7CisgICAgfQorCiB9CiAKIC8qKgpJ bmRleDogV2ViS2l0L2d0ay9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2d0ay9DaGFu Z2VMb2cJKHJldmlzaW9uIDYzMDkwKQorKysgV2ViS2l0L2d0ay9DaGFuZ2VMb2cJKHdvcmtpbmcg Y29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wNy0xMiAgU2FyYWggU3Ryb25nICA8c2FyYWgu ZS5zdHJvbmdAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFtHVEtdIENsaXBib2FyZCBkYXRhIGlzIGxvc3Qgb24gZXhpdAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc0MTEKKworICAgICAg ICAqIHdlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJfdmlld19j dXRfY2xpcGJvYXJkKToKKyAgICAgICAgKHdlYmtpdF93ZWJfdmlld19jb3B5X2NsaXBib2FyZCk6 CisKIDIwMTAtMDctMTIgIFhhbiBMb3BleiAgPHhsb3BlekBpZ2FsaWEuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IEd1c3Rhdm8gTm9yb25oYS4K 61256 2010-07-12 12:24:10 -0700 2010-07-16 10:22:45 -0700 Sets gtk_clipboard_set_can_store in WebCore. With changes suggested by mrobinson: https://bugs.webkit.org/show_bug.cgi?id=27411#c9 webkitbug27411-v3 text/plain 1138 sarah.e.strong SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MzEwMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDctMTIgIFNhcmFoIFN0cm9uZyAgPHNhcmFoLmUuc3Ryb25n QGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbR1RLXSBDbGlwYm9hcmQgZGF0YSBpcyBsb3N0IG9uIGV4aXQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3NDExCisKKyAgICAgICAgTm8gbmV3 IHRlc3RzLiAoT09QUyEpCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvUGFzdGVib2FyZEhlbHBl ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQYXN0ZWJvYXJkSGVscGVyOjp3cml0ZUNsaXBib2Fy ZENvbnRlbnRzKToKKwogMjAxMC0wNy0xMiAgQW5kcmVhcyBLbGluZyAgPGFuZHJlYXMua2xpbmdA bm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9saXZlciBIdW50LgpJbmRleDogV2Vi Q29yZS9wbGF0Zm9ybS9ndGsvUGFzdGVib2FyZEhlbHBlci5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9wbGF0Zm9ybS9ndGsvUGFzdGVib2FyZEhlbHBlci5jcHAJKHJldmlzaW9uIDYzMDkwKQor KysgV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUGFzdGVib2FyZEhlbHBlci5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTI5Niw2ICsyOTYsNyBAQAogCiAgICAgICAgIGd0a19jbGlwYm9hcmRfc2V0X3dpdGhf ZGF0YShjbGlwYm9hcmQsIHRhYmxlLCBudW1iZXJPZlRhcmdldHMsCiAgICAgICAgICAgICBnZXRD bGlwYm9hcmRDb250ZW50c0NhbGxiYWNrLCBjbGVhckNsaXBib2FyZENvbnRlbnRzQ2FsbGJhY2ss IGNhbGxiYWNrKTsKKyAgICAgICAgZ3RrX2NsaXBib2FyZF9zZXRfY2FuX3N0b3JlKGNsaXBib2Fy ZCwgMCwgMCk7CiAKICAgICAgICAgc2V0dGluZ0NsaXBib2FyZERhdGFPYmplY3QgPSAwOwogCg== 61822 2010-07-16 10:22:45 -0700 2010-07-16 10:55:30 -0700 Sets gtk_clipboard_set_can_store in WebCore. With updated information about testing the behaviour. webkit-clipboard-persistence-patch-r3 text/plain 1734 sarah.e.strong SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MzEwMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDctMTIgIFNhcmFoIFN0cm9uZyAgPHNhcmFoLmUuc3Ryb25n QGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbR1RLXSBDbGlwYm9hcmQgZGF0YSBpcyBsb3N0IG9uIGV4aXQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3NDExCisKKyAgICAgICAgTm8gbmV3 IHRlc3RzLiBUbyBtYW51YWxseSB0ZXN0IHRoZSBidWcgZml4ZWQgYnkgdGhpcyBwYXRjaDoKKyAg ICAgICAgMSkgT3BlbiBhbiBhcHBsaWNhdGlvbiB0aGF0IHVzZXMgYSB3ZWJraXQgd2VidmlldyBv biBhIEdOT01FLWJhc2VkIHN5c3RlbQorICAgICAgICAyKSBDb3B5IHNvbWUgdGV4dCBmcm9tIHRo YXQgYXBwbGljYXRpb24KKyAgICAgICAgMykgT3B0aW9uYWw6IHBhc3RlIGl0IHRvIGFub3RoZXIg YXBwbGljYXRpb24uIFRoaXMgc2hvdWxkIHdvcmsgcHJvcGVybHkgd2l0aCBhbmQgd2l0aG91dCB0 aGlzIHBhdGNoLgorICAgICAgICA0KSBFeGl0IHRoZSBhcHBsaWNhdGlvbiBjb21wbGV0ZWx5Lgor ICAgICAgICA1KSBQYXN0ZToKKyAgICAgICAgICAgICAgICAgIFdpdGhvdXQgdGhpcyBwYXRjaCwg eW91IGNhbm5vdCBiZWNhdXNlIHlvdXIgY2xpcGJvYXJkIGlzIGVtcHR5LgorICAgICAgICAgICAg ICAgICAgV2l0aCB0aGlzIHBhdGNoLCBwYXN0aW5nIHN1Y2NlZWRzLgorICAgICAgICBJIGhhdmVu J3QgaW5jbHVkZWQgYW4gYXV0b21hdGVkIHRlc3QgYmVjYXVzZSBvZiB0aGUgZGlmZmljdWx0eSBv ZiB0ZXN0aW5nIGJlaGF2aW91ciBhZnRlciBhcHBsaWNhdGlvbiBleGl0LgorCisgICAgICAgICog cGxhdGZvcm0vZ3RrL1Bhc3RlYm9hcmRIZWxwZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGFz dGVib2FyZEhlbHBlcjo6d3JpdGVDbGlwYm9hcmRDb250ZW50cyk6CisKIDIwMTAtMDctMTIgIEFu ZHJlYXMgS2xpbmcgIDxhbmRyZWFzLmtsaW5nQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBPbGl2ZXIgSHVudC4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3RrL1Bhc3RlYm9hcmRI ZWxwZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3RrL1Bhc3RlYm9hcmRI ZWxwZXIuY3BwCShyZXZpc2lvbiA2MzA5MCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3RrL1Bhc3Rl Ym9hcmRIZWxwZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yOTYsNiArMjk2LDcgQEAKIAogICAg ICAgICBndGtfY2xpcGJvYXJkX3NldF93aXRoX2RhdGEoY2xpcGJvYXJkLCB0YWJsZSwgbnVtYmVy T2ZUYXJnZXRzLAogICAgICAgICAgICAgZ2V0Q2xpcGJvYXJkQ29udGVudHNDYWxsYmFjaywgY2xl YXJDbGlwYm9hcmRDb250ZW50c0NhbGxiYWNrLCBjYWxsYmFjayk7CisgICAgICAgIGd0a19jbGlw Ym9hcmRfc2V0X2Nhbl9zdG9yZShjbGlwYm9hcmQsIDAsIDApOwogCiAgICAgICAgIHNldHRpbmdD bGlwYm9hcmREYXRhT2JqZWN0ID0gMDsK 61827 2010-07-16 11:13:47 -0700 2010-07-16 14:49:45 -0700 Sets gtk_clipboard_set_can_store in WebCore. With malformed patch fix webkitbug27411-v4 text/plain 1624 sarah.e.strong SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MzU2NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTAtMDctMTYgIFNhcmFoIFN0cm9uZyAgPHNhcmFoLmUuc3Ryb25n QGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbR1RLXSBDbGlwYm9hcmQgZGF0YSBpcyBsb3N0IG9uIGV4aXQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3NDExCisKKyAgICAgICAgTm8gbmV3 IHRlc3RzLiBUbyBtYW51YWxseSB0ZXN0IHRoZSBidWcgZml4ZWQgYnkgdGhpcyBwYXRjaDoKKyAg ICAgICAgMSkgT3BlbiBhbiBhcHBsaWNhdGlvbiB0aGF0IHVzZXMgYSB3ZWJraXQgd2VidmlldyBv biBhIEdOT01FLWJhc2VkIHN5c3RlbQorICAgICAgICAyKSBDb3B5IHNvbWUgdGV4dCBmcm9tIHRo YXQgYXBwbGljYXRpb24KKyAgICAgICAgMykgT3B0aW9uYWw6IHBhc3RlIGl0IHRvIGFub3RoZXIg YXBwbGljYXRpb24uIFRoaXMgc2hvdWxkIHdvcmsgcHJvcGVybHkgd2l0aCBhbmQgd2l0aG91dCB0 aGlzIHBhdGNoLgorICAgICAgICA0KSBFeGl0IHRoZSBhcHBsaWNhdGlvbiBjb21wbGV0ZWx5Lgor ICAgICAgICA1KSBQYXN0ZToKKyAgICAgICAgICAgICAgICAgIFdpdGhvdXQgdGhpcyBwYXRjaCwg eW91IGNhbm5vdCBiZWNhdXNlIHlvdXIgY2xpcGJvYXJkIGlzIGVtcHR5LgorICAgICAgICAgICAg ICAgICAgV2l0aCB0aGlzIHBhdGNoLCBwYXN0aW5nIHN1Y2NlZWRzLgorICAgICAgICBJIGhhdmUg bm90IGluY2x1ZGVkIGFuIGF1dG9tYXRlZCB0ZXN0IGJlY2F1c2Ugb2YgdGhlIGRpZmZpY3VsdHkg b2YgdGVzdGluZyBiZWhhdmlvdXIgYWZ0ZXIgYXBwbGljYXRpb24gZXhpdC4KKwogMjAxMC0wNy0x NiAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IERhdmlkIExldmluLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUGFzdGVib2Fy ZEhlbHBlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUGFzdGVib2Fy ZEhlbHBlci5jcHAJKHJldmlzaW9uIDYzMDkwKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUGFz dGVib2FyZEhlbHBlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI5Niw2ICsyOTYsNyBAQAogCiAg ICAgICAgIGd0a19jbGlwYm9hcmRfc2V0X3dpdGhfZGF0YShjbGlwYm9hcmQsIHRhYmxlLCBudW1i ZXJPZlRhcmdldHMsCiAgICAgICAgICAgICBnZXRDbGlwYm9hcmRDb250ZW50c0NhbGxiYWNrLCBj bGVhckNsaXBib2FyZENvbnRlbnRzQ2FsbGJhY2ssIGNhbGxiYWNrKTsKKyAgICAgICAgZ3RrX2Ns aXBib2FyZF9zZXRfY2FuX3N0b3JlKGNsaXBib2FyZCwgMCwgMCk7CiAKICAgICAgICAgc2V0dGlu Z0NsaXBib2FyZERhdGFPYmplY3QgPSAwOwogCg==