27406 2009-07-18 00:04:25 -0700 Minor FrameLoader.cpp cleanup 2009-07-18 10:59:54 -0700 1 1 1 Unclassified WebKit Frames 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned darin oldest_to_newest 132861 0 abarth 2009-07-18 00:04:25 -0700 I was just looking at this code and it could be slightly better. 132862 1 33011 abarth 2009-07-18 00:05:42 -0700 Created attachment 33011 patch 132883 2 33011 jmalonzo 2009-07-18 01:24:04 -0700 Comment on attachment 33011 patch r=me. 132884 3 abarth 2009-07-18 01:31:51 -0700 Sending WebCore/ChangeLog Sending WebCore/loader/FrameLoader.cpp Transmitting file data .. Committed revision 46088. http://trac.webkit.org/changeset/46088 132926 4 33011 darin 2009-07-18 10:39:23 -0700 Comment on attachment 33011 patch I believe sizeof("xxxxxxxxx") will always return the size of a pointer. 132928 5 abarth 2009-07-18 10:48:45 -0700 Sending WebCore/ChangeLog Sending WebCore/loader/FrameLoader.cpp Transmitting file data .. Committed revision 46094. http://trac.webkit.org/changeset/46094 132929 6 abarth 2009-07-18 10:56:09 -0700 (In reply to comment #4) > (From update of attachment 33011 [details]) > I believe sizeof("xxxxxxxxx") will always return the size of a pointer. I'll write a reduced test case, but the javascriptURL tests pass. 132931 7 abarth 2009-07-18 10:59:54 -0700 abarth@zenque:~/tmp/sizeof$ cat main.c #include <stdio.h> #include <string.h> int main(void) { printf("%d\n", sizeof("A long string that has many bytes") - 1); printf("%d\n", strlen("A long string that has many bytes")); return 0; } abarth@zenque:~/tmp/sizeof$ gcc main.c abarth@zenque:~/tmp/sizeof$ ./a.out 33 33 33011 2009-07-18 00:05:42 -0700 2009-07-18 10:39:23 -0700 patch bug-27406-20090718000542.patch text/plain 1648 abarth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YzRmOWMzYS4uNTQyZDE3NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0wNy0xOCAgQWRhbSBCYXJ0aCAg PGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE1pbm9yIEZyYW1lTG9hZGVyLmNwcCBjbGVhbnVwCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzQwNgorCisgICAgICAgIE5vIGJl aGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIGxvYWRlci9GcmFtZUxvYWRlci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlcjo6ZXhlY3V0ZUlmSmF2YVNjcmlwdFVSTCk6CisKIDIw MDktMDctMTcgIERhbmllbCBCYXRlcyAgPGRiYXRlc0BpbnR1ZGF0YS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvbG9hZGVyL0ZyYW1l TG9hZGVyLmNwcCBiL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAppbmRleCAxNDQzMGY4 Li40Zjk4ZjI0IDEwMDY0NAotLS0gYS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKKysr IGIvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCkBAIC03MjcsMTUgKzcyNywxNiBAQCBi b29sIEZyYW1lTG9hZGVyOjpleGVjdXRlSWZKYXZhU2NyaXB0VVJMKGNvbnN0IEtVUkwmIHVybCwg Ym9vbCB1c2VyR2VzdHVyZSwgYm9vbAogICAgIGlmIChtX2ZyYW1lLT5wYWdlKCkgJiYgIW1fZnJh bWUtPnBhZ2UoKS0+amF2YVNjcmlwdFVSTHNBcmVBbGxvd2VkKCkpCiAgICAgICAgIHJldHVybiB0 cnVlOwogCi0gICAgU3RyaW5nIHNjcmlwdCA9IGRlY29kZVVSTEVzY2FwZVNlcXVlbmNlcyh1cmwu c3RyaW5nKCkuc3Vic3RyaW5nKHN0cmxlbigiamF2YXNjcmlwdDoiKSkpOworICAgIGNvbnN0IGlu dCBqYXZhc2NyaXB0U2NoZW1lTGVuZ3RoID0gc2l6ZW9mKCJqYXZhc2NyaXB0OiIpIC0gMTsKKwor ICAgIFN0cmluZyBzY3JpcHQgPSBkZWNvZGVVUkxFc2NhcGVTZXF1ZW5jZXModXJsLnN0cmluZygp LnN1YnN0cmluZyhqYXZhc2NyaXB0U2NoZW1lTGVuZ3RoKTsKICAgICBTY3JpcHRWYWx1ZSByZXN1 bHQgPSBleGVjdXRlU2NyaXB0KHNjcmlwdCwgdXNlckdlc3R1cmUpOwogCiAgICAgU3RyaW5nIHNj cmlwdFJlc3VsdDsKICAgICBpZiAoIXJlc3VsdC5nZXRTdHJpbmcoc2NyaXB0UmVzdWx0KSkKICAg ICAgICAgcmV0dXJuIHRydWU7CiAKLSAgICBTZWN1cml0eU9yaWdpbiogY3VycmVudFNlY3VyaXR5 T3JpZ2luID0gMDsKLSAgICBjdXJyZW50U2VjdXJpdHlPcmlnaW4gPSBtX2ZyYW1lLT5kb2N1bWVu dCgpLT5zZWN1cml0eU9yaWdpbigpOworICAgIFNlY3VyaXR5T3JpZ2luKiBjdXJyZW50U2VjdXJp dHlPcmlnaW4gPSBtX2ZyYW1lLT5kb2N1bWVudCgpLT5zZWN1cml0eU9yaWdpbigpOwogCiAgICAg Ly8gRklYTUU6IFdlIHNob3VsZCBhbHdheXMgcmVwbGFjZSB0aGUgZG9jdW1lbnQsIGJ1dCBkb2lu ZyBzbwogICAgIC8vICAgICAgICBzeW5jaHJvbm91c2x5IGNhbiBjYXVzZSBjcmFzaGVzOg==