274032 2024-05-11 01:51:10 -0700 [GTK] [2.45.1] Fails to build on big-endian machines due to lack of support in Skia 2024-05-14 09:16:56 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Linux RESOLVED FIXED P2 Normal --- 1 berto dpino bugs-noreply mcatanzaro philn oldest_to_newest 2034693 0 berto 2024-05-11 01:51:10 -0700 https://github.com/WebKit/WebKit/blob/webkitgtk-2.45.1/Source/ThirdParty/skia/include/private/base/SkLoadUserConfig.h#L56 #if defined(SK_CPU_BENDIAN) && !defined(I_ACKNOWLEDGE_SKIA_DOES_NOT_SUPPORT_BIG_ENDIAN) #error "The Skia team is not endian-savvy enough to support big-endian CPUs." #error "If you still want to use Skia," #error "please define I_ACKNOWLEDGE_SKIA_DOES_NOT_SUPPORT_BIG_ENDIAN." #endif I confirm that it builds on s390x at least if I use -DUSE_SKIA=OFF so we should autodetect that situation. 2034699 1 mcatanzaro 2024-05-11 05:11:00 -0700 Pull request: https://github.com/WebKit/WebKit/pull/28429 2035183 2 ews-feeder 2024-05-14 00:36:18 -0700 Committed 278740@main (7a1468c7a3f3): <https://commits.webkit.org/278740@main> Reviewed commits have been landed. Closing PR #28429 and removing active labels. 2035221 3 philn 2024-05-14 05:13:06 -0700 This broke builds where CMake is too old (3.16)... CMake Error at Source/cmake/OptionsWPE.cmake:84 (if): if given arguments: "3.16.9" "VERSION_LESS" "3.20" "OR" "STREQUAL" "LITTLE_ENDIAN" Unknown arguments specified 2035228 4 mcatanzaro 2024-05-14 06:04:02 -0700 Drat, I forgot we have to do it in two separate conditionals. I'll land a follow-up. 2035264 5 dpino 2024-05-14 09:11:39 -0700 Re-opening for pull request https://github.com/webkit/webkit/pull/28540 2035265 6 dpino 2024-05-14 09:14:00 -0700 Many post-commit bots are currently failing and there's another build error that needs to be fixed. https://build.webkit.org/#/builders/992 2035266 7 ews-feeder 2024-05-14 09:16:54 -0700 Committed 278764@main (9c1f32d066a4): <https://commits.webkit.org/278764@main> Reviewed commits have been landed. Closing PR #28540 and removing active labels.