274011 2024-05-10 12:59:00 -0700 Fix RenderTreeBuilder::move() to clear percent height map 2024-08-13 02:39:29 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED BrowserCompat, InRadar P2 Normal --- 1 ahmad.saleem792 ahmad.saleem792 bfulgham simon.fraser webkit-bug-importer zalan oldest_to_newest 2034596 0 ahmad.saleem792 2024-05-10 12:59:00 -0700 Hi Team, While looking into old Blink's commit, I came across another failing test case: Test Case - https://jsfiddle.net/nqt0g1yz/ ^ Does not show 'blue' box in Safari / WebKit ToT while does show in Chrome Canary 126 and Firefox Nightly 127. Blink Commit - https://chromium.googlesource.com/chromium/src.git/+/7afb0474da50c93fa2360fc70ccbb73a313a45f7 WebKit Source: https://searchfox.org/wubkat/rev/5169139ac1127c419017b37d9f2106a2c199070f/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp#489 , https://searchfox.org/wubkat/rev/5169139ac1127c419017b37d9f2106a2c199070f/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp#545 and https://searchfox.org/wubkat/rev/5169139ac1127c419017b37d9f2106a2c199070f/Source/WebCore/rendering/RenderBlock.cpp#832 ___ I did following changes and it compiles and progress following: > RenderTreeBuilder::move() if (normalizeAfterInsertion == NormalizeAfterInsertion::Yes && is<RenderBlock>(from) && child.isRenderBox()) RenderBlock::removePercentHeightDescendantIfNeeded(downcast<RenderBox>(child)); and > RenderTreeBuilder::moveChildren() - Line 549 RenderBlock::removePercentHeightDescendantIfNeeded(*blockFlow); and RenderBlock::dirtyForLayoutFromPercentageHeightDescendants() ASSERT(renderer->isDescendantOf(this)); ___ Just raising so we can fix it. Thanks! 2036099 1 webkit-bug-importer 2024-05-17 12:59:15 -0700 <rdar://problem/128289804> 2052175 2 ahmad.saleem792 2024-08-12 14:35:01 -0700 Pull request: https://github.com/WebKit/WebKit/pull/32064 2052324 3 ews-feeder 2024-08-13 02:39:27 -0700 Committed 282160@main (1223895a9c1b): <https://commits.webkit.org/282160@main> Reviewed commits have been landed. Closing PR #32064 and removing active labels.