27401 2009-07-17 18:27:14 -0700 webkit-tools-completion.sh has two typos and sorting issues. 2009-07-17 18:37:17 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 levin levin oldest_to_newest 132810 0 levin 2009-07-17 18:27:14 -0700 There is a --dif (instead of --diff) for prepare-ChangeLog and a -clean (instead of --clean) for build-webkit. In addition, a nice rule to follow when laying out items is that if ordering doesn't matter, then sort them and the script doesn't currently do that for the many lists in it. 132811 1 32997 levin 2009-07-17 18:30:54 -0700 Created attachment 32997 Proposed fix. 132814 2 levin 2009-07-17 18:37:17 -0700 Committed as http://trac.webkit.org/changeset/46076 32997 2009-07-17 18:30:54 -0700 2009-07-17 18:33:06 -0700 Proposed fix. bug27401.txt text/plain 4708 levin ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA2MTVhMGQ0Li4yMDc3OTEzIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDct MTcgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHdlYmtpdC10b29scy1jb21wbGV0aW9uLnNo IGhhcyB0d28gdHlwb3MgYW5kIHNvcnRpbmcgaXNzdWVzLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc0MDEKKworICAgICAgICAqIFNjcmlwdHMvd2Vi a2l0LXRvb2xzLWNvbXBsZXRpb24uc2g6IEZpeCB0d28gdHlwb3MgIi0tZGlmIiBhbmQgIi1jbGVh biIuCisgICAgICAgICAgQWxzbywgc29ydCBhbGwgbGlzdHMgaW5jbHVkaW5nIGl0ZW1zIGluIHRo ZSBjYXNlIHN0YXRlbWVudCBhbmQgZmxhZ3MgZm9yCisgICAgICAgICAgdGhlIGNvbW1hbmRzLgor CiAyMDA5LTA3LTE3ICBQZXRlciBLYXN0aW5nICA8cGthc3RpbmdAZ29vZ2xlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBEYXZpZCBLaWx6ZXIuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9T Y3JpcHRzL3dlYmtpdC10b29scy1jb21wbGV0aW9uLnNoIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93 ZWJraXQtdG9vbHMtY29tcGxldGlvbi5zaAppbmRleCBjYjk5MTdlLi44ZGMxNzA4IDEwMDY0NAot LS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdC10b29scy1jb21wbGV0aW9uLnNoCisrKyBi L1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0LXRvb2xzLWNvbXBsZXRpb24uc2gKQEAgLTUwLDM5 ICs1MCw0MiBAQCBfYnVnemlsbGEtdG9vbF9jb21wbGV0ZSgpCiAgICAgZXNhYwogCiAgICAgaWYg WyAkQ09NUF9DV09SRCAtZXEgMSBdOyB0aGVuCi0gICAgICAgIF9fYnVnemlsbGEtdG9vbF9nZW5l cmF0ZV9yZXBseSAiLS1oZWxwIGJ1Z3MtdG8tY29tbWl0IHBhdGNoZXMtdG8tY29tbWl0IHJldmll d2VkLXBhdGNoZXMgYXBwbHktcGF0Y2hlcyBsYW5kLWRpZmYgbGFuZC1wYXRjaGVzIGNvbW1pdC1t ZXNzYWdlIG9ic29sZXRlLWF0dGFjaG1lbnRzIHBvc3QtZGlmZiBwb3N0LWNvbW1pdHMiCisgICAg ICAgIF9fYnVnemlsbGEtdG9vbF9nZW5lcmF0ZV9yZXBseSAiLS1oZWxwIGFwcGx5LXBhdGNoZXMg YnVncy10by1jb21taXQgY29tbWl0LW1lc3NhZ2UgbGFuZC1kaWZmIGxhbmQtcGF0Y2hlcyBvYnNv bGV0ZS1hdHRhY2htZW50cyBwYXRjaGVzLXRvLWNvbW1pdCBwb3N0LWNvbW1pdHMgcG9zdC1kaWZm IHJldmlld2VkLXBhdGNoZXMiCiAgICAgICAgIHJldHVybgogICAgIGZpCiAKICAgICBjYXNlICIk Y29tbWFuZCIgaW4KICAgICAgICAgYXBwbHktcGF0Y2hlcykKLSAgICAgICAgICAgIF9fYnVnemls bGEtdG9vbF9nZW5lcmF0ZV9yZXBseSAiLS1uby11cGRhdGUgLS1mb3JjZS1jbGVhbiAtLW5vLWNs ZWFuIC0tbG9jYWwtY29tbWl0IgorICAgICAgICAgICAgX19idWd6aWxsYS10b29sX2dlbmVyYXRl X3JlcGx5ICItLWZvcmNlLWNsZWFuIC0tbG9jYWwtY29tbWl0IC0tbm8tY2xlYW4gLS1uby11cGRh dGUiCisgICAgICAgICAgICByZXR1cm4KKyAgICAgICAgICAgIDs7CisgICAgICAgIGNvbW1pdC1t ZXNzYWdlKQogICAgICAgICAgICAgcmV0dXJuCiAgICAgICAgICAgICA7OwogICAgICAgICBsYW5k LWRpZmYpCi0gICAgICAgICAgICBfX2J1Z3ppbGxhLXRvb2xfZ2VuZXJhdGVfcmVwbHkgIi1yIC0t cmV2aWV3ZXIgLS1uby1jbG9zZSAtLW5vLWJ1aWxkIC0tbm8tdGVzdCIKKyAgICAgICAgICAgIF9f YnVnemlsbGEtdG9vbF9nZW5lcmF0ZV9yZXBseSAiLS1uby1idWlsZCAtLW5vLWNsb3NlIC0tbm8t dGVzdCAtLXJldmlld2VyPSAtciIKICAgICAgICAgICAgIHJldHVybgogICAgICAgICAgICAgOzsK ICAgICAgICAgbGFuZC1wYXRjaGVzKQotICAgICAgICAgICAgX19idWd6aWxsYS10b29sX2dlbmVy YXRlX3JlcGx5ICItLWZvcmNlLWNsZWFuIC0tbm8tY2xlYW4gLS1uby1idWlsZCAtLW5vLXRlc3Qi CisgICAgICAgICAgICBfX2J1Z3ppbGxhLXRvb2xfZ2VuZXJhdGVfcmVwbHkgIi0tZm9yY2UtY2xl YW4gLS1uby1idWlsZCAtLW5vLWNsZWFuIC0tbm8tdGVzdCIKICAgICAgICAgICAgIHJldHVybgog ICAgICAgICAgICAgOzsKLSAgICAgICAgY29tbWl0LW1lc3NhZ2V8b2Jzb2xldGUtYXR0YWNobWVu dHMpCisgICAgICAgIG9ic29sZXRlLWF0dGFjaG1lbnRzKQogICAgICAgICAgICAgcmV0dXJuCiAg ICAgICAgICAgICA7OwogICAgICAgICBwb3N0LWRpZmYpCi0gICAgICAgICAgICBfX2J1Z3ppbGxh LXRvb2xfZ2VuZXJhdGVfcmVwbHkgIi0tbm8tb2Jzb2xldGUgLS1uby1yZXZpZXcgLW0gLS1kZXNj cmlwdGlvbiIKKyAgICAgICAgICAgIF9fYnVnemlsbGEtdG9vbF9nZW5lcmF0ZV9yZXBseSAiLS1k ZXNjcmlwdGlvbiAtLW5vLW9ic29sZXRlIC0tbm8tcmV2aWV3IC1tIgogICAgICAgICAgICAgcmV0 dXJuCiAgICAgICAgICAgICA7OwogICAgICAgICBwb3N0LWNvbW1pdHMpCi0gICAgICAgICAgICBf X2J1Z3ppbGxhLXRvb2xfZ2VuZXJhdGVfcmVwbHkgIi1iIC0tYnVnLWlkPSAtLW5vLWNvbW1lbnQg LS1uby1vYnNvbGV0ZSAtLW5vLXJldmlldyIKKyAgICAgICAgICAgIF9fYnVnemlsbGEtdG9vbF9n ZW5lcmF0ZV9yZXBseSAiLS1idWctaWQ9IC0tbm8tY29tbWVudCAtLW5vLW9ic29sZXRlIC0tbm8t cmV2aWV3IC1iIgogICAgICAgICAgICAgcmV0dXJuCiAgICAgICAgICAgICA7OwogICAgIGVzYWMK IH0KIAogY29tcGxldGUgLUYgX2J1Z3ppbGxhLXRvb2xfY29tcGxldGUgYnVnemlsbGEtdG9vbAot Y29tcGxldGUgLVcgIi1jIC0tY29udGludWUgLS1uby1jb250aW51ZSAtZiAtLWZpeC1tZXJnZWQg LWggLS1oZWxwIC13IC0td2FybmluZ3MgLS1uby13YXJuaW5ncyIgcmVzb2x2ZS1DaGFuZ2VMb2dz Ci1jb21wbGV0ZSAtVyAiLS1idWcgLWQgLS1kaWYgLS1naXQtY29tbWl0IC0tZ2l0LWluZGV4IC0t Z2l0LXJldmlld2VyIC1oIC0taGVscCAtbyAtLW9wZW4gLS1uby11cGRhdGUgLS11cGRhdGUiIHBy ZXBhcmUtQ2hhbmdlTG9nCi1jb21wbGV0ZSAtVyAiLS1kZWJ1ZyAtY2xlYW4gLS1oZWxwIC1oIiBi dWlsZC13ZWJraXQKLWNvbXBsZXRlIC1XICItLWFkZC1wbGF0Zm9ybS1leGNlcHRpb25zIC0tY29t cGxleC10ZXh0IC1jIC0tY29uZmlndXJhdGlvbiAtZyAtLWd1YXJkLW1hbGxvYyAtLWhlbHAgLWgg LWkgLS1pZ25vcmUtdGVzdHMgLS1uby1odHRwIC0tbm8tbGF1bmNoLXNhZmFyaSAtLW5vLW5ldy10 ZXN0LXJlc3VsdHMgLS1odHRwIC0tbGF1bmNoLXNhZmFyaSAtLW5ldy10ZXN0LXJlc3VsdHMgLWwg LS1sZWFrcyAtcCAtLXBpeGVsLXRlc3RzIC0tdG9sZXJhbmNlIC0tcGxhdGZvcm0gLS1wb3J0IC1x IC0tcXVpZXQgLS1yZXNldC1yZXN1bHRzIC1vIC0tcmVzdWx0cy1kaXJlY3RvcnkgLS1yYW5kb20g LS1yZXZlcnNlIC0tcm9vdCAtLW5vLXNhbXBsZS1vbi10aW1lb3V0IC0tc2FtcGxlLW9uLXRpbWVv dXQgLTEgLS1zaW5nbHkgLS1za2lwcGVkIC0tc2xvd2VzdCAtLXN0cmljdCAtLW5vLXN0cmlwLWVk aXRpbmctY2FsbGJhY2tzIC0tc3RyaXAtZWRpdGluZy1jYWxsYmFja3MgLXQgLS10aHJlYWRlZCAt LXRpbWVvdXQgLS12YWxncmluZCAtdiAtLXZlcmJvc2UgLW0gLS1tZXJnZS1sZWFrLWRlcHRoIC0t dXNlLXJlbW90ZS1saW5rcy10by10ZXN0cyIgcnVuLXdlYmtpdC10ZXN0cworY29tcGxldGUgLVcg Ii0tY29udGludWUgLS1maXgtbWVyZ2VkIC0taGVscCAtLW5vLWNvbnRpbnVlIC0tbm8td2Fybmlu Z3MgLS13YXJuaW5ncyAtYyAtZiAtaCAtdyIgcmVzb2x2ZS1DaGFuZ2VMb2dzCitjb21wbGV0ZSAt VyAiLS1idWcgLS1kaWZmIC0tZ2l0LWNvbW1pdCAtLWdpdC1pbmRleCAtLWdpdC1yZXZpZXdlciAt LWhlbHAgLS1uby11cGRhdGUgLS1vcGVuIC0tdXBkYXRlIC1kIC1oIC1vIiBwcmVwYXJlLUNoYW5n ZUxvZworY29tcGxldGUgLVcgIi0tY2xlYW4gLS1kZWJ1ZyAtLWhlbHAgLWgiIGJ1aWxkLXdlYmtp dAorY29tcGxldGUgLVcgIi0tYWRkLXBsYXRmb3JtLWV4Y2VwdGlvbnMgLS1jb21wbGV4LXRleHQg LS1jb25maWd1cmF0aW9uIC0tZ3VhcmQtbWFsbG9jIC0taGVscCAtLWh0dHAgLS1pZ25vcmUtdGVz dHMgLS1sYXVuY2gtc2FmYXJpIC0tbGVha3MgLS1tZXJnZS1sZWFrLWRlcHRoIC0tbmV3LXRlc3Qt cmVzdWx0cyAtLW5vLWh0dHAgLS1uby1sYXVuY2gtc2FmYXJpIC0tbm8tbmV3LXRlc3QtcmVzdWx0 cyAtLW5vLXNhbXBsZS1vbi10aW1lb3V0IC0tbm8tc3RyaXAtZWRpdGluZy1jYWxsYmFja3MgLS1w aXhlbC10ZXN0cyAtLXBsYXRmb3JtIC0tcG9ydCAtLXF1aWV0IC0tcmFuZG9tIC0tcmVzZXQtcmVz dWx0cyAtLXJlc3VsdHMtZGlyZWN0b3J5IC0tcmV2ZXJzZSAtLXJvb3QgLS1zYW1wbGUtb24tdGlt ZW91dCAtLXNpbmdseSAtLXNraXBwZWQgLS1zbG93ZXN0IC0tc3RyaWN0IC0tc3RyaXAtZWRpdGlu Zy1jYWxsYmFja3MgLS10aHJlYWRlZCAtLXRpbWVvdXQgLS10b2xlcmFuY2UgLS11c2UtcmVtb3Rl LWxpbmtzLXRvLXRlc3RzIC0tdmFsZ3JpbmQgLS12ZXJib3NlIC0xIC1jIC1nIC1oIC1pIC1sIC1t IC1vIC1wIC1xIC10IC12IiBydW4td2Via2l0LXRlc3RzCg==