273974 2024-05-09 14:54:08 -0700 UNPACK_COLORSPACE_CONVERSION_WEBGL should only be used from texImage2D and texSubImage2D calls taking HTMLImageElement 2024-05-09 16:29:00 -0700 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build Unspecified Unspecified ASSIGNED InRadar P2 Normal --- 272015 1 g_squelart g_squelart dino kbr kkinnunen webkit-bug-importer oldest_to_newest 2034409 0 g_squelart 2024-05-09 14:54:08 -0700 According to the specs https://registry.khronos.org/webgl/specs/latest/1.0/#PIXEL_STORAGE_PARAMETERS : > UNPACK_COLORSPACE_CONVERSION_WEBGL of type unsigned long > If set to BROWSER_DEFAULT_WEBGL, then the browser's default colorspace conversion is applied during subsequent texImage2D and texSubImage2D calls taking HTMLImageElement. [...] > If the TexImageSource is an ImageBitmap, then [this] parameter will be ignored. But looking at the source code in WebGLRenderingContextBase.cpp, I see that it's used in `WebGLRenderingContextBase::texImageImpl`, which is called from `WebGLRenderingContextBase::texImageSource(..., HTMLImageElement& source)` (as expected), but also from others that take `ImageBitmap`, `HTMLCanvasElement`, etc. rdar://127580661 2034434 1 g_squelart 2024-05-09 16:29:00 -0700 Pull request: https://github.com/WebKit/WebKit/pull/28371