<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>273956</bug_id>
          
          <creation_ts>2024-05-09 10:06:14 -0700</creation_ts>
          <short_desc>[Navigation] Improve maintaining the entries list and their interaction with HistoryItems.</short_desc>
          <delta_ts>2024-11-14 14:54:26 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=274368</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=283136</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>258384</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Patrick Griffis">pgriffis</reporter>
          <assigned_to name="Patrick Griffis">pgriffis</assigned_to>
          <cc>fujii</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2034320</commentid>
    <comment_count>0</comment_count>
    <who name="Patrick Griffis">pgriffis</who>
    <bug_when>2024-05-09 10:06:14 -0700</bug_when>
    <thetext>This changes a few areas but it all adds up to solving the same problems.
I&apos;ll go over the changes by entry point:

- navigation.navigate() takes a historyHandling argument that controls the
  history behavior all the way down.
- navigation.back/forward/traverseTo load the known HistoryItem instead of
  loading a URL as well as specify the correct FrameLoadType.
- the location APIs use the proper historyHandling.
- navigation.entries() is more accurately maintained:
  - On reactivation (loading a cached page from history) we regenerate the entires.
  - On a cross-document navigation we filter out any cross-origin entries.
- history.pushState/history.replaceState changes are reflected in entries.
  - This also no longer changes the key of replaced entries.
- Traversal events use the proper HistoryItem.

This all leads to a more consistent and correct list of entries. In order for adding
these entries to work there were also a few dispatches of NavigateEvent in the
expected places like during a history traversal or history state change.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2034323</commentid>
    <comment_count>1</comment_count>
    <who name="Patrick Griffis">pgriffis</who>
    <bug_when>2024-05-09 10:09:25 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/28346</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2035823</commentid>
    <comment_count>2</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2024-05-16 10:07:13 -0700</bug_when>
    <thetext>&lt;rdar://problem/128207459&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2036232</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2024-05-18 13:26:05 -0700</bug_when>
    <thetext>Committed 278960@main (7e54fb8ea939): &lt;https://commits.webkit.org/278960@main&gt;

Reviewed commits have been landed. Closing PR #28346 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2036292</commentid>
    <comment_count>4</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2024-05-19 13:23:00 -0700</bug_when>
    <thetext>Regressed: Bug 274368 – REGRESSION(278960@main): http/tests/security/no-indexeddb-from-sandbox.html is recently randomly crashing</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>