27390 2009-07-17 14:59:58 -0700 CSS custom cursor hotspots should work in quirks mode 2009-08-05 20:36:34 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 bdakin bdakin bdakin darin oldest_to_newest 132720 0 bdakin 2009-07-17 14:59:58 -0700 Right now, our implementation of CSS custom cursor hotspots is only enabled in strict mode. The original implementor (Rob Buis) and reviewer (Eric Seidel) do not remember why it was done this way. Neither does Hyatt. I can't find any information in the spec indicating that hotspots should be strict mode only, and furthermore, Firefox implements hotspots in both quirks and strict modes. I have a patch to post shortly! 132728 1 32978 bdakin 2009-07-17 15:11:18 -0700 Created attachment 32978 Patch In Radar as <rdar://problem/6554340> 137508 2 darin 2009-08-05 20:36:34 -0700 http://trac.webkit.org/changeset/46061 32978 2009-07-17 15:11:18 -0700 2009-07-17 15:18:08 -0700 Patch forReview.txt text/plain 5872 bdakin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NjA2MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDktMDctMTcgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBm b3IgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3MzkwIENTUyBjdXN0 b20gCisgICAgICAgIGN1cnNvciBob3RzcG90cyBzaG91bGQgd29yayBpbiBxdWlya3MgbW9kZQor ICAgICAgICAtIGFuZCBjb3JyZXNwb25kaW5nIDxyZGFyOi8vcHJvYmxlbS82NTU0MzQwPgorCisg ICAgICAgIEVuYWJsZSBob3RzcG90cyBpbiBxdWlya3MgbW9kZS4KKyAgICAgICAgKiBjc3MvQ1NT UGFyc2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1BhcnNlcjo6cGFyc2VWYWx1ZSk6CisK KyAgICAgICAgVXBkYXRlIHRoaXMgbWFudWFsIHRlc3QgdG8gcmVmbGVjdCB0aGUgZmFjdCB0aGF0 IGhvdHNwb3RzIGFyZSBub3cgCisgICAgICAgIGV4cGVjdGVkIHRvIHdvcmsgaW4gcXVpcmtzIG1v ZGUuCisgICAgICAgICogbWFudWFsLXRlc3RzL2NzczMtY3Vyc29yLWZhbGxiYWNrLXF1aXJrcy5o dG1sOgorCiAyMDA5LTA3LTE3ICBQZXRlciBLYXN0aW5nICA8cGthc3RpbmdAZ29vZ2xlLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBTdGV2ZSBGYWxrZW5idXJnLgpJbmRleDogV2ViQ29yZS9j c3MvQ1NTUGFyc2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3Bw CShyZXZpc2lvbiA0NjA0OSkKKysrIFdlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTgyMiwxOCArODIyLDE3IEBAIGJvb2wgQ1NTUGFyc2VyOjpwYXJzZVZhbHVlKGlu dCBwcm9wSWQsIGIKICAgICAgICAgICAgIH0KICAgICAgICAgICAgIEludFBvaW50IGhvdHNwb3Q7 CiAgICAgICAgICAgICBpbnQgbnJjb29yZHMgPSBjb29yZHMuc2l6ZSgpOwotICAgICAgICAgICAg aWYgKG5yY29vcmRzID4gMCAmJiBucmNvb3JkcyAhPSAyKSB7Ci0gICAgICAgICAgICAgICAgaWYg KG1fc3RyaWN0KSAvLyBvbmx5IHN1cHBvcnQgaG90c3BvdCBwYWlycyBpbiBzdHJpY3QgbW9kZQot ICAgICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgICAgICAgICB9IGVsc2UgaWYg KG1fc3RyaWN0ICYmIG5yY29vcmRzID09IDIpCisgICAgICAgICAgICBpZiAobnJjb29yZHMgPiAw ICYmIG5yY29vcmRzICE9IDIpCisgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAg ICAgICAgaWYgKG5yY29vcmRzID09IDIpCiAgICAgICAgICAgICAgICAgaG90c3BvdCA9IEludFBv aW50KGNvb3Jkc1swXSwgY29vcmRzWzFdKTsKLSAgICAgICAgICAgIGlmIChtX3N0cmljdCB8fCBj b29yZHMuc2l6ZSgpID09IDApIHsKLSAgICAgICAgICAgICAgICBpZiAoIXVyaS5pc051bGwoKSAm JiBtX3N0eWxlU2hlZXQpIHsKLSAgICAgICAgICAgICAgICAgICAgLy8gRklYTUU6IFRoZSBjb21w bGV0ZVVSTCBjYWxsIHNob3VsZCBiZSBkb25lIHdoZW4gdXNpbmcgdGhlIENTU0N1cnNvckltYWdl VmFsdWUsCi0gICAgICAgICAgICAgICAgICAgIC8vIG5vdCB3aGVuIGNyZWF0aW5nIGl0LgotICAg ICAgICAgICAgICAgICAgICBsaXN0LT5hcHBlbmQoQ1NTQ3Vyc29ySW1hZ2VWYWx1ZTo6Y3JlYXRl KG1fc3R5bGVTaGVldC0+Y29tcGxldGVVUkwodXJpKSwgaG90c3BvdCkpOwotICAgICAgICAgICAg ICAgIH0KKyAgICAgICAgICAKKyAgICAgICAgICAgIGlmICghdXJpLmlzTnVsbCgpICYmIG1fc3R5 bGVTaGVldCkgeworICAgICAgICAgICAgICAgIC8vIEZJWE1FOiBUaGUgY29tcGxldGVVUkwgY2Fs bCBzaG91bGQgYmUgZG9uZSB3aGVuIHVzaW5nIHRoZSBDU1NDdXJzb3JJbWFnZVZhbHVlLAorICAg ICAgICAgICAgICAgIC8vIG5vdCB3aGVuIGNyZWF0aW5nIGl0LgorICAgICAgICAgICAgICAgIGxp c3QtPmFwcGVuZChDU1NDdXJzb3JJbWFnZVZhbHVlOjpjcmVhdGUobV9zdHlsZVNoZWV0LT5jb21w bGV0ZVVSTCh1cmkpLCBob3RzcG90KSk7CiAgICAgICAgICAgICB9CisKICAgICAgICAgICAgIGlm ICgobV9zdHJpY3QgJiYgIXZhbHVlKSB8fCAodmFsdWUgJiYgISh2YWx1ZS0+dW5pdCA9PSBDU1NQ YXJzZXJWYWx1ZTo6T3BlcmF0b3IgJiYgdmFsdWUtPmlWYWx1ZSA9PSAnLCcpKSkKICAgICAgICAg ICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAgICAgICB2YWx1ZSA9IG1fdmFsdWVMaXN0LT5u ZXh0KCk7IC8vIGNvbW1hCkluZGV4OiBXZWJDb3JlL21hbnVhbC10ZXN0cy9jc3MzLWN1cnNvci1m YWxsYmFjay1xdWlya3MuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL21hbnVhbC10ZXN0cy9j c3MzLWN1cnNvci1mYWxsYmFjay1xdWlya3MuaHRtbAkocmV2aXNpb24gNDYwNDkpCisrKyBXZWJD b3JlL21hbnVhbC10ZXN0cy9jc3MzLWN1cnNvci1mYWxsYmFjay1xdWlya3MuaHRtbAkod29ya2lu ZyBjb3B5KQpAQCAtMjQsMTQgKzI0LDIwIEBACiA8dGQ+PGRpdiBzdHlsZT0nd2lkdGg6MTAwcHg7 aGVpZ2h0OjEwMHB4O2JhY2tncm91bmQtY29sb3I6bGlnaHRibHVlOyBjdXJzb3I6dXJsKHJlc291 cmNlcy9oZWxwQ3Vyc29yLnRpZmYpIDEgMSB0ZXh0Oyc+PC9kaXY+PC90ZD4gPCEtLSBDU1MzIGhv dCBzcG90IC0gaW52YWxpZCwgc2hvdWxkIGhhdmUgY29tbWEgYWZ0ZXIgaG90c3BvdCBjb29yZHMg LS0+CiA8L3RyPgogPC90YWJsZT4KLTxwPkluIGVhY2ggb2YgdGhlIGJsdWUgYm94ZXMgYmVsb3cs IHRoZSBjdXJzb3Igc2hvdWxkIHNob3cgdGhlIHRleHQgY3Vyc29yLCBzaW5jZSBhbGwgaG90c3Bv dCBkZWZpbml0aW9ucyBhcmUgaWdub3JlZCBpbiBxdWlya3MgbW9kZS48L3A+Cis8cD5JbiBlYWNo IG9mIHRoZSBibHVlIGJveGVzIGJlbG93LCB0aGUgY3Vyc29yIHNob3VsZCBzaG93IHRoZSB0ZXh0 IGN1cnNvciwgc2luY2UgdGhleSBjb250YWluIGludmFsaWQgaG90c3BvdHMuPC9wPgogPHRhYmxl Pjx0cj4KIDx0ZD48ZGl2IHN0eWxlPSd3aWR0aDoxMDBweDtoZWlnaHQ6MTAwcHg7YmFja2dyb3Vu ZC1jb2xvcjpsaWdodGJsdWU7IGN1cnNvcjp1cmwocmVzb3VyY2VzL2hlbHBDdXJzb3IudGlmZikg MSwgdGV4dDsnPjwvZGl2PjwvdGQ+IDwhLS0gQ1NTMyBob3Qgc3BvdCAtIGlnbm9yZWQgaW4gSUUg LS0+Ci08dGQ+PGRpdiBzdHlsZT0nd2lkdGg6MTAwcHg7aGVpZ2h0OjEwMHB4O2JhY2tncm91bmQt Y29sb3I6bGlnaHRibHVlOyBjdXJzb3I6dXJsKHJlc291cmNlcy9oZWxwQ3Vyc29yLnRpZmYpIDEg MiwgdGV4dDsnPjwvZGl2PjwvdGQ+IDwhLS0gQ1NTMyBob3Qgc3BvdCAtIGlnbm9yZWQgaW4gSUUg LS0+CiAgPHRkPjxkaXYgc3R5bGU9J3dpZHRoOjEwMHB4O2hlaWdodDoxMDBweDtiYWNrZ3JvdW5k LWNvbG9yOmxpZ2h0Ymx1ZTsgY3Vyc29yOnVybChyZXNvdXJjZXMvaGVscEN1cnNvci50aWZmKSAx IDIgMywgdGV4dDsnPjwvZGl2PjwvdGQ+IDwhLS0gQ1NTMyBob3Qgc3BvdCAtIGlnbm9yZWQgaW4g SUUgLS0+CiA8L3RyPgogPC90YWJsZT4KIAorPHA+SW4gZWFjaCBvZiB0aGUgYmx1ZSBib3hlcyBi ZWxvdywgdGhlIGN1cnNvciBzaG91bGQgc2hvdyB0aGUgaGVscCwgc2luY2UgdGhleSBjb250YWlu IHZhbGlkIGhvdHNwb3RzLjwvcD4KKzx0YWJsZT48dHI+Cis8dGQ+PGRpdiBzdHlsZT0nd2lkdGg6 MTAwcHg7aGVpZ2h0OjEwMHB4O2JhY2tncm91bmQtY29sb3I6bGlnaHRibHVlOyBjdXJzb3I6dXJs KHJlc291cmNlcy9oZWxwQ3Vyc29yLnRpZmYpIDEgMjsnPjwvZGl2PjwvdGQ+IDwhLS0gQ1NTMyBo b3Qgc3BvdCAtIGlnbm9yZWQgaW4gSUUgLS0+Cis8dGQ+PGRpdiBzdHlsZT0nd2lkdGg6MTAwcHg7 aGVpZ2h0OjEwMHB4O2JhY2tncm91bmQtY29sb3I6bGlnaHRibHVlOyBjdXJzb3I6dXJsKHJlc291 cmNlcy9oZWxwQ3Vyc29yLnRpZmYpIDEgMiwgdGV4dDsnPjwvZGl2PjwvdGQ+IDwhLS0gQ1NTMyBo b3Qgc3BvdCAtIGlnbm9yZWQgaW4gSUUgLS0+Cis8L3RyPgorPC90YWJsZT4KKwogPHA+PC9wPgog PHA+PHNwYW4gc3R5bGU9J2JhY2tncm91bmQtY29sb3I6Z3JheTsgY3Vyc29yOnVybChub25leGlz dGVudC5wbmcpLCB1cmwoInJlc291cmNlcy9oZWxwQ3Vyc29yLnRpZmYiKTsnPlNob3VsZCBzaG93 IGFuIEktYmVhbSBjdXJzb3IuPC9zcGFuPjwvcD4gPCEtLSBBbiBpbnZhbGlkIGRlY2xhcmF0aW9u LCBldmVuIGJ5IFdpbklFIHN0YW5kYXJkcyAtLT4KIDxwPlRoZSBmb2xsb3dpbmcgdGVzdGNhc2Vz IHRlc3QgaW5oZXJpdGFuY2Ugb2YgdGhlIGN1cnNvciBwcm9wZXJ0eS4gVGhlIGZpcnN0IG9uZSBz aG91bGQgaGF2ZSB0aGUgaGVscCBjdXJzb3IgZm9yIGJvdGggZGl2cyAobm9ybWFsIGluaGVyaXRh bmNlKS4gVGhlIHNlY29uZCBvbmUgc2hvdWxkIGhhdmUgaGVscCBjdXJzb3IgZm9yIGJpZyBkaXYs IHRleHQgY3Vyc29yIGZvciBzbWFsbCBkaXYgKGlubmVyIGRpdiBoYXMgY3Vyc29yIHByb3BlcnR5 LCBzaG91bGQgbm90IGluaGVyaXQpLiBUaGUgbmV4dCBoYXMgaW52YWxpZCBjc3Mgc3ludGF4IGlu IHRoZSBpbm5lciBkaXYsIHNvIGl0IHNob3VsZCBpbmhlcml0IGZyb20gdGhlIHBhcmVudC4gVGhl IGxhc3QgdHdvIHRlc3RjYXNlcyBoYXZlIGNvcnJlY3Qgc3ludGF4IGFuZCB0aGVyZSBpcyBubyBp bmhlcml0YW5jZSBpbiB0aGlzIGNhc2UuPC9wPgpAQCAtNDMsNyArNDksNyBAQAogPC90ZD48dGQ+ CiA8ZGl2IHN0eWxlPSd3aWR0aDoxMDBweDtoZWlnaHQ6MTAwcHg7YmFja2dyb3VuZC1jb2xvcjps aWdodGJsdWU7IGN1cnNvcjp1cmwocmVzb3VyY2VzL2hlbHBDdXJzb3IudGlmZiksIHRleHQ7Jz48 ZGl2IHN0eWxlPSJ3aWR0aDo1MHB4O2hlaWdodDo1MHB4O2JhY2tncm91bmQtY29sb3I6Z3JheTtj dXJzb3I6Zm9vYmFyIj48L2Rpdj48L2Rpdj4KIDwvdGQ+PHRkPgotPGRpdiBzdHlsZT0nd2lkdGg6 MTAwcHg7aGVpZ2h0OjEwMHB4O2JhY2tncm91bmQtY29sb3I6bGlnaHRibHVlOyBjdXJzb3I6dXJs KHJlc291cmNlcy9oZWxwQ3Vyc29yLnRpZmYpLCB0ZXh0Oyc+PGRpdiBzdHlsZT0id2lkdGg6NTBw eDtoZWlnaHQ6NTBweDtiYWNrZ3JvdW5kLWNvbG9yOmdyYXk7Y3Vyc29yOnVybChyZXNvdXJjZXMv aGVscEN1cnNvci50aWZmKSAxIDIgMywgdGV4dCI+PC9kaXY+PC9kaXY+Cis8ZGl2IHN0eWxlPSd3 aWR0aDoxMDBweDtoZWlnaHQ6MTAwcHg7YmFja2dyb3VuZC1jb2xvcjpsaWdodGJsdWU7IGN1cnNv cjp1cmwocmVzb3VyY2VzL2hlbHBDdXJzb3IudGlmZiksIHRleHQ7Jz48ZGl2IHN0eWxlPSJ3aWR0 aDo1MHB4O2hlaWdodDo1MHB4O2JhY2tncm91bmQtY29sb3I6Z3JheTtjdXJzb3I6dXJsKHJlc291 cmNlcy9oZWxwQ3Vyc29yLnRpZmYpIDEgMiwgdGV4dCI+PC9kaXY+PC9kaXY+CiA8L3RkPjx0ZD4K IDxkaXYgc3R5bGU9J3dpZHRoOjEwMHB4O2hlaWdodDoxMDBweDtiYWNrZ3JvdW5kLWNvbG9yOmxp Z2h0Ymx1ZTsgY3Vyc29yOnVybChyZXNvdXJjZXMvaGVscEN1cnNvci50aWZmKSwgdGV4dDsnPjxk aXYgc3R5bGU9IndpZHRoOjUwcHg7aGVpZ2h0OjUwcHg7YmFja2dyb3VuZC1jb2xvcjpncmF5O2N1 cnNvcjp1cmwobm9uZXhpc3RhbnQucG5nKSwgdGV4dCI+PC9kaXY+PC9kaXY+CiA8L3RkPjwvdHI+ Cg==