<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>27386</bug_id>
          
          <creation_ts>2009-07-17 14:18:54 -0700</creation_ts>
          <short_desc>Add support for Qt&apos;s foreach to cpplint</short_desc>
          <delta_ts>2009-07-20 02:48:05 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Kenneth Rohde Christiansen">kenneth</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>hausmann</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>132695</commentid>
    <comment_count>0</comment_count>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2009-07-17 14:18:54 -0700</bug_when>
    <thetext>Add support for Qt&apos;s foreach to cpplint</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>132701</commentid>
    <comment_count>1</comment_count>
      <attachid>32969</attachid>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2009-07-17 14:21:05 -0700</bug_when>
    <thetext>Created attachment 32969
Support for foreach in cpplint</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>132710</commentid>
    <comment_count>2</comment_count>
      <attachid>32972</attachid>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2009-07-17 14:29:36 -0700</bug_when>
    <thetext>Created attachment 32972
Support for foreach in cpplint

Now with ChangeLog that was missing in the last patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>133092</commentid>
    <comment_count>3</comment_count>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2009-07-20 02:48:05 -0700</bug_when>
    <thetext>Landed in r46113</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>32969</attachid>
            <date>2009-07-17 14:21:05 -0700</date>
            <delta_ts>2009-07-17 14:29:36 -0700</delta_ts>
            <desc>Support for foreach in cpplint</desc>
            <filename>0001-2009-07-17-Kenneth-Rohde-Christiansen-cpplint.patch</filename>
            <type>text/plain</type>
            <size>6968</size>
            <attacher name="Kenneth Rohde Christiansen">kenneth</attacher>
            
              <data encoding="base64">RnJvbSAzMTA4ZThjMjMzYTk4NDQ5ZTFkMzQ1ZmUyOGE2NzUyNjU5ODM5NzdkIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiA8a2VubmV0aEB3
ZWJraXQub3JnPgpEYXRlOiBGcmksIDE3IEp1bCAyMDA5IDE4OjE5OjM4IC0wMzAwClN1YmplY3Q6
IFtQQVRDSF0gMjAwOS0wNy0xNyAgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4gIDxrZW5uZXRo
QHdlYmtpdC5vcmc+CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAg
ICBBZGQgc3VwcG9ydCBmb3IgUXQncyBmb3JlYWNoIHRvIGNwcGxpbnQKICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjczODYKCiAgICAgICAgKiBTY3JpcHRz
L21vZHVsZXMvY3BwbGludC5weToKICAgICAgICAqIFNjcmlwdHMvbW9kdWxlcy9jcHBsaW50X3Vu
aXR0ZXN0LnB5OgotLS0KIFdlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBsaW50LnB5ICAg
ICAgICAgIHwgICAxNyArKysrKysrKystLS0tLS0tLQogV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1
bGVzL2NwcGxpbnRfdW5pdHRlc3QucHkgfCAgIDExICsrKysrKysrKysrCiAyIGZpbGVzIGNoYW5n
ZWQsIDIwIGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViS2l0
VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NwcGxpbnQucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL21v
ZHVsZXMvY3BwbGludC5weQppbmRleCAxM2ZlZjgwLi4zNTBiNDQwIDEwMDY0NAotLS0gYS9XZWJL
aXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwbGludC5weQorKysgYi9XZWJLaXRUb29scy9TY3Jp
cHRzL21vZHVsZXMvY3BwbGludC5weQpAQCAtMTI2OCwxMyArMTI2OCwxNCBAQCBkZWYgY2hlY2tf
c3BhY2luZ19mb3JfZnVuY3Rpb25fY2FsbChmaWxlbmFtZSwgbGluZSwgbGluZV9udW1iZXIsIGVy
cm9yKToKICAgICAgIGVycm9yOiBUaGUgZnVuY3Rpb24gdG8gY2FsbCB3aXRoIGFueSBlcnJvcnMg
Zm91bmQuCiAgICAgIiIiCiAKLSAgICAjIFNpbmNlIGZ1bmN0aW9uIGNhbGxzIG9mdGVuIG9jY3Vy
IGluc2lkZSBpZi9mb3Ivd2hpbGUvc3dpdGNoCisgICAgIyBTaW5jZSBmdW5jdGlvbiBjYWxscyBv
ZnRlbiBvY2N1ciBpbnNpZGUgaWYvZm9yL2ZvcmVhY2gvd2hpbGUvc3dpdGNoCiAgICAgIyBleHBy
ZXNzaW9ucyAtIHdoaWNoIGhhdmUgdGhlaXIgb3duLCBtb3JlIGxpYmVyYWwgY29udmVudGlvbnMg
LSB3ZQogICAgICMgZmlyc3Qgc2VlIGlmIHdlIHNob3VsZCBiZSBsb29raW5nIGluc2lkZSBzdWNo
IGFuIGV4cHJlc3Npb24gZm9yIGEKICAgICAjIGZ1bmN0aW9uIGNhbGwsIHRvIHdoaWNoIHdlIGNh
biBhcHBseSBtb3JlIHN0cmljdCBzdGFuZGFyZHMuCiAgICAgZnVuY3Rpb25fY2FsbCA9IGxpbmUg
ICAgIyBpZiB0aGVyZSdzIG5vIGNvbnRyb2wgZmxvdyBjb25zdHJ1Y3QsIGxvb2sgYXQgd2hvbGUg
bGluZQogICAgIGZvciBwYXR0ZXJuIGluIChyJ1xiaWZccypcKCguKilcKVxzKnsnLAogICAgICAg
ICAgICAgICAgICAgICByJ1xiZm9yXHMqXCgoLiopXClccyp7JywKKyAgICAgICAgICAgICAgICAg
ICAgcidcYmZvcmVhY2hccypcKCguKilcKVxzKnsnLAogICAgICAgICAgICAgICAgICAgICByJ1xi
d2hpbGVccypcKCguKilcKVxzKlt7O10nLAogICAgICAgICAgICAgICAgICAgICByJ1xic3dpdGNo
XHMqXCgoLiopXClccyp7Jyk6CiAgICAgICAgIG1hdGNoZWQgPSBzZWFyY2gocGF0dGVybiwgbGlu
ZSkKQEAgLTEyODIsNyArMTI4Myw3IEBAIGRlZiBjaGVja19zcGFjaW5nX2Zvcl9mdW5jdGlvbl9j
YWxsKGZpbGVuYW1lLCBsaW5lLCBsaW5lX251bWJlciwgZXJyb3IpOgogICAgICAgICAgICAgZnVu
Y3Rpb25fY2FsbCA9IG1hdGNoZWQuZ3JvdXAoMSkgICAgIyBsb29rIGluc2lkZSB0aGUgcGFyZW5z
IGZvciBmdW5jdGlvbiBjYWxscwogICAgICAgICAgICAgYnJlYWsKIAotICAgICMgRXhjZXB0IGlu
IGlmL2Zvci93aGlsZS9zd2l0Y2gsIHRoZXJlIHNob3VsZCBuZXZlciBiZSBzcGFjZQorICAgICMg
RXhjZXB0IGluIGlmL2Zvci9mb3JlYWNoL3doaWxlL3N3aXRjaCwgdGhlcmUgc2hvdWxkIG5ldmVy
IGJlIHNwYWNlCiAgICAgIyBpbW1lZGlhdGVseSBpbnNpZGUgcGFyZW5zIChlZyAiZiggMywgNCAp
IikuICBXZSBtYWtlIGFuIGV4Y2VwdGlvbgogICAgICMgZm9yIG5lc3RlZCBwYXJlbnMgKCAoYSti
KSArIGMgKS4gIExpa2V3aXNlLCB0aGVyZSBzaG91bGQgbmV2ZXIgYmUKICAgICAjIGEgc3BhY2Ug
YmVmb3JlIGEgKCB3aGVuIGl0J3MgYSBmdW5jdGlvbiBhcmd1bWVudC4gIEkgYXNzdW1lIGl0J3Mg
YQpAQCAtMTI5Niw3ICsxMjk3LDcgQEAgZGVmIGNoZWNrX3NwYWNpbmdfZm9yX2Z1bmN0aW9uX2Nh
bGwoZmlsZW5hbWUsIGxpbmUsIGxpbmVfbnVtYmVyLCBlcnJvcik6CiAgICAgIyBOb3RlIHRoYXQg
d2UgYXNzdW1lIHRoZSBjb250ZW50cyBvZiBbXSB0byBiZSBzaG9ydCBlbm91Z2ggdGhhdAogICAg
ICMgdGhleSdsbCBuZXZlciBuZWVkIHRvIHdyYXAuCiAgICAgaWYgKCAgIyBJZ25vcmUgY29udHJv
bCBzdHJ1Y3R1cmVzLgotICAgICAgICBub3Qgc2VhcmNoKHInXGIoaWZ8Zm9yfHdoaWxlfHN3aXRj
aHxyZXR1cm58bmV3fGRlbGV0ZSlcYicsIGZ1bmN0aW9uX2NhbGwpCisgICAgICAgIG5vdCBzZWFy
Y2gocidcYihpZnxmb3J8Zm9yZWFjaHx3aGlsZXxzd2l0Y2h8cmV0dXJufG5ld3xkZWxldGUpXGIn
LCBmdW5jdGlvbl9jYWxsKQogICAgICAgICAjIElnbm9yZSBwb2ludGVycy9yZWZlcmVuY2VzIHRv
IGZ1bmN0aW9ucy4KICAgICAgICAgYW5kIG5vdCBzZWFyY2gocicgXChbXildK1wpXChbXildKihc
KXwsJCknLCBmdW5jdGlvbl9jYWxsKQogICAgICAgICAjIElnbm9yZSBwb2ludGVycy9yZWZlcmVu
Y2VzIHRvIGFycmF5cy4KQEAgLTE1NjAsMTcgKzE1NjEsMTcgQEAgZGVmIGNoZWNrX3NwYWNpbmco
ZmlsZW5hbWUsIGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZXJyb3IpOgogICAgICAgICAgICAg
ICAnRXh0cmEgc3BhY2UgZm9yIG9wZXJhdG9yICVzJyAlIG1hdGNoZWQuZ3JvdXAoMSkpCiAKICAg
ICAjIEEgcGV0IHBlZXZlIG9mIG1pbmU6IG5vIHNwYWNlcyBhZnRlciBhbiBpZiwgd2hpbGUsIHN3
aXRjaCwgb3IgZm9yCi0gICAgbWF0Y2hlZCA9IHNlYXJjaChyJyAoaWZcKHxmb3JcKHx3aGlsZVwo
fHN3aXRjaFwoKScsIGxpbmUpCisgICAgbWF0Y2hlZCA9IHNlYXJjaChyJyAoaWZcKHxmb3JcKHxm
b3JlYWNoXCh8d2hpbGVcKHxzd2l0Y2hcKCknLCBsaW5lKQogICAgIGlmIG1hdGNoZWQ6CiAgICAg
ICAgIGVycm9yKGZpbGVuYW1lLCBsaW5lX251bWJlciwgJ3doaXRlc3BhY2UvcGFyZW5zJywgNSwK
ICAgICAgICAgICAgICAgJ01pc3Npbmcgc3BhY2UgYmVmb3JlICggaW4gJXMnICUgbWF0Y2hlZC5n
cm91cCgxKSkKIAotICAgICMgRm9yIGlmL2Zvci93aGlsZS9zd2l0Y2gsIHRoZSBsZWZ0IGFuZCBy
aWdodCBwYXJlbnMgc2hvdWxkIGJlCisgICAgIyBGb3IgaWYvZm9yL2ZvcmVhY2gvd2hpbGUvc3dp
dGNoLCB0aGUgbGVmdCBhbmQgcmlnaHQgcGFyZW5zIHNob3VsZCBiZQogICAgICMgY29uc2lzdGVu
dCBhYm91dCBob3cgbWFueSBzcGFjZXMgYXJlIGluc2lkZSB0aGUgcGFyZW5zLCBhbmQKICAgICAj
IHRoZXJlIHNob3VsZCBlaXRoZXIgYmUgemVybyBvciBvbmUgc3BhY2VzIGluc2lkZSB0aGUgcGFy
ZW5zLgogICAgICMgV2UgZG9uJ3Qgd2FudDogImlmICggZm9vKSIgb3IgImlmICggZm9vICAgKSIu
CiAgICAgIyBFeGNlcHRpb246ICJmb3IgKCA7IGZvbzsgYmFyKSIgYW5kICJmb3IgKGZvbzsgYmFy
OyApIiBhcmUgYWxsb3dlZC4KLSAgICBtYXRjaGVkID0gc2VhcmNoKHInXGIoaWZ8Zm9yfHdoaWxl
fHN3aXRjaClccypcKChbIF0qKSguKS4qW14gXSsoWyBdKilcKVxzKntccyokJywKKyAgICBtYXRj
aGVkID0gc2VhcmNoKHInXGIoaWZ8Zm9yfGZvcmVhY2h8d2hpbGV8c3dpdGNoKVxzKlwoKFsgXSop
KC4pLipbXiBdKyhbIF0qKVwpXHMqe1xzKiQnLAogICAgICAgICAgICAgICAgICAgICAgbGluZSkK
ICAgICBpZiBtYXRjaGVkOgogICAgICAgICBpZiBsZW4obWF0Y2hlZC5ncm91cCgyKSkgIT0gbGVu
KG1hdGNoZWQuZ3JvdXAoNCkpOgpAQCAtMTY4Myw3ICsxNjg0LDcgQEAgZGVmIGNoZWNrX2JyYWNl
cyhmaWxlbmFtZSwgY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBlcnJvcik6CiAgICAgICAgICAg
ICAgICAgICAnVGhpcyB7IHNob3VsZCBiZSBhdCB0aGUgZW5kIG9mIHRoZSBwcmV2aW91cyBsaW5l
JykKICAgICBlbGlmIChzZWFyY2gocidcKVxzKihjb25zdFxzKik/e1xzKiQnLCBsaW5lKQogICAg
ICAgICAgIGFuZCBsaW5lLmNvdW50KCcoJykgPT0gbGluZS5jb3VudCgnKScpCi0gICAgICAgICAg
YW5kIG5vdCBzZWFyY2gocidcYihpZnxmb3J8d2hpbGV8c3dpdGNoKVxiJywgbGluZSkpOgorICAg
ICAgICAgIGFuZCBub3Qgc2VhcmNoKHInXGIoaWZ8Zm9yfGZvcmVhY2h8d2hpbGV8c3dpdGNoKVxi
JywgbGluZSkpOgogICAgICAgICBlcnJvcihmaWxlbmFtZSwgbGluZV9udW1iZXIsICd3aGl0ZXNw
YWNlL2JyYWNlcycsIDQsCiAgICAgICAgICAgICAgICdQbGFjZSBicmFjZSBvbiBpdHMgb3duIGxp
bmUgZm9yIGZ1bmN0aW9uIGRlZmluaXRpb25zLicpCiAKQEAgLTE2OTIsNyArMTY5Myw3IEBAIGRl
ZiBjaGVja19icmFjZXMoZmlsZW5hbWUsIGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZXJyb3Ip
OgogICAgICAgICAjIG9uZSBsaW5lIGNvbnRyb2wgc3RhdGVtZW50IHdhcyBwcmV2aW91cy4KICAg
ICAgICAgcHJldmlvdXNfbGluZSA9IGNsZWFuX2xpbmVzLmVsaWRlZFtsaW5lX251bWJlciAtIDJd
CiAgICAgICAgIGlmIChwcmV2aW91c19saW5lLmZpbmQoJ3snKSA+IDAKLSAgICAgICAgICAgIGFu
ZCBzZWFyY2gocidcYihpZnxmb3J8d2hpbGV8ZWxzZSlcYicsIHByZXZpb3VzX2xpbmUpKToKKyAg
ICAgICAgICAgIGFuZCBzZWFyY2gocidcYihpZnxmb3J8Zm9yZWFjaHx3aGlsZXxlbHNlKVxiJywg
cHJldmlvdXNfbGluZSkpOgogICAgICAgICAgICAgZXJyb3IoZmlsZW5hbWUsIGxpbmVfbnVtYmVy
LCAnd2hpdGVzcGFjZS9icmFjZXMnLCA0LAogICAgICAgICAgICAgICAgICAgJ09uZSBsaW5lIGNv
bnRyb2wgY2xhdXNlcyBzaG91bGQgbm90IHVzZSBicmFjZXMuJykKIApkaWZmIC0tZ2l0IGEvV2Vi
S2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NwcGxpbnRfdW5pdHRlc3QucHkgYi9XZWJLaXRUb29s
cy9TY3JpcHRzL21vZHVsZXMvY3BwbGludF91bml0dGVzdC5weQppbmRleCA3ZDJiYzMxLi45MDQ1
NmM4IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwbGludF91bml0
dGVzdC5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwbGludF91bml0dGVz
dC5weQpAQCAtMTE1NiwxMiArMTE1NiwxNyBAQCBjbGFzcyBDcHBsaW50VGVzdChDcHBsaW50VGVz
dEJhc2UpOgogICAgICAgICBzZWxmLmFzc2VydF9saW50KCdmb3IgKCA7IGZvbzsgYmFyKSB7Jywg
JycpCiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ2ZvciAoIDsgZm9vOyBiYXIgKSB7JywgJycp
CiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ2ZvciAoZm9vOyBiYXI7ICkgeycsICcnKQorICAg
ICAgICBzZWxmLmFzc2VydF9saW50KCdmb3JlYWNoIChmb28sIGZvb3MgKSB7JywgJ01pc21hdGNo
aW5nIHNwYWNlcyBpbnNpZGUgKCkgaW4gZm9yZWFjaCcKKyAgICAgICAgICAgICAgICAgICAgICAg
ICAnICBbd2hpdGVzcGFjZS9wYXJlbnNdIFs1XScpCisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQo
J2ZvcmVhY2ggKCBmb28sIGZvb3MpIHsnLCAnTWlzbWF0Y2hpbmcgc3BhY2VzIGluc2lkZSAoKSBp
biBmb3JlYWNoJworICAgICAgICAgICAgICAgICAgICAgICAgICcgIFt3aGl0ZXNwYWNlL3BhcmVu
c10gWzVdJykKICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnd2hpbGUgKCAgZm9vICApIHsnLCAn
U2hvdWxkIGhhdmUgemVybyBvciBvbmUgc3BhY2VzIGluc2lkZScKICAgICAgICAgICAgICAgICAg
ICAgICAgICAnICggYW5kICkgaW4gd2hpbGUgIFt3aGl0ZXNwYWNlL3BhcmVuc10gWzVdJykKIAog
ICAgIGRlZiB0ZXN0X3NwYWNpbmdfZm9yX2ZuY2FsbChzZWxmKToKICAgICAgICAgc2VsZi5hc3Nl
cnRfbGludCgnaWYgKGZvbykgeycsICcnKQogICAgICAgICBzZWxmLmFzc2VydF9saW50KCdmb3Ig
KGZvbztiYXI7YmF6KSB7JywgJycpCisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ2ZvcmVhY2gg
KGZvbywgZm9vcykgeycsICcnKQogICAgICAgICBzZWxmLmFzc2VydF9saW50KCd3aGlsZSAoZm9v
KSB7JywgJycpCiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ3N3aXRjaCAoZm9vKSB7JywgJycp
CiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ25ldyAoUmVuZGVyQXJlbmEoKSkgUmVuZGVySW5s
aW5lKGRvY3VtZW50KCkpJywgJycpCkBAIC0yODg2LDYgKzI4OTEsMTIgQEAgY2xhc3MgV2ViS2l0
U3R5bGVUZXN0KENwcGxpbnRUZXN0QmFzZSk6CiAgICAgICAgICAgICAnT25lIGxpbmUgY29udHJv
bCBjbGF1c2VzIHNob3VsZCBub3QgdXNlIGJyYWNlcy4gIFt3aGl0ZXNwYWNlL2JyYWNlc10gWzRd
JykKIAogICAgICAgICBzZWxmLmFzc2VydF9tdWx0aV9saW5lX2xpbnQoCisgICAgICAgICAgICAn
Zm9yZWFjaCAoZm9vLCBmb29zKSB7XG4nCisgICAgICAgICAgICAnICAgIGludCBiYXI7XG4nCisg
ICAgICAgICAgICAnfVxuJywKKyAgICAgICAgICAgICdPbmUgbGluZSBjb250cm9sIGNsYXVzZXMg
c2hvdWxkIG5vdCB1c2UgYnJhY2VzLiAgW3doaXRlc3BhY2UvYnJhY2VzXSBbNF0nKQorCisgICAg
ICAgIHNlbGYuYXNzZXJ0X211bHRpX2xpbmVfbGludCgKICAgICAgICAgICAgICd3aGlsZSAodHJ1
ZSkge1xuJwogICAgICAgICAgICAgJyAgICBpbnQgZm9vO1xuJwogICAgICAgICAgICAgJ31cbics
Ci0tIAoxLjYuMC40Cgo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>32972</attachid>
            <date>2009-07-17 14:29:36 -0700</date>
            <delta_ts>2009-07-17 14:30:47 -0700</delta_ts>
            <desc>Support for foreach in cpplint</desc>
            <filename>0001-2009-07-17-Kenneth-Rohde-Christiansen-kenneth-web.patch</filename>
            <type>text/plain</type>
            <size>7589</size>
            <attacher name="Kenneth Rohde Christiansen">kenneth</attacher>
            
              <data encoding="base64">RnJvbSAxOTE4NTIwOWEwZGU0MmVhMDE4NDkxMjc0YzdjODU2YjY3MmZlODI4IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiA8a2VubmV0aEB3
ZWJraXQub3JnPgpEYXRlOiBGcmksIDE3IEp1bCAyMDA5IDE4OjE5OjM4IC0wMzAwClN1YmplY3Q6
IFtQQVRDSF0gMjAwOS0wNy0xNyAgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4gIDxrZW5uZXRo
QHdlYmtpdC5vcmc+CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAg
ICBBZGQgc3VwcG9ydCBmb3IgUXQncyBmb3JlYWNoIHRvIGNwcGxpbnQKICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjczODYKCiAgICAgICAgKiBTY3JpcHRz
L21vZHVsZXMvY3BwbGludC5weToKICAgICAgICAqIFNjcmlwdHMvbW9kdWxlcy9jcHBsaW50X3Vu
aXR0ZXN0LnB5OgotLS0KIFdlYktpdFRvb2xzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAg
ICAgICAgIHwgICAxMCArKysrKysrKysrCiBXZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3Bw
bGludC5weSAgICAgICAgICB8ICAgMTcgKysrKysrKysrLS0tLS0tLS0KIFdlYktpdFRvb2xzL1Nj
cmlwdHMvbW9kdWxlcy9jcHBsaW50X3VuaXR0ZXN0LnB5IHwgICAxMSArKysrKysrKysrKwogMyBm
aWxlcyBjaGFuZ2VkLCAzMCBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp
dCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwppbmRleCAx
ZGMzYTI1Li5hYmRkZTkwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cKKysrIGIv
V2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDctMTcgIEtlbm5l
dGggUm9oZGUgQ2hyaXN0aWFuc2VuICA8a2VubmV0aEB3ZWJraXQub3JnPgorCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBzdXBwb3J0IGZvciBRdCdz
IGZvcmVhY2ggdG8gY3BwbGludCAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTI3Mzg2CisKKyAgICAgICAgKiBTY3JpcHRzL21vZHVsZXMvY3BwbGludC5w
eToKKyAgICAgICAgKiBTY3JpcHRzL21vZHVsZXMvY3BwbGludF91bml0dGVzdC5weToKKwogMjAw
OS0wNy0xNyAgQWRhbSBUcmVhdCAgPGFkYW0udHJlYXRAdG9yY2htb2JpbGUuY29tPgogCiAgICAg
ICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMv
U2NyaXB0cy9tb2R1bGVzL2NwcGxpbnQucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMv
Y3BwbGludC5weQppbmRleCAxM2ZlZjgwLi4zNTBiNDQwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s
cy9TY3JpcHRzL21vZHVsZXMvY3BwbGludC5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL21v
ZHVsZXMvY3BwbGludC5weQpAQCAtMTI2OCwxMyArMTI2OCwxNCBAQCBkZWYgY2hlY2tfc3BhY2lu
Z19mb3JfZnVuY3Rpb25fY2FsbChmaWxlbmFtZSwgbGluZSwgbGluZV9udW1iZXIsIGVycm9yKToK
ICAgICAgIGVycm9yOiBUaGUgZnVuY3Rpb24gdG8gY2FsbCB3aXRoIGFueSBlcnJvcnMgZm91bmQu
CiAgICAgIiIiCiAKLSAgICAjIFNpbmNlIGZ1bmN0aW9uIGNhbGxzIG9mdGVuIG9jY3VyIGluc2lk
ZSBpZi9mb3Ivd2hpbGUvc3dpdGNoCisgICAgIyBTaW5jZSBmdW5jdGlvbiBjYWxscyBvZnRlbiBv
Y2N1ciBpbnNpZGUgaWYvZm9yL2ZvcmVhY2gvd2hpbGUvc3dpdGNoCiAgICAgIyBleHByZXNzaW9u
cyAtIHdoaWNoIGhhdmUgdGhlaXIgb3duLCBtb3JlIGxpYmVyYWwgY29udmVudGlvbnMgLSB3ZQog
ICAgICMgZmlyc3Qgc2VlIGlmIHdlIHNob3VsZCBiZSBsb29raW5nIGluc2lkZSBzdWNoIGFuIGV4
cHJlc3Npb24gZm9yIGEKICAgICAjIGZ1bmN0aW9uIGNhbGwsIHRvIHdoaWNoIHdlIGNhbiBhcHBs
eSBtb3JlIHN0cmljdCBzdGFuZGFyZHMuCiAgICAgZnVuY3Rpb25fY2FsbCA9IGxpbmUgICAgIyBp
ZiB0aGVyZSdzIG5vIGNvbnRyb2wgZmxvdyBjb25zdHJ1Y3QsIGxvb2sgYXQgd2hvbGUgbGluZQog
ICAgIGZvciBwYXR0ZXJuIGluIChyJ1xiaWZccypcKCguKilcKVxzKnsnLAogICAgICAgICAgICAg
ICAgICAgICByJ1xiZm9yXHMqXCgoLiopXClccyp7JywKKyAgICAgICAgICAgICAgICAgICAgcidc
YmZvcmVhY2hccypcKCguKilcKVxzKnsnLAogICAgICAgICAgICAgICAgICAgICByJ1xid2hpbGVc
cypcKCguKilcKVxzKlt7O10nLAogICAgICAgICAgICAgICAgICAgICByJ1xic3dpdGNoXHMqXCgo
LiopXClccyp7Jyk6CiAgICAgICAgIG1hdGNoZWQgPSBzZWFyY2gocGF0dGVybiwgbGluZSkKQEAg
LTEyODIsNyArMTI4Myw3IEBAIGRlZiBjaGVja19zcGFjaW5nX2Zvcl9mdW5jdGlvbl9jYWxsKGZp
bGVuYW1lLCBsaW5lLCBsaW5lX251bWJlciwgZXJyb3IpOgogICAgICAgICAgICAgZnVuY3Rpb25f
Y2FsbCA9IG1hdGNoZWQuZ3JvdXAoMSkgICAgIyBsb29rIGluc2lkZSB0aGUgcGFyZW5zIGZvciBm
dW5jdGlvbiBjYWxscwogICAgICAgICAgICAgYnJlYWsKIAotICAgICMgRXhjZXB0IGluIGlmL2Zv
ci93aGlsZS9zd2l0Y2gsIHRoZXJlIHNob3VsZCBuZXZlciBiZSBzcGFjZQorICAgICMgRXhjZXB0
IGluIGlmL2Zvci9mb3JlYWNoL3doaWxlL3N3aXRjaCwgdGhlcmUgc2hvdWxkIG5ldmVyIGJlIHNw
YWNlCiAgICAgIyBpbW1lZGlhdGVseSBpbnNpZGUgcGFyZW5zIChlZyAiZiggMywgNCApIikuICBX
ZSBtYWtlIGFuIGV4Y2VwdGlvbgogICAgICMgZm9yIG5lc3RlZCBwYXJlbnMgKCAoYStiKSArIGMg
KS4gIExpa2V3aXNlLCB0aGVyZSBzaG91bGQgbmV2ZXIgYmUKICAgICAjIGEgc3BhY2UgYmVmb3Jl
IGEgKCB3aGVuIGl0J3MgYSBmdW5jdGlvbiBhcmd1bWVudC4gIEkgYXNzdW1lIGl0J3MgYQpAQCAt
MTI5Niw3ICsxMjk3LDcgQEAgZGVmIGNoZWNrX3NwYWNpbmdfZm9yX2Z1bmN0aW9uX2NhbGwoZmls
ZW5hbWUsIGxpbmUsIGxpbmVfbnVtYmVyLCBlcnJvcik6CiAgICAgIyBOb3RlIHRoYXQgd2UgYXNz
dW1lIHRoZSBjb250ZW50cyBvZiBbXSB0byBiZSBzaG9ydCBlbm91Z2ggdGhhdAogICAgICMgdGhl
eSdsbCBuZXZlciBuZWVkIHRvIHdyYXAuCiAgICAgaWYgKCAgIyBJZ25vcmUgY29udHJvbCBzdHJ1
Y3R1cmVzLgotICAgICAgICBub3Qgc2VhcmNoKHInXGIoaWZ8Zm9yfHdoaWxlfHN3aXRjaHxyZXR1
cm58bmV3fGRlbGV0ZSlcYicsIGZ1bmN0aW9uX2NhbGwpCisgICAgICAgIG5vdCBzZWFyY2gocidc
YihpZnxmb3J8Zm9yZWFjaHx3aGlsZXxzd2l0Y2h8cmV0dXJufG5ld3xkZWxldGUpXGInLCBmdW5j
dGlvbl9jYWxsKQogICAgICAgICAjIElnbm9yZSBwb2ludGVycy9yZWZlcmVuY2VzIHRvIGZ1bmN0
aW9ucy4KICAgICAgICAgYW5kIG5vdCBzZWFyY2gocicgXChbXildK1wpXChbXildKihcKXwsJCkn
LCBmdW5jdGlvbl9jYWxsKQogICAgICAgICAjIElnbm9yZSBwb2ludGVycy9yZWZlcmVuY2VzIHRv
IGFycmF5cy4KQEAgLTE1NjAsMTcgKzE1NjEsMTcgQEAgZGVmIGNoZWNrX3NwYWNpbmcoZmlsZW5h
bWUsIGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZXJyb3IpOgogICAgICAgICAgICAgICAnRXh0
cmEgc3BhY2UgZm9yIG9wZXJhdG9yICVzJyAlIG1hdGNoZWQuZ3JvdXAoMSkpCiAKICAgICAjIEEg
cGV0IHBlZXZlIG9mIG1pbmU6IG5vIHNwYWNlcyBhZnRlciBhbiBpZiwgd2hpbGUsIHN3aXRjaCwg
b3IgZm9yCi0gICAgbWF0Y2hlZCA9IHNlYXJjaChyJyAoaWZcKHxmb3JcKHx3aGlsZVwofHN3aXRj
aFwoKScsIGxpbmUpCisgICAgbWF0Y2hlZCA9IHNlYXJjaChyJyAoaWZcKHxmb3JcKHxmb3JlYWNo
XCh8d2hpbGVcKHxzd2l0Y2hcKCknLCBsaW5lKQogICAgIGlmIG1hdGNoZWQ6CiAgICAgICAgIGVy
cm9yKGZpbGVuYW1lLCBsaW5lX251bWJlciwgJ3doaXRlc3BhY2UvcGFyZW5zJywgNSwKICAgICAg
ICAgICAgICAgJ01pc3Npbmcgc3BhY2UgYmVmb3JlICggaW4gJXMnICUgbWF0Y2hlZC5ncm91cCgx
KSkKIAotICAgICMgRm9yIGlmL2Zvci93aGlsZS9zd2l0Y2gsIHRoZSBsZWZ0IGFuZCByaWdodCBw
YXJlbnMgc2hvdWxkIGJlCisgICAgIyBGb3IgaWYvZm9yL2ZvcmVhY2gvd2hpbGUvc3dpdGNoLCB0
aGUgbGVmdCBhbmQgcmlnaHQgcGFyZW5zIHNob3VsZCBiZQogICAgICMgY29uc2lzdGVudCBhYm91
dCBob3cgbWFueSBzcGFjZXMgYXJlIGluc2lkZSB0aGUgcGFyZW5zLCBhbmQKICAgICAjIHRoZXJl
IHNob3VsZCBlaXRoZXIgYmUgemVybyBvciBvbmUgc3BhY2VzIGluc2lkZSB0aGUgcGFyZW5zLgog
ICAgICMgV2UgZG9uJ3Qgd2FudDogImlmICggZm9vKSIgb3IgImlmICggZm9vICAgKSIuCiAgICAg
IyBFeGNlcHRpb246ICJmb3IgKCA7IGZvbzsgYmFyKSIgYW5kICJmb3IgKGZvbzsgYmFyOyApIiBh
cmUgYWxsb3dlZC4KLSAgICBtYXRjaGVkID0gc2VhcmNoKHInXGIoaWZ8Zm9yfHdoaWxlfHN3aXRj
aClccypcKChbIF0qKSguKS4qW14gXSsoWyBdKilcKVxzKntccyokJywKKyAgICBtYXRjaGVkID0g
c2VhcmNoKHInXGIoaWZ8Zm9yfGZvcmVhY2h8d2hpbGV8c3dpdGNoKVxzKlwoKFsgXSopKC4pLipb
XiBdKyhbIF0qKVwpXHMqe1xzKiQnLAogICAgICAgICAgICAgICAgICAgICAgbGluZSkKICAgICBp
ZiBtYXRjaGVkOgogICAgICAgICBpZiBsZW4obWF0Y2hlZC5ncm91cCgyKSkgIT0gbGVuKG1hdGNo
ZWQuZ3JvdXAoNCkpOgpAQCAtMTY4Myw3ICsxNjg0LDcgQEAgZGVmIGNoZWNrX2JyYWNlcyhmaWxl
bmFtZSwgY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBlcnJvcik6CiAgICAgICAgICAgICAgICAg
ICAnVGhpcyB7IHNob3VsZCBiZSBhdCB0aGUgZW5kIG9mIHRoZSBwcmV2aW91cyBsaW5lJykKICAg
ICBlbGlmIChzZWFyY2gocidcKVxzKihjb25zdFxzKik/e1xzKiQnLCBsaW5lKQogICAgICAgICAg
IGFuZCBsaW5lLmNvdW50KCcoJykgPT0gbGluZS5jb3VudCgnKScpCi0gICAgICAgICAgYW5kIG5v
dCBzZWFyY2gocidcYihpZnxmb3J8d2hpbGV8c3dpdGNoKVxiJywgbGluZSkpOgorICAgICAgICAg
IGFuZCBub3Qgc2VhcmNoKHInXGIoaWZ8Zm9yfGZvcmVhY2h8d2hpbGV8c3dpdGNoKVxiJywgbGlu
ZSkpOgogICAgICAgICBlcnJvcihmaWxlbmFtZSwgbGluZV9udW1iZXIsICd3aGl0ZXNwYWNlL2Jy
YWNlcycsIDQsCiAgICAgICAgICAgICAgICdQbGFjZSBicmFjZSBvbiBpdHMgb3duIGxpbmUgZm9y
IGZ1bmN0aW9uIGRlZmluaXRpb25zLicpCiAKQEAgLTE2OTIsNyArMTY5Myw3IEBAIGRlZiBjaGVj
a19icmFjZXMoZmlsZW5hbWUsIGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZXJyb3IpOgogICAg
ICAgICAjIG9uZSBsaW5lIGNvbnRyb2wgc3RhdGVtZW50IHdhcyBwcmV2aW91cy4KICAgICAgICAg
cHJldmlvdXNfbGluZSA9IGNsZWFuX2xpbmVzLmVsaWRlZFtsaW5lX251bWJlciAtIDJdCiAgICAg
ICAgIGlmIChwcmV2aW91c19saW5lLmZpbmQoJ3snKSA+IDAKLSAgICAgICAgICAgIGFuZCBzZWFy
Y2gocidcYihpZnxmb3J8d2hpbGV8ZWxzZSlcYicsIHByZXZpb3VzX2xpbmUpKToKKyAgICAgICAg
ICAgIGFuZCBzZWFyY2gocidcYihpZnxmb3J8Zm9yZWFjaHx3aGlsZXxlbHNlKVxiJywgcHJldmlv
dXNfbGluZSkpOgogICAgICAgICAgICAgZXJyb3IoZmlsZW5hbWUsIGxpbmVfbnVtYmVyLCAnd2hp
dGVzcGFjZS9icmFjZXMnLCA0LAogICAgICAgICAgICAgICAgICAgJ09uZSBsaW5lIGNvbnRyb2wg
Y2xhdXNlcyBzaG91bGQgbm90IHVzZSBicmFjZXMuJykKIApkaWZmIC0tZ2l0IGEvV2ViS2l0VG9v
bHMvU2NyaXB0cy9tb2R1bGVzL2NwcGxpbnRfdW5pdHRlc3QucHkgYi9XZWJLaXRUb29scy9TY3Jp
cHRzL21vZHVsZXMvY3BwbGludF91bml0dGVzdC5weQppbmRleCA3ZDJiYzMxLi45MDQ1NmM4IDEw
MDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwbGludF91bml0dGVzdC5w
eQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwbGludF91bml0dGVzdC5weQpA
QCAtMTE1NiwxMiArMTE1NiwxNyBAQCBjbGFzcyBDcHBsaW50VGVzdChDcHBsaW50VGVzdEJhc2Up
OgogICAgICAgICBzZWxmLmFzc2VydF9saW50KCdmb3IgKCA7IGZvbzsgYmFyKSB7JywgJycpCiAg
ICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ2ZvciAoIDsgZm9vOyBiYXIgKSB7JywgJycpCiAgICAg
ICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ2ZvciAoZm9vOyBiYXI7ICkgeycsICcnKQorICAgICAgICBz
ZWxmLmFzc2VydF9saW50KCdmb3JlYWNoIChmb28sIGZvb3MgKSB7JywgJ01pc21hdGNoaW5nIHNw
YWNlcyBpbnNpZGUgKCkgaW4gZm9yZWFjaCcKKyAgICAgICAgICAgICAgICAgICAgICAgICAnICBb
d2hpdGVzcGFjZS9wYXJlbnNdIFs1XScpCisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ2ZvcmVh
Y2ggKCBmb28sIGZvb3MpIHsnLCAnTWlzbWF0Y2hpbmcgc3BhY2VzIGluc2lkZSAoKSBpbiBmb3Jl
YWNoJworICAgICAgICAgICAgICAgICAgICAgICAgICcgIFt3aGl0ZXNwYWNlL3BhcmVuc10gWzVd
JykKICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnd2hpbGUgKCAgZm9vICApIHsnLCAnU2hvdWxk
IGhhdmUgemVybyBvciBvbmUgc3BhY2VzIGluc2lkZScKICAgICAgICAgICAgICAgICAgICAgICAg
ICAnICggYW5kICkgaW4gd2hpbGUgIFt3aGl0ZXNwYWNlL3BhcmVuc10gWzVdJykKIAogICAgIGRl
ZiB0ZXN0X3NwYWNpbmdfZm9yX2ZuY2FsbChzZWxmKToKICAgICAgICAgc2VsZi5hc3NlcnRfbGlu
dCgnaWYgKGZvbykgeycsICcnKQogICAgICAgICBzZWxmLmFzc2VydF9saW50KCdmb3IgKGZvbzti
YXI7YmF6KSB7JywgJycpCisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ2ZvcmVhY2ggKGZvbywg
Zm9vcykgeycsICcnKQogICAgICAgICBzZWxmLmFzc2VydF9saW50KCd3aGlsZSAoZm9vKSB7Jywg
JycpCiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ3N3aXRjaCAoZm9vKSB7JywgJycpCiAgICAg
ICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ25ldyAoUmVuZGVyQXJlbmEoKSkgUmVuZGVySW5saW5lKGRv
Y3VtZW50KCkpJywgJycpCkBAIC0yODg2LDYgKzI4OTEsMTIgQEAgY2xhc3MgV2ViS2l0U3R5bGVU
ZXN0KENwcGxpbnRUZXN0QmFzZSk6CiAgICAgICAgICAgICAnT25lIGxpbmUgY29udHJvbCBjbGF1
c2VzIHNob3VsZCBub3QgdXNlIGJyYWNlcy4gIFt3aGl0ZXNwYWNlL2JyYWNlc10gWzRdJykKIAog
ICAgICAgICBzZWxmLmFzc2VydF9tdWx0aV9saW5lX2xpbnQoCisgICAgICAgICAgICAnZm9yZWFj
aCAoZm9vLCBmb29zKSB7XG4nCisgICAgICAgICAgICAnICAgIGludCBiYXI7XG4nCisgICAgICAg
ICAgICAnfVxuJywKKyAgICAgICAgICAgICdPbmUgbGluZSBjb250cm9sIGNsYXVzZXMgc2hvdWxk
IG5vdCB1c2UgYnJhY2VzLiAgW3doaXRlc3BhY2UvYnJhY2VzXSBbNF0nKQorCisgICAgICAgIHNl
bGYuYXNzZXJ0X211bHRpX2xpbmVfbGludCgKICAgICAgICAgICAgICd3aGlsZSAodHJ1ZSkge1xu
JwogICAgICAgICAgICAgJyAgICBpbnQgZm9vO1xuJwogICAgICAgICAgICAgJ31cbicsCi0tIAox
LjYuMC40Cgo=
</data>
<flag name="review"
          id="17314"
          type_id="1"
          status="+"
          setter="levin"
    />
          </attachment>
      

    </bug>

</bugzilla>