27382 2009-07-17 11:44:20 -0700 Build break -- including a corefoundation header 2009-07-17 12:36:53 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eroman eroman ap oldest_to_newest 132651 0 eroman 2009-07-17 11:44:20 -0700 http://trac.webkit.org/changeset/46042 add an include of "RetainPtr.h" in CollatorICU.cpp. RetainPtr.h in turn includes: include <CoreFoundation/CoreFoundation.h> This breaks compile on non-mac builds for users of CollatorICU.cpp (Broke chromium builder) 132654 1 32962 eroman 2009-07-17 12:05:05 -0700 Created attachment 32962 Add a header inclusion guard 132658 2 32962 darin 2009-07-17 12:09:21 -0700 Comment on attachment 32962 Add a header inclusion guard Conditionalized includes go in separate paragraphs in our coding style. Typo "Build fox" instead of build fix. Would you be willing to do a new patch with those fixed? 132661 3 32964 eroman 2009-07-17 12:18:07 -0700 Created attachment 32964 Add a header inclusion guard (v2) New patch -- addressed darin@apple.com's feedback. 132666 4 eroman 2009-07-17 12:36:53 -0700 Landed in r46049. 32962 2009-07-17 12:05:05 -0700 2009-07-17 12:09:21 -0700 Add a header inclusion guard buildfix.patch text/plain 1086 eroman SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ2MDQ1KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDctMTcgIEVyaWMgUm9t YW4gIDxlcm9tYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEJ1aWxkIGZveCBvbiBub24tRGFyd2luIHBsYXRmb3Jtcy4KKyAg ICAgICAgQWRkIGEgZ3VhcmQgZm9yIGluY2x1c2lvbiBvZiBSZXRhaW5QdHIuaCB3aGljaCBpbmNs dWRlcyBDb3JlRm91bmRhdGlvbi5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yNzM4MgorCisgICAgICAgICogd3RmL3VuaWNvZGUvaWN1L0NvbGxhdG9y SUNVLmNwcDoKKwogMjAwOS0wNy0xNyAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQHdlYmtpdC5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSm9obiBTdWxsaXZhbi4KSW5kZXg6IEphdmFTY3Jp cHRDb3JlL3d0Zi91bmljb2RlL2ljdS9Db2xsYXRvcklDVS5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2 YVNjcmlwdENvcmUvd3RmL3VuaWNvZGUvaWN1L0NvbGxhdG9ySUNVLmNwcAkocmV2aXNpb24gNDYw NDUpCisrKyBKYXZhU2NyaXB0Q29yZS93dGYvdW5pY29kZS9pY3UvQ29sbGF0b3JJQ1UuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0zMiw3ICszMiw5IEBACiAjaWYgVVNFKElDVV9VTklDT0RFKSAmJiAh VUNPTkZJR19OT19DT0xMQVRJT04KIAogI2luY2x1ZGUgIkFzc2VydGlvbnMuaCIKKyNpZiBQTEFU Rk9STShEQVJXSU4pCiAjaW5jbHVkZSAiUmV0YWluUHRyLmgiCisjZW5kaWYKICNpbmNsdWRlICJU aHJlYWRpbmcuaCIKICNpbmNsdWRlIDx1bmljb2RlL3Vjb2wuaD4KICNpbmNsdWRlIDxzdHJpbmcu aD4K 32964 2009-07-17 12:18:07 -0700 2009-07-17 12:22:56 -0700 Add a header inclusion guard (v2) buildfix-v2.patch text/plain 1153 eroman SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ2MDQ1KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDctMTcgIEVyaWMgUm9t YW4gIDxlcm9tYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEJ1aWxkIGZpeCBmb3Igbm9uLURhcndpbi4KKyAgICAgICAgQWRk IGEgZ3VhcmQgZm9yIGluY2x1c2lvbiBvZiBSZXRhaW5QdHIuaCB3aGljaCBpbmNsdWRlcyBDb3Jl Rm91bmRhdGlvbi5oCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTI3MzgyCisKKyAgICAgICAgKiB3dGYvdW5pY29kZS9pY3UvQ29sbGF0b3JJQ1UuY3Bw OgorCiAyMDA5LTA3LTE3ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAd2Via2l0Lm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBKb2huIFN1bGxpdmFuLgpJbmRleDogSmF2YVNjcmlwdENvcmUv d3RmL3VuaWNvZGUvaWN1L0NvbGxhdG9ySUNVLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS93dGYvdW5pY29kZS9pY3UvQ29sbGF0b3JJQ1UuY3BwCShyZXZpc2lvbiA0NjA0NSkKKysr IEphdmFTY3JpcHRDb3JlL3d0Zi91bmljb2RlL2ljdS9Db2xsYXRvcklDVS5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTMyLDEyICszMiwxMiBAQAogI2lmIFVTRShJQ1VfVU5JQ09ERSkgJiYgIVVDT05G SUdfTk9fQ09MTEFUSU9OCiAKICNpbmNsdWRlICJBc3NlcnRpb25zLmgiCi0jaW5jbHVkZSAiUmV0 YWluUHRyLmgiCiAjaW5jbHVkZSAiVGhyZWFkaW5nLmgiCiAjaW5jbHVkZSA8dW5pY29kZS91Y29s Lmg+CiAjaW5jbHVkZSA8c3RyaW5nLmg+CiAKICNpZiBQTEFURk9STShEQVJXSU4pCisjaW5jbHVk ZSAiUmV0YWluUHRyLmgiCiAjaW5jbHVkZSA8Q29yZUZvdW5kYXRpb24vQ29yZUZvdW5kYXRpb24u aD4KICNlbmRpZgogCg==