273780 2024-05-06 10:36:11 -0700 REGRESSION(273922@main): [GTK] Epiphany keyboard shortcuts broken with non-Latin keyboard layout 2024-09-06 06:49:56 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 261348 1 mcatanzaro mcatanzaro bugs-noreply mcatanzaro muziknavi oldest_to_newest 2033494 0 mcatanzaro 2024-05-06 10:36:11 -0700 Moving this from https://gitlab.gnome.org/GNOME/epiphany/-/issues/2312, the problem is since Epiphany 46 keyboard shortcuts no longer work when using non-Latin keyboard layouts, like Ukranian or Hebrew. Currently we only consider the keyval when activating application accelerators. We need to consider the raw keycode as well. E.g. on a Hebrew keyboard pressing Ctrl+א should open a new tab, because the same key is used for both א and T. 2033497 1 mcatanzaro 2024-05-06 10:40:53 -0700 (This is *sort of* a regression from 273922@main, except in practice it probably only affects Epiphany. Only matters if the application allows the web view to process key events before it allows its GtkWindow to do so, which has to be done manually.) 2033499 2 mcatanzaro 2024-05-06 10:44:36 -0700 Pull request: https://github.com/WebKit/WebKit/pull/28181 2033709 3 ews-feeder 2024-05-07 05:34:51 -0700 Committed 278456@main (48d82b12d119): <https://commits.webkit.org/278456@main> Reviewed commits have been landed. Closing PR #28181 and removing active labels. 2049117 4 mcatanzaro 2024-07-29 08:55:32 -0700 Reopening because something is wrong and this isn't working. See: https://gitlab.gnome.org/GNOME/epiphany/-/issues/2396 2049925 5 mcatanzaro 2024-07-31 14:17:12 -0700 gtk_accelerator_name_with_keycode() is returning "<Control>hebrew_aleph" which of course doesn't match any actions. So that doesn't work at all. But three months ago, I was convinced that it did work. The question is why. Did I trick myself, or did something change? 2049933 6 mcatanzaro 2024-07-31 14:51:10 -0700 Guess: this never worked, and I tricked myself by testing on about:overview, where the web view is not focused and not actually receiving the key press events? 2050695 7 mcatanzaro 2024-08-05 11:04:53 -0700 I don't have a solution for this. We might need to revert 273922@main, which would be unfortunate because that will bring back other serious bugs, but at least then all keyboard layouts would be equally broken. (I hesitate to treat non-Latin keyboard layouts worse off than Latin layouts.) 2056020 8 muziknavi 2024-08-28 12:19:29 -0700 fwiw, libreoffice in gtk4 also suffers from this issue. Is it maybe more general issue in gtk4? https://bugs.documentfoundation.org/show_bug.cgi?id=161589 2056038 9 mcatanzaro 2024-08-28 13:25:28 -0700 No, this is a WebKit bug. 2058185 10 mcatanzaro 2024-09-06 05:38:21 -0700 Let's bring back key event reinjection to get back to the state we had before I broke Hebrew/Ukrainian keyboards. That won't work properly either, but at least it will be equally broken for everyone. 2058188 11 mcatanzaro 2024-09-06 05:56:26 -0700 Pull request: https://github.com/WebKit/WebKit/pull/33242 2058194 12 ews-feeder 2024-09-06 06:49:53 -0700 Committed 283267@main (5978873cc8be): <https://commits.webkit.org/283267@main> Reviewed commits have been landed. Closing PR #33242 and removing active labels.