27375 2009-07-17 09:59:45 -0700 [Chromium] Need a DOM_STORAGE guard in DerivedSourcesAllInOne.cpp 2009-07-17 11:02:25 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jorlow jorlow dglazkov eroman levin oldest_to_newest 132608 0 jorlow 2009-07-17 09:59:45 -0700 In https://bugs.webkit.org/show_bug.cgi?id=27360 I added Storage.cpp and StorageEvent.cpp. Unfortunately, until later this afternoon, DOM_STORAGE is not turned on by default in Chromium, and so these two files are never generated. This breaks the compile. There are no other instances of guards in the file, which puzzles me..but I think adding guards is the right way to go about this. 132611 1 jorlow 2009-07-17 10:10:19 -0700 Currently testing a fix. 132623 2 32957 jorlow 2009-07-17 10:43:53 -0700 Created attachment 32957 v1 In https://bugs.webkit.org/show_bug.cgi?id=27360 I added Storage.cpp and StorageEvent.cpp. Unfortunately, until later this afternoon, DOM_STORAGE is not turned on by default in Chromium, and so these two files are never generated. This breaks the compile. There are no other instances of guards in the file, which puzzles me..but I think adding guards is the right way to go about this. 132626 3 32957 dglazkov 2009-07-17 10:47:44 -0700 Comment on attachment 32957 v1 r=me 132637 4 dglazkov 2009-07-17 11:02:25 -0700 Landed as http://trac.webkit.org/changeset/46041. 32957 2009-07-17 10:43:53 -0700 2009-07-17 10:47:44 -0700 v1 add_guard.v1.patch text/plain 1644 jorlow SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NjAzOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDktMDctMTcgIEplcmVteSBPcmxvdyAgPGpvcmxvd0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg TmVlZCBhIERPTV9TVE9SQUdFIGd1YXJkIGluIERlcml2ZWRTcm91Y2VzQWxsSW5PbmUuY3BwCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzM3NQorCisg ICAgICAgIEluIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzM2MCBJ IGFkZGVkIFN0b3JhZ2UuY3BwCisgICAgICAgIGFuZCBTdG9yYWdlRXZlbnQuY3BwLiAgVW5mb3J0 dW5hdGVseSwgdW50aWwgbGF0ZXIgdGhpcyBhZnRlcm5vb24sCisgICAgICAgIERPTV9TVE9SQUdF IGlzIG5vdCB0dXJuZWQgb24gYnkgZGVmYXVsdCBpbiBDaHJvbWl1bSwgYW5kIHNvIHRoZXNlIHR3 bworICAgICAgICBmaWxlcyBhcmUgbmV2ZXIgZ2VuZXJhdGVkLiAgVGhpcyBicmVha3MgdGhlIGNv bXBpbGUuCisKKyAgICAgICAgVGhlcmUgYXJlIG5vIG90aGVyIGluc3RhbmNlcyBvZiBndWFyZHMg aW4gdGhlIGZpbGUsIHdoaWNoIHB1enpsZXMgbWUuLi4KKyAgICAgICAgYnV0IEkgdGhpbmsgYWRk aW5nIGd1YXJkcyBpcyB0aGUgcmlnaHQgd2F5IHRvIGdvIGFib3V0IHRoaXMuCisKKyAgICAgICAg KiBiaW5kaW5ncy92OC9EZXJpdmVkU291cmNlc0FsbEluT25lLmNwcDogIEFkZCB0aGUgZ3VhcmQu CisKIDIwMDktMDctMTcgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtc2FuY2hlekBpZ2FsaWEuY29t PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEd1c3Rhdm8gTm9yb25oYS4KSW5kZXg6IFdlYkNvcmUv YmluZGluZ3MvdjgvRGVyaXZlZFNvdXJjZXNBbGxJbk9uZS5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9iaW5kaW5ncy92OC9EZXJpdmVkU291cmNlc0FsbEluT25lLmNwcAkocmV2aXNpb24gNDYw MzgpCisrKyBXZWJDb3JlL2JpbmRpbmdzL3Y4L0Rlcml2ZWRTb3VyY2VzQWxsSW5PbmUuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0xODQsOCArMTg0LDEwIEBACiAjaW5jbHVkZSAiYmluZGluZ3MvVjhT UUxSZXN1bHRTZXQuY3BwIgogI2luY2x1ZGUgImJpbmRpbmdzL1Y4U1FMUmVzdWx0U2V0Um93TGlz dC5jcHAiCiAjaW5jbHVkZSAiYmluZGluZ3MvVjhTUUxUcmFuc2FjdGlvbi5jcHAiCisjaWYgRU5B QkxFKERPTV9TVE9SQUdFKQogI2luY2x1ZGUgImJpbmRpbmdzL1Y4U3RvcmFnZS5jcHAiCiAjaW5j bHVkZSAiYmluZGluZ3MvVjhTdG9yYWdlRXZlbnQuY3BwIgorI2VuZGlmCiAjaW5jbHVkZSAiYmlu ZGluZ3MvVjhTdHlsZVNoZWV0LmNwcCIKICNpbmNsdWRlICJiaW5kaW5ncy9WOFN0eWxlU2hlZXRM aXN0LmNwcCIKICNpbmNsdWRlICJiaW5kaW5ncy9WOFNWR0FFbGVtZW50LmNwcCIK