27369 2009-07-17 05:48:15 -0700 [v8] Restore proxy retrieval lost in -r45596 2009-07-20 04:34:09 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 antonm jorlow ager dglazkov jorlow oldest_to_newest 132552 0 antonm 2009-07-17 05:48:15 -0700 In my change list (http://trac.webkit.org/changeset?old_path=%2Ftrunk%2FWebCore%2Fbindings%2Fv8&old=45595&new_path=%2Ftrunk%2FWebCore%2Fbindings%2Fv8&new=45596) I made a typo and instead: 2414 if (!proxy) 2415 proxy = V8Proxy::retrieve(); I put 2414 if (!proxy) 2415 V8Proxy* proxy = V8Proxy::retrieve(); which made us notably slower. Those line later were refactored, so change looks somewhat different. 132554 1 32934 antonm 2009-07-17 05:53:29 -0700 Created attachment 32934 Initial version 132605 2 ager 2009-07-17 09:49:34 -0700 Looks good to me. Over to Dimitri for the official review. 132641 3 32934 dglazkov 2009-07-17 11:18:27 -0700 Comment on attachment 32934 Initial version ok. 132823 4 jorlow 2009-07-17 19:03:50 -0700 Assigning for landing 132825 5 jorlow 2009-07-17 19:15:17 -0700 Landed in r46079 133113 6 antonm 2009-07-20 04:34:09 -0700 (In reply to comment #5) > Landed in r46079 Thank you, everyone. 32934 2009-07-17 05:53:29 -0700 2009-07-17 11:18:27 -0700 Initial version webcore.patch text/plain 1348 antonm SW5kZXg6IHRoaXJkX3BhcnR5L1dlYktpdC9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSB0aGlyZF9wYXJ0eS9XZWJLaXQvV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ2MDI5KQor KysgdGhpcmRfcGFydHkvV2ViS2l0L1dlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMDctMTcgIEFudG9uIE11aGluICA8YW50b25tQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBS ZXN0b3JlIHByb3h5IHJldHJpZXZhbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjczNjkKKworICAgICAgICBObyBuZXcgdGVzdHMgYXJlIG5lZWRlZC4K KworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHA6CisgICAgICAgIChXZWJD b3JlOjpWOERPTVdyYXBwZXI6Omluc3RhbnRpYXRlVjhPYmplY3QpOgorCiAyMDA5LTA3LTE3ICBU b3IgQXJuZSBWZXN0YsO4ICA8dG9yLmFybmUudmVzdGJvQG5va2lhLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KSW5kZXg6IHRoaXJkX3BhcnR5L1dlYktpdC9XZWJD b3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gdGhpcmRfcGFy dHkvV2ViS2l0L1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmNwcAkocmV2aXNpb24g NDU5NTgpCisrKyB0aGlyZF9wYXJ0eS9XZWJLaXQvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdy YXBwZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03MDAsNyArNzAwLDkgQEAgdjg6OkxvY2FsPHY4 OjpPYmplY3Q+IFY4RE9NV3JhcHBlcjo6aW5zdAogICAgICAgICBwcm94eSA9IDA7CiAgICAgICAg IC8vIEZJWE1FOiBEbyB3ZSBuZWVkIGEgd3JhcHBlciBjYWNoZSBmb3IgdGhlIGlzb2xhdGVkIHdv cmxkPyAgV2Ugc2hvdWxkCiAgICAgICAgIC8vIHNlZSBpZiB0aGUgcGVyZm9ybWFuY2UgZ2FpbnMg YXJlIHdvcnRoIHdoaWxlLgotICAgIH0KKyAgICB9IGVsc2UgaWYgKCFwcm94eSkKKyAgICAgICAg cHJveHkgPSBWOFByb3h5OjpyZXRyaWV2ZSgpOworCiAgICAgdjg6OkxvY2FsPHY4OjpPYmplY3Q+ IGluc3RhbmNlOwogICAgIGlmIChwcm94eSkKICAgICAgICAgaW5zdGFuY2UgPSBwcm94eS0+Y3Jl YXRlV3JhcHBlckZyb21DYWNoZShkZXNjcmlwdG9yVHlwZSk7Cg==