<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>27360</bug_id>
          
          <creation_ts>2009-07-16 20:28:05 -0700</creation_ts>
          <short_desc>[Chromium] Fix build with DOM_STORAGE enabled.</short_desc>
          <delta_ts>2009-07-17 00:43:52 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jeremy Orlow">jorlow</reporter>
          <assigned_to name="David Levin">levin</assigned_to>
          <cc>levin</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>132449</commentid>
    <comment_count>0</comment_count>
    <who name="Jeremy Orlow">jorlow</who>
    <bug_when>2009-07-16 20:28:05 -0700</bug_when>
    <thetext>A few small changes so Chromium builds with DOM_STORAGE enabled.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>132450</commentid>
    <comment_count>1</comment_count>
      <attachid>32912</attachid>
    <who name="Jeremy Orlow">jorlow</who>
    <bug_when>2009-07-16 20:33:54 -0700</bug_when>
    <thetext>Created attachment 32912
v1

* bindings/v8/DerivedSourcesAllInOne.cpp: Add the generated .ccp files.
* storage/StorageAreaImpl.cpp:  #include &quot;DOMWindow.h&quot;

I&apos;m sorry this didn&apos;t get attached to my previous v8 patch, but I _think_ this is the last change that needs to be made.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>132455</commentid>
    <comment_count>2</comment_count>
      <attachid>32912</attachid>
    <who name="David Levin">levin</who>
    <bug_when>2009-07-16 21:09:20 -0700</bug_when>
    <thetext>Comment on attachment 32912
v1

Two nits which I can fix up on landing.

&gt; Index: WebCore/ChangeLog
&gt; +        * bindings/v8/DerivedSourcesAllInOne.cpp: Add the generated .ccp files.
Typo: ccp

&gt; Index: WebCore/storage/StorageAreaImpl.cpp

&gt;  #include &quot;EventNames.h&quot;
&gt;  #include &quot;ExceptionCode.h&quot;
&gt; +#include &quot;DOMWindow.h&quot;
&gt;  #include &quot;Frame.h&quot;

Out of alphabetical order.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>132456</commentid>
    <comment_count>3</comment_count>
    <who name="Jeremy Orlow">jorlow</who>
    <bug_when>2009-07-16 21:15:26 -0700</bug_when>
    <thetext>Sorry about that!  I should have looked closer before uploading apparently.  :-(</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>132502</commentid>
    <comment_count>4</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2009-07-17 00:13:22 -0700</bug_when>
    <thetext>Assign to levin for landing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>132513</commentid>
    <comment_count>5</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2009-07-17 00:43:52 -0700</bug_when>
    <thetext>Committed as http://trac.webkit.org/changeset/46022</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>32912</attachid>
            <date>2009-07-16 20:33:54 -0700</date>
            <delta_ts>2009-07-16 21:09:20 -0700</delta_ts>
            <desc>v1</desc>
            <filename>v8_cleanup.v1.patch</filename>
            <type>text/plain</type>
            <size>1641</size>
            <attacher name="Jeremy Orlow">jorlow</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA0NjAwNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTUgQEAKKzIwMDktMDctMTYgIEplcmVteSBPcmxvdyAgPGpvcmxvd0BjaHJvbWl1
bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
Rml4IENocm9taXVtIGJ1aWxkIHdpdGggRE9NX1NUT1JBR0UgZW5hYmxlZC4KKyAgICAgICAgaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3MzYwCisKKyAgICAgICAgMiBt
aW5vciBjaGFuZ2VzIGFzIG5vdGVkIGJlbG93OgorCisgICAgICAgICogYmluZGluZ3MvdjgvRGVy
aXZlZFNvdXJjZXNBbGxJbk9uZS5jcHA6IEFkZCB0aGUgZ2VuZXJhdGVkIC5jY3AgZmlsZXMuCisg
ICAgICAgICogc3RvcmFnZS9TdG9yYWdlQXJlYUltcGwuY3BwOiAgI2luY2x1ZGUgIkRPTVdpbmRv
dy5oIgorCiAyMDA5LTA3LTE2ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAg
ICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgpJbmRleDogV2ViQ29yZS9iaW5kaW5ncy92
OC9EZXJpdmVkU291cmNlc0FsbEluT25lLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRp
bmdzL3Y4L0Rlcml2ZWRTb3VyY2VzQWxsSW5PbmUuY3BwCShyZXZpc2lvbiA0NjAwMSkKKysrIFdl
YkNvcmUvYmluZGluZ3MvdjgvRGVyaXZlZFNvdXJjZXNBbGxJbk9uZS5jcHAJKHdvcmtpbmcgY29w
eSkKQEAgLTE4NCw2ICsxODQsOCBAQAogI2luY2x1ZGUgImJpbmRpbmdzL1Y4U1FMUmVzdWx0U2V0
LmNwcCIKICNpbmNsdWRlICJiaW5kaW5ncy9WOFNRTFJlc3VsdFNldFJvd0xpc3QuY3BwIgogI2lu
Y2x1ZGUgImJpbmRpbmdzL1Y4U1FMVHJhbnNhY3Rpb24uY3BwIgorI2luY2x1ZGUgImJpbmRpbmdz
L1Y4U3RvcmFnZS5jcHAiCisjaW5jbHVkZSAiYmluZGluZ3MvVjhTdG9yYWdlRXZlbnQuY3BwIgog
I2luY2x1ZGUgImJpbmRpbmdzL1Y4U3R5bGVTaGVldC5jcHAiCiAjaW5jbHVkZSAiYmluZGluZ3Mv
VjhTdHlsZVNoZWV0TGlzdC5jcHAiCiAjaW5jbHVkZSAiYmluZGluZ3MvVjhTVkdBRWxlbWVudC5j
cHAiCkluZGV4OiBXZWJDb3JlL3N0b3JhZ2UvU3RvcmFnZUFyZWFJbXBsLmNwcAo9PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
Ci0tLSBXZWJDb3JlL3N0b3JhZ2UvU3RvcmFnZUFyZWFJbXBsLmNwcAkocmV2aXNpb24gNDYwMDEp
CisrKyBXZWJDb3JlL3N0b3JhZ2UvU3RvcmFnZUFyZWFJbXBsLmNwcAkod29ya2luZyBjb3B5KQpA
QCAtMzAsNiArMzAsNyBAQAogCiAjaW5jbHVkZSAiRXZlbnROYW1lcy5oIgogI2luY2x1ZGUgIkV4
Y2VwdGlvbkNvZGUuaCIKKyNpbmNsdWRlICJET01XaW5kb3cuaCIKICNpbmNsdWRlICJGcmFtZS5o
IgogI2luY2x1ZGUgIlBhZ2UuaCIKICNpbmNsdWRlICJQYWdlR3JvdXAuaCIK
</data>
<flag name="review"
          id="17261"
          type_id="1"
          status="+"
          setter="levin"
    />
          </attachment>
      

    </bug>

</bugzilla>