273569 2024-05-01 13:10:34 -0700 Added a compile time assertion that forbids classes that offer WeakPtr with no corresponding RefPtr or CheckedPtr 2024-05-01 21:29:17 -0700 1 1 1 Unclassified WebKit DOM Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ggaren dpino dpino webkit-bug-importer oldest_to_newest 2032554 0 ggaren 2024-05-01 13:10:34 -0700 https://github.com/WebKit/WebKit/pull/27847 2032556 1 ggaren 2024-05-01 13:11:49 -0700 <rdar://problem/127296969> 2032557 2 ggaren 2024-05-01 13:12:07 -0700 Pull request: https://github.com/WebKit/WebKit/pull/27847 2032558 3 ews-feeder 2024-05-01 13:15:04 -0700 Committed 278224@main (c13321a96e1d): <https://commits.webkit.org/278224@main> Reviewed commits have been landed. Closing PR #27847 and removing active labels. 2032702 4 dpino 2024-05-01 21:20:20 -0700 After this patch, the GTK-Linux-64-bit-Release-Clang-Build bot is failing with the followin build error: https://build.webkit.org/#/builders/629/builds/11538 ``` In file included from /app/webkit/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreClient.h:29: /app/webkit/Source/WebKit/UIProcess/Authentication/AuthenticationChallengeProxy.h:47:33: error: unknown type name 'nullptr_t'; did you mean 'std::nullptr_t'? using WeakPtrSecKeyProxyStore = nullptr_t; ^~~~~~~~~ std::nullptr_t /usr/lib/gcc/x86_64-unknown-linux-gnu/13.2.0/../../../../include/c++/13.2.0/x86_64-unknown-linux-gnu/bits/c++config.h:312:29: note: 'std::nullptr_t' declared here typedef decltype(nullptr) nullptr_t; ^ 1 error generated. ``` 2032703 5 dpino 2024-05-01 21:21:11 -0700 Re-opening for pull request https://github.com/webkit/webkit/pull/28034 2032704 6 ews-feeder 2024-05-01 21:29:15 -0700 Committed 278246@main (514a7d938a6c): <https://commits.webkit.org/278246@main> Reviewed commits have been landed. Closing PR #28034 and removing active labels.