<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>273556</bug_id>
          
          <creation_ts>2024-05-01 10:49:30 -0700</creation_ts>
          <short_desc>[Win] Use SystemV ABI for JIT entrypoints in YarrJIT on Windows</short_desc>
          <delta_ts>2024-06-26 14:52:11 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Windows 10</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ian Grunert">ian.grunert</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>fujii</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2032512</commentid>
    <comment_count>0</comment_count>
    <who name="Ian Grunert">ian.grunert</who>
    <bug_when>2024-05-01 10:49:30 -0700</bug_when>
    <thetext>clang-cl gives us the option of changing a function to use the SystemV ABI:

https://clang.llvm.org/docs/AttributeReference.html#sysv-abi

By using this on functions on the C++ / JIT boundaries, we can use the same codepaths for function calls and the same register mappings between Windows and Linux / Mac / BSD.

Yarr JIT is a good self-contained place to try out this change. We should be able to enable a few disabled features in Yarr JIT on Windows in the process:

YARR_JIT_ALL_PARENS_EXPRESSIONS
YARR_JIT_REGEXP_TEST_INLINE
YARR_JIT_BACKREFERENCES
YARR_JIT_BACKREFERENCES_FOR_16BIT_EXPRS</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2034032</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2024-05-08 10:50:16 -0700</bug_when>
    <thetext>&lt;rdar://problem/127751244&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2043223</commentid>
    <comment_count>2</comment_count>
    <who name="Ian Grunert">ian.grunert</who>
    <bug_when>2024-06-26 11:05:13 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/30197</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2043279</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2024-06-26 14:52:09 -0700</bug_when>
    <thetext>Committed 280393@main (778df0f67e60): &lt;https://commits.webkit.org/280393@main&gt;

Reviewed commits have been landed. Closing PR #30197 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>