<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>273553</bug_id>
          
          <creation_ts>2024-05-01 09:08:32 -0700</creation_ts>
          <short_desc>Test for parsing XML with WebCore and libxml2 in the same process</short_desc>
          <delta_ts>2024-05-03 18:19:24 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>273045</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="David Kilzer (:ddkilzer)">ddkilzer</reporter>
          <assigned_to name="David Kilzer (:ddkilzer)">ddkilzer</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2032494</commentid>
    <comment_count>0</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2024-05-01 09:08:32 -0700</bug_when>
    <thetext>Test for parsing XML with WebCore and libxml2 in the same process.

Adding a test for this fix:

    [WK1] WebKit XML parsing can deny external entity loads from other in-process libxml2 clients
    https://bugs.webkit.org/show_bug.cgi?id=273045
    &lt;rdar://126476952&gt;
    &lt;https://commits.webkit.org/278168@main&gt;

&lt;rdar://127295719&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2032496</commentid>
    <comment_count>1</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2024-05-01 09:18:11 -0700</bug_when>
    <thetext>Verified the new API test breaks (as expected) when locally reverting the fix for Bug 273045:

$ ./Tools/Scripts/run-api-tests --no-timeout --no-build --release TestWebKitAPI.XMLParsing.WebCoreDoesNotBreakLibxml2
Running tests       

OpenSource/Tools/TestWebKitAPI/Tests/WebCore/XMLParsing.mm:47
Value of: !!doc
  Actual: false
Expected: true


worker/0 TestWebKitAPI.XMLParsing.WebCoreDoesNotBreakLibxml2 Failed
Ran 1 tests of 1 with 0 successful
------------------------------
Test suite failed

Failed

    TestWebKitAPI.XMLParsing.WebCoreDoesNotBreakLibxml2
        OpenSource/Tools/TestWebKitAPI/Tests/WebCore/XMLParsing.mm:47Value of: !!doc  Actual: falseExpected: true</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2032514</commentid>
    <comment_count>2</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2024-05-01 11:02:06 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/27989</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2032764</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2024-05-02 06:14:51 -0700</bug_when>
    <thetext>Committed 278253@main (8130984fb356): &lt;https://commits.webkit.org/278253@main&gt;

Reviewed commits have been landed. Closing PR #27989 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2033144</commentid>
    <comment_count>4</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2024-05-03 12:49:25 -0700</bug_when>
    <thetext>Re-opening for pull request https://github.com/WebKit/WebKit/pull/28118</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2033235</commentid>
    <comment_count>5</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2024-05-03 18:19:22 -0700</bug_when>
    <thetext>Committed 278359@main (a759149fe1d9): &lt;https://commits.webkit.org/278359@main&gt;

Reviewed commits have been landed. Closing PR #28118 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>