27352 2009-07-16 14:36:04 -0700 Video size sometimes jumps just after the video starts loading 2009-07-16 18:33:04 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser eric.carlson oldest_to_newest 132346 0 simon.fraser 2009-07-16 14:36:04 -0700 With hardware-accelerated video, sometimes the size jumps just after the video starts loading. It's an ordering problem where we end up creating the video rendering before the intrinsic size is known. 132347 1 32893 simon.fraser 2009-07-16 14:39:52 -0700 Created attachment 32893 Patch, changelog 132348 2 32893 darin 2009-07-16 14:41:29 -0700 Comment on attachment 32893 Patch, changelog > + bool readyForRendering() const; I think it would be slightly better to call this isReadyForRendering for two reasons. 1) "ready" is verb as well as an adjective. 2) Without the "is", the function seems like it might be the caller saying we are ready, rather than asking. r=me 132436 3 simon.fraser 2009-07-16 18:33:04 -0700 http://trac.webkit.org/changeset/45986 32893 2009-07-16 14:39:52 -0700 2009-07-16 14:41:28 -0700 Patch, changelog 27352_patch.txt text/plain 3115 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OWUyNGE3Mi4uNzVkNDFmYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAwOS0wNy0xNiAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBWaWRlbyBzaXplIHNvbWV0aW1lcyBqdW1wcyBqdXN0IGFmdGVy IHRoZSB2aWRlbyBzdGFydHMgbG9hZGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjczNTIKKworICAgICAgICBFbnN1cmUgdGhhdCB0aGUgbWVkaWEg cGxheWVyIGlzIGF0IG9yIGFmdGVyIHRoZSAnSGF2ZU1ldGFkYXRhJyBzdGF0ZSBzbyB0aGF0Cisg ICAgICAgIHRoZSBpbnN0cmluc2ljIHNpemUgaXMga25vd24gYmVmb3JlIHdlIGNyZWF0ZSB0aGUg bGF5ZXIgZm9yIHZpZGVvLiBUaGlzIGF2b2lkcworICAgICAgICBhIGZsYXNoIGNhdXNlZCBieSBj b21wdXRpbmcgdGhlIHZpZGVvIHJlY3QgdXNpbmcgdGhlIGRlZmF1bHQgaW50cmluc2ljIHNpemUs IGFuZCB0aGVuCisgICAgICAgIHJlLWNvbXB1dGluZyBpdCB3aGVuIHRoYXQgc2l6ZSBjaGFuZ2Vz LgorICAgICAgICAKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9tYWMvTWVkaWFQbGF5ZXJQ cml2YXRlUVRLaXQuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9tYWMvTWVkaWFQbGF5 ZXJQcml2YXRlUVRLaXQubW06CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGU6 OnJlYWR5Rm9yUmVuZGVyaW5nKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0 ZTo6dXBkYXRlU3RhdGVzKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZTo6 c3VwcG9ydHNBY2NlbGVyYXRlZFJlbmRlcmluZyk6CisKIDIwMDktMDctMTYgIEJyYWR5IEVpZHNv biAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFudHRpIEtvaXZp c3RvLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvTWVkaWFQbGF5 ZXJQcml2YXRlUVRLaXQuaCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL01lZGlhUGxh eWVyUHJpdmF0ZVFUS2l0LmgKaW5kZXggM2RhMDhiMS4uNDIwOTMzZiAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvTWVkaWFQbGF5ZXJQcml2YXRlUVRLaXQuaAorKysg Yi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9NZWRpYVBsYXllclByaXZhdGVRVEtpdC5o CkBAIC0xNTgsNiArMTU4LDggQEAgcHJpdmF0ZToKICAgICB2b2lkIGNhY2hlTW92aWVTY2FsZSgp OwogICAgIGJvb2wgbWV0YURhdGFBdmFpbGFibGUoKSBjb25zdCB7IHJldHVybiBtX3F0TW92aWUg JiYgbV9yZWFkeVN0YXRlID49IE1lZGlhUGxheWVyOjpIYXZlTWV0YWRhdGE7IH0KIAorICAgIGJv b2wgcmVhZHlGb3JSZW5kZXJpbmcoKSBjb25zdDsKKyAgICAKICAgICBNZWRpYVBsYXllciogbV9w bGF5ZXI7CiAgICAgUmV0YWluUHRyPFFUTW92aWU+IG1fcXRNb3ZpZTsKICAgICBSZXRhaW5QdHI8 UVRNb3ZpZVZpZXc+IG1fcXRNb3ZpZVZpZXc7CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL21hYy9NZWRpYVBsYXllclByaXZhdGVRVEtpdC5tbSBiL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvbWFjL01lZGlhUGxheWVyUHJpdmF0ZVFUS2l0Lm1tCmluZGV4IDQxZGY2ZTMu LmE1ZDA5M2UgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL01lZGlh UGxheWVyUHJpdmF0ZVFUS2l0Lm1tCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFj L01lZGlhUGxheWVyUHJpdmF0ZVFUS2l0Lm1tCkBAIC04NDAsNiArODQwLDExIEBAIHZvaWQgTWVk aWFQbGF5ZXJQcml2YXRlOjpjYWNoZU1vdmllU2NhbGUoKQogICAgICAgICBtX3NjYWxlRmFjdG9y LnNldEhlaWdodChpbml0aWFsU2l6ZS5oZWlnaHQgLyBuYXR1cmFsU2l6ZS5oZWlnaHQpOwogfQog Citib29sIE1lZGlhUGxheWVyUHJpdmF0ZTo6cmVhZHlGb3JSZW5kZXJpbmcoKSBjb25zdAorewor ICAgIHJldHVybiBtX3JlYWR5U3RhdGUgPj0gTWVkaWFQbGF5ZXI6OkhhdmVNZXRhZGF0YSAmJiBt X3BsYXllci0+dmlzaWJsZSgpOworfQorCiB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZTo6dXBkYXRl U3RhdGVzKCkKIHsKICAgICBNZWRpYVBsYXllcjo6TmV0d29ya1N0YXRlIG9sZE5ldHdvcmtTdGF0 ZSA9IG1fbmV0d29ya1N0YXRlOwpAQCAtOTI4LDcgKzkzMyw3IEBAIHZvaWQgTWVkaWFQbGF5ZXJQ cml2YXRlOjp1cGRhdGVTdGF0ZXMoKQogICAgICAgICB9CiAgICAgfQogCi0gICAgaWYgKGxvYWRT dGF0ZSA+PSBRVE1vdmllTG9hZFN0YXRlTG9hZGVkICYmICFoYXNTZXRVcFZpZGVvUmVuZGVyaW5n KCkgJiYgbV9wbGF5ZXItPnZpc2libGUoKSkKKyAgICBpZiAocmVhZHlGb3JSZW5kZXJpbmcoKSAm JiAhaGFzU2V0VXBWaWRlb1JlbmRlcmluZygpKQogICAgICAgICBzZXRVcFZpZGVvUmVuZGVyaW5n KCk7CiAKICAgICBpZiAoc2Vla2luZygpKQpAQCAtMTM0MCw3ICsxMzQ1LDcgQEAgdm9pZCBNZWRp YVBsYXllclByaXZhdGU6OnNhd1Vuc3VwcG9ydGVkVHJhY2tzKCkKIGJvb2wgTWVkaWFQbGF5ZXJQ cml2YXRlOjpzdXBwb3J0c0FjY2VsZXJhdGVkUmVuZGVyaW5nKCkgY29uc3QKIHsKICAgICAvLyBX aGVuIGluIHRoZSBtZWRpYSBkb2N1bWVudCB3ZSByZW5kZXIgdmlhIFFUTW92aWVWaWV3LCB3aGlj aCBpcyBhbHJlYWR5IGFjY2VsZXJhdGVkLgotICAgIHJldHVybiBnZXRRVE1vdmllTGF5ZXJDbGFz cygpICE9IE5pbCAmJiAhbV9wbGF5ZXItPmluTWVkaWFEb2N1bWVudCgpOworICAgIHJldHVybiBy ZWFkeUZvclJlbmRlcmluZygpICYmIGdldFFUTW92aWVMYXllckNsYXNzKCkgIT0gTmlsICYmICFt X3BsYXllci0+aW5NZWRpYURvY3VtZW50KCk7CiB9CiAKIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRl OjphY2NlbGVyYXRlZFJlbmRlcmluZ1N0YXRlQ2hhbmdlZCgpCg==