273485 2024-04-30 03:34:56 -0700 [Skia] Test svg/dom/SVGGeometry-circle.xhtml is failing 2024-05-31 06:20:38 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar, LayoutTestFailure P2 Normal --- 268972 1 cgarcia webkit-unassigned bugs-noreply plampe webkit-bug-importer oldest_to_newest 2032186 0 cgarcia 2024-04-30 03:34:56 -0700 See https://ews-build.s3-us-west-2.amazonaws.com/GTK-WK2-Tests-EWS/6a6b31b3-47907/svg/dom/SVGGeometry-circle-pretty-diff.html I think we could just update the thresholds 2033693 1 webkit-bug-importer 2024-05-07 03:35:16 -0700 <rdar://problem/127659132> 2038991 2 plampe 2024-05-31 02:08:25 -0700 Pull request: https://github.com/WebKit/WebKit/pull/29365 2038992 3 plampe 2024-05-31 02:10:30 -0700 As discussed offline, just updating the thresholds would be enough unless the: imported/w3c/web-platform-tests/css/motion/offset-path-shape-circle-003.html imported/w3c/web-platform-tests/css/motion/offset-path-shape-circle-007.html layout tests would not suffer from the same lack-of-precision issue. It turns out the above test cases run the codepaths such as: 1 0x7f3e4a0c8e6f WTFCrash 2 0x7f3e4df2c27d WebCore::PathSkia::applyElements(WTF::Function<void (WebCore::PathElement const&)> const&) const 3 0x7f3e4ddf56a2 WebCore::Path::length() const 4 0x7f3e4e0cf9b0 WebCore::MotionPath::applyMotionPathTransform(WebCore::TransformationMatrix&, WebCore::TransformOperationData const&, WebCore::FloatPoint const&, WebCore::PathOperation const&, WebCore::LengthPoint const&, WebCore::Length const&, WebCore::OffsetRotation const&, WebCore::TransformBox) 5 0x7f3e4e0cfcf1 WebCore::MotionPath::applyMotionPathTransform(WebCore::RenderStyle const&, WebCore::TransformOperationData const&, WebCore::TransformationMatrix&) 6 0x7f3e4e30d766 WebCore::RenderStyle::applyCSSTransform(WebCore::TransformationMatrix&, WebCore::TransformOperationData const&, WTF::OptionSet<WebCore::RenderStyle::TransformOperationOption>) const 7 0x7f3e4e30d9b2 WebCore::RenderStyle::applyTransform(WebCore::TransformationMatrix&, WebCore::TransformOperationData const&, WTF::OptionSet<WebCore::RenderStyle::TransformOperationOption>) const 8 0x7f3e4e0d8bcf WebCore::RenderBox::applyTransform(WebCore::TransformationMatrix&, WebCore::RenderStyle const&, WebCore::FloatRect const&, WTF::OptionSet<WebCore::RenderStyle::TransformOperationOption>) const 9 0x7f3e4e1a0456 WebCore::RenderLayer::updateTransformFromStyle(WebCore::TransformationMatrix&, WebCore::RenderStyle const&, WTF::OptionSet<WebCore::RenderStyle::TransformOperationOption>) const 10 0x7f3e4e1aa164 WebCore::RenderLayer::updateTransform() 11 0x7f3e4e0e5730 WebCore::RenderBlock::updateDescendantTransformsAfterLayout() 12 0x7f3e4e140b0c WebCore::RenderBlockFlow::layoutBlock(bool, WebCore::LayoutUnit) 13 0x7f3e4e0f7e1a WebCore::RenderBlock::layout() 14 0x7f3e4e13090e WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox&, WebCore::RenderBlockFlow::MarginInfo&, WebCore::LayoutUnit&, WebCore::LayoutUnit&) 15 0x7f3e4e13e656 WebCore::RenderBlockFlow::layoutBlockChildren(bool, WebCore::LayoutUnit&) 16 0x7f3e4e140354 WebCore::RenderBlockFlow::layoutInFlowChildren(bool, WebCore::LayoutUnit&, WebCore::LayoutUnit&, WebCore::LayoutUnit&) 17 0x7f3e4e1409ef WebCore::RenderBlockFlow::layoutBlock(bool, WebCore::LayoutUnit) 18 0x7f3e4e0f7e1a WebCore::RenderBlock::layout() 19 0x7f3e4e13090e WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox&, WebCore::RenderBlockFlow::MarginInfo&, WebCore::LayoutUnit&, WebCore::LayoutUnit&) 20 0x7f3e4e13e656 WebCore::RenderBlockFlow::layoutBlockChildren(bool, WebCore::LayoutUnit&) 21 0x7f3e4e140354 WebCore::RenderBlockFlow::layoutInFlowChildren(bool, WebCore::LayoutUnit&, WebCore::LayoutUnit&, WebCore::LayoutUnit&) 22 0x7f3e4e1409ef WebCore::RenderBlockFlow::layoutBlock(bool, WebCore::LayoutUnit) 23 0x7f3e4e0f7e1a WebCore::RenderBlock::layout() 24 0x7f3e4e13090e WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox&, WebCore::RenderBlockFlow::MarginInfo&, WebCore::LayoutUnit&, WebCore::LayoutUnit&) 25 0x7f3e4e13e656 WebCore::RenderBlockFlow::layoutBlockChildren(bool, WebCore::LayoutUnit&) 26 0x7f3e4e140354 WebCore::RenderBlockFlow::layoutInFlowChildren(bool, WebCore::LayoutUnit&, WebCore::LayoutUnit&, WebCore::LayoutUnit&) 27 0x7f3e4e1409ef WebCore::RenderBlockFlow::layoutBlock(bool, WebCore::LayoutUnit) 28 0x7f3e4e0f7e1a WebCore::RenderBlock::layout() 29 0x7f3e4e2a6fcb WebCore::RenderView::layout() 30 0x7f3e4db71cd5 WebCore::LocalFrameViewLayoutContext::performLayout() 31 0x7f3e4db72270 WebCore::LocalFrameViewLayoutContext::layout() that require more precision anyway. 2039024 4 ews-feeder 2024-05-31 06:20:36 -0700 Committed 279573@main (9482ee7698d4): <https://commits.webkit.org/279573@main> Reviewed commits have been landed. Closing PR #29365 and removing active labels.