<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>27342</bug_id>
          
          <creation_ts>2009-07-16 03:11:36 -0700</creation_ts>
          <short_desc>Allow custom memory allocation control for OpaqueJSPropertyNameArray struct</short_desc>
          <delta_ts>2009-07-25 15:14:21 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Zoltan Horvath">zoltan</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>132217</commentid>
    <comment_count>0</comment_count>
    <who name="Zoltan Horvath">zoltan</who>
    <bug_when>2009-07-16 03:11:36 -0700</bug_when>
    <thetext>Inherits OpaqueJSPropertyNameArray struct from FastAllocBase because it has been instantiated by &apos;new&apos; JavaScriptCore/API/JSObjectRef.cpp:473.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>132218</commentid>
    <comment_count>1</comment_count>
      <attachid>32850</attachid>
    <who name="Zoltan Horvath">zoltan</who>
    <bug_when>2009-07-16 03:13:15 -0700</bug_when>
    <thetext>Created attachment 32850
proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>133249</commentid>
    <comment_count>2</comment_count>
      <attachid>32850</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-07-20 15:08:23 -0700</bug_when>
    <thetext>Comment on attachment 32850
proposed patch

Seems fine to me.  Whoever lands this needs to make sure to build and run tests
(&quot;bugzilla-tool land-patches 27342&quot; will do that for you).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>134015</commentid>
    <comment_count>3</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2009-07-22 21:36:24 -0700</bug_when>
    <thetext>I&apos;m going to try one of these again.  Eric, always pimping the bugzilla-tool.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>134016</commentid>
    <comment_count>4</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2009-07-22 22:02:46 -0700</bug_when>
    <thetext>I have no idea why, but these patches don&apos;t agree with my machine.  History suggests that other people won&apos;t have trouble with the patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>134778</commentid>
    <comment_count>5</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2009-07-25 15:13:39 -0700</bug_when>
    <thetext>Ok.  I&apos;m going to live on the edge and give this one to the bots.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>134779</commentid>
    <comment_count>6</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2009-07-25 15:14:21 -0700</bug_when>
    <thetext>Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	JavaScriptCore/API/JSObjectRef.cpp
	M	JavaScriptCore/ChangeLog
Committed r46401
	M	JavaScriptCore/API/JSObjectRef.cpp
	M	JavaScriptCore/ChangeLog
r46401 = 8bdbc6b4591eee273bddec9d2fa419147fec5a56 (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/46401</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>32850</attachid>
            <date>2009-07-16 03:13:15 -0700</date>
            <delta_ts>2009-07-20 15:08:29 -0700</delta_ts>
            <desc>proposed patch</desc>
            <filename>OpaqueJSPropertyNameArray.patch</filename>
            <type>text/plain</type>
            <size>1231</size>
            <attacher name="Zoltan Horvath">zoltan</attacher>
            
              <data encoding="base64">SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ1OTY4KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDctMTYgIFpvbHRhbiBI
b3J2YXRoICA8aHpvbHRhbkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWxsb3cgY3VzdG9tIG1lbW9yeSBhbGxvY2F0aW9u
IGNvbnRyb2wgZm9yIE9wYXF1ZUpTUHJvcGVydHlOYW1lQXJyYXkgc3RydWN0CisgICAgICAgIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzM0MgorCisgICAgICAgIElu
aGVyaXRzIE9wYXF1ZUpTUHJvcGVydHlOYW1lQXJyYXkgc3RydWN0IGZyb20gRmFzdEFsbG9jQmFz
ZSBiZWNhdXNlIGl0IGhhcyBiZWVuCisgICAgICAgIGluc3RhbnRpYXRlZCBieSAnbmV3JyBKYXZh
U2NyaXB0Q29yZS9BUEkvSlNPYmplY3RSZWYuY3BwOjQ3My4KKworICAgICAgICAqIEFQSS9KU09i
amVjdFJlZi5jcHA6CisKIDIwMDktMDctMTUgIFN0ZXZlIEZhbGtlbmJ1cmcgIDxzZmFsa2VuQGFw
cGxlLmNvbT4KIAogICAgICAgICBXaW5kb3dzIEJ1aWxkIGZpeC4KSW5kZXg6IEphdmFTY3JpcHRD
b3JlL0FQSS9KU09iamVjdFJlZi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvQVBJ
L0pTT2JqZWN0UmVmLmNwcAkocmV2aXNpb24gNDU5NjgpCisrKyBKYXZhU2NyaXB0Q29yZS9BUEkv
SlNPYmplY3RSZWYuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NDksNyArNDQ5LDcgQEAgSlNPYmpl
Y3RSZWYgSlNPYmplY3RDYWxsQXNDb25zdHJ1Y3RvcihKUwogICAgIHJldHVybiByZXN1bHQ7CiB9
CiAKLXN0cnVjdCBPcGFxdWVKU1Byb3BlcnR5TmFtZUFycmF5IHsKK3N0cnVjdCBPcGFxdWVKU1By
b3BlcnR5TmFtZUFycmF5IDogRmFzdEFsbG9jQmFzZSB7CiAgICAgT3BhcXVlSlNQcm9wZXJ0eU5h
bWVBcnJheShKU0dsb2JhbERhdGEqIGdsb2JhbERhdGEpCiAgICAgICAgIDogcmVmQ291bnQoMCkK
ICAgICAgICAgLCBnbG9iYWxEYXRhKGdsb2JhbERhdGEpCg==
</data>
<flag name="review"
          id="17206"
          type_id="1"
          status="+"
          setter="eric"
    />
          </attachment>
      

    </bug>

</bugzilla>