<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>27336</bug_id>
          
          <creation_ts>2009-07-16 01:17:48 -0700</creation_ts>
          <short_desc>Allow custom memory allocation control in JavaScriptCore&apos;s CodeBlock.h</short_desc>
          <delta_ts>2009-07-16 16:29:02 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Zoltan Horvath">zoltan</reporter>
          <assigned_to name="Adam Barth">abarth</assigned_to>
          <cc>abarth</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>132189</commentid>
    <comment_count>0</comment_count>
    <who name="Zoltan Horvath">zoltan</who>
    <bug_when>2009-07-16 01:17:48 -0700</bug_when>
    <thetext>Inherits ExceptionInfo and RareData struct from FastAllocBase because these have been instantiated by &apos;new&apos; in JavaScriptCore/bytecode/CodeBlock.cpp:1289 and in JavaScriptCore/bytecode/CodeBlock.h:453.

Remove unnecessary WTF:: namespace from CodeBlock class&apos; inheritance.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>132191</commentid>
    <comment_count>1</comment_count>
      <attachid>32842</attachid>
    <who name="Zoltan Horvath">zoltan</who>
    <bug_when>2009-07-16 01:21:21 -0700</bug_when>
    <thetext>Created attachment 32842
proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>132198</commentid>
    <comment_count>2</comment_count>
      <attachid>32842</attachid>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2009-07-16 01:32:18 -0700</bug_when>
    <thetext>Comment on attachment 32842
proposed patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>132389</commentid>
    <comment_count>3</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2009-07-16 16:13:59 -0700</bug_when>
    <thetext>Will land.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>132394</commentid>
    <comment_count>4</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2009-07-16 16:29:02 -0700</bug_when>
    <thetext>Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	JavaScriptCore/ChangeLog
	M	JavaScriptCore/bytecode/CodeBlock.h
Committed r45995
	M	WebKitTools/ChangeLog
r45994 = a6577d576b13e9c0253cd6db6b26ee9a682a40d4 (trunk)
	M	JavaScriptCore/ChangeLog
	M	JavaScriptCore/bytecode/CodeBlock.h
r45995 = 74f1264acb9a12a6f5d2df14fc16583f6e71dd79 (trunk)
First, rewinding head to replay your work on top of it...
Nothing to do.
http://trac.webkit.org/changeset/45995</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>32842</attachid>
            <date>2009-07-16 01:21:21 -0700</date>
            <delta_ts>2009-07-16 01:32:18 -0700</delta_ts>
            <desc>proposed patch</desc>
            <filename>CB.patch</filename>
            <type>text/plain</type>
            <size>1900</size>
            <attacher name="Zoltan Horvath">zoltan</attacher>
            
              <data encoding="base64">SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ1OTY3KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDktMDctMTYgIFpvbHRhbiBI
b3J2YXRoICA8aHpvbHRhbkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWxsb3cgY3VzdG9tIG1lbW9yeSBhbGxvY2F0aW9u
IGNvbnRyb2wgaW4gRXhjZXB0aW9uSW5mbyBhbmQgUmFyZURhdGEgc3RydWN0CisgICAgICAgIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzMzNgorCisgICAgICAgIElu
aGVyaXRzIEV4Y2VwdGlvbkluZm8gYW5kIFJhcmVEYXRhIHN0cnVjdCBmcm9tIEZhc3RBbGxvY0Jh
c2UgYmVjYXVzZSB0aGVzZQorICAgICAgICBoYXZlIGJlZW4gaW5zdGFudGlhdGVkIGJ5ICduZXcn
IGluIEphdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5jcHA6MTI4OSBhbmQKKyAgICAg
ICAgaW4gSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmg6NDUzLgorCisgICAgICAg
IFJlbW92ZSB1bm5lY2Vzc2FyeSBXVEY6OiBuYW1lc3BhY2UgZnJvbSBDb2RlQmxvY2sgaW5oZXJp
dGFuY2UuCisgCisgICAgICAgICogYnl0ZWNvZGUvQ29kZUJsb2NrLmg6CisKIDIwMDktMDctMTUg
IFN0ZXZlIEZhbGtlbmJ1cmcgIDxzZmFsa2VuQGFwcGxlLmNvbT4KIAogICAgICAgICBXaW5kb3dz
IEJ1aWxkIGZpeC4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5oCj09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5oCShyZXZpc2lv
biA0NTk2NykKKysrIEphdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5oCSh3b3JraW5n
IGNvcHkpCkBAIC0yMjEsNyArMjIxLDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgfQogI2VuZGlm
CiAKLSAgICBjbGFzcyBDb2RlQmxvY2sgOiBwdWJsaWMgV1RGOjpGYXN0QWxsb2NCYXNlIHsKKyAg
ICBjbGFzcyBDb2RlQmxvY2sgOiBwdWJsaWMgRmFzdEFsbG9jQmFzZSB7CiAgICAgICAgIGZyaWVu
ZCBjbGFzcyBKSVQ7CiAgICAgcHVibGljOgogICAgICAgICBDb2RlQmxvY2soU2NvcGVOb2RlKiBv
d25lck5vZGUpOwpAQCAtNDkzLDcgKzQ5Myw3IEBAIG5hbWVzcGFjZSBKU0MgewogCiAgICAgICAg
IFN5bWJvbFRhYmxlIG1fc3ltYm9sVGFibGU7CiAKLSAgICAgICAgc3RydWN0IEV4Y2VwdGlvbklu
Zm8geworICAgICAgICBzdHJ1Y3QgRXhjZXB0aW9uSW5mbyA6IEZhc3RBbGxvY0Jhc2UgewogICAg
ICAgICAgICAgVmVjdG9yPEV4cHJlc3Npb25SYW5nZUluZm8+IG1fZXhwcmVzc2lvbkluZm87CiAg
ICAgICAgICAgICBWZWN0b3I8TGluZUluZm8+IG1fbGluZUluZm87CiAgICAgICAgICAgICBWZWN0
b3I8R2V0QnlJZEV4Y2VwdGlvbkluZm8+IG1fZ2V0QnlJZEV4Y2VwdGlvbkluZm87CkBAIC01MDQs
NyArNTA0LDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIH07CiAgICAgICAgIE93blB0cjxF
eGNlcHRpb25JbmZvPiBtX2V4Y2VwdGlvbkluZm87CiAKLSAgICAgICAgc3RydWN0IFJhcmVEYXRh
IHsKKyAgICAgICAgc3RydWN0IFJhcmVEYXRhIDogRmFzdEFsbG9jQmFzZSB7CiAgICAgICAgICAg
ICBWZWN0b3I8SGFuZGxlckluZm8+IG1fZXhjZXB0aW9uSGFuZGxlcnM7CiAKICAgICAgICAgICAg
IC8vIFJhcmUgQ29uc3RhbnRzCg==
</data>
<flag name="review"
          id="17199"
          type_id="1"
          status="+"
          setter="oliver"
    />
          </attachment>
      

    </bug>

</bugzilla>