27327 2009-07-15 19:21:21 -0700 [Chromium] Clean up v8 bindings a bit 2009-07-17 18:43:58 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jorlow jorlow ager dglazkov fishd pfeldman oldest_to_newest 132122 0 jorlow 2009-07-15 19:21:21 -0700 The DOMWindow::*Storage functions currently return 0 in some cases. Currently, the v8 bindings will just wrap the NULL/0 with a Storage object. Given that 0 is returned when *Storage is "unavailable" it makes more sense to return Undefined. Pavel: Can you please look at the ScriptObjectQuarantine part, please? 132136 1 32831 jorlow 2009-07-15 21:41:57 -0700 Created attachment 32831 v1 The DOMWindow::*Storage functions currently return 0 in some cases. Currently, the v8 bindings will just wrap the NULL/0 with a Storage object. Given that 0 is returned when *Storage is "unavailable" it makes more sense to return Undefined. Pavel: Can you please look at the ScriptObjectQuarantine part, please? 132146 2 fishd 2009-07-15 22:15:16 -0700 This change looks good to me, but I'd like Mads or Dimitri to OK it too. 132151 3 ager 2009-07-15 22:52:53 -0700 In the ScriptObjectQuarantine part you need to make sure to enter the right context for creating the wrapper object. You have the frame and from there you can get the context that you have to enter before creating the wrapper. Just follow the pattern in the other methods. With that change, this looks good to me as well. 132152 4 jorlow 2009-07-15 22:54:36 -0700 Actually, now I'm not so sure about the DOMWindow portion of this change. I ran 'alert(typeof window.localStorage)' and 'alert(window.localStorage)' in safari with DOMWindow::localStorage hard coded to return 0 and Safari returned 'Object' and 'null'. In other words, the way it is before this patch matches Safari. Still, if you do 'alert(typeof window.blahblahblah)' you get undefined in both Chromium and Safari. So it seems to me that if we want to pretend we know nothing about LocalStorage, we should be returning undefined. What do you guys think? 132161 5 32837 jorlow 2009-07-15 23:29:52 -0700 Created attachment 32837 v2 Made the change Mads pointed out. 132280 6 32878 jorlow 2009-07-16 09:33:30 -0700 Created attachment 32878 v2 minus DOMWindow changes This is the other possible option: Only change ScriptObjectQuarantine and leave DOMWindow as is. I'm leaning towards this patch, but both seem like fine options. 132281 7 32878 dglazkov 2009-07-16 09:34:45 -0700 Comment on attachment 32878 v2 minus DOMWindow changes I like this one better -- I was just going to suggest letting codegen do its thing. 132327 8 ager 2009-07-16 13:10:56 -0700 Will the ScriptObjectQuarantine change work? You seem to be using node to get to the context, but you don't have a node parameter here. Instead, you have the actual frame. I think you can get the context by doing V8Proxy::context(frame). 132332 9 32878 dglazkov 2009-07-16 13:24:57 -0700 Comment on attachment 32878 v2 minus DOMWindow changes Whoops. Mads is right. Actually, you should just be able to use Frame* that's being passed. 132402 10 32901 jorlow 2009-07-16 16:41:02 -0700 Created attachment 32901 rev 3 Made the change Mads suggested. Also a disclaimer that I should have made earlier: I know nothing about the Inspector, nothing about this code, and only some about the bindings in general. This stuff is definitely over my head. I'm only doing it because hitting the NOTIMPLEMENTED was blocking me from enabling DOM_STORAGE. The inspector has seemingly worked even after the previously buggy implementations, so please take a close look before you r+ it. That said, we really need to get this in before we can go much further in enabling DOM storage. 132749 11 32901 dglazkov 2009-07-17 15:59:19 -0700 Comment on attachment 32901 rev 3 ok. 132816 12 jorlow 2009-07-17 18:43:58 -0700 Landed in r46074 32831 2009-07-15 21:41:57 -0700 2009-07-15 23:29:52 -0700 v1 v8.v1.patch text/plain 3976 jorlow SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NTk2MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjQgQEAKKzIwMDktMDctMTUgIEplcmVteSBPcmxvdyAgPGpvcmxvd0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Q2xlYW51cCBET00gU3RvcmFnZSBWOCBiaW5kaW5ncy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3MzI3CisKKyAgICAgICAgVGhlIERPTVdpbmRvdzo6 KlN0b3JhZ2UgZnVuY3Rpb25zIGN1cnJlbnRseSByZXR1cm4gMCBpbiBzb21lIGNhc2VzLgorICAg ICAgICBDdXJyZW50bHksIHRoZSB2OCBiaW5kaW5ncyB3aWxsIGp1c3Qgd3JhcCB0aGUgTlVMTC8w IHdpdGggYSBTdG9yYWdlCisgICAgICAgIG9iamVjdC4gIEdpdmVuIHRoYXQgMCBpcyByZXR1cm5l ZCB3aGVuICpTdG9yYWdlIGlzICJ1bmF2YWlsYWJsZSIgaXQKKyAgICAgICAgbWFrZXMgbW9yZSBz ZW5zZSB0byByZXR1cm4gVW5kZWZpbmVkLgorCisgICAgICAgICogYmluZGluZ3MvdjgvU2NyaXB0 T2JqZWN0UXVhcmFudGluZS5jcHA6IFdyYXAgdGhlIHN0b3JhZ2Ugb2JqZWN0IHdpdGgKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYSBnZW5lcmljIG9i amVjdCBhcyBpcyBkb25lCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGVsc2V3aGVyZSBpbiB0aGUgZmlsZS4KKyAgICAgICAgKFdlYkNvcmU6OmdldFF1 YXJhbnRpbmVkU2NyaXB0T2JqZWN0KToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9jdXN0b20vVjhE T01XaW5kb3dDdXN0b20uY3BwOiBBZGQgY3VzdG9tIGhhbmRsZXJzIGZvcgorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICpzdG9yYWdlLgorICAgICAg ICAoV2ViQ29yZTo6QUNDRVNTT1JfR0VUVEVSKToKKyAgICAgICAgKiBwYWdlL0RPTVdpbmRvdy5p ZGw6IEFkZCBWOEN1c3RvbSB0byBsb2NhbFN0b3JhZ2UgYW5kIHNlc3Npb25TdG9yYWdlCisKIDIw MDktMDctMTUgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIExh eW91dCB0ZXN0IGZpeCwgcmV2ZXJ0aW5nIHByZXZpb3VzIGNoYW5nZS4KSW5kZXg6IFdlYkNvcmUv YmluZGluZ3MvdjgvU2NyaXB0T2JqZWN0UXVhcmFudGluZS5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9iaW5kaW5ncy92OC9TY3JpcHRPYmplY3RRdWFyYW50aW5lLmNwcAkocmV2aXNpb24gNDU4 ODgpCisrKyBXZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdE9iamVjdFF1YXJhbnRpbmUuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC02Niw5ICs2NiwxMyBAQCBib29sIGdldFF1YXJhbnRpbmVkU2NyaXB0 T2JqZWN0KEZyYW1lKiBmCiAgICAgQVNTRVJUKGZyYW1lKTsKICAgICBBU1NFUlQoc3RvcmFnZSk7 CiAKLSAgICAvLyBGSVhNRTogSW1wbGVtZW50IHdoZW4gRE9NIFN0b3JhZ2UgVjggYmluZGluZ3Mg YXJlIGVuYWJsZWQKKyNpZiBFTkFCTEUoRE9NX1NUT1JBR0UpCisgICAgdjg6OkhhbmRsZTx2ODo6 VmFsdWU+IHY4U3RvcmFnZSA9IFY4RE9NV3JhcHBlcjo6Y29udmVydFRvVjhPYmplY3QoVjhDbGFz c0luZGV4OjpTVE9SQUdFLCBzdG9yYWdlKTsKKyAgICBxdWFyYW50aW5lZE9iamVjdCA9IFNjcmlw dE9iamVjdCh2ODo6TG9jYWw8djg6Ok9iamVjdD4odjg6Ok9iamVjdDo6Q2FzdCgqdjhTdG9yYWdl KSkpOworI2Vsc2UKICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICBxdWFyYW50aW5lZE9i amVjdCA9IFNjcmlwdE9iamVjdCgpOworI2VuZGlmCiAgICAgcmV0dXJuIHRydWU7CiB9CiAKSW5k ZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4RE9NV2luZG93Q3VzdG9tLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOERPTVdpbmRvd0N1c3RvbS5j cHAJKHJldmlzaW9uIDQ1ODg4KQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhET01X aW5kb3dDdXN0b20uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNTMsNiArMTUzLDMwIEBAIEFDQ0VT U09SX0dFVFRFUihET01XaW5kb3dFdmVudCkKICAgICByZXR1cm4ganNFdmVudDsKIH0KIAorI2lm IEVOQUJMRShET01fU1RPUkFHRSkKK0FDQ0VTU09SX0dFVFRFUihET01XaW5kb3dMb2NhbFN0b3Jh Z2UpCit7CisgICAgSU5DX1NUQVRTKCJET00uRE9NV2luZG93LmxvY2FsU3RvcmFnZS5fZ2V0Iik7 CisgICAgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiBob2xkZXIgPSBpbmZvLkhvbGRlcigpOworICAg IERPTVdpbmRvdyogaW1wID0gVjhET01XcmFwcGVyOjpjb252ZXJ0VG9OYXRpdmVPYmplY3Q8RE9N V2luZG93PihWOENsYXNzSW5kZXg6OkRPTVdJTkRPVywgaG9sZGVyKTsKKyAgICBTdG9yYWdlKiBz dG9yYWdlID0gaW1wLT5sb2NhbFN0b3JhZ2UoKTsKKyAgICBpZiAoIXN0b3JhZ2UpCisgICAgICAg IHJldHVybiB2ODo6VW5kZWZpbmVkKCk7CisgICAgcmV0dXJuIFY4RE9NV3JhcHBlcjo6Y29udmVy dFRvVjhPYmplY3QoVjhDbGFzc0luZGV4OjpTVE9SQUdFLCBzdG9yYWdlKTsKK30KKworQUNDRVNT T1JfR0VUVEVSKERPTVdpbmRvd1Nlc3Npb25TdG9yYWdlKQoreworICAgIElOQ19TVEFUUygiRE9N LkRPTVdpbmRvdy5zZXNzaW9uU3RvcmFnZS5fZ2V0Iik7CisgICAgdjg6OkhhbmRsZTx2ODo6T2Jq ZWN0PiBob2xkZXIgPSBpbmZvLkhvbGRlcigpOworICAgIERPTVdpbmRvdyogaW1wID0gVjhET01X cmFwcGVyOjpjb252ZXJ0VG9OYXRpdmVPYmplY3Q8RE9NV2luZG93PihWOENsYXNzSW5kZXg6OkRP TVdJTkRPVywgaG9sZGVyKTsKKyAgICBTdG9yYWdlKiBzdG9yYWdlID0gaW1wLT5zZXNzaW9uU3Rv cmFnZSgpOworICAgIGlmICghc3RvcmFnZSkKKyAgICAgICAgcmV0dXJuIHY4OjpVbmRlZmluZWQo KTsKKyAgICByZXR1cm4gVjhET01XcmFwcGVyOjpjb252ZXJ0VG9WOE9iamVjdChWOENsYXNzSW5k ZXg6OlNUT1JBR0UsIHN0b3JhZ2UpOworfQorI2VuZGlmCisKIEFDQ0VTU09SX0dFVFRFUihET01X aW5kb3dDcnlwdG8pCiB7CiAgICAgLy8gRklYTUU6IEltcGxlbWVudCBtZS4KSW5kZXg6IFdlYkNv cmUvcGFnZS9ET01XaW5kb3cuaWRsCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9ET01XaW5k b3cuaWRsCShyZXZpc2lvbiA0NTg4OCkKKysrIFdlYkNvcmUvcGFnZS9ET01XaW5kb3cuaWRsCSh3 b3JraW5nIGNvcHkpCkBAIC0xNjAsOCArMTYwLDggQEAgbW9kdWxlIHdpbmRvdyB7CiAgICAgICAg ICAgICByYWlzZXMoRE9NRXhjZXB0aW9uKTsKICNlbmRpZgogI2lmIGRlZmluZWQoRU5BQkxFX0RP TV9TVE9SQUdFKSAmJiBFTkFCTEVfRE9NX1NUT1JBR0UKLSAgICAgICAgcmVhZG9ubHkgYXR0cmli dXRlIFN0b3JhZ2Ugc2Vzc2lvblN0b3JhZ2U7Ci0gICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBT dG9yYWdlIGxvY2FsU3RvcmFnZTsKKyAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIFtWOEN1c3Rv bV0gU3RvcmFnZSBzZXNzaW9uU3RvcmFnZTsKKyAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIFtW OEN1c3RvbV0gU3RvcmFnZSBsb2NhbFN0b3JhZ2U7CiAjZW5kaWYKIAogICAgICAgICAgICAgICAg ICBhdHRyaWJ1dGUgW1JlcGxhY2VhYmxlXSBDb25zb2xlIGNvbnNvbGU7Cg== 32837 2009-07-15 23:29:52 -0700 2009-07-16 09:35:05 -0700 v2 v8.v2.patch text/plain 4138 jorlow SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NTk2NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjQgQEAKKzIwMDktMDctMTUgIEplcmVteSBPcmxvdyAgPGpvcmxvd0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Q2xlYW51cCBET00gU3RvcmFnZSBWOCBiaW5kaW5ncy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3MzI3CisKKyAgICAgICAgVGhlIERPTVdpbmRvdzo6 KlN0b3JhZ2UgZnVuY3Rpb25zIGN1cnJlbnRseSByZXR1cm4gMCBpbiBzb21lIGNhc2VzLgorICAg ICAgICBDdXJyZW50bHksIHRoZSB2OCBiaW5kaW5ncyB3aWxsIGp1c3Qgd3JhcCB0aGUgTlVMTC8w IHdpdGggYSBTdG9yYWdlCisgICAgICAgIG9iamVjdC4gIEdpdmVuIHRoYXQgMCBpcyByZXR1cm5l ZCB3aGVuICpTdG9yYWdlIGlzICJ1bmF2YWlsYWJsZSIgaXQKKyAgICAgICAgbWFrZXMgbW9yZSBz ZW5zZSB0byByZXR1cm4gVW5kZWZpbmVkLgorCisgICAgICAgICogYmluZGluZ3MvdjgvU2NyaXB0 T2JqZWN0UXVhcmFudGluZS5jcHA6IFdyYXAgdGhlIHN0b3JhZ2Ugb2JqZWN0IHdpdGgKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYSBnZW5lcmljIG9i amVjdCBhcyBpcyBkb25lCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGVsc2V3aGVyZSBpbiB0aGUgZmlsZS4KKyAgICAgICAgKFdlYkNvcmU6OmdldFF1 YXJhbnRpbmVkU2NyaXB0T2JqZWN0KToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9jdXN0b20vVjhE T01XaW5kb3dDdXN0b20uY3BwOiBBZGQgY3VzdG9tIGhhbmRsZXJzIGZvcgorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICpzdG9yYWdlLgorICAgICAg ICAoV2ViQ29yZTo6QUNDRVNTT1JfR0VUVEVSKToKKyAgICAgICAgKiBwYWdlL0RPTVdpbmRvdy5p ZGw6IEFkZCBWOEN1c3RvbSB0byBsb2NhbFN0b3JhZ2UgYW5kIHNlc3Npb25TdG9yYWdlCisKIDIw MDktMDctMTUgIEFkYW0gTGFuZ2xleSAgPGFnbEBnb29nbGUuY29tPgogCiAgICAgICAgIE5vIHJl dmlldzogcmV2ZXJ0aW5nIHByZXZpb3VzIGNoYW5nZS4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3Mv djgvU2NyaXB0T2JqZWN0UXVhcmFudGluZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5k aW5ncy92OC9TY3JpcHRPYmplY3RRdWFyYW50aW5lLmNwcAkocmV2aXNpb24gNDU5NjQpCisrKyBX ZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdE9iamVjdFF1YXJhbnRpbmUuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC02Niw5ICs2NiwxNyBAQCBib29sIGdldFF1YXJhbnRpbmVkU2NyaXB0T2JqZWN0KEZy YW1lKiBmCiAgICAgQVNTRVJUKGZyYW1lKTsKICAgICBBU1NFUlQoc3RvcmFnZSk7CiAKLSAgICAv LyBGSVhNRTogSW1wbGVtZW50IHdoZW4gRE9NIFN0b3JhZ2UgVjggYmluZGluZ3MgYXJlIGVuYWJs ZWQKKyNpZiBFTkFCTEUoRE9NX1NUT1JBR0UpCisgICAgdjg6OkhhbmRsZVNjb3BlIGhhbmRsZVNj b3BlOworICAgIHY4OjpMb2NhbDx2ODo6Q29udGV4dD4gY29udGV4dCA9IFY4UHJveHk6OmNvbnRl eHQobm9kZS0+ZG9jdW1lbnQoKS0+cGFnZSgpLT5tYWluRnJhbWUoKSk7CisgICAgdjg6OkNvbnRl eHQ6OlNjb3BlIHNjb3BlKGNvbnRleHQpOworCisgICAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IHY4 U3RvcmFnZSA9IFY4RE9NV3JhcHBlcjo6Y29udmVydFRvVjhPYmplY3QoVjhDbGFzc0luZGV4OjpT VE9SQUdFLCBzdG9yYWdlKTsKKyAgICBxdWFyYW50aW5lZE9iamVjdCA9IFNjcmlwdE9iamVjdCh2 ODo6TG9jYWw8djg6Ok9iamVjdD4odjg6Ok9iamVjdDo6Q2FzdCgqdjhTdG9yYWdlKSkpOworI2Vs c2UKICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICBxdWFyYW50aW5lZE9iamVjdCA9IFNj cmlwdE9iamVjdCgpOworI2VuZGlmCiAgICAgcmV0dXJuIHRydWU7CiB9CiAKSW5kZXg6IFdlYkNv cmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4RE9NV2luZG93Q3VzdG9tLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOERPTVdpbmRvd0N1c3RvbS5jcHAJKHJldmlz aW9uIDQ1OTY0KQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhET01XaW5kb3dDdXN0 b20uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNTMsNiArMTUzLDMwIEBAIEFDQ0VTU09SX0dFVFRF UihET01XaW5kb3dFdmVudCkKICAgICByZXR1cm4ganNFdmVudDsKIH0KIAorI2lmIEVOQUJMRShE T01fU1RPUkFHRSkKK0FDQ0VTU09SX0dFVFRFUihET01XaW5kb3dMb2NhbFN0b3JhZ2UpCit7Cisg ICAgSU5DX1NUQVRTKCJET00uRE9NV2luZG93LmxvY2FsU3RvcmFnZS5fZ2V0Iik7CisgICAgdjg6 OkhhbmRsZTx2ODo6T2JqZWN0PiBob2xkZXIgPSBpbmZvLkhvbGRlcigpOworICAgIERPTVdpbmRv dyogaW1wID0gVjhET01XcmFwcGVyOjpjb252ZXJ0VG9OYXRpdmVPYmplY3Q8RE9NV2luZG93PihW OENsYXNzSW5kZXg6OkRPTVdJTkRPVywgaG9sZGVyKTsKKyAgICBTdG9yYWdlKiBzdG9yYWdlID0g aW1wLT5sb2NhbFN0b3JhZ2UoKTsKKyAgICBpZiAoIXN0b3JhZ2UpCisgICAgICAgIHJldHVybiB2 ODo6VW5kZWZpbmVkKCk7CisgICAgcmV0dXJuIFY4RE9NV3JhcHBlcjo6Y29udmVydFRvVjhPYmpl Y3QoVjhDbGFzc0luZGV4OjpTVE9SQUdFLCBzdG9yYWdlKTsKK30KKworQUNDRVNTT1JfR0VUVEVS KERPTVdpbmRvd1Nlc3Npb25TdG9yYWdlKQoreworICAgIElOQ19TVEFUUygiRE9NLkRPTVdpbmRv dy5zZXNzaW9uU3RvcmFnZS5fZ2V0Iik7CisgICAgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiBob2xk ZXIgPSBpbmZvLkhvbGRlcigpOworICAgIERPTVdpbmRvdyogaW1wID0gVjhET01XcmFwcGVyOjpj b252ZXJ0VG9OYXRpdmVPYmplY3Q8RE9NV2luZG93PihWOENsYXNzSW5kZXg6OkRPTVdJTkRPVywg aG9sZGVyKTsKKyAgICBTdG9yYWdlKiBzdG9yYWdlID0gaW1wLT5zZXNzaW9uU3RvcmFnZSgpOwor ICAgIGlmICghc3RvcmFnZSkKKyAgICAgICAgcmV0dXJuIHY4OjpVbmRlZmluZWQoKTsKKyAgICBy ZXR1cm4gVjhET01XcmFwcGVyOjpjb252ZXJ0VG9WOE9iamVjdChWOENsYXNzSW5kZXg6OlNUT1JB R0UsIHN0b3JhZ2UpOworfQorI2VuZGlmCisKIEFDQ0VTU09SX0dFVFRFUihET01XaW5kb3dDcnlw dG8pCiB7CiAgICAgLy8gRklYTUU6IEltcGxlbWVudCBtZS4KSW5kZXg6IFdlYkNvcmUvcGFnZS9E T01XaW5kb3cuaWRsCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9ET01XaW5kb3cuaWRsCShy ZXZpc2lvbiA0NTk2NCkKKysrIFdlYkNvcmUvcGFnZS9ET01XaW5kb3cuaWRsCSh3b3JraW5nIGNv cHkpCkBAIC0xNjAsOCArMTYwLDggQEAgbW9kdWxlIHdpbmRvdyB7CiAgICAgICAgICAgICByYWlz ZXMoRE9NRXhjZXB0aW9uKTsKICNlbmRpZgogI2lmIGRlZmluZWQoRU5BQkxFX0RPTV9TVE9SQUdF KSAmJiBFTkFCTEVfRE9NX1NUT1JBR0UKLSAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIFN0b3Jh Z2Ugc2Vzc2lvblN0b3JhZ2U7Ci0gICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBTdG9yYWdlIGxv Y2FsU3RvcmFnZTsKKyAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIFtWOEN1c3RvbV0gU3RvcmFn ZSBzZXNzaW9uU3RvcmFnZTsKKyAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIFtWOEN1c3RvbV0g U3RvcmFnZSBsb2NhbFN0b3JhZ2U7CiAjZW5kaWYKIAogICAgICAgICAgICAgICAgICBhdHRyaWJ1 dGUgW1JlcGxhY2VhYmxlXSBDb25zb2xlIGNvbnNvbGU7Cg== 32878 2009-07-16 09:33:30 -0700 2009-07-16 16:41:02 -0700 v2 minus DOMWindow changes v8.alt.v3.patch text/plain 1696 jorlow SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NTk2NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMDctMTUgIEplcmVteSBPcmxvdyAgPGpvcmxvd0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWRkIHY4IGltcGxlbWVudGF0aW9uIGZvciBET00gU3RvcmFnZSBTY3JpcHRPYmplY3RRdWFyYW50 aW5lLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjcz MjcKKworICAgICAgICBXcmFwIHRoZSBzdG9yYWdlIG9iamVjdCB3aXRoIGEgZ2VuZXJpYyBvYmpl Y3QgYXMgaXMgZG9uZSBlbHNld2hlcmUgaW4KKyAgICAgICAgdGhlIGZpbGUgKGJ1dCBjb250aW51 ZSB0byBoaXQgYSBOT1RJTVBMRU1FTlRFRCBpZiBET01fU1RPUkFHRSBpcyBub3QKKyAgICAgICAg ZW5hYmxlZC4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1NjcmlwdE9iamVjdFF1YXJhbnRpbmUu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6Z2V0UXVhcmFudGluZWRTY3JpcHRPYmplY3QpOgorCiAy MDA5LTA3LTE1ICBTaGluaWNoaXJvIEhhbWFqaSAgPGhhbWFqaUBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL3Y4 L1NjcmlwdE9iamVjdFF1YXJhbnRpbmUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGlu Z3MvdjgvU2NyaXB0T2JqZWN0UXVhcmFudGluZS5jcHAJKHJldmlzaW9uIDQ1OTY3KQorKysgV2Vi Q29yZS9iaW5kaW5ncy92OC9TY3JpcHRPYmplY3RRdWFyYW50aW5lLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNjYsOSArNjYsMTcgQEAgYm9vbCBnZXRRdWFyYW50aW5lZFNjcmlwdE9iamVjdChGcmFt ZSogZgogICAgIEFTU0VSVChmcmFtZSk7CiAgICAgQVNTRVJUKHN0b3JhZ2UpOwogCi0gICAgLy8g RklYTUU6IEltcGxlbWVudCB3aGVuIERPTSBTdG9yYWdlIFY4IGJpbmRpbmdzIGFyZSBlbmFibGVk CisjaWYgRU5BQkxFKERPTV9TVE9SQUdFKQorICAgIHY4OjpIYW5kbGVTY29wZSBoYW5kbGVTY29w ZTsKKyAgICB2ODo6TG9jYWw8djg6OkNvbnRleHQ+IGNvbnRleHQgPSBWOFByb3h5Ojpjb250ZXh0 KG5vZGUtPmRvY3VtZW50KCktPnBhZ2UoKS0+bWFpbkZyYW1lKCkpOworICAgIHY4OjpDb250ZXh0 OjpTY29wZSBzY29wZShjb250ZXh0KTsKKworICAgIHY4OjpIYW5kbGU8djg6OlZhbHVlPiB2OFN0 b3JhZ2UgPSBWOERPTVdyYXBwZXI6OmNvbnZlcnRUb1Y4T2JqZWN0KFY4Q2xhc3NJbmRleDo6U1RP UkFHRSwgc3RvcmFnZSk7CisgICAgcXVhcmFudGluZWRPYmplY3QgPSBTY3JpcHRPYmplY3Qodjg6 OkxvY2FsPHY4OjpPYmplY3Q+KHY4OjpPYmplY3Q6OkNhc3QoKnY4U3RvcmFnZSkpKTsKKyNlbHNl CiAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgcXVhcmFudGluZWRPYmplY3QgPSBTY3Jp cHRPYmplY3QoKTsKKyNlbmRpZgogICAgIHJldHVybiB0cnVlOwogfQogCg== 32901 2009-07-16 16:41:02 -0700 2009-07-17 15:59:19 -0700 rev 3 v8.v3.patch text/plain 1677 jorlow SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NTk2MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMDctMTUgIEplcmVteSBPcmxvdyAgPGpvcmxvd0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg IEFkZCB2OCBpbXBsZW1lbnRhdGlvbiBmb3IgRE9NIFN0b3JhZ2UgU2NyaXB0T2JqZWN0UXVhcmFu dGluZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3 MzI3CisKKyAgICAgICAgV3JhcCB0aGUgc3RvcmFnZSBvYmplY3Qgd2l0aCBhIGdlbmVyaWMgb2Jq ZWN0IGFzIGlzIGRvbmUgZWxzZXdoZXJlIGluCisgICAgICAgIHRoZSBmaWxlIChidXQgY29udGlu dWUgdG8gaGl0IGEgTk9USU1QTEVNRU5URUQgaWYgRE9NX1NUT1JBR0UgaXMgbm90CisgICAgICAg IGVuYWJsZWQuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9TY3JpcHRPYmplY3RRdWFyYW50aW5l LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmdldFF1YXJhbnRpbmVkU2NyaXB0T2JqZWN0KToKKwog MjAwOS0wNy0xNSAgRGF2aWQgTGV2aW4gIDxsZXZpbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg TGF5b3V0IHRlc3QgZml4LCByZXZlcnRpbmcgcHJldmlvdXMgY2hhbmdlLgpJbmRleDogV2ViQ29y ZS9iaW5kaW5ncy92OC9TY3JpcHRPYmplY3RRdWFyYW50aW5lLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdE9iamVjdFF1YXJhbnRpbmUuY3BwCShyZXZpc2lvbiA0 NTg4OCkKKysrIFdlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0T2JqZWN0UXVhcmFudGluZS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTY2LDkgKzY2LDE3IEBAIGJvb2wgZ2V0UXVhcmFudGluZWRTY3Jp cHRPYmplY3QoRnJhbWUqIGYKICAgICBBU1NFUlQoZnJhbWUpOwogICAgIEFTU0VSVChzdG9yYWdl KTsKIAotICAgIC8vIEZJWE1FOiBJbXBsZW1lbnQgd2hlbiBET00gU3RvcmFnZSBWOCBiaW5kaW5n cyBhcmUgZW5hYmxlZAorI2lmIEVOQUJMRShET01fU1RPUkFHRSkKKyAgICB2ODo6SGFuZGxlU2Nv cGUgaGFuZGxlU2NvcGU7CisgICAgdjg6OkxvY2FsPHY4OjpDb250ZXh0PiBjb250ZXh0ID0gVjhQ cm94eTo6Y29udGV4dChmcmFtZSk7CisgICAgdjg6OkNvbnRleHQ6OlNjb3BlIHNjb3BlKGNvbnRl eHQpOworCisgICAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IHY4U3RvcmFnZSA9IFY4RE9NV3JhcHBl cjo6Y29udmVydFRvVjhPYmplY3QoVjhDbGFzc0luZGV4OjpTVE9SQUdFLCBzdG9yYWdlKTsKKyAg ICBxdWFyYW50aW5lZE9iamVjdCA9IFNjcmlwdE9iamVjdCh2ODo6TG9jYWw8djg6Ok9iamVjdD4o djg6Ok9iamVjdDo6Q2FzdCgqdjhTdG9yYWdlKSkpOworI2Vsc2UKICAgICBBU1NFUlRfTk9UX1JF QUNIRUQoKTsKICAgICBxdWFyYW50aW5lZE9iamVjdCA9IFNjcmlwdE9iamVjdCgpOworI2VuZGlm CiAgICAgcmV0dXJuIHRydWU7CiB9CiAK