27321 2009-07-15 15:44:37 -0700 v8 bindings missing from the build 2009-07-16 17:38:11 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 atwilson levin levin oldest_to_newest 132062 0 atwilson 2009-07-15 15:44:37 -0700 In addition to being added to the .gypi files, apparently all new V8 bindings must also be added to the DerivedSourcesAllInOne.cpp file. Both V8AbstractWorker.cpp and V8SharedWorker.cpp are missing from this file, which causes link errors in Chromium when SHARED_WORKERS is enabled. 132096 1 atwilson 2009-07-15 17:05:31 -0700 Also, the vcproj files are missing the SHARED_WORKER flags and associated files. 132307 2 atwilson 2009-07-16 12:03:48 -0700 Of course, since the V8 bindings are missing, the JSC bindings were also missing. I'm chagrined to find that we manually keep parallel lists of DerivedSources files separate from the build config. Who knew? 132308 3 32885 atwilson 2009-07-16 12:04:47 -0700 Created attachment 32885 proposed patch that fixes the windows build when ENABLE_SHARED_WORKERS=true 132328 4 32885 levin 2009-07-16 13:17:26 -0700 Comment on attachment 32885 proposed patch that fixes the windows build when ENABLE_SHARED_WORKERS=true The new modes being set on: WebCore/bindings/v8/custom/V8AbstractWorkerCustom.cpp WebCore/bindings/v8/custom/V8SharedWorkerCustom.cpp Seem odd (to both of us). I'll remove them from the patch when I land it. 132329 5 levin 2009-07-16 13:18:19 -0700 Assigned to levin for landing. 132424 6 levin 2009-07-16 17:38:11 -0700 Committed as http://trac.webkit.org/changeset/45997 32885 2009-07-16 12:04:47 -0700 2009-07-16 13:17:26 -0700 proposed patch that fixes the windows build when ENABLE_SHARED_WORKERS=true patch.txt text/plain 6677 atwilson ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDJmZmVhNi4uODY4ODYwYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAwOS0wNy0xNSAgRHJldyBXaWxzb24g IDxhdHdpbHNvbkBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEFkZGVkIFNIQVJFRF9XT1JLRVIgZmxhZyB0byBXaW5kb3dzIGJ1aWxk IGZpbGVzLCBhcyB3ZWxsIGFzIGFzc29jaWF0ZWQgLmNjcC8uaCBmaWxlcy4KKyAgICAgICAgQWRk ZWQgbWlzc2luZyBWOCBiaW5kaW5ncyB0byB0aGUgQWxsSW5PbmUgZmlsZQorCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzMyMQorCisgICAgICAgICog V2ViQ29yZS52Y3Byb2ovV2ViQ29yZS52Y3Byb2o6CisgICAgICAgIEFkZGVkIG1pc3NpbmcgZmls ZXMgdG8gYnVpbGQuCisgICAgICAgICogYmluZGluZ3MvdjgvRGVyaXZlZFNvdXJjZXNBbGxJbk9u ZS5jcHA6CisgICAgICAgIEFkZGVkIG1pc3NpbmcgVjggYmluZGluZ3MgKFY4QWJzdHJhY3RXb3Jr ZXIuY3BwIGFuZCBWOFNoYXJlZFdvcmtlci5jcHApCisgICAgICAgICogRGVyaXZlZFNvdXJjZXMu Y3BwCisgICAgICAgIEFkZGVkIG1pc3NpbmcgSlMgYmluZGluZ3MgKEpTQWJzdHJhY3RXb3JrZXIu Y3BwIGFuZCBKU1NoYXJlZFdvcmtlci5jcHApCisKIDIwMDktMDctMTUgIE1hcmsgUm93ZSAgPG1y b3dlQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggdGhlIE1hYyBidWlsZC4KZGlmZiAtLWdpdCBh L1dlYkNvcmUvRGVyaXZlZFNvdXJjZXMuY3BwIGIvV2ViQ29yZS9EZXJpdmVkU291cmNlcy5jcHAK aW5kZXggNjljYzNlMy4uNDIyY2ZkOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9EZXJpdmVkU291cmNl cy5jcHAKKysrIGIvV2ViQ29yZS9EZXJpdmVkU291cmNlcy5jcHAKQEAgLTI1LDYgKzI1LDcgQEAK IAogLy8gVGhpcyBhbGwtaW4tb25lIGNwcCBmaWxlIGN1dHMgZG93biBvbiB0ZW1wbGF0ZSBibG9h dCB0byBhbGxvdyB1cyB0byBidWlsZCBvdXIgV2luZG93cyByZWxlYXNlIGJ1aWxkLgogCisjaW5j bHVkZSAiSlNBYnN0cmFjdFdvcmtlci5jcHAiCiAjaW5jbHVkZSAiSlNBdHRyLmNwcCIKICNpbmNs dWRlICJKU0JhckluZm8uY3BwIgogI2luY2x1ZGUgIkpTQ2FudmFzR3JhZGllbnQuY3BwIgpAQCAt MTcxLDYgKzE3Miw3IEBACiAjaW5jbHVkZSAiSlNSYW5nZUV4Y2VwdGlvbi5jcHAiCiAjaW5jbHVk ZSAiSlNSZWN0LmNwcCIKICNpbmNsdWRlICJKU1NjcmVlbi5jcHAiCisjaW5jbHVkZSAiSlNTaGFy ZWRXb3JrZXIuY3BwIgogI2luY2x1ZGUgIkpTU1FMRXJyb3IuY3BwIgogI2luY2x1ZGUgIkpTU1FM UmVzdWx0U2V0LmNwcCIKICNpbmNsdWRlICJKU1NRTFJlc3VsdFNldFJvd0xpc3QuY3BwIgpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9XZWJDb3JlLnZjcHJvai9XZWJDb3JlLnZjcHJvaiBiL1dlYkNvcmUv V2ViQ29yZS52Y3Byb2ovV2ViQ29yZS52Y3Byb2oKaW5kZXggNTMyYTdiNC4uNzVlM2VhOCAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9XZWJDb3JlLnZjcHJvai9XZWJDb3JlLnZjcHJvagorKysgYi9XZWJD b3JlL1dlYkNvcmUudmNwcm9qL1dlYkNvcmUudmNwcm9qCkBAIC00MTgsNiArNDE4LDU0IEBACiAJ CQkJPg0KIAkJCTwvRmlsZT4NCiAJCQk8RmlsZQ0KKwkJCQlSZWxhdGl2ZVBhdGg9IiQoV2ViS2l0 T3V0cHV0RGlyKVxvYmpcV2ViQ29yZVxEZXJpdmVkU291cmNlc1xKU0Fic3RyYWN0V29ya2VyLmNw cCINCisJCQkJPg0KKwkJCQk8RmlsZUNvbmZpZ3VyYXRpb24NCisJCQkJCU5hbWU9IkRlYnVnfFdp bjMyIg0KKwkJCQkJRXhjbHVkZWRGcm9tQnVpbGQ9InRydWUiDQorCQkJCQk+DQorCQkJCQk8VG9v bA0KKwkJCQkJCU5hbWU9IlZDQ0xDb21waWxlclRvb2wiDQorCQkJCQkvPg0KKwkJCQk8L0ZpbGVD b25maWd1cmF0aW9uPg0KKwkJCQk8RmlsZUNvbmZpZ3VyYXRpb24NCisJCQkJCU5hbWU9IlJlbGVh c2V8V2luMzIiDQorCQkJCQlFeGNsdWRlZEZyb21CdWlsZD0idHJ1ZSINCisJCQkJCT4NCisJCQkJ CTxUb29sDQorCQkJCQkJTmFtZT0iVkNDTENvbXBpbGVyVG9vbCINCisJCQkJCS8+DQorCQkJCTwv RmlsZUNvbmZpZ3VyYXRpb24+DQorCQkJCTxGaWxlQ29uZmlndXJhdGlvbg0KKwkJCQkJTmFtZT0i RGVidWdfSW50ZXJuYWx8V2luMzIiDQorCQkJCQlFeGNsdWRlZEZyb21CdWlsZD0idHJ1ZSINCisJ CQkJCT4NCisJCQkJCTxUb29sDQorCQkJCQkJTmFtZT0iVkNDTENvbXBpbGVyVG9vbCINCisJCQkJ CS8+DQorCQkJCTwvRmlsZUNvbmZpZ3VyYXRpb24+DQorCQkJCTxGaWxlQ29uZmlndXJhdGlvbg0K KwkJCQkJTmFtZT0iRGVidWdfQ2Fpcm98V2luMzIiDQorCQkJCQlFeGNsdWRlZEZyb21CdWlsZD0i dHJ1ZSINCisJCQkJCT4NCisJCQkJCTxUb29sDQorCQkJCQkJTmFtZT0iVkNDTENvbXBpbGVyVG9v bCINCisJCQkJCS8+DQorCQkJCTwvRmlsZUNvbmZpZ3VyYXRpb24+DQorCQkJCTxGaWxlQ29uZmln dXJhdGlvbg0KKwkJCQkJTmFtZT0iUmVsZWFzZV9DYWlyb3xXaW4zMiINCisJCQkJCUV4Y2x1ZGVk RnJvbUJ1aWxkPSJ0cnVlIg0KKwkJCQkJPg0KKwkJCQkJPFRvb2wNCisJCQkJCQlOYW1lPSJWQ0NM Q29tcGlsZXJUb29sIg0KKwkJCQkJLz4NCisJCQkJPC9GaWxlQ29uZmlndXJhdGlvbj4NCisJCQk8 L0ZpbGU+DQorCQkJPEZpbGUNCisJCQkJUmVsYXRpdmVQYXRoPSIkKFdlYktpdE91dHB1dERpcilc b2JqXFdlYkNvcmVcRGVyaXZlZFNvdXJjZXNcSlNBYnN0cmFjdFdvcmtlci5oIg0KKwkJCQk+DQor CQkJPC9GaWxlPg0KKwkJCTxGaWxlDQogCQkJCVJlbGF0aXZlUGF0aD0iJChXZWJLaXRPdXRwdXRE aXIpXG9ialwkKFByb2plY3ROYW1lKVxEZXJpdmVkU291cmNlc1xKU0F0dHIuY3BwIg0KIAkJCQk+ DQogCQkJCTxGaWxlQ29uZmlndXJhdGlvbg0KQEAgLTc2NzQsNiArNzcyMiw1NCBAQAogCQkJCT4N CiAJCQk8L0ZpbGU+DQogCQkJPEZpbGUNCisJCQkJUmVsYXRpdmVQYXRoPSIkKFdlYktpdE91dHB1 dERpcilcb2JqXFdlYkNvcmVcRGVyaXZlZFNvdXJjZXNcSlNTaGFyZWRXb3JrZXIuY3BwIg0KKwkJ CQk+DQorCQkJCTxGaWxlQ29uZmlndXJhdGlvbg0KKwkJCQkJTmFtZT0iRGVidWd8V2luMzIiDQor CQkJCQlFeGNsdWRlZEZyb21CdWlsZD0idHJ1ZSINCisJCQkJCT4NCisJCQkJCTxUb29sDQorCQkJ CQkJTmFtZT0iVkNDTENvbXBpbGVyVG9vbCINCisJCQkJCS8+DQorCQkJCTwvRmlsZUNvbmZpZ3Vy YXRpb24+DQorCQkJCTxGaWxlQ29uZmlndXJhdGlvbg0KKwkJCQkJTmFtZT0iUmVsZWFzZXxXaW4z MiINCisJCQkJCUV4Y2x1ZGVkRnJvbUJ1aWxkPSJ0cnVlIg0KKwkJCQkJPg0KKwkJCQkJPFRvb2wN CisJCQkJCQlOYW1lPSJWQ0NMQ29tcGlsZXJUb29sIg0KKwkJCQkJLz4NCisJCQkJPC9GaWxlQ29u ZmlndXJhdGlvbj4NCisJCQkJPEZpbGVDb25maWd1cmF0aW9uDQorCQkJCQlOYW1lPSJEZWJ1Z19J bnRlcm5hbHxXaW4zMiINCisJCQkJCUV4Y2x1ZGVkRnJvbUJ1aWxkPSJ0cnVlIg0KKwkJCQkJPg0K KwkJCQkJPFRvb2wNCisJCQkJCQlOYW1lPSJWQ0NMQ29tcGlsZXJUb29sIg0KKwkJCQkJLz4NCisJ CQkJPC9GaWxlQ29uZmlndXJhdGlvbj4NCisJCQkJPEZpbGVDb25maWd1cmF0aW9uDQorCQkJCQlO YW1lPSJEZWJ1Z19DYWlyb3xXaW4zMiINCisJCQkJCUV4Y2x1ZGVkRnJvbUJ1aWxkPSJ0cnVlIg0K KwkJCQkJPg0KKwkJCQkJPFRvb2wNCisJCQkJCQlOYW1lPSJWQ0NMQ29tcGlsZXJUb29sIg0KKwkJ CQkJLz4NCisJCQkJPC9GaWxlQ29uZmlndXJhdGlvbj4NCisJCQkJPEZpbGVDb25maWd1cmF0aW9u DQorCQkJCQlOYW1lPSJSZWxlYXNlX0NhaXJvfFdpbjMyIg0KKwkJCQkJRXhjbHVkZWRGcm9tQnVp bGQ9InRydWUiDQorCQkJCQk+DQorCQkJCQk8VG9vbA0KKwkJCQkJCU5hbWU9IlZDQ0xDb21waWxl clRvb2wiDQorCQkJCQkvPg0KKwkJCQk8L0ZpbGVDb25maWd1cmF0aW9uPg0KKwkJCTwvRmlsZT4N CisJCQk8RmlsZQ0KKwkJCQlSZWxhdGl2ZVBhdGg9IiQoV2ViS2l0T3V0cHV0RGlyKVxvYmpcV2Vi Q29yZVxEZXJpdmVkU291cmNlc1xKU1NoYXJlZFdvcmtlci5oIg0KKwkJCQk+DQorCQkJPC9GaWxl Pg0KKwkJCTxGaWxlDQogCQkJCVJlbGF0aXZlUGF0aD0iJChXZWJLaXRPdXRwdXREaXIpXG9ialwk KFByb2plY3ROYW1lKVxEZXJpdmVkU291cmNlc1xKU1NRTEVycm9yLmNwcCINCiAJCQkJPg0KIAkJ CQk8RmlsZUNvbmZpZ3VyYXRpb24NCkBAIC0yMzc5OSwxMCArMjM4OTUsMjYgQEAKIAkJCU5hbWU9 IndvcmtlcnMiDQogCQkJPg0KIAkJCTxGaWxlDQorCQkJCVJlbGF0aXZlUGF0aD0iLi5cd29ya2Vy c1xBYnN0cmFjdFdvcmtlci5jcHAiDQorCQkJCT4NCisJCQk8L0ZpbGU+DQorCQkJPEZpbGUNCisJ CQkJUmVsYXRpdmVQYXRoPSIuLlx3b3JrZXJzXEFic3RyYWN0V29ya2VyLmgiDQorCQkJCT4NCisJ CQk8L0ZpbGU+DQorCQkJPEZpbGUNCiAJCQkJUmVsYXRpdmVQYXRoPSIuLlx3b3JrZXJzXEdlbmVy aWNXb3JrZXJUYXNrLmgiDQogCQkJCT4NCiAJCQk8L0ZpbGU+DQogCQkJPEZpbGUNCisJCQkJUmVs YXRpdmVQYXRoPSIuLlx3b3JrZXJzXFNoYXJlZFdvcmtlci5jcHAiDQorCQkJCT4NCisJCQk8L0Zp bGU+DQorCQkJPEZpbGUNCisJCQkJUmVsYXRpdmVQYXRoPSIuLlx3b3JrZXJzXFNoYXJlZFdvcmtl ci5oIg0KKwkJCQk+DQorCQkJPC9GaWxlPg0KKwkJCTxGaWxlDQogCQkJCVJlbGF0aXZlUGF0aD0i Li5cd29ya2Vyc1xXb3JrZXIuY3BwIg0KIAkJCQk+DQogCQkJPC9GaWxlPg0KQEAgLTI4MDAyLDYg KzI4MTE0LDEwIEBACiAJCQkJCT4NCiAJCQkJPC9GaWxlPg0KIAkJCQk8RmlsZQ0KKwkJCQkJUmVs YXRpdmVQYXRoPSIuLlxiaW5kaW5nc1xqc1xKU0Fic3RyYWN0V29ya2VyQ3VzdG9tLmNwcCINCisJ CQkJCT4NCisJCQkJPC9GaWxlPg0KKwkJCQk8RmlsZQ0KIAkJCQkJUmVsYXRpdmVQYXRoPSIuLlxi aW5kaW5nc1xqc1xKU0F0dHJDdXN0b20uY3BwIg0KIAkJCQkJPg0KIAkJCQk8L0ZpbGU+DQpAQCAt Mjg0MjIsNiArMjg1MzgsMTggQEAKIAkJCQkJPg0KIAkJCQk8L0ZpbGU+DQogCQkJCTxGaWxlDQor CQkJCQlSZWxhdGl2ZVBhdGg9Ii4uXGJpbmRpbmdzXGpzXEpTU2hhcmVkV29ya2VyQ29uc3RydWN0 b3IuY3BwIg0KKwkJCQkJPg0KKwkJCQk8L0ZpbGU+DQorCQkJCTxGaWxlDQorCQkJCQlSZWxhdGl2 ZVBhdGg9Ii4uXGJpbmRpbmdzXGpzXEpTU2hhcmVkV29ya2VyQ29uc3RydWN0b3IuaCINCisJCQkJ CT4NCisJCQkJPC9GaWxlPg0KKwkJCQk8RmlsZQ0KKwkJCQkJUmVsYXRpdmVQYXRoPSIuLlxiaW5k aW5nc1xqc1xKU1NoYXJlZFdvcmtlckN1c3RvbS5jcHAiDQorCQkJCQk+DQorCQkJCTwvRmlsZT4N CisJCQkJPEZpbGUNCiAJCQkJCVJlbGF0aXZlUGF0aD0iLi5cYmluZGluZ3NcanNcSlNTUUxSZXN1 bHRTZXRSb3dMaXN0Q3VzdG9tLmNwcCINCiAJCQkJCT4NCiAJCQkJPC9GaWxlPg0KZGlmZiAtLWdp dCBhL1dlYkNvcmUvYmluZGluZ3MvdjgvRGVyaXZlZFNvdXJjZXNBbGxJbk9uZS5jcHAgYi9XZWJD b3JlL2JpbmRpbmdzL3Y4L0Rlcml2ZWRTb3VyY2VzQWxsSW5PbmUuY3BwCmluZGV4IGY2ZTc3YTQu LjhjNzAyY2QgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvdjgvRGVyaXZlZFNvdXJjZXNB bGxJbk9uZS5jcHAKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9EZXJpdmVkU291cmNlc0FsbElu T25lLmNwcApAQCAtMzEsNiArMzEsNyBAQAogLy8gVGhpcyBzb3VyY2UgZmlsZSBjb2FsZXNjZXMg dGhlIEhUTUwgZWxlbWVudHMgaW50byBhIHNpbmdsZSBvYmplY3QgZmlsZSB0bwogLy8gcmVkdWNl IGJsb2F0IGFuZCBhbGxvdyB1cyB0byBsaW5rIHJlbGVhc2UgYnVpbGRzIG9uIDMyLWJpdCBXaW5k b3dzLgogCisjaW5jbHVkZSAiYmluZGluZ3MvVjhBYnN0cmFjdFdvcmtlci5jcHAiCiAjaW5jbHVk ZSAiYmluZGluZ3MvVjhBdHRyLmNwcCIKICNpbmNsdWRlICJiaW5kaW5ncy9WOEJhckluZm8uY3Bw IgogI2luY2x1ZGUgImJpbmRpbmdzL1Y4Q2FudmFzR3JhZGllbnQuY3BwIgpAQCAtMTc4LDYgKzE3 OSw3IEBACiAjaW5jbHVkZSAiYmluZGluZ3MvVjhSZWN0LmNwcCIKICNpbmNsdWRlICJiaW5kaW5n cy9WOFJHQkNvbG9yLmNwcCIKICNpbmNsdWRlICJiaW5kaW5ncy9WOFNjcmVlbi5jcHAiCisjaW5j bHVkZSAiYmluZGluZ3MvVjhTaGFyZWRXb3JrZXIuY3BwIgogI2luY2x1ZGUgImJpbmRpbmdzL1Y4 U1FMRXJyb3IuY3BwIgogI2luY2x1ZGUgImJpbmRpbmdzL1Y4U1FMUmVzdWx0U2V0LmNwcCIKICNp bmNsdWRlICJiaW5kaW5ncy9WOFNRTFJlc3VsdFNldFJvd0xpc3QuY3BwIgpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhBYnN0cmFjdFdvcmtlckN1c3RvbS5jcHAgYi9X ZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEFic3RyYWN0V29ya2VyQ3VzdG9tLmNwcApvbGQg bW9kZSAxMDA2NDQKbmV3IG1vZGUgMTAwNzU1CmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdz L3Y4L2N1c3RvbS9WOFNoYXJlZFdvcmtlckN1c3RvbS5jcHAgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4 L2N1c3RvbS9WOFNoYXJlZFdvcmtlckN1c3RvbS5jcHAKb2xkIG1vZGUgMTAwNjQ0Cm5ldyBtb2Rl IDEwMDc1NQo=