27309 2009-07-15 12:00:43 -0700 Local variable in instantiateV8Object shadows function parameter 2009-07-15 22:04:10 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 jhawkins abarth abarth oldest_to_newest 131982 0 jhawkins 2009-07-15 12:00:43 -0700 v8::Local<v8::Object> V8DOMWrapper::instantiateV8Object(V8Proxy* proxy, ... ... if (!proxy) V8Proxy* proxy = V8Proxy::retrieve(); proxy is declared as a local variable in the if clause, which shadows the function parameter of the same name. This is a typo. I will attach a patch which fixes this issue. 131983 1 32797 jhawkins 2009-07-15 12:02:53 -0700 Created attachment 32797 Patch which removes the local variable 131986 2 32797 abarth 2009-07-15 12:07:00 -0700 Comment on attachment 32797 Patch which removes the local variable + No test required as this change does not affect layout. You should say that no test is required because this change does not change our behavior. The LayoutTests test much more than just layout. :) 131991 3 32800 jhawkins 2009-07-15 12:11:41 -0700 Created attachment 32800 Patch2: modified the changelog 131993 4 32800 abarth 2009-07-15 12:14:14 -0700 Comment on attachment 32800 Patch2: modified the changelog Thanks! 132140 5 abarth 2009-07-15 21:53:25 -0700 Will land. 132145 6 abarth 2009-07-15 22:04:10 -0700 Sending WebCore/ChangeLog Sending WebCore/bindings/v8/V8DOMWrapper.cpp Transmitting file data .. Committed revision 45965. 32797 2009-07-15 12:02:53 -0700 2009-07-15 12:11:41 -0700 Patch which removes the local variable removeshadow.diff text/plain 1292 jhawkins SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NTkzNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMDctMTUgIEphbWVzIEhhd2tpbnMgIDxqaGF3a2luc0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisJW1Y4XSBS ZW1vdmUgYSBsb2NhbCB2YXJpYWJsZSB0aGF0IGlzIHNoYWRvd2luZyBhIGZ1bmN0aW9uIHBhcmFt ZXRlci4KKwlodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjczMDkKKwor CU5vIHRlc3QgcmVxdWlyZWQgYXMgdGhpcyBjaGFuZ2UgZG9lcyBub3QgYWZmZWN0IGxheW91dC4K KworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHA6CisgICAgICAgIChXZWJD b3JlOjpWOERPTVdyYXBwZXI6Omluc3RhbnRpYXRlVjhPYmplY3QpOgorCiAyMDA5LTA3LTE1ICBN YXJrIFJvd2UgIDxtcm93ZUBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IHRoZSBNYWMgYnVpbGQu CkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuY3BwCShyZXZpc2lvbiA0NTkzNCkK KysrIFdlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmNwcAkod29ya2luZyBjb3B5KQpA QCAtNjkzLDggKzY5Myw2IEBAIHY4OjpMb2NhbDx2ODo6T2JqZWN0PiBWOERPTVdyYXBwZXI6Omlu c3QKICAgICBpZiAoZGVzY3JpcHRvclR5cGUgPT0gVjhDbGFzc0luZGV4OjpIVE1MQ09MTEVDVElP TiAmJiBzdGF0aWNfY2FzdDxIVE1MQ29sbGVjdGlvbio+KGltcGwpLT50eXBlKCkgPT0gRG9jQWxs KQogICAgICAgICBkZXNjcmlwdG9yVHlwZSA9IFY4Q2xhc3NJbmRleDo6SFRNTEFMTENPTExFQ1RJ T047CiAKLSAgICBpZiAoIXByb3h5KQotICAgICAgICBWOFByb3h5KiBwcm94eSA9IFY4UHJveHk6 OnJldHJpZXZlKCk7CiAgICAgaWYgKFY4SXNvbGF0ZWRXb3JsZDo6Z2V0RW50ZXJlZCgpKSB7CiAg ICAgICAgIC8vIFRoaXMgZWZmZWN0aXZlbHkgZGlzYWJsZXMgdGhlIHdyYXBwZXIgY2FjaGUgZm9y IGlzb2xhdGVkIHdvcmxkcy4KICAgICAgICAgcHJveHkgPSAwOwo= 32800 2009-07-15 12:11:41 -0700 2009-07-15 12:14:14 -0700 Patch2: modified the changelog removeshadow.diff text/plain 1312 jhawkins SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NTkzNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMDctMTUgIEphbWVzIEhhd2tpbnMgIDxqaGF3a2luc0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisJW1Y4XSBS ZW1vdmUgYSBsb2NhbCB2YXJpYWJsZSB0aGF0IGlzIHNoYWRvd2luZyBhIGZ1bmN0aW9uIHBhcmFt ZXRlci4KKwlodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjczMDkKKwor CU5vIHRlc3QgcmVxdWlyZWQgYXMgdGhpcyBtb2RpZmljYXRpb24gZG9lcyBub3QgY2hhbmdlIHRo ZSBjdXJyZW50IGJlaGF2aW9yLgorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhET01XcmFwcGVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4RE9NV3JhcHBlcjo6aW5zdGFudGlhdGVWOE9iamVj dCk6CisKIDIwMDktMDctMTUgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KIAogICAgICAg ICBGaXggdGhlIE1hYyBidWlsZC4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFw cGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5j cHAJKHJldmlzaW9uIDQ1OTM0KQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC02OTMsOCArNjkzLDYgQEAgdjg6OkxvY2FsPHY4OjpPYmpl Y3Q+IFY4RE9NV3JhcHBlcjo6aW5zdAogICAgIGlmIChkZXNjcmlwdG9yVHlwZSA9PSBWOENsYXNz SW5kZXg6OkhUTUxDT0xMRUNUSU9OICYmIHN0YXRpY19jYXN0PEhUTUxDb2xsZWN0aW9uKj4oaW1w bCktPnR5cGUoKSA9PSBEb2NBbGwpCiAgICAgICAgIGRlc2NyaXB0b3JUeXBlID0gVjhDbGFzc0lu ZGV4OjpIVE1MQUxMQ09MTEVDVElPTjsKIAotICAgIGlmICghcHJveHkpCi0gICAgICAgIFY4UHJv eHkqIHByb3h5ID0gVjhQcm94eTo6cmV0cmlldmUoKTsKICAgICBpZiAoVjhJc29sYXRlZFdvcmxk OjpnZXRFbnRlcmVkKCkpIHsKICAgICAgICAgLy8gVGhpcyBlZmZlY3RpdmVseSBkaXNhYmxlcyB0 aGUgd3JhcHBlciBjYWNoZSBmb3IgaXNvbGF0ZWQgd29ybGRzLgogICAgICAgICBwcm94eSA9IDA7 Cg==