27303 2009-07-15 09:25:01 -0700 [WINCE] implement createThreadInternal 2009-07-15 11:24:39 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 23154 0 joenotcharles webkit-unassigned manyoso staikos yong.li.webkit oldest_to_newest 131914 0 joenotcharles 2009-07-15 09:25:01 -0700 On WinCE, createThreadInternal can be implemented directly with CreateThread 131915 1 32790 joenotcharles 2009-07-15 09:27:19 -0700 Created attachment 32790 patch to ThreadingWin.cpp 131921 2 32790 manyoso 2009-07-15 09:41:46 -0700 Comment on attachment 32790 patch to ThreadingWin.cpp > +#if !PLATFORM(WINCE) > #include <process.h> > +#endif For? > +#if HAVE(ERRNO_H) > +#include <errno.h> > +#else > +#define NO_ERRNO > +#endif I'm not sure. In a previous patch to RegisterFile we were using 'GetLastError' instead of errno for WINCE. Shouldn't we do the same here? Moreover, we should create a proper WTF abstraction for ERRNO it seems. > +#if PLATFORM(WINCE) > + // This should be safe on WINCE. On Windows desktop it is not. > + HANDLE threadHandle = CreateThread(0, 0, (LPTHREAD_START_ROUTINE)wtfThreadEntryPoint, invocation, 0, (LPDWORD)&threadIdentifier); Why is it safe for WINCE, but not for desktop and what does it gain us? 131925 3 yong.li.webkit 2009-07-15 09:48:08 -0700 (In reply to comment #2) > (From update of attachment 32790 [details]) > > +#if !PLATFORM(WINCE) > > #include <process.h> > > +#endif > > For? process.h doesn't exist on WINCE > > > +#if HAVE(ERRNO_H) > > +#include <errno.h> > > +#else > > +#define NO_ERRNO > > +#endif > > I'm not sure. In a previous patch to RegisterFile we were using 'GetLastError' > instead of errno for WINCE. Shouldn't we do the same here? Moreover, we > should create a proper WTF abstraction for ERRNO it seems. I'm not sure replacing ERRNO with GetLastError is good in all cases. In this file, we can do that because the only case of using errno is after CreateThread() fails. > > > +#if PLATFORM(WINCE) > > + // This should be safe on WINCE. On Windows desktop it is not. > > + HANDLE threadHandle = CreateThread(0, 0, (LPTHREAD_START_ROUTINE)wtfThreadEntryPoint, invocation, 0, (LPDWORD)&threadIdentifier); > > Why is it safe for WINCE, but not for desktop and what does it gain us? No gain. we do this because with don't have _beginthreadex() on WINCE. 131945 4 manyoso 2009-07-15 10:24:49 -0700 (In reply to comment #3) > I'm not sure replacing ERRNO with GetLastError is good in all cases. In this > file, we can do that because the only case of using errno is after > CreateThread() fails. We should do that then. 131952 5 staikos 2009-07-15 10:44:32 -0700 (In reply to comment #4) > (In reply to comment #3) > > I'm not sure replacing ERRNO with GetLastError is good in all cases. In this > > file, we can do that because the only case of using errno is after > > CreateThread() fails. > > We should do that then. Seems like a separate bug+patch. 131954 6 32795 joenotcharles 2009-07-15 10:49:24 -0700 Created attachment 32795 Updated patch Updated the patch to call ::GetLastError on WINCE (and also leave the NO_ERRNO path in, just in case there's a different platform without errno). Also added a more detailed comment on why CreateThread is safe. 131956 7 32795 staikos 2009-07-15 10:54:30 -0700 Comment on attachment 32795 Updated patch I'm not sure that NO_ERRNO is needed anymore but I don't see the harm either. It will help in porting to other platforms I think. 131964 8 32795 manyoso 2009-07-15 11:18:47 -0700 Comment on attachment 32795 Updated patch Looks good to me too. 131965 9 manyoso 2009-07-15 11:24:39 -0700 Landed with r45931. 32790 2009-07-15 09:27:19 -0700 2009-07-15 10:49:24 -0700 patch to ThreadingWin.cpp bug27303.patch text/plain 2321 joenotcharles ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBlYzg2Y2VjLi41OTYxMjdjIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMDktMDctMTUgIEdlb3JnZSBTdGFpa29zICA8Z2VvcmdlLnN0YWlrb3NAdG9yY2htb2Jp bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzMwMworICAgICAgICBJ bXBsZW1lbnQgY3JlYXRlVGhyZWFkSW50ZXJuYWwgZm9yIFdpbkNFLgorCisgICAgICAgICogd3Rm L1RocmVhZGluZ1dpbi5jcHA6CisgICAgICAgIChXVEY6OmNyZWF0ZVRocmVhZEludGVybmFsKToK KwogMjAwOS0wNy0xNSAgSm9lIE1hc29uICA8am9lLm1hc29uQHRvcmNobW9iaWxlLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL0phdmFTY3Jp cHRDb3JlL3d0Zi9UaHJlYWRpbmdXaW4uY3BwIGIvSmF2YVNjcmlwdENvcmUvd3RmL1RocmVhZGlu Z1dpbi5jcHAKaW5kZXggZWExODY1Ni4uNWEwNTJmNiAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENv cmUvd3RmL1RocmVhZGluZ1dpbi5jcHAKKysrIGIvSmF2YVNjcmlwdENvcmUvd3RmL1RocmVhZGlu Z1dpbi5jcHAKQEAgLTEsNiArMSw3IEBACiAvKgogICogQ29weXJpZ2h0IChDKSAyMDA3LCAyMDA4 IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqIENvcHlyaWdodCAoQykgMjAwOSBH b29nbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDA5IFRv cmNoIE1vYmlsZSwgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0 aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAog ICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2lu ZyBjb25kaXRpb25zCkBAIC04OSw3ICs5MCwxNCBAQAogI2lmICFVU0UoUFRIUkVBRFMpICYmIFBM QVRGT1JNKFdJTl9PUykKICNpbmNsdWRlICJUaHJlYWRTcGVjaWZpYy5oIgogI2VuZGlmCisjaWYg IVBMQVRGT1JNKFdJTkNFKQogI2luY2x1ZGUgPHByb2Nlc3MuaD4KKyNlbmRpZgorI2lmIEhBVkUo RVJSTk9fSCkKKyNpbmNsdWRlIDxlcnJuby5oPgorI2Vsc2UKKyNkZWZpbmUgTk9fRVJSTk8KKyNl bmRpZgogI2luY2x1ZGUgPHdpbmRvd3MuaD4KICNpbmNsdWRlIDx3dGYvQ3VycmVudFRpbWUuaD4K ICNpbmNsdWRlIDx3dGYvSGFzaE1hcC5oPgpAQCAtMjEwLDkgKzIxOCwxOCBAQCBUaHJlYWRJZGVu dGlmaWVyIGNyZWF0ZVRocmVhZEludGVybmFsKFRocmVhZEZ1bmN0aW9uIGVudHJ5UG9pbnQsIHZv aWQqIGRhdGEsIGNvbgogICAgIHVuc2lnbmVkIHRocmVhZElkZW50aWZpZXIgPSAwOwogICAgIFRo cmVhZElkZW50aWZpZXIgdGhyZWFkSUQgPSAwOwogICAgIFRocmVhZEZ1bmN0aW9uSW52b2NhdGlv biogaW52b2NhdGlvbiA9IG5ldyBUaHJlYWRGdW5jdGlvbkludm9jYXRpb24oZW50cnlQb2ludCwg ZGF0YSk7CisjaWYgUExBVEZPUk0oV0lOQ0UpCisgICAgLy8gVGhpcyBzaG91bGQgYmUgc2FmZSBv biBXSU5DRS4gIE9uIFdpbmRvd3MgZGVza3RvcCBpdCBpcyBub3QuCisgICAgSEFORExFIHRocmVh ZEhhbmRsZSA9IENyZWF0ZVRocmVhZCgwLCAwLCAoTFBUSFJFQURfU1RBUlRfUk9VVElORSl3dGZU aHJlYWRFbnRyeVBvaW50LCBpbnZvY2F0aW9uLCAwLCAoTFBEV09SRCkmdGhyZWFkSWRlbnRpZmll cik7CisjZWxzZQogICAgIEhBTkRMRSB0aHJlYWRIYW5kbGUgPSByZWludGVycHJldF9jYXN0PEhB TkRMRT4oX2JlZ2ludGhyZWFkZXgoMCwgMCwgd3RmVGhyZWFkRW50cnlQb2ludCwgaW52b2NhdGlv biwgMCwgJnRocmVhZElkZW50aWZpZXIpKTsKKyNlbmRpZgogICAgIGlmICghdGhyZWFkSGFuZGxl KSB7CisjaWZkZWYgTk9fRVJSTk8KKyAgICAgICAgTE9HX0VSUk9SKCJGYWlsZWQgdG8gY3JlYXRl IHRocmVhZCBhdCBlbnRyeSBwb2ludCAlcCB3aXRoIGRhdGEgJXAuIiwgZW50cnlQb2ludCwgZGF0 YSk7CisjZWxzZQogICAgICAgICBMT0dfRVJST1IoIkZhaWxlZCB0byBjcmVhdGUgdGhyZWFkIGF0 IGVudHJ5IHBvaW50ICVwIHdpdGggZGF0YSAlcDogJWxkIiwgZW50cnlQb2ludCwgZGF0YSwgZXJy bm8pOworI2VuZGlmCiAgICAgICAgIHJldHVybiAwOwogICAgIH0KIAo= 32795 2009-07-15 10:49:24 -0700 2009-07-15 11:18:47 -0700 Updated patch bug27303.patch text/plain 2591 joenotcharles ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBlYzg2Y2VjLi41OTYxMjdjIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMDktMDctMTUgIEdlb3JnZSBTdGFpa29zICA8Z2VvcmdlLnN0YWlrb3NAdG9yY2htb2Jp bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzMwMworICAgICAgICBJ bXBsZW1lbnQgY3JlYXRlVGhyZWFkSW50ZXJuYWwgZm9yIFdpbkNFLgorCisgICAgICAgICogd3Rm L1RocmVhZGluZ1dpbi5jcHA6CisgICAgICAgIChXVEY6OmNyZWF0ZVRocmVhZEludGVybmFsKToK KwogMjAwOS0wNy0xNSAgSm9lIE1hc29uICA8am9lLm1hc29uQHRvcmNobW9iaWxlLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL0phdmFTY3Jp cHRDb3JlL3d0Zi9UaHJlYWRpbmdXaW4uY3BwIGIvSmF2YVNjcmlwdENvcmUvd3RmL1RocmVhZGlu Z1dpbi5jcHAKaW5kZXggZWExODY1Ni4uY2NjYmRhMSAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENv cmUvd3RmL1RocmVhZGluZ1dpbi5jcHAKKysrIGIvSmF2YVNjcmlwdENvcmUvd3RmL1RocmVhZGlu Z1dpbi5jcHAKQEAgLTEsNiArMSw3IEBACiAvKgogICogQ29weXJpZ2h0IChDKSAyMDA3LCAyMDA4 IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqIENvcHlyaWdodCAoQykgMjAwOSBH b29nbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDA5IFRv cmNoIE1vYmlsZSwgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0 aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAog ICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2lu ZyBjb25kaXRpb25zCkBAIC04OSw3ICs5MCwxNCBAQAogI2lmICFVU0UoUFRIUkVBRFMpICYmIFBM QVRGT1JNKFdJTl9PUykKICNpbmNsdWRlICJUaHJlYWRTcGVjaWZpYy5oIgogI2VuZGlmCisjaWYg IVBMQVRGT1JNKFdJTkNFKQogI2luY2x1ZGUgPHByb2Nlc3MuaD4KKyNlbmRpZgorI2lmIEhBVkUo RVJSTk9fSCkKKyNpbmNsdWRlIDxlcnJuby5oPgorI2Vsc2UKKyNkZWZpbmUgTk9fRVJSTk8KKyNl bmRpZgogI2luY2x1ZGUgPHdpbmRvd3MuaD4KICNpbmNsdWRlIDx3dGYvQ3VycmVudFRpbWUuaD4K ICNpbmNsdWRlIDx3dGYvSGFzaE1hcC5oPgpAQCAtMjEwLDkgKzIxOCwyMSBAQCBUaHJlYWRJZGVu dGlmaWVyIGNyZWF0ZVRocmVhZEludGVybmFsKFRocmVhZEZ1bmN0aW9uIGVudHJ5UG9pbnQsIHZv aWQqIGRhdGEsIGNvbgogICAgIHVuc2lnbmVkIHRocmVhZElkZW50aWZpZXIgPSAwOwogICAgIFRo cmVhZElkZW50aWZpZXIgdGhyZWFkSUQgPSAwOwogICAgIFRocmVhZEZ1bmN0aW9uSW52b2NhdGlv biogaW52b2NhdGlvbiA9IG5ldyBUaHJlYWRGdW5jdGlvbkludm9jYXRpb24oZW50cnlQb2ludCwg ZGF0YSk7CisjaWYgUExBVEZPUk0oV0lOQ0UpCisgICAgLy8gVGhpcyBpcyBzYWZlIG9uIFdJTkNF LCBzaW5jZSBDUlQgaXMgaW4gdGhlIGNvcmUgYW5kIGlubmF0ZWx5IG11bHRpdGhyZWFkZWQuCisg ICAgLy8gT24gZGVza3RvcCBXaW5kb3dzLCBuZWVkIHRvIHVzZSBfYmVnaW50aHJlYWRleCAobm90 IGF2YWlsYWJsZSBvbiBXaW5DRSkgaWYgdXNpbmcgYW55IENSVCBmdW5jdGlvbnMKKyAgICBIQU5E TEUgdGhyZWFkSGFuZGxlID0gQ3JlYXRlVGhyZWFkKDAsIDAsIChMUFRIUkVBRF9TVEFSVF9ST1VU SU5FKXd0ZlRocmVhZEVudHJ5UG9pbnQsIGludm9jYXRpb24sIDAsIChMUERXT1JEKSZ0aHJlYWRJ ZGVudGlmaWVyKTsKKyNlbHNlCiAgICAgSEFORExFIHRocmVhZEhhbmRsZSA9IHJlaW50ZXJwcmV0 X2Nhc3Q8SEFORExFPihfYmVnaW50aHJlYWRleCgwLCAwLCB3dGZUaHJlYWRFbnRyeVBvaW50LCBp bnZvY2F0aW9uLCAwLCAmdGhyZWFkSWRlbnRpZmllcikpOworI2VuZGlmCiAgICAgaWYgKCF0aHJl YWRIYW5kbGUpIHsKKyNpZiBQTEFURk9STShXSU5DRSkKKyAgICAgICAgTE9HX0VSUk9SKCJGYWls ZWQgdG8gY3JlYXRlIHRocmVhZCBhdCBlbnRyeSBwb2ludCAlcCB3aXRoIGRhdGEgJXA6ICVsZCIs IGVudHJ5UG9pbnQsIGRhdGEsIDo6R2V0TGFzdEVycm9yKCkpOworI2VsaWYgZGVmaW5lZChOT19F UlJOTykKKyAgICAgICAgTE9HX0VSUk9SKCJGYWlsZWQgdG8gY3JlYXRlIHRocmVhZCBhdCBlbnRy eSBwb2ludCAlcCB3aXRoIGRhdGEgJXAuIiwgZW50cnlQb2ludCwgZGF0YSk7CisjZWxzZQogICAg ICAgICBMT0dfRVJST1IoIkZhaWxlZCB0byBjcmVhdGUgdGhyZWFkIGF0IGVudHJ5IHBvaW50ICVw IHdpdGggZGF0YSAlcDogJWxkIiwgZW50cnlQb2ludCwgZGF0YSwgZXJybm8pOworI2VuZGlmCiAg ICAgICAgIHJldHVybiAwOwogICAgIH0KIAo=