27295 2009-07-15 05:46:55 -0700 The Qt DRT pops up message boxes when javascript execution takes too long 2009-07-15 05:51:54 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 26886 1 hausmann webkit-unassigned oldest_to_newest 131862 0 32779 hausmann 2009-07-15 05:46:55 -0700 Created attachment 32779 patch to re-implement shouldInterruptJavaScript() in Qt DRT Tests like fast/js/try-catch-crash.html take a long time with debug builds and the interpreter and may result in a message box popping up. Qt DRT should re-implement QWebPage::shouldInterruptJavaScript() and return false, to avoid the message boxes. The run-webkit-tests counterpart takes care of the timeout handling. 131864 1 hausmann 2009-07-15 05:51:54 -0700 Landed in r45906 32779 2009-07-15 05:46:55 -0700 2009-07-15 05:50:04 -0700 patch to re-implement shouldInterruptJavaScript() in Qt DRT patch.txt text/plain 1297 hausmann ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBiYjU0ZDk0Li5mNzJlMWY2IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDct MTUgIFNpbW9uIEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5Abm9raWEuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlLWltcGxlbWVudCBRV2Vi UGFnZTo6c2hvdWxkSW50ZXJydXB0SmF2YVNjcmlwdCB0byBkaXNhYmxlCisgICAgICAgIGpzIGlu dGVycnVwdGlvbiBhbmQgYXZvaWQgc2hvd2luZyBhIG1lc3NhZ2Vib3ggZHVyaW5nIFF0IERSVAor ICAgICAgICBydW5zIHdoZW4gc2NyaXB0IGV4ZWN1dGlvbiB0YWtlcyBhIGJpdCBsb25nZXIuCisK KyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpXZWJQYWdlOjpzaG91bGRJbnRlcnJ1cHRKYXZhU2NyaXB0KTogUmV0dXJuIGZh bHNlCisgICAgICAgIGluIHJlLWltcGxlbWVudGVkIHNsb3QuCisKIDIwMDktMDctMTUgIFpvbHRh biBIb3J2YXRoICA8aHpvbHRhbkBpbmYudS1zemVnZWQuaHU+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgSmFuIEFsb256by4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0 L0R1bXBSZW5kZXJUcmVlLmNwcCBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBS ZW5kZXJUcmVlLmNwcAppbmRleCA5NjRmNmRlLi4xNjc5OGM3IDEwMDY0NAotLS0gYS9XZWJLaXRU b29scy9EdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZS5jcHAKKysrIGIvV2ViS2l0VG9v bHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWUuY3BwCkBAIC03OSw2ICs3OSw5IEBA IHB1YmxpYzoKICAgICBib29sIGphdmFTY3JpcHRDb25maXJtKFFXZWJGcmFtZSAqZnJhbWUsIGNv bnN0IFFTdHJpbmcmIG1zZyk7CiAgICAgYm9vbCBqYXZhU2NyaXB0UHJvbXB0KFFXZWJGcmFtZSAq ZnJhbWUsIGNvbnN0IFFTdHJpbmcmIG1zZywgY29uc3QgUVN0cmluZyYgZGVmYXVsdFZhbHVlLCBR U3RyaW5nKiByZXN1bHQpOwogCitwdWJsaWMgc2xvdHM6CisgICAgYm9vbCBzaG91bGRJbnRlcnJ1 cHRKYXZhU2NyaXB0KCkgeyByZXR1cm4gZmFsc2U7IH0KKwogcHJpdmF0ZSBzbG90czoKICAgICB2 b2lkIHNldFZpZXdHZW9tZXRyeShjb25zdCBRUmVjdCAmcikKICAgICB7Cg==