27292 2009-07-15 02:22:36 -0700 Improve handling of <canvas> path operations on an empty path. 2009-07-16 08:10:40 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 deanm webkit-unassigned dglazkov dimich oldest_to_newest 131829 0 deanm 2009-07-15 02:22:36 -0700 There was originally some work on this: https://bugs.webkit.org/show_bug.cgi?id=27187 This patch further does a few more things: - Don't emit a line or curve, just set the current point (moveTo). - For curves, emit the end point and not the control point. - Update the Skia backend to implement hasCurrentPoint. 131831 1 32772 deanm 2009-07-15 02:47:50 -0700 Created attachment 32772 Patch 131833 2 32772 oliver 2009-07-15 02:51:53 -0700 Comment on attachment 32772 Patch In general this seems okay to me -- how does the output compare to firefox? 131836 3 deanm 2009-07-15 03:04:05 -0700 Differs from Firefox, looks like the control point vs endpoint, but I really don't see how control point could ever make any sense. I'll look at their code today, and maybe file a bug with them. (In reply to comment #2) > (From update of attachment 32772 [details]) > In general this seems okay to me -- how does the output compare to firefox? 131837 4 deanm 2009-07-15 03:10:04 -0700 (In reply to comment #3) > Differs from Firefox, looks like the control point vs endpoint, but I really > don't see how control point could ever make any sense. I'll look at their code > today, and maybe file a bug with them. > > (In reply to comment #2) > > (From update of attachment 32772 [details] [details]) > > In general this seems okay to me -- how does the output compare to firefox? Ok, so Firefox just passes this directly to cairo: 162 void 163 gfxContext::LineTo(const gfxPoint& pt) 164 { 165 cairo_line_to(mCairo, pt.x, pt.y); 166 } And Cairo has the control point behavior: http://cairographics.org/manual/cairo-paths.html#cairo-curve-to If there is no current point before the call to cairo_curve_to() this function will behave as if preceded by a call to cairo_move_to(cr, x1, y1). I think they should cairo_has_current_point() and cairo_move_to the endpoints if not. I'll file a bug with Mozilla. I wonder why Cairo has this behavior. 131839 5 deanm 2009-07-15 03:20:01 -0700 Discussion of the cairo behavior is here: http://lists.freedesktop.org/archives/cairo/2008-June/014262.html I guess the reason cairo behaves like it does, is because it still wants to emit a curve. I think the current behavior for browser should be to not emit anything, and just do the moveTo. I will follow up with Mozilla. (In reply to comment #4) > (In reply to comment #3) > > Differs from Firefox, looks like the control point vs endpoint, but I really > > don't see how control point could ever make any sense. I'll look at their code > > today, and maybe file a bug with them. > > > > (In reply to comment #2) > > > (From update of attachment 32772 [details] [details] [details]) > > > In general this seems okay to me -- how does the output compare to firefox? > > Ok, so Firefox just passes this directly to cairo: > > 162 void > 163 gfxContext::LineTo(const gfxPoint& pt) > 164 { > 165 cairo_line_to(mCairo, pt.x, pt.y); > 166 } > > And Cairo has the control point behavior: > > http://cairographics.org/manual/cairo-paths.html#cairo-curve-to > > If there is no current point before the call to cairo_curve_to() this function > will behave as if preceded by a call to cairo_move_to(cr, x1, y1). > > I think they should cairo_has_current_point() and cairo_move_to the endpoints > if not. I'll file a bug with Mozilla. I wonder why Cairo has this behavior. 132264 6 dglazkov 2009-07-16 08:10:40 -0700 Landed as http://trac.webkit.org/changeset/45973. 32772 2009-07-15 02:47:50 -0700 2009-07-15 02:51:53 -0700 Patch x.diff text/plain 6717 deanm ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkM2VkYjZiLi5hNzBkZjBlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDct MTUgIERlYW4gTWNOYW1lZSAgPGRlYW5tQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjcyOTIKKyAgICAgICAgSW1wcm92ZSBoYW5kbGluZyBvZiA8Y2FudmFz PiBwYXRoIG9wZXJhdGlvbnMgb24gYW4gZW1wdHkgcGF0aC4KKyAgICAgICAgSW1wbGVtZW50IFNr aWEncyBQYXRoOjpoYXNDdXJyZW50UG9pbnQoKS4KKworICAgICAgICAqIGZhc3QvY2FudmFzL2Nh bnZhcy1tb2RpZnktZW1wdHlQYXRoLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2NhbnZh cy9yZXNvdXJjZXMvY2FudmFzLW1vZGlmeS1lbXB0eVBhdGguanM6CisKIDIwMDktMDctMTQgIEJy aWFuIFdlaW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJ1YmJlcnN0 YW1wZWQgYnkgTWFyayBSb3dlLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMv Y2FudmFzLW1vZGlmeS1lbXB0eVBhdGgtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9j YW52YXMvY2FudmFzLW1vZGlmeS1lbXB0eVBhdGgtZXhwZWN0ZWQudHh0CmluZGV4IDFkMGRlYWMu LjJkMTdiMWYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL2NhbnZhcy1tb2Rp ZnktZW1wdHlQYXRoLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy9j YW52YXMtbW9kaWZ5LWVtcHR5UGF0aC1leHBlY3RlZC50eHQKQEAgLTQsMTMgKzQsMjAgQEAgT24g c3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93 ZWQgYnkgIlRFU1QgQ09NUExFVEUKIAogCiBUZXN0IGxpbmVUbwotUEFTUyBnZXRDb2xvcig1MCw1 MCkgaXMgWzAsMTI4LDAsMjU1XQorUEFTUyBnZXRDb2xvcig0MCw0MCkgaXMgWzAsMTI4LDAsMjU1 XQogVGVzdCBsaW5lVG8gc2VxdWVuY2UKK1BBU1MgZ2V0Q29sb3IoMCwwKSBpcyBbMjU1LDAsMCwy NTVdCiBQQVNTIGdldENvbG9yKDUwLDUwKSBpcyBbMCwxMjgsMCwyNTVdCiBUZXN0IHF1YWRyYXRp Y0N1cnZlVG8KLVBBU1MgZ2V0Q29sb3IoNTAsNTApIGlzIFswLDEyOCwwLDI1NV0KK1BBU1MgZ2V0 Q29sb3IoNTAsNTApIGlzIFsyNTUsMCwwLDI1NV0KK1Rlc3QgcXVhZHJhdGljQ3VydmVUbyBlbmRw b2ludAorUEFTUyBnZXRDb2xvcig5OSw1MSkgaXMgWzAsMTI4LDAsMjU1XQorUEFTUyBnZXRDb2xv cig1MCw1MCkgaXMgWzI1NSwwLDAsMjU1XQogVGVzdCBiZXppZXJDdXJ2ZVRvCi1QQVNTIGdldENv bG9yKDUwLDUwKSBpcyBbMCwxMjgsMCwyNTVdCitQQVNTIGdldENvbG9yKDUwLDUwKSBpcyBbMjU1 LDAsMCwyNTVdCitUZXN0IGJlemllckN1cnZlVG8gZW5kcG9pbnQKK1BBU1MgZ2V0Q29sb3IoOTks NTEpIGlzIFswLDEyOCwwLDI1NV0KK1BBU1MgZ2V0Q29sb3IoNTAsNTApIGlzIFsyNTUsMCwwLDI1 NV0KIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKIAogVEVTVCBDT01QTEVURQpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvcmVzb3VyY2VzL2NhbnZhcy1tb2RpZnkt ZW1wdHlQYXRoLmpzIGIvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvcmVzb3VyY2VzL2NhbnZhcy1t b2RpZnktZW1wdHlQYXRoLmpzCmluZGV4IDkwOTEwNzkuLjk4ZDJiMDggMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL2Zhc3QvY2FudmFzL3Jlc291cmNlcy9jYW52YXMtbW9kaWZ5LWVtcHR5UGF0aC5q cworKysgYi9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy9yZXNvdXJjZXMvY2FudmFzLW1vZGlmeS1l bXB0eVBhdGguanMKQEAgLTIwLDggKzIwLDggQEAgY3R4LmJlZ2luUGF0aCgpOwogY3R4LmZpbGxS ZWN0KDAsIDAsIDEwMCwgMTAwKTsKIGN0eC5saW5lVG8oNTAsIDUwKTsKIGN0eC5zdHJva2UoKTsK LXNob3VsZEJlKCJnZXRDb2xvcig1MCw1MCkiLCAiWzAsMTI4LDAsMjU1XSIpOwotCitzaG91bGRC ZSgiZ2V0Q29sb3IoNDAsNDApIiwgIlswLDEyOCwwLDI1NV0iKTsKK2N0eC5jbGVhclJlY3QoMCwg MCwgMzAwLCAzMDApOwogCiAvLyBUZXN0IHBhdGggbW9kaWZpY2F0aW9ucyB0aGF0IHJlc3VsdCBp biBkcmF3aW5nCiBjdHguZmlsbFN0eWxlID0gJ3JlZCc7CkBAIC0zMywyMCArMzMsNDUgQEAgY3R4 LmZpbGxSZWN0KDAsIDAsIDEwMCwgMTAwKTsKIGN0eC5saW5lVG8oMCwgNTApOwogY3R4LmxpbmVU bygxMDAsIDUwKTsKIGN0eC5zdHJva2UoKTsKK3Nob3VsZEJlKCJnZXRDb2xvcigwLDApIiwgIlsy NTUsMCwwLDI1NV0iKTsKIHNob3VsZEJlKCJnZXRDb2xvcig1MCw1MCkiLCAiWzAsMTI4LDAsMjU1 XSIpOworY3R4LmNsZWFyUmVjdCgwLCAwLCAzMDAsIDMwMCk7CiAKIGRlYnVnKCJUZXN0IHF1YWRy YXRpY0N1cnZlVG8iKQogY3R4LmJlZ2luUGF0aCgpOwogY3R4LmZpbGxSZWN0KDAsIDAsIDEwMCwg MTAwKTsKIGN0eC5xdWFkcmF0aWNDdXJ2ZVRvKDAsIDUwLCAxMDAsIDUwKTsKIGN0eC5zdHJva2Uo KTsKLXNob3VsZEJlKCJnZXRDb2xvcig1MCw1MCkiLCAiWzAsMTI4LDAsMjU1XSIpOworc2hvdWxk QmUoImdldENvbG9yKDUwLDUwKSIsICJbMjU1LDAsMCwyNTVdIik7CitjdHguY2xlYXJSZWN0KDAs IDAsIDMwMCwgMzAwKTsKKworZGVidWcoIlRlc3QgcXVhZHJhdGljQ3VydmVUbyBlbmRwb2ludCIp CitjdHguYmVnaW5QYXRoKCk7CitjdHguZmlsbFJlY3QoMCwgMCwgMTAwLCAxMDApOworY3R4LnF1 YWRyYXRpY0N1cnZlVG8oMCwgNTAsIDEwMCwgNTApOworY3R4LmxpbmVUbyg1MCwgMTAwKTsKK2N0 eC5zdHJva2UoKTsKK3Nob3VsZEJlKCJnZXRDb2xvcig5OSw1MSkiLCAiWzAsMTI4LDAsMjU1XSIp Oworc2hvdWxkQmUoImdldENvbG9yKDUwLDUwKSIsICJbMjU1LDAsMCwyNTVdIik7CitjdHguY2xl YXJSZWN0KDAsIDAsIDMwMCwgMzAwKTsKIAogZGVidWcoIlRlc3QgYmV6aWVyQ3VydmVUbyIpCiBj dHguYmVnaW5QYXRoKCk7CiBjdHguZmlsbFJlY3QoMCwgMCwgMTAwLCAxMDApOwogY3R4LmJlemll ckN1cnZlVG8oMCwgNTAsIDUwLCA1MCwgMTAwLCA1MCk7CiBjdHguc3Ryb2tlKCk7Ci1zaG91bGRC ZSgiZ2V0Q29sb3IoNTAsNTApIiwgIlswLDEyOCwwLDI1NV0iKTsKK3Nob3VsZEJlKCJnZXRDb2xv cig1MCw1MCkiLCAiWzI1NSwwLDAsMjU1XSIpOworY3R4LmNsZWFyUmVjdCgwLCAwLCAzMDAsIDMw MCk7CisKK2RlYnVnKCJUZXN0IGJlemllckN1cnZlVG8gZW5kcG9pbnQiKQorY3R4LmJlZ2luUGF0 aCgpOworY3R4LmZpbGxSZWN0KDAsIDAsIDEwMCwgMTAwKTsKK2N0eC5iZXppZXJDdXJ2ZVRvKDAs IDUwLCA1MCwgNTAsIDEwMCwgNTApOworY3R4LnN0cm9rZSgpOworY3R4LmxpbmVUbyg1MCwgMTAw KTsKK2N0eC5zdHJva2UoKTsKK3Nob3VsZEJlKCJnZXRDb2xvcig5OSw1MSkiLCAiWzAsMTI4LDAs MjU1XSIpOworc2hvdWxkQmUoImdldENvbG9yKDUwLDUwKSIsICJbMjU1LDAsMCwyNTVdIik7Citj dHguY2xlYXJSZWN0KDAsIDAsIDMwMCwgMzAwKTsKIAogdmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9 IHRydWU7CmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9n CmluZGV4IGRiMjA2ODMuLjY0ODc5NTAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisr KyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMDktMDctMTUgIERlYW4g TWNOYW1lZSAgPGRlYW5tQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjcyOTIKKyAgICAgICAgSW1wcm92ZSBoYW5kbGluZyBvZiA8Y2FudmFzPiBwYXRoIG9w ZXJhdGlvbnMgb24gYW4gZW1wdHkgcGF0aC4KKyAgICAgICAgSW1wbGVtZW50IFNraWEncyBQYXRo OjpoYXNDdXJyZW50UG9pbnQoKS4KKworICAgICAgICAqIGh0bWwvQ2FudmFzUmVuZGVyaW5nQ29u dGV4dDJELmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6 bGluZVRvKToKKyAgICAgICAgKFdlYkNvcmU6OkNhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6cXVh ZHJhdGljQ3VydmVUbyk6CisgICAgICAgIChXZWJDb3JlOjpDYW52YXNSZW5kZXJpbmdDb250ZXh0 MkQ6OmJlemllckN1cnZlVG8pOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3NraWEvUGF0 aFNraWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGF0aDo6aGFzQ3VycmVudFBvaW50KToKKwog MjAwOS0wNy0xNCAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNoZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0 bWwvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcCBiL1dlYkNvcmUvaHRtbC9DYW52YXNSZW5k ZXJpbmdDb250ZXh0MkQuY3BwCmluZGV4IDIyODY0NzkuLjY4NzgxMjkgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvaHRtbC9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwCisrKyBiL1dlYkNvcmUvaHRt bC9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwCkBAIC01NDgsNyArNTQ4LDggQEAgdm9pZCBD YW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OmxpbmVUbyhmbG9hdCB4LCBmbG9hdCB5KQogICAgICAg ICByZXR1cm47CiAgICAgaWYgKCFtX3BhdGguaGFzQ3VycmVudFBvaW50KCkpCiAgICAgICAgIG1f cGF0aC5tb3ZlVG8oRmxvYXRQb2ludCh4LCB5KSk7Ci0gICAgbV9wYXRoLmFkZExpbmVUbyhGbG9h dFBvaW50KHgsIHkpKTsKKyAgICBlbHNlCisgICAgICAgIG1fcGF0aC5hZGRMaW5lVG8oRmxvYXRQ b2ludCh4LCB5KSk7CiB9CiAKIHZvaWQgQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEOjpxdWFkcmF0 aWNDdXJ2ZVRvKGZsb2F0IGNweCwgZmxvYXQgY3B5LCBmbG9hdCB4LCBmbG9hdCB5KQpAQCAtNTU4 LDggKzU1OSw5IEBAIHZvaWQgQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEOjpxdWFkcmF0aWNDdXJ2 ZVRvKGZsb2F0IGNweCwgZmxvYXQgY3B5LCBmbG9hdCB4LCBmCiAgICAgaWYgKCFzdGF0ZSgpLm1f aW52ZXJ0aWJsZUNUTSkKICAgICAgICAgcmV0dXJuOwogICAgIGlmICghbV9wYXRoLmhhc0N1cnJl bnRQb2ludCgpKQotICAgICAgICBtX3BhdGgubW92ZVRvKEZsb2F0UG9pbnQoY3B4LCBjcHkpKTsK LSAgICBtX3BhdGguYWRkUXVhZEN1cnZlVG8oRmxvYXRQb2ludChjcHgsIGNweSksIEZsb2F0UG9p bnQoeCwgeSkpOworICAgICAgICBtX3BhdGgubW92ZVRvKEZsb2F0UG9pbnQoeCwgeSkpOworICAg IGVsc2UKKyAgICAgICAgbV9wYXRoLmFkZFF1YWRDdXJ2ZVRvKEZsb2F0UG9pbnQoY3B4LCBjcHkp LCBGbG9hdFBvaW50KHgsIHkpKTsKIH0KIAogdm9pZCBDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6 OmJlemllckN1cnZlVG8oZmxvYXQgY3AxeCwgZmxvYXQgY3AxeSwgZmxvYXQgY3AyeCwgZmxvYXQg Y3AyeSwgZmxvYXQgeCwgZmxvYXQgeSkKQEAgLTU2OSw4ICs1NzEsOSBAQCB2b2lkIENhbnZhc1Jl bmRlcmluZ0NvbnRleHQyRDo6YmV6aWVyQ3VydmVUbyhmbG9hdCBjcDF4LCBmbG9hdCBjcDF5LCBm bG9hdCBjcDJ4LAogICAgIGlmICghc3RhdGUoKS5tX2ludmVydGlibGVDVE0pCiAgICAgICAgIHJl dHVybjsKICAgICBpZiAoIW1fcGF0aC5oYXNDdXJyZW50UG9pbnQoKSkKLSAgICAgICAgbV9wYXRo Lm1vdmVUbyhGbG9hdFBvaW50KGNwMXgsIGNwMXkpKTsKLSAgICBtX3BhdGguYWRkQmV6aWVyQ3Vy dmVUbyhGbG9hdFBvaW50KGNwMXgsIGNwMXkpLCBGbG9hdFBvaW50KGNwMngsIGNwMnkpLCBGbG9h dFBvaW50KHgsIHkpKTsKKyAgICAgICAgbV9wYXRoLm1vdmVUbyhGbG9hdFBvaW50KHgsIHkpKTsK KyAgICBlbHNlCisgICAgICAgIG1fcGF0aC5hZGRCZXppZXJDdXJ2ZVRvKEZsb2F0UG9pbnQoY3Ax eCwgY3AxeSksIEZsb2F0UG9pbnQoY3AyeCwgY3AyeSksIEZsb2F0UG9pbnQoeCwgeSkpOwogfQog CiB2b2lkIENhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6YXJjVG8oZmxvYXQgeDAsIGZsb2F0IHkw LCBmbG9hdCB4MSwgZmxvYXQgeTEsIGZsb2F0IHIsIEV4Y2VwdGlvbkNvZGUmIGVjKQpkaWZmIC0t Z2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BhdGhTa2lhLmNwcCBiL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QYXRoU2tpYS5jcHAKaW5kZXggMWU1ZTNmMS4uNWFj MTRiOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BhdGhTa2lh LmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvUGF0aFNraWEuY3BwCkBA IC03MCw3ICs3MCw3IEBAIGJvb2wgUGF0aDo6aXNFbXB0eSgpIGNvbnN0CiAKIGJvb2wgUGF0aDo6 aGFzQ3VycmVudFBvaW50KCkgY29uc3QKIHsKLSAgICByZXR1cm4gdHJ1ZTsKKyAgICByZXR1cm4g bV9wYXRoLT5nZXRQb2ludHMoTlVMTCwgMCkgIT0gMDsKIH0KIAogYm9vbCBQYXRoOjpjb250YWlu cyhjb25zdCBGbG9hdFBvaW50JiBwb2ludCwgV2luZFJ1bGUgcnVsZSkgY29uc3QK