272901 2024-04-18 09:42:29 -0700 [WASM] Avoid extraneous move for simple integer arithmetic in BBQ 2024-04-21 13:47:39 -0700 1 1 1 Unclassified WebKit WebAssembly WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=273048 InRadar P2 Normal --- 1 d_degazio d_degazio fujii webkit-bug-importer oldest_to_newest 2029486 0 d_degazio 2024-04-18 09:42:29 -0700 When we emit various simple integer arithmetic instructions in BBQ with a constant operand, we currently use the MacroAssembler API pretty pessimistically, for example in i32.add: m_jit.move(ImmHelpers::regLocation(lhsLocation, rhsLocation).asGPR(), resultLocation.asGPR()); m_jit.add32(Imm32(ImmHelpers::imm(lhs, rhs).asI32()), resultLocation.asGPR()); It's well-supported in our MacroAssembler to perform a three-operand add (and other arithmetic instructions) even on platforms like x86, so we should just use that. It should save us from obviously redundant codegen like the following on ARM: mov x1, x0 add x1, x1, #1 ...and allow us to use instructions like lea on x86 to accomplish much the same. 2029487 1 webkit-bug-importer 2024-04-18 09:42:58 -0700 <rdar://problem/126695575> 2029508 2 d_degazio 2024-04-18 10:45:41 -0700 *** Bug 272902 has been marked as a duplicate of this bug. *** 2029587 3 d_degazio 2024-04-18 14:13:39 -0700 Pull request: https://github.com/WebKit/WebKit/pull/27473 2029993 4 ews-feeder 2024-04-19 17:09:15 -0700 Committed 277770@main (7a2375d28da4): <https://commits.webkit.org/277770@main> Reviewed commits have been landed. Closing PR #27473 and removing active labels. 2030111 5 fujii 2024-04-21 13:47:39 -0700 Regressed: Bug 273048 – REGRESSION(277770@main): [Mac WK1, GTK, WPE, Win] ASSERTION FAILED: v <= 0 under MacroAssemblerX86Common::sub32