27286 2009-07-14 18:29:53 -0700 Inspector: Keyboard Shortcuts to Switch Panels 2009-07-25 14:35:01 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 joepeck webkit-unassigned abarth oldest_to_newest 131784 0 joepeck 2009-07-14 18:29:53 -0700 It would be nice to flip between Web Inspector Panels with keyboard shortcuts. They are much like tabs in the browser. 131789 1 32758 joepeck 2009-07-14 18:48:01 -0700 Created attachment 32758 Keyboard Shortcuts for Switching Panels Some of the more obvious keyboard shortcuts are taken by Safari. Like ⌘1, ⌘2, etc. are hot links to bookmarks and Safari grabs them. It also seems to grab ⇧⌘[ and ⇧⌘] probably because it thinks an undocked Inspector is a window. So I resorted to ⌘] and ⌘[ for Macs. I don't actually have a Windows Safari setup but I did ^[ and ^]. Let me know if you can think of other keyboard shortcuts for any features or better ones for panel manipulation. 134171 2 32758 timothy 2009-07-23 11:40:21 -0700 Comment on attachment 32758 Keyboard Shortcuts for Switching Panels > + index = (index === 0) ? this.panelOrder.length-1 : index-1; Should have spaces around the "-"s. 134240 3 33368 joepeck 2009-07-23 13:54:43 -0700 Created attachment 33368 Keyboard Shortcuts for Switching Panels Fix based on review. 134242 4 joepeck 2009-07-23 13:56:05 -0700 (In reply to comment #2) > Should have spaces around the "-"s. Done. 134769 5 abarth 2009-07-25 14:35:01 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/inspector.js Committed r46397 M WebCore/ChangeLog M WebCore/inspector/front-end/inspector.js r46397 = 1c431f0eb9ac3e3fdcb5cae52a97bf531525a6b7 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46397 32758 2009-07-14 18:48:01 -0700 2009-07-23 13:54:43 -0700 Keyboard Shortcuts for Switching Panels PanelSwitchingKeyboardShortcuts.patch text/plain 2956 joepeck SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NTg4NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDctMTQgIEpvc2VwaCBQZWNvcmFybyAgPGpvZXBlY2swMkBn bWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgSW5zcGVjdG9yOiBLZXlib2FyZCBTaG9ydGN1dHMgdG8gU3dpdGNoIFBhbmVscworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjcyODYKKworICAgICAg ICAqIGluc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzOgorICAgICAgICAoV2ViSW5zcGVj dG9yLmxvYWRlZCk6IHNhdmUgYSBsaXN0IG9mIHRoZSBvcmRlciBvZiB0aGUgcGFuZWxzCisgICAg ICAgIChXZWJJbnNwZWN0b3IuZG9jdW1lbnRLZXlEb3duKTogaGFuZGxlIHRoZSBrZXlib2FyZCBz aG9ydGN1dHMgdG8gdHJhdmVyc2UgdGhlIHBhbmVscworCiAyMDA5LTA3LTE0ICBSeW9zdWtlIE5p d2EgIDxybml3YUBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVs LgpJbmRleDogV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzCShyZXZpc2lv biA0NTg4MikKKysrIFdlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanMJKHdv cmtpbmcgY29weSkKQEAgLTMwMSw5ICszMDEsMTEgQEAgV2ViSW5zcGVjdG9yLmxvYWRlZCA9IGZ1 bmN0aW9uKCkKICAgICB2YXIgdG9vbGJhckVsZW1lbnQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZCgidG9vbGJhciIpOwogICAgIHZhciBwcmV2aW91c1Rvb2xiYXJJdGVtID0gdG9vbGJhckVsZW1l bnQuY2hpbGRyZW5bMF07CiAKKyAgICB0aGlzLnBhbmVsT3JkZXIgPSBbXTsKICAgICBmb3IgKHZh ciBwYW5lbE5hbWUgaW4gdGhpcy5wYW5lbHMpIHsKICAgICAgICAgdmFyIHBhbmVsID0gdGhpcy5w YW5lbHNbcGFuZWxOYW1lXTsKICAgICAgICAgdmFyIHBhbmVsVG9vbGJhckl0ZW0gPSBwYW5lbC50 b29sYmFySXRlbTsKKyAgICAgICAgdGhpcy5wYW5lbE9yZGVyLnB1c2gocGFuZWwpOwogICAgICAg ICBwYW5lbFRvb2xiYXJJdGVtLmFkZEV2ZW50TGlzdGVuZXIoImNsaWNrIiwgdGhpcy5fdG9vbGJh ckl0ZW1DbGlja2VkLmJpbmQodGhpcykpOwogICAgICAgICBpZiAocHJldmlvdXNUb29sYmFySXRl bSkKICAgICAgICAgICAgIHRvb2xiYXJFbGVtZW50Lmluc2VydEJlZm9yZShwYW5lbFRvb2xiYXJJ dGVtLCBwcmV2aW91c1Rvb2xiYXJJdGVtLm5leHRTaWJsaW5nKTsKQEAgLTUyNiw2ICs1MjgsMzYg QEAgV2ViSW5zcGVjdG9yLmRvY3VtZW50S2V5RG93biA9IGZ1bmN0aW9uKAogICAgICAgICAgICAg ICAgIH0KIAogICAgICAgICAgICAgICAgIGJyZWFrOworCisgICAgICAgICAgICBjYXNlICJVKzAw NUIiOiAvLyBbIGtleQorICAgICAgICAgICAgICAgIGlmIChpc01hYykKKyAgICAgICAgICAgICAg ICAgICAgdmFyIGlzUm90YXRlTGVmdCA9IGV2ZW50Lm1ldGFLZXkgJiYgIWV2ZW50LnNoaWZ0S2V5 ICYmICFldmVudC5jdHJsS2V5ICYmICFldmVudC5hbHRLZXk7CisgICAgICAgICAgICAgICAgZWxz ZQorICAgICAgICAgICAgICAgICAgICB2YXIgaXNSb3RhdGVMZWZ0ID0gZXZlbnQuY3RybEtleSAm JiAhZXZlbnQuc2hpZnRLZXkgJiYgIWV2ZW50Lm1ldGFLZXkgJiYgIWV2ZW50LmFsdEtleTsKKwor ICAgICAgICAgICAgICAgIGlmIChpc1JvdGF0ZUxlZnQpIHsKKyAgICAgICAgICAgICAgICAgICAg dmFyIGluZGV4ID0gdGhpcy5wYW5lbE9yZGVyLmluZGV4T2YodGhpcy5jdXJyZW50UGFuZWwpOwor ICAgICAgICAgICAgICAgICAgICBpbmRleCA9IChpbmRleCA9PT0gMCkgPyB0aGlzLnBhbmVsT3Jk ZXIubGVuZ3RoLTEgOiBpbmRleC0xOworICAgICAgICAgICAgICAgICAgICB0aGlzLnBhbmVsT3Jk ZXJbaW5kZXhdLnRvb2xiYXJJdGVtLmNsaWNrKCk7CisgICAgICAgICAgICAgICAgICAgIGV2ZW50 LnByZXZlbnREZWZhdWx0KCk7CisgICAgICAgICAgICAgICAgfQorCisgICAgICAgICAgICAgICAg YnJlYWs7CisKKyAgICAgICAgICAgIGNhc2UgIlUrMDA1RCI6IC8vIF0ga2V5CisgICAgICAgICAg ICAgICAgaWYgKGlzTWFjKQorICAgICAgICAgICAgICAgICAgICB2YXIgaXNSb3RhdGVSaWdodCA9 IGV2ZW50Lm1ldGFLZXkgJiYgIWV2ZW50LnNoaWZ0S2V5ICYmICFldmVudC5jdHJsS2V5ICYmICFl dmVudC5hbHRLZXk7CisgICAgICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgICAgICB2 YXIgaXNSb3RhdGVSaWdodCA9IGV2ZW50LmN0cmxLZXkgJiYgIWV2ZW50LnNoaWZ0S2V5ICYmICFl dmVudC5tZXRhS2V5ICYmICFldmVudC5hbHRLZXk7CisKKyAgICAgICAgICAgICAgICBpZiAoaXNS b3RhdGVSaWdodCkgeworICAgICAgICAgICAgICAgICAgICB2YXIgaW5kZXggPSB0aGlzLnBhbmVs T3JkZXIuaW5kZXhPZih0aGlzLmN1cnJlbnRQYW5lbCk7CisgICAgICAgICAgICAgICAgICAgIGlu ZGV4ID0gKGluZGV4ICsgMSkgJSB0aGlzLnBhbmVsT3JkZXIubGVuZ3RoOworICAgICAgICAgICAg ICAgICAgICB0aGlzLnBhbmVsT3JkZXJbaW5kZXhdLnRvb2xiYXJJdGVtLmNsaWNrKCk7CisgICAg ICAgICAgICAgICAgICAgIGV2ZW50LnByZXZlbnREZWZhdWx0KCk7CisgICAgICAgICAgICAgICAg fQorCisgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KICAgICB9CiB9Cg== 33368 2009-07-23 13:54:43 -0700 2009-07-24 15:07:10 -0700 Keyboard Shortcuts for Switching Panels PanelSwitchingKeyboardShortcuts.patch text/plain 2907 joepeck ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MWUzMTMzZi4uMTVlN2JlYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0wNy0yMyAgSm9zZXBoIFBlY29y YXJvICA8am9lcGVjazAyQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBJbnNwZWN0b3I6IEtleWJvYXJkIFNob3J0Y3V0cyB0byBTd2l0 Y2ggUGFuZWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yNzI4NgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanM6Cisg ICAgICAgIChXZWJJbnNwZWN0b3IubG9hZGVkKTogc2F2ZSBhIGxpc3Qgb2YgdGhlIG9yZGVyIG9m IHRoZSBwYW5lbHMKKyAgICAgICAgKFdlYkluc3BlY3Rvci5kb2N1bWVudEtleURvd24pOiBoYW5k bGUgdGhlIGtleWJvYXJkIHNob3J0Y3V0cyB0byB0cmF2ZXJzZSB0aGUgcGFuZWxzCisKIDIwMDkt MDctMjMgIEppYW4gTGkgIDxqaWFubGlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IERhdmlkIExldmluLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L2luc3BlY3Rvci5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanMK aW5kZXggMzYzZjNkZC4uZDFkMWYxYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL2luc3BlY3Rvci5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5z cGVjdG9yLmpzCkBAIC0zMDYsOSArMzA2LDExIEBAIFdlYkluc3BlY3Rvci5sb2FkZWQgPSBmdW5j dGlvbigpCiAgICAgdmFyIHRvb2xiYXJFbGVtZW50ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo InRvb2xiYXIiKTsKICAgICB2YXIgcHJldmlvdXNUb29sYmFySXRlbSA9IHRvb2xiYXJFbGVtZW50 LmNoaWxkcmVuWzBdOwogCisgICAgdGhpcy5wYW5lbE9yZGVyID0gW107CiAgICAgZm9yICh2YXIg cGFuZWxOYW1lIGluIHRoaXMucGFuZWxzKSB7CiAgICAgICAgIHZhciBwYW5lbCA9IHRoaXMucGFu ZWxzW3BhbmVsTmFtZV07CiAgICAgICAgIHZhciBwYW5lbFRvb2xiYXJJdGVtID0gcGFuZWwudG9v bGJhckl0ZW07CisgICAgICAgIHRoaXMucGFuZWxPcmRlci5wdXNoKHBhbmVsKTsKICAgICAgICAg cGFuZWxUb29sYmFySXRlbS5hZGRFdmVudExpc3RlbmVyKCJjbGljayIsIHRoaXMuX3Rvb2xiYXJJ dGVtQ2xpY2tlZC5iaW5kKHRoaXMpKTsKICAgICAgICAgaWYgKHByZXZpb3VzVG9vbGJhckl0ZW0p CiAgICAgICAgICAgICB0b29sYmFyRWxlbWVudC5pbnNlcnRCZWZvcmUocGFuZWxUb29sYmFySXRl bSwgcHJldmlvdXNUb29sYmFySXRlbS5uZXh0U2libGluZyk7CkBAIC01MzEsNiArNTMzLDM2IEBA IFdlYkluc3BlY3Rvci5kb2N1bWVudEtleURvd24gPSBmdW5jdGlvbihldmVudCkKICAgICAgICAg ICAgICAgICB9CiAKICAgICAgICAgICAgICAgICBicmVhazsKKworICAgICAgICAgICAgY2FzZSAi VSswMDVCIjogLy8gWyBrZXkKKyAgICAgICAgICAgICAgICBpZiAoaXNNYWMpCisgICAgICAgICAg ICAgICAgICAgIHZhciBpc1JvdGF0ZUxlZnQgPSBldmVudC5tZXRhS2V5ICYmICFldmVudC5zaGlm dEtleSAmJiAhZXZlbnQuY3RybEtleSAmJiAhZXZlbnQuYWx0S2V5OworICAgICAgICAgICAgICAg IGVsc2UKKyAgICAgICAgICAgICAgICAgICAgdmFyIGlzUm90YXRlTGVmdCA9IGV2ZW50LmN0cmxL ZXkgJiYgIWV2ZW50LnNoaWZ0S2V5ICYmICFldmVudC5tZXRhS2V5ICYmICFldmVudC5hbHRLZXk7 CisKKyAgICAgICAgICAgICAgICBpZiAoaXNSb3RhdGVMZWZ0KSB7CisgICAgICAgICAgICAgICAg ICAgIHZhciBpbmRleCA9IHRoaXMucGFuZWxPcmRlci5pbmRleE9mKHRoaXMuY3VycmVudFBhbmVs KTsKKyAgICAgICAgICAgICAgICAgICAgaW5kZXggPSAoaW5kZXggPT09IDApID8gdGhpcy5wYW5l bE9yZGVyLmxlbmd0aCAtIDEgOiBpbmRleCAtIDE7CisgICAgICAgICAgICAgICAgICAgIHRoaXMu cGFuZWxPcmRlcltpbmRleF0udG9vbGJhckl0ZW0uY2xpY2soKTsKKyAgICAgICAgICAgICAgICAg ICAgZXZlbnQucHJldmVudERlZmF1bHQoKTsKKyAgICAgICAgICAgICAgICB9CisKKyAgICAgICAg ICAgICAgICBicmVhazsKKworICAgICAgICAgICAgY2FzZSAiVSswMDVEIjogLy8gXSBrZXkKKyAg ICAgICAgICAgICAgICBpZiAoaXNNYWMpCisgICAgICAgICAgICAgICAgICAgIHZhciBpc1JvdGF0 ZVJpZ2h0ID0gZXZlbnQubWV0YUtleSAmJiAhZXZlbnQuc2hpZnRLZXkgJiYgIWV2ZW50LmN0cmxL ZXkgJiYgIWV2ZW50LmFsdEtleTsKKyAgICAgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAg ICAgICAgIHZhciBpc1JvdGF0ZVJpZ2h0ID0gZXZlbnQuY3RybEtleSAmJiAhZXZlbnQuc2hpZnRL ZXkgJiYgIWV2ZW50Lm1ldGFLZXkgJiYgIWV2ZW50LmFsdEtleTsKKworICAgICAgICAgICAgICAg IGlmIChpc1JvdGF0ZVJpZ2h0KSB7CisgICAgICAgICAgICAgICAgICAgIHZhciBpbmRleCA9IHRo aXMucGFuZWxPcmRlci5pbmRleE9mKHRoaXMuY3VycmVudFBhbmVsKTsKKyAgICAgICAgICAgICAg ICAgICAgaW5kZXggPSAoaW5kZXggKyAxKSAlIHRoaXMucGFuZWxPcmRlci5sZW5ndGg7CisgICAg ICAgICAgICAgICAgICAgIHRoaXMucGFuZWxPcmRlcltpbmRleF0udG9vbGJhckl0ZW0uY2xpY2so KTsKKyAgICAgICAgICAgICAgICAgICAgZXZlbnQucHJldmVudERlZmF1bHQoKTsKKyAgICAgICAg ICAgICAgICB9CisKKyAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQogICAgIH0KIH0K